linux-next: Fixes tags need some work in the net tree

linux-next: Fixes tags need some work in the net tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi all,

In commit

  1023121375c6 ("net: tls: Fix deadlock in free_resources tx")

Fixes tag

  Fixes: a42055e8d2c30 ("Add support for async encryption of records...")

has these problem(s):

  - Subject does not match target commit subject

In commit

  32eb67b93c9e ("net: tls: Save iv in tls_rec for async crypto requests")

Fixes tag

  Fixes: a42055e8d2c30 ("Add support for async encryption of records...")

has these problem(s):

  - Subject does not match target commit subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tags need some work in the net tree

[Joakim Zhang]

Hi Stephen,

Thanks for reporting this, it's a mistake when adding Fixes tag. And ./scripts/checkpatch.pl script seems can't 
report this issue(even with --strict parameter).

Could you tell me how can you get these errors before sending out the patches for reviewing?
  
Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: 2021年6月17日 6:03
> To: David Miller <davem@davemloft.net>; Networking
> <netdev@vger.kernel.org>
> Cc: Fugang Duan <fugang.duan@nxp.com>; Joakim Zhang
> <qiangqing.zhang@nxp.com>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Linux Next Mailing List
> <linux-next@vger.kernel.org>
> Subject: linux-next: Fixes tags need some work in the net tree
> 
> Hi all,
> 
> In commit
> 
>   cb3cefe3f3f8 ("net: fec_ptp: add clock rate zero check")
> 
> Fixes tag
> 
>   Fixes: commit 85bd1798b24a ("net: fec: fix spin_lock dead lock")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected
> 
> In commit
> 
>   8f269102baf7 ("net: stmmac: disable clocks in
> stmmac_remove_config_dt()")
> 
> Fixes tag
> 
>   Fixes: commit d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and
> fixed-link-phydev leaks")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected
> 
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tags need some work in the net tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Hi all,

In commit

  cb3cefe3f3f8 ("net: fec_ptp: add clock rate zero check")

Fixes tag

  Fixes: commit 85bd1798b24a ("net: fec: fix spin_lock dead lock")

has these problem(s):

  - leading word 'commit' unexpected

In commit

  8f269102baf7 ("net: stmmac: disable clocks in stmmac_remove_config_dt()")

Fixes tag

  Fixes: commit d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tags need some work in the net tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

Hi all,

In commit

  66a5209b5341 ("octeontx2-pf: Fix synchnorization issue in mbox")

Fixes tag

  Fixes: d424b6c02 ("octeontx2-pf: Enable SRIOV and added VF mbox handling")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

In commit

  1ea0166da050 ("octeontx2-pf: Fix the device state on error")

Fixes tag

  Fixes: 50fe6c02e ("octeontx2-pf: Register and handle link notifications")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

In commit

  89eae5e87b4f ("octeontx2-pf: Fix TCP/UDP checksum offload for IPv6 frames")

Fixes tag

  Fixes: 3ca6c4c88 ("octeontx2-pf: Add packet transmission support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tags need some work in the net tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Hi all,

In commit

  a26ad4d5676f ("net: phy: DP83822: Update Kconfig with DP83825I support")

Fixes tag

  Fixes: 32b12dc8fde1  ("net: phy: Add DP83825I to the DP83822 driver")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 06acc17a9621 ("net: phy: Add DP83825I to the DP83822 driver")

In commit

  443180567763 ("net: phy: DP83TC811: Fix typo in Kconfig")

Fixes tag

  Fixes: 6d749428788b {"net: phy: DP83TC811: Introduce support for the DP83TC811 phy")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tags need some work in the net tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

Hi all,

In commit

  3b2c4f4d63a5 ("net: dsa: sja1105: Don't return a negative in u8 sja1105_stp_state_get")

Fixes tag

  Fixes: 640f763f98c2: ("net: dsa: sja1105: Add support for Spanning Tree Protocol")

has these problem(s):

  - the ':' after the SHA1 is unexpected
    Just use
	git log -1 --format='Fixes: %h ("%s")'

In commit

  e9919a24d302 ("fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied")

Fixes tag

  Fixes: 153380ec4b9 ("fib_rules: Added NLM_F_EXCL support to fib_nl_newrule")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tags need some work in the net tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

Hi all,

In commit

  a40061ea2e39 ("net: systemport: Fix reception of BPDUs")

Fixes tag

  Fixes: 4e8aedfe78c7 ("net: systemport: Turn on offloads by default")

has these problem(s):

  - Target SHA1 does not exist
    Did you mean

  Fixes: b5061778f822 ("net: systemport: Turn on offloads by default")?

In commit

  3b89ea9c5902 ("net: Fix for_each_netdev_feature on Big endian")

Fixes tag

  Fixes: fd867d51f ("net/core: generic support for disabling netdev features down stack")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]