Hi Greg, After merging the driver-core tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: "__arm_smccc_hvc" [drivers/firmware/stratix10-svc.ko] undefined! ERROR: "__arm_smccc_smc" [drivers/firmware/stratix10-svc.ko] undefined! Exposed by commit 095ff29d2b88 ("firmware: intel_stratix10_service: add hardware dependency") I have added the following partial revert for today: From: Stephen Rothwell Date: Fri, 1 Feb 2019 13:37:59 +1100 Subject: [PATCH] firmware: intel_stratix10_service: remove COMPILE_TEST This does not build yet ... Signed-off-by: Stephen Rothwell --- drivers/firmware/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 7e5491aed5c8..cac16c4b0df3 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -218,7 +218,7 @@ config FW_CFG_SYSFS_CMDLINE config INTEL_STRATIX10_SERVICE tristate "Intel Stratix10 Service Layer" - depends on (ARCH_STRATIX10 && HAVE_ARM_SMCCC) || COMPILE_TEST + depends on ARCH_STRATIX10 && HAVE_ARM_SMCCC default n help Intel Stratix10 service layer runs at privileged exception level, -- 2.20.1 -- Cheers, Stephen Rothwell