From: Marc Zyngier <marc.zyngier@arm.com>
To: Brian Masney <masneyb@onstation.org>
Cc: linus.walleij@linaro.org, tglx@linutronix.de,
andy.gross@linaro.org, sboyd@kernel.org,
kernel-build-reports@lists.linaro.org,
linaro-kernel@lists.linaro.org, linux-next@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/2] genirq: export irq_chip_set_wake_parent symbol
Date: Sun, 3 Feb 2019 13:05:33 +0000 [thread overview]
Message-ID: <20190203130533.072b235e@why.wild-wind.fr.eu.org> (raw)
In-Reply-To: <20190203123131.28323-1-masneyb@onstation.org>
On Sun, 3 Feb 2019 07:31:30 -0500
Brian Masney <masneyb@onstation.org> wrote:
Hi Brian,
> Export the irq_chip_set_wake_parent symbol so that drivers with
> hierarchical IRQ chips can be built as a module.
>
> This fixes a build failure in linux-next's spmi-gpio when using
> allmodconfig.
I don't think the mention of linux-next helps in the commit message. It
would have been better together with the note below.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> Reported-by: Mark Brown <broonie@kernel.org>
Otherwise:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Thanks,
M.
> ---
> See https://www.spinics.net/lists/linux-next/msg46362.html for Mark's
> message.
>
> kernel/irq/chip.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index 34e969069488..086d5a34b5a0 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -1381,6 +1381,7 @@ int irq_chip_set_wake_parent(struct irq_data *data, unsigned int on)
>
> return -ENOSYS;
> }
> +EXPORT_SYMBOL_GPL(irq_chip_set_wake_parent);
> #endif
>
> /**
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2019-02-03 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 12:31 [PATCH -next 1/2] genirq: export irq_chip_set_wake_parent symbol Brian Masney
2019-02-03 12:31 ` [PATCH -next 2/2] pinctrl: qcom: spmi-gpio: select IRQ_DOMAIN_HIERARCHY in Kconfig Brian Masney
2019-02-03 13:05 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190203130533.072b235e@why.wild-wind.fr.eu.org \
--to=marc.zyngier@arm.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).