linux-next: Fixes tag needs some work in the scsi-fixes tree

linux-next: Fixes tag needs some work in the scsi-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Hi Martin,

In commit

  bb61b843ffd4 ("scsi: cxlflash: Prevent deadlock when adapter probe fails")

Fixes tag

  Fixes: c21e0bbfc485("cxlflash: Base support for IBM CXL Flash Adapter")

has these problem(s):

  - missing space between the SHA1 and the subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

[Vaibhav Jain]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Martin,
>
> In commit
>
>   bb61b843ffd4 ("scsi: cxlflash: Prevent deadlock when adapter probe fails")
>
> Fixes tag
>
>   Fixes: c21e0bbfc485("cxlflash: Base support for IBM CXL Flash Adapter")
>
> has these problem(s):
>
>   - missing space between the SHA1 and the subject
Thanks for catching this Stephen. I am surprised that the checkpatch.pl
script didnt catch this.

Martin, should I resend the patch with this fixed ?

Thanks,
-- 
Vaibhav Jain <vaibhav@linux.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi Vaibhav,

On Wed, 06 Feb 2019 09:25:12 +0530 Vaibhav Jain <vaibhav@linux.ibm.com> wrote:
>
> Martin, should I resend the patch with this fixed ?

I wouldn't bother, it is a really picky report (I almost didn't send
it) :-)

Consider it just a reminder for next time.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

[Martin K. Petersen]

Vaibhav,

> Martin, should I resend the patch with this fixed ?

No need, I fixed it up yesterday.

-- 
Martin K. Petersen	Oracle Linux Engineering

linux-next: Fixes tag needs some work in the scsi-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

Hi all,

In commit

  b614d55b970d ("scsi: mpt3sas: Don't call disable_irq from IRQ poll handler")

Fixes tag

  Fixes: 320e77acb3 scsi: mpt3sas: Irq poll to avoid CPU hard lockups

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  d2af39141eea ("scsi: megaraid_sas: Don't call disable_irq from process IRQ poll")

Fixes tag

  Fixes: a6ffd5bf681 scsi: megaraid_sas: Call disable_irq from process IRQ poll

has these problem(s):

  - SHA1 should be at least 12 digits long

These can be fixed in the future by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

Also, Fixes tags are usually generated using

  git log -1 --format='Fixes: %h ("%s")' <SHA1>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

[Martin K. Petersen]

Stephen,

>   Fixes: 320e77acb3 scsi: mpt3sas: Irq poll to avoid CPU hard lockups
>   Fixes: a6ffd5bf681 scsi: megaraid_sas: Call disable_irq from process IRQ poll

Ah, my regex missed the short SHAs due to the missing description
quotation marks. Fixed my script and fixed up the commits.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

linux-next: Fixes tag needs some work in the scsi-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  46da547e21d6 ("scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()")

Fixes tag

  Fixes: 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

[SeongJae Park]

On Wed, 24 Jun 2020 17:07:42 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> 
> [-- Attachment #1: Type: text/plain, Size: 385 bytes --]
> 
> Hi all,
> 
> In commit
> 
>   46da547e21d6 ("scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()")
> 
> Fixes tag
> 
>   Fixes: 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Oops, sorry for the mistake.  I will send the fixed version in reply to this.


Thanks,
SeongJae Park

> 
> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Hi SeongJae,

On Wed, 24 Jun 2020 09:14:47 +0200 SeongJae Park <sjpark@amazon.com> wrote:
>
> Oops, sorry for the mistake.  I will send the fixed version in reply to this.

Unless Martin says otherwise, I am not sure it is worth fixing.  Just
remember for next time.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the scsi-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Hi all,

In commit

  0f3b2f3fb5dc ("scsi: qla2xxx: Do not log message when reading port speed via sysfs")

Fixes tag

  Fixes: 4910b524ac9 ("scsi: qla2xxx: Add support for setting port speed")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

[Martin K. Petersen]

Stephen,

>   Fixes: 4910b524ac9 ("scsi: qla2xxx: Add support for setting port speed")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long

I'm pretty good at spotting 8-digit SHAs but the 11 digits tripped me up
in this case.

I refined the SHA validation logic in my commit hook script to ensure 12
digits going forward.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

linux-next: Fixes tag needs some work in the scsi-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

Hi all,

In commit

  b63195698dea ("scsi: zfcp: fix sysfs block queue limit output for max_segment_size")

Fixes tag

  Fixes: 50c2e9107f ("scsi: introduce a max_segment_size host_template parameters")

has these problem(s):

  - SHA1 should be at least 12 digits long

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the scsi-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

Hi Martin,

In commit

  a8cf59a6692c ("scsi: communicate max segment size to the DMA mapping code")

Fixes tag

  Fixes: 50c2e9107f ("scsi: introduce a max_segment_size host_template parameters")

has these problem(s):

  - SHA1 should be at least 12 digits long

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]