linux-next: Fixes tag needs some work in the net-next tree

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi all,

In commit

  a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")

Fixes tag

  Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")

has these problem(s):

  - Target SHA1 does not exist

Did you mean:

  Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[Vinod Koul]

On 20-02-19, 09:31, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
> 
> Fixes tag
> 
>   Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean:
> 
>   Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")

Yes looks like I messed up the commit id.. Not sure why :(

Dave would you like to drop this and me sending updated patch or
something else..

Sorry about the miss

-- 
~Vinod

Re: linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

Hi Vinod,

On Wed, 20 Feb 2019 10:10:55 +0530 Vinod Koul <vkoul@kernel.org> wrote:
>
> Dave would you like to drop this and me sending updated patch or
> something else..

Dave doesn't rebase/reset net-next, so we will just have to use this as
a learning experience :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[David Miller]

From: Vinod Koul <vkoul@kernel.org>
Date: Wed, 20 Feb 2019 10:10:55 +0530

> On 20-02-19, 09:31, Stephen Rothwell wrote:
>> Hi all,
>> 
>> In commit
>> 
>>   a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>> 
>> Fixes tag
>> 
>>   Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>> 
>> has these problem(s):
>> 
>>   - Target SHA1 does not exist
>> 
>> Did you mean:
>> 
>>   Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
> 
> Yes looks like I messed up the commit id.. Not sure why :(
> 
> Dave would you like to drop this and me sending updated patch or
> something else..
> 
> Sorry about the miss

Doesn't work that way, something in my tree is there forever.

Re: linux-next: Fixes tag needs some work in the net-next tree

[Jiri Pirko]

Wed, Feb 20, 2019 at 07:48:13AM CET, davem@davemloft.net wrote:
>From: Vinod Koul <vkoul@kernel.org>
>Date: Wed, 20 Feb 2019 10:10:55 +0530
>
>> On 20-02-19, 09:31, Stephen Rothwell wrote:
>>> Hi all,
>>> 
>>> In commit
>>> 
>>>   a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>>> 
>>> Fixes tag
>>> 
>>>   Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>>> 
>>> has these problem(s):
>>> 
>>>   - Target SHA1 does not exist
>>> 
>>> Did you mean:
>>> 
>>>   Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
>> 
>> Yes looks like I messed up the commit id.. Not sure why :(
>> 
>> Dave would you like to drop this and me sending updated patch or
>> something else..
>> 
>> Sorry about the miss
>
>Doesn't work that way, something in my tree is there forever.

Would be good to have some robot checking "Fixes" sanity...

Re: linux-next: Fixes tag needs some work in the net-next tree

[David Miller]

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 20 Feb 2019 09:36:11 +0100

> Would be good to have some robot checking "Fixes" sanity...

I want to add a script to my trees that locally do it for me but the
backlog for patch review for me is so huge that I never get to "fun"
tasks like that....

This has been discussed before too.

Re: linux-next: Fixes tag needs some work in the net-next tree

[Jiri Pirko]

Wed, Feb 20, 2019 at 08:02:01PM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Wed, 20 Feb 2019 09:36:11 +0100
>
>> Would be good to have some robot checking "Fixes" sanity...
>
>I want to add a script to my trees that locally do it for me but the

When it is in tree, it's already late. The robot has to check
emails/patchwork.


>backlog for patch review for me is so huge that I never get to "fun"
>tasks like that....
>
>This has been discussed before too.

Re: linux-next: Fixes tag needs some work in the net-next tree

[David Miller]

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 20 Feb 2019 20:58:11 +0100

> Wed, Feb 20, 2019 at 08:02:01PM CET, davem@davemloft.net wrote:
>>From: Jiri Pirko <jiri@resnulli.us>
>>Date: Wed, 20 Feb 2019 09:36:11 +0100
>>
>>> Would be good to have some robot checking "Fixes" sanity...
>>
>>I want to add a script to my trees that locally do it for me but the
> 
> When it is in tree, it's already late. The robot has to check
> emails/patchwork.

It's for me, on my computer, to abort things when I try to commit
with a bad fixes tag or missing signoff.

Re: linux-next: Fixes tag needs some work in the net-next tree

[Jiri Pirko]

Wed, Feb 20, 2019 at 09:25:22PM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Wed, 20 Feb 2019 20:58:11 +0100
>
>> Wed, Feb 20, 2019 at 08:02:01PM CET, davem@davemloft.net wrote:
>>>From: Jiri Pirko <jiri@resnulli.us>
>>>Date: Wed, 20 Feb 2019 09:36:11 +0100
>>>
>>>> Would be good to have some robot checking "Fixes" sanity...
>>>
>>>I want to add a script to my trees that locally do it for me but the
>> 
>> When it is in tree, it's already late. The robot has to check
>> emails/patchwork.
>
>It's for me, on my computer, to abort things when I try to commit
>with a bad fixes tag or missing signoff.

Okay, but still, robot checking emails/patchwork would safe you some
overhead.

Re: linux-next: Fixes tag needs some work in the net-next tree

[Stefano Brivio]

On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Jiri Pirko <jiri@resnulli.us>
> Date: Wed, 20 Feb 2019 09:36:11 +0100
> 
> > Would be good to have some robot checking "Fixes" sanity...  
> 
> I want to add a script to my trees that locally do it for me but the
> backlog for patch review for me is so huge that I never get to "fun"
> tasks like that....

If it helps, this is what I use after being bitten once:

#!/bin/sh

[ ${#} -ne 2 ] && echo "Usage: %0 PATCH_FILE GIT_TREE" && exit 1
grep "^Fixes: " "${1}" | while read -r f; do
	sha="$(echo "${f}" | cut -d' ' -f2)"
	if [ -z "${sha}" ] || [ "${f}" != "$(git -C "${2}" show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
		echo "Bad tag: ${f}" && exit 1
	fi
done

-- 
Stefano

Re: linux-next: Fixes tag needs some work in the net-next tree

[David Miller]

From: Stefano Brivio <sbrivio@redhat.com>
Date: Wed, 20 Feb 2019 20:59:10 +0100

> On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> David Miller <davem@davemloft.net> wrote:
> 
>> From: Jiri Pirko <jiri@resnulli.us>
>> Date: Wed, 20 Feb 2019 09:36:11 +0100
>> 
>> > Would be good to have some robot checking "Fixes" sanity...  
>> 
>> I want to add a script to my trees that locally do it for me but the
>> backlog for patch review for me is so huge that I never get to "fun"
>> tasks like that....
> 
> If it helps, this is what I use after being bitten once:

Awesome, thanks!  You put this in as a pre-commit script?

Re: linux-next: Fixes tag needs some work in the net-next tree

[Stefano Brivio]

On Wed, 20 Feb 2019 12:25:48 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Stefano Brivio <sbrivio@redhat.com>
> Date: Wed, 20 Feb 2019 20:59:10 +0100
> 
> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> > David Miller <davem@davemloft.net> wrote:
> >   
> >> From: Jiri Pirko <jiri@resnulli.us>
> >> Date: Wed, 20 Feb 2019 09:36:11 +0100
> >>   
> >> > Would be good to have some robot checking "Fixes" sanity...    
> >> 
> >> I want to add a script to my trees that locally do it for me but the
> >> backlog for patch review for me is so huge that I never get to "fun"
> >> tasks like that....  
> > 
> > If it helps, this is what I use after being bitten once:  
> 
> Awesome, thanks!  You put this in as a pre-commit script?

Nope, I use it before sending patches out with git send-email.

But you can use this as .git/hooks/commit-msg, just skip taking the
tree as second argument, something like this (just quickly tested):

#!/bin/sh

grep "^Fixes: " "${1}" | while read -r f; do
	sha="$(echo "${f}" | cut -d' ' -f2)"
	if [ -z "${sha}" ] || [ "${f}" != "$(git show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
		echo "Bad tag: ${f}" && exit 1
	fi
done

-- 
Stefano

Re: linux-next: Fixes tag needs some work in the net-next tree

[David Miller]

From: Stefano Brivio <sbrivio@redhat.com>
Date: Wed, 20 Feb 2019 21:37:29 +0100

> On Wed, 20 Feb 2019 12:25:48 -0800 (PST)
> David Miller <davem@davemloft.net> wrote:
> 
>> From: Stefano Brivio <sbrivio@redhat.com>
>> Date: Wed, 20 Feb 2019 20:59:10 +0100
>> 
>> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
>> > David Miller <davem@davemloft.net> wrote:
>> >   
>> >> From: Jiri Pirko <jiri@resnulli.us>
>> >> Date: Wed, 20 Feb 2019 09:36:11 +0100
>> >>   
>> >> > Would be good to have some robot checking "Fixes" sanity...    
>> >> 
>> >> I want to add a script to my trees that locally do it for me but the
>> >> backlog for patch review for me is so huge that I never get to "fun"
>> >> tasks like that....  
>> > 
>> > If it helps, this is what I use after being bitten once:  
>> 
>> Awesome, thanks!  You put this in as a pre-commit script?
> 
> Nope, I use it before sending patches out with git send-email.
> 
> But you can use this as .git/hooks/commit-msg, just skip taking the
> tree as second argument, something like this (just quickly tested):

Awesome, thank you!

Re: linux-next: Fixes tag needs some work in the net-next tree

[Vinod Koul]

On 20-02-19, 20:59, Stefano Brivio wrote:
> On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> David Miller <davem@davemloft.net> wrote:
> 
> > From: Jiri Pirko <jiri@resnulli.us>
> > Date: Wed, 20 Feb 2019 09:36:11 +0100
> > 
> > > Would be good to have some robot checking "Fixes" sanity...  
> > 
> > I want to add a script to my trees that locally do it for me but the
> > backlog for patch review for me is so huge that I never get to "fun"
> > tasks like that....
> 
> If it helps, this is what I use after being bitten once:
> 
> #!/bin/sh
> 
> [ ${#} -ne 2 ] && echo "Usage: %0 PATCH_FILE GIT_TREE" && exit 1
> grep "^Fixes: " "${1}" | while read -r f; do
> 	sha="$(echo "${f}" | cut -d' ' -f2)"
> 	if [ -z "${sha}" ] || [ "${f}" != "$(git -C "${2}" show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
> 		echo "Bad tag: ${f}" && exit 1
> 	fi
> done

Awesome thanks, I am adding this into my patch commit script and well as
send script

-- 
~Vinod

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Hi all,

In commit

  acde891c243c ("rxrpc: Fix _usecs_to_jiffies() by using usecs_to_jiffies()")

Fixes tag

  Fixes: c410bf01933e ("Fix the excessive initial retransmission timeout")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

So

Fixes: c410bf01933e ("rxrpc: Fix the excessive initial retransmission timeout")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

Hi all,

In commit

  175e66924719 ("net: bridge: mcast: account for ipv6 size when dumping querier state")

Fixes tag

  Fixes: 5e924fe6ccfd ("net: bridge: mcast: dump ipv6 querier state")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 85b410821174 ("net: bridge: mcast: dump ipv6 querier state")

In commit

  cdda378bd8d9 ("net: bridge: mcast: drop sizeof for nest attribute's zero size")

Fixes tag

  Fixes: 606433fe3e11 ("net: bridge: mcast: dump ipv4 querier state")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: c7fa1d9b1fb1 ("net: bridge: mcast: dump ipv4 querier state")

In commit

  0f0c4f1b72e0 ("samples: pktgen: add missing IPv6 option to pktgen scripts")

Fixes tag

  Fixes: 0f06a6787e05 ("samples: Add an IPv6 "-6" option to the pktgen scripts")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Also, please keep all the commit message tags together at the end of
the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[Nikolay Aleksandrov]

On 17/08/2021 01:04, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   175e66924719 ("net: bridge: mcast: account for ipv6 size when dumping querier state")
> 
> Fixes tag
> 
>   Fixes: 5e924fe6ccfd ("net: bridge: mcast: dump ipv6 querier state")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 85b410821174 ("net: bridge: mcast: dump ipv6 querier state")
> 
> In commit
> 
>   cdda378bd8d9 ("net: bridge: mcast: drop sizeof for nest attribute's zero size")
> 
> Fixes tag
> 
>   Fixes: 606433fe3e11 ("net: bridge: mcast: dump ipv4 querier state")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: c7fa1d9b1fb1 ("net: bridge: mcast: dump ipv4 querier state")

Hi,
Indeed that's what I meant, apologies for the mix up. I was working on my
querier state branch where I made the feature and forgot to rebase it before
doing the fixes on top.

Thanks,
 Nik

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Hi all,

In commit

  0e672f306a28 ("veth: check for NAPI instead of xdp_prog before xmit of XDP frame")

Fixes tag

  Fixes: 6788fa154546 ("veth: allow enabling NAPI even without XDP")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d3256efd8e8b ("veth: allow enabling NAPI even without XDP")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Hi all,

In commit

  d24f511b04b8 ("tcp: fix tcp_min_tso_segs sysctl")

Fixes tag

  Fixes: 47996b489bdc ("tcp: convert elligible sysctls to u8")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 4ecc1baf362c ("tcp: convert elligible sysctls to u8")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi all,

In commit

  63c173ff7aa3 ("net: stmmac: Fix kernel panic due to NULL pointer dereference of fpe_cfg")

Fixes tag

  Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

Hi all,

In commit

  9f19306d1666 ("net: stmmac: use netif_tx_start|stop_all_queues() function")

Fixes tag

  Fixes: c22a3f48 net: stmmac: adding multiple napi mechanism

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Also, please keep the commit message tags all together at the end of
the commit message and just use

git log -1 --format='Fixes: %h ("%s")' <SHA1>

to generate Fixes tag lines.

Since Dave does not rebase his tree, this is just for future reference.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi all,

In commit

  055be6865dea ("Crypto/chcr: Fixes a coccinile check error")

Fixes tag

  Fixes: 567be3a5d227 ("crypto:

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[Ayush Sawal]

Hi Stephen & David,

On 6/2/2020 4:42 AM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>    055be6865dea ("Crypto/chcr: Fixes a coccinile check error")
>
> Fixes tag
>
>    Fixes: 567be3a5d227 ("crypto:
>
> has these problem(s):
>
>    - Subject has leading but no trailing parentheses
>    - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.

I am so sorry for this mistake.
Is there a way to fix this?

Thanks,
Ayush

Re: linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

Hi Ayush,

On Tue, 2 Jun 2020 13:01:09 +0530 Ayush Sawal <ayush.sawal@chelsio.com> wrote:
>
> On 6/2/2020 4:42 AM, Stephen Rothwell wrote:
> >
> > In commit
> >
> >    055be6865dea ("Crypto/chcr: Fixes a coccinile check error")
> >
> > Fixes tag
> >
> >    Fixes: 567be3a5d227 ("crypto:
> >
> > has these problem(s):
> >
> >    - Subject has leading but no trailing parentheses
> >    - Subject has leading but no trailing quotes
> >
> > Please do not split Fixes tags over more than one line.  
> 
> I am so sorry for this mistake.
> Is there a way to fix this?

No, David does not rebase his tree.  Just remember for next time.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[Ayush Sawal]

On 6/2/2020 3:48 PM, Stephen Rothwell wrote:
> Hi Ayush,
>
> On Tue, 2 Jun 2020 13:01:09 +0530 Ayush Sawal <ayush.sawal@chelsio.com> wrote:
>> On 6/2/2020 4:42 AM, Stephen Rothwell wrote:
>>> In commit
>>>
>>>     055be6865dea ("Crypto/chcr: Fixes a coccinile check error")
>>>
>>> Fixes tag
>>>
>>>     Fixes: 567be3a5d227 ("crypto:
>>>
>>> has these problem(s):
>>>
>>>     - Subject has leading but no trailing parentheses
>>>     - Subject has leading but no trailing quotes
>>>
>>> Please do not split Fixes tags over more than one line.
>> I am so sorry for this mistake.
>> Is there a way to fix this?
> No, David does not rebase his tree.  Just remember for next time.

Okay , i will keep this in mind. Thanks.

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Hi all,

In commit

  7dec902f4fc0 ("net: mscc: ocelot: refine the ocelot_ace_is_problematic_mac_etype function")

Fixes tag

  Fixes: d4d0cb741d7b ("net: mscc: ocelot: deal with problematic MAC_ETYPE VCAP IS2 rules")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 89f9ffd3eb67 ("net: mscc: ocelot: deal with problematic MAC_ETYPE VCAP IS2 rules")

Dave, since you don't rebase your tree, can you start pushing back on
these, please?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi all,

In commit

  fe867cac9e19 ("net/mlx5e: Use preactivate hook to set the indirection table")

Fixes tag

  Fixes: 85082dba0a ("net/mlx5e: Correctly handle RSS indirection table when changing number of channels")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[Maxim Mikityanskiy]

On 2020-02-27 06:42, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    fe867cac9e19 ("net/mlx5e: Use preactivate hook to set the indirection table")
> 
> Fixes tag
> 
>    Fixes: 85082dba0a ("net/mlx5e: Correctly handle RSS indirection table when changing number of channels")
> 
> has these problem(s):
> 
>    - SHA1 should be at least 12 digits long
>      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>      or later) just making sure it is not set (or set to "auto").
> 

Oops, so sorry about that =/

I relied on our CI that has to check the Fixes tag, but apparently 
failed this time. We'll address the issue with CI.

The correct tag is:

Fixes: 85082dba0a50 ("net/mlx5e: Correctly handle RSS indirection table 
when changing number of channels")

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi all,

In commit

  7bf47f609f7e ("sh_eth: check sh_eth_cpu_data::no_xdfar when dumping registers")

Fixes tag

  Fixes: 4c1d45850d5 ("sh_eth: add sh_eth_cpu_data::cexcr flag")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

Hi all,

In commit

  b7ffa045e700 ("tipc: don't send gap blocks in ACK messages")

Fixes tag

  Fixes: commit 02288248b051 ("tipc: eliminate gap indicator from ACK messages")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi all,

In commit

  4c76bf696a60 ("net: openvswitch: don't unlock mutex when changing the user_features fails")

Fixes tag

  Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain index")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Hi all,

In commit

  ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()")

Fixes tag

  Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types")

has these problem(s):

  - missing space between the SHA1 and the subject

Presumably:

Fixes: c93cc69004df ("bpftool: add ability to dump BTF types")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi all,

In commit

  7c5b42055964 ("tipc: reduce risk of wakeup queue starvation")

Fixes tag

  Fixes: 365ad35 ("tipc: reduce risk of user starvation during link congestion")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi all,

In commit

  473d924d7d46 ("can: fix ioctl function removal")

Fixes tag

  Fixes: 60649d4e0af ("can: remove obsolete empty ioctl() handler")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi all,

In commit

  66b5f1c43984 ("net-ipv6-ndisc: add support for RFC7710 RA Captive Portal Identifier")

Fixes tag

  Fixes: e35f30c131a56

has these problem(s):

  - missing subject

Did you mean

Fixes: e35f30c131a5 ("Treat ND option 31 as userland (DNSSL support)")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi Maciej,

On Tue, 23 Jul 2019 09:46:29 +0900 Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
>
> I'm afraid I'm currently travelling and due to an unplanned and f'ed up
> office move I've lost (access to?) my dev workstation so I can't respin
> this.  Might be too late either way?

Yeah, Dave doesn't rebase his trees, so just take this as a lesson for
next time. :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

In commit

  d62962b37ceb ("loopback: fix lockdep splat")

Fixes tag

  Fixes: 4de83b88c66 ("loopback: create blackhole net device similar to loopack.")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi all,

In commit

  18d219b783da ("net: hns3: fix a -Wformat-nonliteral compile warning")

Fixes tag

  Fixes: 46a3df9f9718 ("Add HNS3 Acceleration Engine & Compatibility Layer Support")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Hi all,

In commit

  7d26c96052cd ("nfp: flower: fix size_t compile warning")

Fixes tag

  Fixes: a6156a6ab0f9 ("nfp: flower: handle merge hint messages")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: dbc2d68edc98 ("nfp: flower: handle merge hint messages")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[John Hurley]

On Mon, Apr 22, 2019 at 10:26 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   7d26c96052cd ("nfp: flower: fix size_t compile warning")
>
> Fixes tag
>
>   Fixes: a6156a6ab0f9 ("nfp: flower: handle merge hint messages")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: dbc2d68edc98 ("nfp: flower: handle merge hint messages")
>

Hi Stephen,
Yes, the fixes SHA1 tag you have is correct.
I have no idea how the incorrect one went in!
Thanks,
John

> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

In commit

  e1279ff7aec1 ("tipc: add NULL pointer check")

Fixes tag

  Fixes: c55c8edafa9 ("tipc: smooth change between replicast and broadcast")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Hi all,

In commits

  08e046c8966a ("tipc: fix a null pointer deref")
  77d5ad4048fb ("tipc: fix use-after-free in tipc_sk_filter_rcv")

Fixes tag

  Fixes: c55c8eda ("tipc: smooth change between replicast and broadcast")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi all,

In commit

  a638b1d8cc87 ("net: hns3: fix get VF RSS issue")

Fixes tag

  Fixes: 374ad291762a ("net: hns3: net: hns3: Add RSS general configuration support for VF")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h (%s)'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[tanhuazhong]

Hi Stephen & David,

It is my mistake, so sorry about this. There is a redundant "net: hns3: 
" in the fixes tag.

How could I fix it?

Thanks.

On 2019/2/25 16:00, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    a638b1d8cc87 ("net: hns3: fix get VF RSS issue")
> 
> Fixes tag
> 
>    Fixes: 374ad291762a ("net: hns3: net: hns3: Add RSS general configuration support for VF")
> 
> has these problem(s):
> 
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h (%s)'
> 

Re: linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hi,

On Wed, 27 Feb 2019 09:12:57 +0800 tanhuazhong <tanhuazhong@huawei.com> wrote:
>
> It is my mistake, so sorry about this. There is a redundant "net: hns3: 
> " in the fixes tag.
> 
> How could I fix it?

Since Dave doesn't rebase his tree, there is no way to fix it (and it
is not that important any in this case), just use this as a learning
experience for next time :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the net-next tree

[tanhuazhong]

On 2019/2/27 10:23, Stephen Rothwell wrote:
> Hi,
> 
> On Wed, 27 Feb 2019 09:12:57 +0800 tanhuazhong <tanhuazhong@huawei.com> wrote:
>>
>> It is my mistake, so sorry about this. There is a redundant "net: hns3:
>> " in the fixes tag.
>>
>> How could I fix it?
> 
> Since Dave doesn't rebase his tree, there is no way to fix it (and it
> is not that important any in this case), just use this as a learning
> experience for next time :-)
> 

Thanks :)

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi all,

In commit

  cbd72b485214 ("net: dsa: microchip: add switch offload forwarding support")

Fixes tag

  Fixes: c2e866911e254067 ("microchip: break KSZ9477 DSA driver into two files")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi all,

In commit

  9fc55413270f ("net: hns3: fix improper error handling in the hclge_init_ae_dev()")

Fixes tag

  Fixes: 288475b2ad01 ("{topost} net: hns3: refine umv space allocation")

has these problem(s):

  - Target SHA1 does not exist

I can't even find it by simple searches for the subject ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]