From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Zhangshaokun <zhangshaokun@hisilicon.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Roberto Sassu <roberto.sassu@huawei.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Feb 20
Date: Wed, 20 Feb 2019 11:52:52 +0200 [thread overview]
Message-ID: <20190220095252.GA9089@linux.intel.com> (raw)
In-Reply-To: <1114b964-8ff8-5632-64d4-e94a9160b998@hisilicon.com>
On Wed, Feb 20, 2019 at 05:11:15PM +0800, Zhangshaokun wrote:
> There is a compiler failure on arm64 platform, as follow:
>
> AS arch/arm64/kvm/hyp.o
> CC kernel/trace/ring_buffer.o
> In file included from security/integrity/ima/ima_fs.c:30:0:
> security/integrity/ima/ima.h:176:7: error: redeclaration of enumerator ‘NONE’
> hook(NONE) \
> ^
> security/integrity/ima/ima.h:188:34: note: in definition of macro ‘__ima_hook_enumify’
> #define __ima_hook_enumify(ENUM) ENUM,
> ^
> security/integrity/ima/ima.h:191:2: note: in expansion of macro ‘__ima_hooks’
> __ima_hooks(__ima_hook_enumify)
> ^
> In file included from ./arch/arm64/include/asm/acpi.h:15:0,
> from ./include/acpi/acpi_io.h:7,
> from ./include/linux/acpi.h:47,
> from ./include/linux/tpm.h:26,
> from security/integrity/ima/ima.h:25,
> from security/integrity/ima/ima_fs.c:30:
> ./include/linux/efi.h:1716:2: note: previous definition of ‘NONE’ was here
> NONE,
> ^
> scripts/Makefile.build:276: recipe for target 'security/integrity/ima/ima_fs.o' failed
> make[3]: *** [security/integrity/ima/ima_fs.o] Error 1
>
> I dug it and it is the commit 901615cb916d ("tpm: move tpm_chip definition to include/linux/tpm.h")
This results from a new include in tpm.h:
#include <linux/acpi.h>
Must be fixed either in include/linux/efi.h or security/integrity/ima.h as
those files have a name collision. Makes me wonder why neither has taken
care of prefixing the constants properly.
/Jarkko
next prev parent reply other threads:[~2019-02-20 9:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 7:43 linux-next: Tree for Feb 20 Stephen Rothwell
2019-02-20 9:11 ` Zhangshaokun
2019-02-20 9:52 ` Jarkko Sakkinen [this message]
2019-02-20 9:58 ` Jarkko Sakkinen
2019-02-20 10:05 ` Ard Biesheuvel
2019-02-20 12:17 ` Mimi Zohar
2019-02-21 0:43 ` Zhangshaokun
2019-02-21 8:03 ` Geert Uytterhoeven
2019-02-21 8:42 ` Zhangshaokun
2019-02-21 9:12 ` Ard Biesheuvel
-- strict thread matches above, loose matches on Subject: below --
2024-02-20 5:13 Stephen Rothwell
2023-02-20 5:39 Stephen Rothwell
2020-02-20 3:44 Stephen Rothwell
2017-02-20 4:57 Stephen Rothwell
2015-02-20 1:59 Stephen Rothwell
2014-02-20 6:58 Stephen Rothwell
2013-02-20 6:50 Stephen Rothwell
2012-02-20 5:59 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220095252.GA9089@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=sfr@canb.auug.org.au \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).