From: Darren Hart <dvhart@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree
Date: Sat, 23 Feb 2019 09:52:07 -0800 [thread overview]
Message-ID: <20190223175207.GC4722@wrath> (raw)
In-Reply-To: <20190224011925.6db87446@canb.auug.org.au>
On Sun, Feb 24, 2019 at 01:19:25AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 9bfe33ba29d0 ("x86/CPU: Add Icelake model number")
>
> is missing a Signed-off-by from its committer.
>
Hi Stephen,
Apologies if I've asked you this before... I didn't find it after some
searching.
We should be catching errors like this before they hit next. First,
there is no reason we can't catch them - unlike the integration failures
only next can catch. Second, once they are in next, there is no "right"
way to fix them. Either rebase or send the bad patch to mainline - both
are bad. Don't get me wrong, I'm glad next catches them.... but I'd like
to get to the point where it doesn't trigger on our subsystem :-)
Are your patch mechanics tests available for us to integrate into our
commit and prepublication checks?
Thanks,
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2019-02-23 17:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 14:19 linux-next: Signed-off-by missing for commit in the drivers-x86 tree Stephen Rothwell
2019-02-23 17:10 ` Darren Hart
2019-02-23 17:52 ` Darren Hart [this message]
2019-02-23 22:56 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2023-06-07 23:15 Stephen Rothwell
2023-06-08 9:02 ` Hans de Goede
2023-02-02 21:33 Stephen Rothwell
2023-02-03 9:06 ` Hans de Goede
2021-04-14 13:51 Stephen Rothwell
2021-04-14 13:55 ` Hans de Goede
2021-04-08 12:13 Stephen Rothwell
2021-04-08 14:18 ` Hans de Goede
2019-05-06 13:22 Stephen Rothwell
2019-05-06 14:50 ` Andy Shevchenko
2018-08-18 14:35 Stephen Rothwell
2018-08-19 8:21 ` Hans de Goede
2018-08-19 8:48 ` Stephen Rothwell
2018-06-01 11:36 Stephen Rothwell
2018-06-01 11:40 ` Andy Shevchenko
2018-06-01 12:08 ` Stephen Rothwell
2018-06-01 14:33 ` dvhart
2018-06-01 14:55 ` Andy Shevchenko
2018-06-01 14:38 ` dvhart
2018-06-01 15:26 ` Stephen Rothwell
2018-06-01 16:43 ` Darren Hart
2018-06-01 14:45 ` Andy Shevchenko
2017-08-02 20:37 Stephen Rothwell
2017-08-02 23:57 ` Darren Hart
2017-08-03 0:28 ` Stephen Rothwell
2017-08-03 1:06 ` Linus Torvalds
2017-08-03 15:50 ` Darren Hart
2017-08-05 21:58 ` Darren Hart
2017-08-16 23:21 ` Darren Hart
2017-08-24 20:56 ` Darren Hart
2017-08-04 17:44 ` Junio C Hamano
2017-08-04 17:47 ` Darren Hart
2017-08-03 8:17 ` Andy Shevchenko
2017-08-03 9:27 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190223175207.GC4722@wrath \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).