Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure after merge of the scsi-mkp tree
@ 2019-04-09  6:27 Stephen Rothwell
  2019-04-10  1:21 ` Stephen Rothwell
  0 siblings, 1 reply; 34+ messages in thread
From: Stephen Rothwell @ 2019-04-09  6:27 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Bart Van Assche

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/scsi/qla2xxx/tcm_qla2xxx.c: In function 'tcm_qla2xxx_init_lport':
drivers/scsi/qla2xxx/tcm_qla2xxx.c:1614:3: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
   vzalloc(array_size(65536,
   ^~~~~~~
   kvzalloc
drivers/scsi/qla2xxx/tcm_qla2xxx.c:1613:26: warning: assignment to 'struct tcm_qla2xxx_fc_loopid *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  lport->lport_loopid_map =
                          ^
drivers/scsi/qla2xxx/tcm_qla2xxx.c: In function 'tcm_qla2xxx_make_lport':
drivers/scsi/qla2xxx/tcm_qla2xxx.c:1677:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
  vfree(lport->lport_loopid_map);
  ^~~~~
  kvfree

Caused by commit

  523c106ad4b1 ("scsi: tcm_qla2xxx: Minimize #include directives")

I have reverted that commit for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2019-04-09  6:27 linux-next: build failure after merge of the scsi-mkp tree Stephen Rothwell
@ 2019-04-10  1:21 ` Stephen Rothwell
  2019-04-10  1:33   ` Martin K. Petersen
  0 siblings, 1 reply; 34+ messages in thread
From: Stephen Rothwell @ 2019-04-10  1:21 UTC (permalink / raw)
  To: James Bottomley
  Cc: Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List, Bart Van Assche

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

Hi all,

On Tue, 9 Apr 2019 16:27:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/scsi/qla2xxx/tcm_qla2xxx.c: In function 'tcm_qla2xxx_init_lport':
> drivers/scsi/qla2xxx/tcm_qla2xxx.c:1614:3: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
>    vzalloc(array_size(65536,
>    ^~~~~~~
>    kvzalloc
> drivers/scsi/qla2xxx/tcm_qla2xxx.c:1613:26: warning: assignment to 'struct tcm_qla2xxx_fc_loopid *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   lport->lport_loopid_map =
>                           ^
> drivers/scsi/qla2xxx/tcm_qla2xxx.c: In function 'tcm_qla2xxx_make_lport':
> drivers/scsi/qla2xxx/tcm_qla2xxx.c:1677:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
>   vfree(lport->lport_loopid_map);
>   ^~~~~
>   kvfree
> 
> Caused by commit
> 
>   523c106ad4b1 ("scsi: tcm_qla2xxx: Minimize #include directives")
> 
> I have reverted that commit for today.

This has now migrated to the scsi tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2019-04-10  1:21 ` Stephen Rothwell
@ 2019-04-10  1:33   ` Martin K. Petersen
  2019-04-10  4:04     ` James Bottomley
  0 siblings, 1 reply; 34+ messages in thread
From: Martin K. Petersen @ 2019-04-10  1:33 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List, Bart Van Assche


Stephen,

>> I have reverted that commit for today.
>
> This has now migrated to the scsi tree.

I have a fix in my tree but I haven't pushed it yet.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2019-04-10  1:33   ` Martin K. Petersen
@ 2019-04-10  4:04     ` James Bottomley
  2019-04-10  4:57       ` Stephen Rothwell
  0 siblings, 1 reply; 34+ messages in thread
From: James Bottomley @ 2019-04-10  4:04 UTC (permalink / raw)
  To: Martin K. Petersen, Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Bart Van Assche

On Tue, 2019-04-09 at 21:33 -0400, Martin K. Petersen wrote:
> Stephen,
> 
> > > I have reverted that commit for today.
> > 
> > This has now migrated to the scsi tree.
> 
> I have a fix in my tree but I haven't pushed it yet.

It's upstream in both trees now.

James

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2019-04-10  4:04     ` James Bottomley
@ 2019-04-10  4:57       ` Stephen Rothwell
  0 siblings, 0 replies; 34+ messages in thread
From: Stephen Rothwell @ 2019-04-10  4:57 UTC (permalink / raw)
  To: James Bottomley
  Cc: Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List, Bart Van Assche

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hi all,

On Wed, 10 Apr 2019 06:04:19 +0200 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
> On Tue, 2019-04-09 at 21:33 -0400, Martin K. Petersen wrote:
> >   
> > > > I have reverted that commit for today.  
> > > 
> > > This has now migrated to the scsi tree.  
> > 
> > I have a fix in my tree but I haven't pushed it yet.  
> 
> It's upstream in both trees now.

Thanks, it'll be in -next tomorrow.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2019-10-29  2:28   ` Martin K. Petersen
@ 2019-10-29  2:48     ` Stephen Rothwell
  0 siblings, 0 replies; 34+ messages in thread
From: Stephen Rothwell @ 2019-10-29  2:48 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: James Bottomley, Linux Next Mailing List,
	Linux Kernel Mailing List, James Smart

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Hi Martin,

On Mon, 28 Oct 2019 22:28:03 -0400 "Martin K. Petersen" <martin.petersen@oracle.com> wrote:
>
> >> I have used the scsi-mkp tree from next-20191024 for today.  
> >
> > This build failure now appears in the scsi tree build.  I have applied
> > the fix from James Smart for today.  
> 
> Should be fixed in my for-next now.

Thanks.  I also see that James B has merged your tree, so its all good
now.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2019-10-28  5:49 ` Stephen Rothwell
@ 2019-10-29  2:28   ` Martin K. Petersen
  2019-10-29  2:48     ` Stephen Rothwell
  0 siblings, 1 reply; 34+ messages in thread
From: Martin K. Petersen @ 2019-10-29  2:28 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, James Bottomley, Linux Next Mailing List,
	Linux Kernel Mailing List, James Smart


Stephen,

>> I have used the scsi-mkp tree from next-20191024 for today.
>
> This build failure now appears in the scsi tree build.  I have applied
> the fix from James Smart for today.

Should be fixed in my for-next now.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2019-10-25  3:07 Stephen Rothwell
  2019-10-25 18:03 ` James Smart
@ 2019-10-28  5:49 ` Stephen Rothwell
  2019-10-29  2:28   ` Martin K. Petersen
  1 sibling, 1 reply; 34+ messages in thread
From: Stephen Rothwell @ 2019-10-28  5:49 UTC (permalink / raw)
  To: Martin K. Petersen, James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, James Smart

[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]

Hi all,

On Fri, 25 Oct 2019 14:07:36 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_release':
> drivers/scsi/lpfc/lpfc_debugfs.c:2109:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
>  2109 |  vfree(debug->buffer);
>       |  ^~~~~
>       |  kvfree
> drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_open':
> drivers/scsi/lpfc/lpfc_debugfs.c:2150:18: error: implicit declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration]
>  2150 |  debug->buffer = vmalloc(size);
>       |                  ^~~~~~~
>       |                  kvmalloc
> drivers/scsi/lpfc/lpfc_debugfs.c:2150:16: warning: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>  2150 |  debug->buffer = vmalloc(size);
>       |                ^
> 
> Caused by commit
> 
>   95bfc6d8ad86 ("scsi: lpfc: Make FW logging dynamically configurable")
> 
> I have used the scsi-mkp tree from next-20191024 for today.

This build failure now appears in the scsi tree build.  I have applied the
fix from James Smart for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2019-10-25  3:07 Stephen Rothwell
@ 2019-10-25 18:03 ` James Smart
  2019-10-28  5:49 ` Stephen Rothwell
  1 sibling, 0 replies; 34+ messages in thread
From: James Smart @ 2019-10-25 18:03 UTC (permalink / raw)
  To: Stephen Rothwell, Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 10/24/2019 8:07 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_release':
> drivers/scsi/lpfc/lpfc_debugfs.c:2109:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
>   2109 |  vfree(debug->buffer);
>        |  ^~~~~
>        |  kvfree
> drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_open':
> drivers/scsi/lpfc/lpfc_debugfs.c:2150:18: error: implicit declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration]
>   2150 |  debug->buffer = vmalloc(size);
>        |                  ^~~~~~~
>        |                  kvmalloc
> drivers/scsi/lpfc/lpfc_debugfs.c:2150:16: warning: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   2150 |  debug->buffer = vmalloc(size);
>        |                ^
> 
> Caused by commit
> 
>    95bfc6d8ad86 ("scsi: lpfc: Make FW logging dynamically configurable")
> 
> I have used the scsi-mkp tree from next-20191024 for today.
> 

I will resolve this quickly...

-- james

^ permalink raw reply	[flat|nested] 34+ messages in thread

* linux-next: build failure after merge of the scsi-mkp tree
@ 2019-10-25  3:07 Stephen Rothwell
  2019-10-25 18:03 ` James Smart
  2019-10-28  5:49 ` Stephen Rothwell
  0 siblings, 2 replies; 34+ messages in thread
From: Stephen Rothwell @ 2019-10-25  3:07 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, James Smart

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_release':
drivers/scsi/lpfc/lpfc_debugfs.c:2109:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
 2109 |  vfree(debug->buffer);
      |  ^~~~~
      |  kvfree
drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_open':
drivers/scsi/lpfc/lpfc_debugfs.c:2150:18: error: implicit declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration]
 2150 |  debug->buffer = vmalloc(size);
      |                  ^~~~~~~
      |                  kvmalloc
drivers/scsi/lpfc/lpfc_debugfs.c:2150:16: warning: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
 2150 |  debug->buffer = vmalloc(size);
      |                ^

Caused by commit

  95bfc6d8ad86 ("scsi: lpfc: Make FW logging dynamically configurable")

I have used the scsi-mkp tree from next-20191024 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2018-03-22  6:25 Stephen Rothwell
@ 2018-03-22 16:33 ` Madhani, Himanshu
  0 siblings, 0 replies; 34+ messages in thread
From: Madhani, Himanshu @ 2018-03-22 16:33 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, Linux-Next Mailing List,
	Linux Kernel Mailing List, Trapp, Darren, Tran, Quinn

Hi Stephen, 


> On Mar 21, 2018, at 11:25 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi Martin,
> 
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/scsi/qla2xxx/qla_gs.c: In function 'qla24xx_async_gnnft_done':
> drivers/scsi/qla2xxx/qla_gs.c:3974:7: error: 'fc4type' undeclared (first use in this function); did you mean 'fc4type_t'?
>  if ((fc4type == FC4_TYPE_FCP_SCSI) && vha->flags.nvme_enabled)
>       ^~~~~~~
>       fc4type_t
> drivers/scsi/qla2xxx/qla_gs.c:3974:7: note: each undeclared identifier is reported only once for each function it appears in
> drivers/scsi/qla2xxx/qla_gs.c:3975:3: error: too few arguments to function 'qla24xx_async_gpnft'
>   qla24xx_async_gpnft(vha, FC4_TYPE_NVME);
>   ^~~~~~~~~~~~~~~~~~~
> In file included from drivers/scsi/qla2xxx/qla_def.h:4633:0,
>                 from drivers/scsi/qla2xxx/qla_gs.c:7:
> drivers/scsi/qla2xxx/qla_gbl.h:661:5: note: declared here
> int qla24xx_async_gpnft(scsi_qla_host_t *, u8, srb_t *);
>     ^~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>  33b28357dd00 ("scsi: qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan")
> 
> interacting with commit
> 
>  2b5b96473efc ("scsi: qla2xxx: Fix FC-NVMe LUN discovery")
> 
> from Linus' tree.
> 
> I have added the following merge fix patch for today. Unfortunately it
> produces this warning, so a better merge resolution is needed ...
> 
> drivers/scsi/qla2xxx/qla_gs.c: In function 'qla24xx_async_gnnft_done':
> drivers/scsi/qla2xxx/qla_gs.c:3974:9: warning: 'rp' may be used uninitialized in this function [-Wmaybe-uninitialized]
>  if ((rp->fc4type == FC4_TYPE_FCP_SCSI) && vha->flags.nvme_enabled)
>       ~~^~~~~~~~~
> 
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 22 Mar 2018 17:09:38 +1100
> Subject: [PATCH] scsi: qla2xxx: merge fix in qla_gs.c
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/scsi/qla2xxx/qla_gs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
> index f84807e850c3..d33f4619332e 100644
> --- a/drivers/scsi/qla2xxx/qla_gs.c
> +++ b/drivers/scsi/qla2xxx/qla_gs.c
> @@ -3971,8 +3971,8 @@ void qla24xx_async_gnnft_done(scsi_qla_host_t *vha, srb_t *sp)
> 	vha->scan.scan_flags &= ~SF_SCANNING;
> 	spin_unlock_irqrestore(&vha->work_lock, flags);
> 
> -	if ((fc4type == FC4_TYPE_FCP_SCSI) && vha->flags.nvme_enabled)
> -		qla24xx_async_gpnft(vha, FC4_TYPE_NVME);
> +	if ((rp->fc4type == FC4_TYPE_FCP_SCSI) && vha->flags.nvme_enabled)
> +		qla24xx_async_gpnft(vha, FC4_TYPE_NVME, NULL);
> }
> 
> static void qla2x00_find_free_fcp_nvme_slot(struct scsi_qla_host *vha,
> -- 
> 2.16.1
> 
> -- 
> Cheers,
> Stephen Rothwell

Thanks so much to attempt to fix the build failure. I was aware of this issue and had 
send the diff yesterday with change that should be used for resolving merge conflict and
compile failure. 

Please use following to fix for the merge conflict and compile failure. 

diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 403fa096f8c8..21eff2d30266 100644
--- a/drivers/scsi/qla2xxx/qla_gs.c
+++ b/drivers/scsi/qla2xxx/qla_gs.c
@@ -3973,9 +3973,6 @@ void qla24xx_async_gnnft_done(scsi_qla_host_t *vha, srb_t *sp)
       spin_lock_irqsave(&vha->work_lock, flags);
       vha->scan.scan_flags &= ~SF_SCANNING;
       spin_unlock_irqrestore(&vha->work_lock, flags);
-
-       if ((fc4type == FC4_TYPE_FCP_SCSI) && vha->flags.nvme_enabled)
-               qla24xx_async_gpnft(vha, FC4_TYPE_NVME);
}

static void qla2x00_async_gpnft_gnnft_sp_done(void *s, int res)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 5c5dcca4d1da..dab847ba4bce 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4822,9 +4822,10 @@ void qla24xx_create_new_sess(struct scsi_qla_host *vha, struct qla_work_evt *e)
                       fcport->d_id = e->u.new_sess.id;
                       fcport->flags |= FCF_FABRIC_DEVICE;
                       fcport->fw_login_state = DSC_LS_PLOGI_PEND;
-                       if (e->u.new_sess.fc4_type == FC4_TYPE_FCP_SCSI) {
+                       if (e->u.new_sess.fc4_type & FC4_TYPE_FCP_SCSI)
                               fcport->fc4_type = FC4_TYPE_FCP_SCSI;
-                       } else if (e->u.new_sess.fc4_type == FC4_TYPE_NVME) {
+
+                       if (e->u.new_sess.fc4_type & FC4_TYPE_NVME) {
                               fcport->fc4_type = FC4_TYPE_OTHER;
                               fcport->fc4f_nvme = FC4_TYPE_NVME;
                       }
(END)

Thanks,
- Himanshu

^ permalink raw reply	[flat|nested] 34+ messages in thread

* linux-next: build failure after merge of the scsi-mkp tree
@ 2018-03-22  6:25 Stephen Rothwell
  2018-03-22 16:33 ` Madhani, Himanshu
  0 siblings, 1 reply; 34+ messages in thread
From: Stephen Rothwell @ 2018-03-22  6:25 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Darren Trapp,
	Himanshu Madhani, Quinn Tran

[-- Attachment #1: Type: text/plain, Size: 2637 bytes --]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/scsi/qla2xxx/qla_gs.c: In function 'qla24xx_async_gnnft_done':
drivers/scsi/qla2xxx/qla_gs.c:3974:7: error: 'fc4type' undeclared (first use in this function); did you mean 'fc4type_t'?
  if ((fc4type == FC4_TYPE_FCP_SCSI) && vha->flags.nvme_enabled)
       ^~~~~~~
       fc4type_t
drivers/scsi/qla2xxx/qla_gs.c:3974:7: note: each undeclared identifier is reported only once for each function it appears in
drivers/scsi/qla2xxx/qla_gs.c:3975:3: error: too few arguments to function 'qla24xx_async_gpnft'
   qla24xx_async_gpnft(vha, FC4_TYPE_NVME);
   ^~~~~~~~~~~~~~~~~~~
In file included from drivers/scsi/qla2xxx/qla_def.h:4633:0,
                 from drivers/scsi/qla2xxx/qla_gs.c:7:
drivers/scsi/qla2xxx/qla_gbl.h:661:5: note: declared here
 int qla24xx_async_gpnft(scsi_qla_host_t *, u8, srb_t *);
     ^~~~~~~~~~~~~~~~~~~

Caused by commit

  33b28357dd00 ("scsi: qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan")

interacting with commit

  2b5b96473efc ("scsi: qla2xxx: Fix FC-NVMe LUN discovery")

from Linus' tree.

I have added the following merge fix patch for today. Unfortunately it
produces this warning, so a better merge resolution is needed ...

drivers/scsi/qla2xxx/qla_gs.c: In function 'qla24xx_async_gnnft_done':
drivers/scsi/qla2xxx/qla_gs.c:3974:9: warning: 'rp' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if ((rp->fc4type == FC4_TYPE_FCP_SCSI) && vha->flags.nvme_enabled)
       ~~^~~~~~~~~


From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 22 Mar 2018 17:09:38 +1100
Subject: [PATCH] scsi: qla2xxx: merge fix in qla_gs.c

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/scsi/qla2xxx/qla_gs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index f84807e850c3..d33f4619332e 100644
--- a/drivers/scsi/qla2xxx/qla_gs.c
+++ b/drivers/scsi/qla2xxx/qla_gs.c
@@ -3971,8 +3971,8 @@ void qla24xx_async_gnnft_done(scsi_qla_host_t *vha, srb_t *sp)
 	vha->scan.scan_flags &= ~SF_SCANNING;
 	spin_unlock_irqrestore(&vha->work_lock, flags);
 
-	if ((fc4type == FC4_TYPE_FCP_SCSI) && vha->flags.nvme_enabled)
-		qla24xx_async_gpnft(vha, FC4_TYPE_NVME);
+	if ((rp->fc4type == FC4_TYPE_FCP_SCSI) && vha->flags.nvme_enabled)
+		qla24xx_async_gpnft(vha, FC4_TYPE_NVME, NULL);
 }
 
 static void qla2x00_find_free_fcp_nvme_slot(struct scsi_qla_host *vha,
-- 
2.16.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-08  1:00               ` Martin K. Petersen
@ 2017-12-11 17:43                 ` Paul E. McKenney
  0 siblings, 0 replies; 34+ messages in thread
From: Paul E. McKenney @ 2017-12-11 17:43 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Stephen Rothwell, Bart Van Assche, josh, linux-kernel,
	linux-scsi, linux-next, ptikhomirov

On Thu, Dec 07, 2017 at 08:00:50PM -0500, Martin K. Petersen wrote:
> 
> > I'm perfectly OK with taking it through the SCSI tree. Probably the
> > path of least resistance.
> 
> Applied to 4.16/scsi-queue and rebased so it sits before Bart's patch.

Thank you!  I have removed this patch from -rcu.

							Thanx, Paul

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-07 21:11             ` Martin K. Petersen
@ 2017-12-08  1:00               ` Martin K. Petersen
  2017-12-11 17:43                 ` Paul E. McKenney
  0 siblings, 1 reply; 34+ messages in thread
From: Martin K. Petersen @ 2017-12-08  1:00 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Stephen Rothwell, Paul E. McKenney, Bart Van Assche, josh,
	linux-kernel, linux-scsi, linux-next, ptikhomirov


> I'm perfectly OK with taking it through the SCSI tree. Probably the
> path of least resistance.

Applied to 4.16/scsi-queue and rebased so it sits before Bart's patch.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-07 20:34           ` Stephen Rothwell
  2017-12-07 21:10             ` Paul E. McKenney
@ 2017-12-07 21:11             ` Martin K. Petersen
  2017-12-08  1:00               ` Martin K. Petersen
  1 sibling, 1 reply; 34+ messages in thread
From: Martin K. Petersen @ 2017-12-07 21:11 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Paul E. McKenney, Bart Van Assche, josh, linux-kernel,
	linux-scsi, linux-next, martin.petersen, ptikhomirov


Stephen,

>> I have to defer to you guys on that one.  Left to myself, I will just
>> push it into the next merge window (as opposed to using my normal
>> process, which at this point would get it into the one following).
>> 
>> So please let me know how you would like to proceed.
>
> Clearly, it needs to go via Martin's tree as otherwise his tree will
> not build in some circumstances ... or if it going to cause problems
> for Paul, then it should be in a separate non-rebasing branch (probably
> of Paul's tree) that is merged into Pauls main branch and Marin's tree.

I'm perfectly OK with taking it through the SCSI tree. Probably the path
of least resistance.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-07 20:34           ` Stephen Rothwell
@ 2017-12-07 21:10             ` Paul E. McKenney
  2017-12-07 21:11             ` Martin K. Petersen
  1 sibling, 0 replies; 34+ messages in thread
From: Paul E. McKenney @ 2017-12-07 21:10 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Bart Van Assche, josh, linux-kernel, linux-scsi, linux-next,
	martin.petersen, ptikhomirov

On Fri, Dec 08, 2017 at 07:34:39AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Thu, 7 Dec 2017 09:40:38 -0800 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> >
> > On Thu, Dec 07, 2017 at 05:30:03PM +0000, Bart Van Assche wrote:
> > > However, what's not clear to me is through which tree this patch should be
> > > sent to Linus? Should the above patch be sent as a v4.15-rc fix or should
> > > Martin perhaps queue it in his tree for v4.16-rc1?  
> > 
> > I have to defer to you guys on that one.  Left to myself, I will just
> > push it into the next merge window (as opposed to using my normal process,
> > which at this point would get it into the one following).
> > 
> > So please let me know how you would like to proceed.
> 
> Clearly, it needs to go via Martin's tree as otherwise his tree will
> not build in some circumstances ... or if it going to cause problems
> for Paul, then it should be in a separate non-rebasing branch (probably
> of Paul's tree) that is merged into Pauls main branch and Marin's tree.

It is unlikely to cause problems, so please let it go up where convenient.

Just please let me know.

							Thanx, Paul

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-07 17:40         ` Paul E. McKenney
@ 2017-12-07 20:34           ` Stephen Rothwell
  2017-12-07 21:10             ` Paul E. McKenney
  2017-12-07 21:11             ` Martin K. Petersen
  0 siblings, 2 replies; 34+ messages in thread
From: Stephen Rothwell @ 2017-12-07 20:34 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Bart Van Assche, josh, linux-kernel, linux-scsi, linux-next,
	martin.petersen, ptikhomirov

Hi all,

On Thu, 7 Dec 2017 09:40:38 -0800 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
> On Thu, Dec 07, 2017 at 05:30:03PM +0000, Bart Van Assche wrote:
> > However, what's not clear to me is through which tree this patch should be
> > sent to Linus? Should the above patch be sent as a v4.15-rc fix or should
> > Martin perhaps queue it in his tree for v4.16-rc1?  
> 
> I have to defer to you guys on that one.  Left to myself, I will just
> push it into the next merge window (as opposed to using my normal process,
> which at this point would get it into the one following).
> 
> So please let me know how you would like to proceed.

Clearly, it needs to go via Martin's tree as otherwise his tree will
not build in some circumstances ... or if it going to cause problems
for Paul, then it should be in a separate non-rebasing branch (probably
of Paul's tree) that is merged into Pauls main branch and Marin's tree.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-07 17:30       ` Bart Van Assche
@ 2017-12-07 17:40         ` Paul E. McKenney
  2017-12-07 20:34           ` Stephen Rothwell
  0 siblings, 1 reply; 34+ messages in thread
From: Paul E. McKenney @ 2017-12-07 17:40 UTC (permalink / raw)
  To: Bart Van Assche
  Cc: sfr, josh, linux-kernel, linux-scsi, linux-next, martin.petersen,
	ptikhomirov

On Thu, Dec 07, 2017 at 05:30:03PM +0000, Bart Van Assche wrote:
> On Wed, 2017-12-06 at 20:42 -0800, Paul E. McKenney wrote:
> > On Thu, Dec 07, 2017 at 03:25:21PM +1100, Stephen Rothwell wrote:
> > > On Thu, 7 Dec 2017 03:59:30 +0000 Bart Van Assche <Bart.VanAssche@wdc.com> wrote:

[ . . . ]

> > commit cde4691a3a4591e7355295dd62610e3262159002
> > Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Date:   Wed Dec 6 20:39:38 2017 -0800
> > 
> >     rcu: Export init_rcu_head() and destroy_rcu_head() to GPL modules
> >     
> >     Use of init_rcu_head() and destroy_rcu_head() from modules results in
> >     the following build-time error:
> >     
> >     	ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> >     	ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> >     
> >     This commit therefore adds EXPORT_SYMBOL_GPL() for each to allow them
> >     to be used by GPL-licensed kernel modules.
> >     
> >     Reported-by: Bart Van Assche <Bart.VanAssche@wdc.com>
> >     Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> >     Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > 
> > diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> > index 8d591d8411fe..4c4d26e9a67b 100644
> > --- a/kernel/rcu/update.c
> > +++ b/kernel/rcu/update.c
> > @@ -422,11 +422,13 @@ void init_rcu_head(struct rcu_head *head)
> >  {
> >  	debug_object_init(head, &rcuhead_debug_descr);
> >  }
> > +EXPORT_SYMBOL_GPL(init_rcu_head);
> >  
> >  void destroy_rcu_head(struct rcu_head *head)
> >  {
> >  	debug_object_free(head, &rcuhead_debug_descr);
> >  }
> > +EXPORT_SYMBOL_GPL(destroy_rcu_head);
> >  
> >  static bool rcuhead_is_static_object(void *addr)
> >  {
> 
> (+linux-scsi)
> 
> Hello Paul,
> 
> How about changing the commit message into "... fixes a build failure with
> CONFIG_DEBUG_OBJECTS_RCU_HEAD=y"? Otherwise the above patch looks fine to me
> and fixes the reported build failure on my setup.

I have updated it as shown below.

> However, what's not clear to me is through which tree this patch should be
> sent to Linus? Should the above patch be sent as a v4.15-rc fix or should
> Martin perhaps queue it in his tree for v4.16-rc1?

I have to defer to you guys on that one.  Left to myself, I will just
push it into the next merge window (as opposed to using my normal process,
which at this point would get it into the one following).

So please let me know how you would like to proceed.

							Thanx, Paul

------------------------------------------------------------------------

commit 193dffdf4354f14b4f3369a85128817e5ba74e58
Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Date:   Wed Dec 6 20:39:38 2017 -0800

    rcu: Export init_rcu_head() and destroy_rcu_head() to GPL modules
    
    Use of init_rcu_head() and destroy_rcu_head() from modules results in
    the following build-time error with CONFIG_DEBUG_OBJECTS_RCU_HEAD=y:
    
    	ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
    	ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
    
    This commit therefore adds EXPORT_SYMBOL_GPL() for each to allow them
    to be used by GPL-licensed kernel modules.
    
    Reported-by: Bart Van Assche <Bart.VanAssche@wdc.com>
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
index 8d591d8411fe..4c4d26e9a67b 100644
--- a/kernel/rcu/update.c
+++ b/kernel/rcu/update.c
@@ -422,11 +422,13 @@ void init_rcu_head(struct rcu_head *head)
 {
 	debug_object_init(head, &rcuhead_debug_descr);
 }
+EXPORT_SYMBOL_GPL(init_rcu_head);
 
 void destroy_rcu_head(struct rcu_head *head)
 {
 	debug_object_free(head, &rcuhead_debug_descr);
 }
+EXPORT_SYMBOL_GPL(destroy_rcu_head);
 
 static bool rcuhead_is_static_object(void *addr)
 {

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-07  4:42     ` Paul E. McKenney
@ 2017-12-07 17:30       ` Bart Van Assche
  2017-12-07 17:40         ` Paul E. McKenney
  0 siblings, 1 reply; 34+ messages in thread
From: Bart Van Assche @ 2017-12-07 17:30 UTC (permalink / raw)
  To: sfr, paulmck
  Cc: josh, linux-kernel, linux-scsi, linux-next, martin.petersen, ptikhomirov

On Wed, 2017-12-06 at 20:42 -0800, Paul E. McKenney wrote:
> On Thu, Dec 07, 2017 at 03:25:21PM +1100, Stephen Rothwell wrote:
> > On Thu, 7 Dec 2017 03:59:30 +0000 Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> > > On Thu, 2017-12-07 at 14:57 +1100, Stephen Rothwell wrote:
> > > > After merging the scsi-mkp tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > > 
> > > > ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> > > > ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> > > > 
> > > > Caused by commit
> > > > 
> > > >   ac90420f17c9 ("scsi: core: Ensure that the SCSI error handler gets woken up")
> > > > 
> > > > I have used the scsi-mkp tree from next-20171206 for today.  
> > > 
> > > Does that mean I'm the first one who added RCU code to the SCSI core?
> > 
> > The only other uses of init_rcu_head() are in drivers/iommu/intel-svm.c
> > and kernel/irq/irqdesc.c.  destroy_rcu_head() appears to not be used
> > anywhere ...
> 
> The key point is that Bart appears to be the first to try using them in
> a module, for which exports are needed.  Does the patch below help?
> 
> 							Thanx, Paul
> 
> ------------------------------------------------------------------------
> 
> commit cde4691a3a4591e7355295dd62610e3262159002
> Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Date:   Wed Dec 6 20:39:38 2017 -0800
> 
>     rcu: Export init_rcu_head() and destroy_rcu_head() to GPL modules
>     
>     Use of init_rcu_head() and destroy_rcu_head() from modules results in
>     the following build-time error:
>     
>     	ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
>     	ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
>     
>     This commit therefore adds EXPORT_SYMBOL_GPL() for each to allow them
>     to be used by GPL-licensed kernel modules.
>     
>     Reported-by: Bart Van Assche <Bart.VanAssche@wdc.com>
>     Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>     Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> 
> diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> index 8d591d8411fe..4c4d26e9a67b 100644
> --- a/kernel/rcu/update.c
> +++ b/kernel/rcu/update.c
> @@ -422,11 +422,13 @@ void init_rcu_head(struct rcu_head *head)
>  {
>  	debug_object_init(head, &rcuhead_debug_descr);
>  }
> +EXPORT_SYMBOL_GPL(init_rcu_head);
>  
>  void destroy_rcu_head(struct rcu_head *head)
>  {
>  	debug_object_free(head, &rcuhead_debug_descr);
>  }
> +EXPORT_SYMBOL_GPL(destroy_rcu_head);
>  
>  static bool rcuhead_is_static_object(void *addr)
>  {

(+linux-scsi)

Hello Paul,

How about changing the commit message into "... fixes a build failure with
CONFIG_DEBUG_OBJECTS_RCU_HEAD=y"? Otherwise the above patch looks fine to me
and fixes the reported build failure on my setup.

However, what's not clear to me is through which tree this patch should be
sent to Linus? Should the above patch be sent as a v4.15-rc fix or should
Martin perhaps queue it in his tree for v4.16-rc1?

Thanks,

Bart.


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-07  4:25   ` Stephen Rothwell
@ 2017-12-07  4:42     ` Paul E. McKenney
  2017-12-07 17:30       ` Bart Van Assche
  0 siblings, 1 reply; 34+ messages in thread
From: Paul E. McKenney @ 2017-12-07  4:42 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Bart Van Assche, Martin K. Petersen, Linus Kernel Mailing List,
	Linux Next Mailing List, Pavel Tikhomirov, Josh Triplett

On Thu, Dec 07, 2017 at 03:25:21PM +1100, Stephen Rothwell wrote:
> Hi Bart,
> 
> [cc'ing some RCU people ...]
> 
> On Thu, 7 Dec 2017 03:59:30 +0000 Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> >
> > On Thu, 2017-12-07 at 14:57 +1100, Stephen Rothwell wrote:
> > > After merging the scsi-mkp tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> > > ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> > > 
> > > Caused by commit
> > > 
> > >   ac90420f17c9 ("scsi: core: Ensure that the SCSI error handler gets woken up")
> > > 
> > > I have used the scsi-mkp tree from next-20171206 for today.  
> > 
> > Does that mean I'm the first one who added RCU code to the SCSI core?
> 
> The only other uses of init_rcu_head() are in drivers/iommu/intel-svm.c
> and kernel/irq/irqdesc.c.  destroy_rcu_head() appears to not be used
> anywhere ...

The key point is that Bart appears to be the first to try using them in
a module, for which exports are needed.  Does the patch below help?

							Thanx, Paul

------------------------------------------------------------------------

commit cde4691a3a4591e7355295dd62610e3262159002
Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Date:   Wed Dec 6 20:39:38 2017 -0800

    rcu: Export init_rcu_head() and destroy_rcu_head() to GPL modules
    
    Use of init_rcu_head() and destroy_rcu_head() from modules results in
    the following build-time error:
    
    	ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
    	ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
    
    This commit therefore adds EXPORT_SYMBOL_GPL() for each to allow them
    to be used by GPL-licensed kernel modules.
    
    Reported-by: Bart Van Assche <Bart.VanAssche@wdc.com>
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
index 8d591d8411fe..4c4d26e9a67b 100644
--- a/kernel/rcu/update.c
+++ b/kernel/rcu/update.c
@@ -422,11 +422,13 @@ void init_rcu_head(struct rcu_head *head)
 {
 	debug_object_init(head, &rcuhead_debug_descr);
 }
+EXPORT_SYMBOL_GPL(init_rcu_head);
 
 void destroy_rcu_head(struct rcu_head *head)
 {
 	debug_object_free(head, &rcuhead_debug_descr);
 }
+EXPORT_SYMBOL_GPL(destroy_rcu_head);
 
 static bool rcuhead_is_static_object(void *addr)
 {

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-07  3:59 ` Bart Van Assche
@ 2017-12-07  4:25   ` Stephen Rothwell
  2017-12-07  4:42     ` Paul E. McKenney
  0 siblings, 1 reply; 34+ messages in thread
From: Stephen Rothwell @ 2017-12-07  4:25 UTC (permalink / raw)
  To: Bart Van Assche
  Cc: Martin K. Petersen, Linus Kernel Mailing List,
	Linux Next Mailing List, Pavel Tikhomirov, Paul E. McKenney,
	Josh Triplett

Hi Bart,

[cc'ing some RCU people ...]

On Thu, 7 Dec 2017 03:59:30 +0000 Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
>
> On Thu, 2017-12-07 at 14:57 +1100, Stephen Rothwell wrote:
> > After merging the scsi-mkp tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> > ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> > 
> > Caused by commit
> > 
> >   ac90420f17c9 ("scsi: core: Ensure that the SCSI error handler gets woken up")
> > 
> > I have used the scsi-mkp tree from next-20171206 for today.  
> 
> Does that mean I'm the first one who added RCU code to the SCSI core?

The only other uses of init_rcu_head() are in drivers/iommu/intel-svm.c
and kernel/irq/irqdesc.c.  destroy_rcu_head() appears to not be used
anywhere ...

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-12-07  3:57 Stephen Rothwell
@ 2017-12-07  3:59 ` Bart Van Assche
  2017-12-07  4:25   ` Stephen Rothwell
  0 siblings, 1 reply; 34+ messages in thread
From: Bart Van Assche @ 2017-12-07  3:59 UTC (permalink / raw)
  To: sfr, martin.petersen; +Cc: linux-kernel, linux-next, ptikhomirov

On Thu, 2017-12-07 at 14:57 +1100, Stephen Rothwell wrote:
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> 
> Caused by commit
> 
>   ac90420f17c9 ("scsi: core: Ensure that the SCSI error handler gets woken up")
> 
> I have used the scsi-mkp tree from next-20171206 for today.

Does that mean I'm the first one who added RCU code to the SCSI core? Anyway,
I will fix this and repost the patch series that introduced this build failure.
Sorry for the inconvenience.

Bart.

^ permalink raw reply	[flat|nested] 34+ messages in thread

* linux-next: build failure after merge of the scsi-mkp tree
@ 2017-12-07  3:57 Stephen Rothwell
  2017-12-07  3:59 ` Bart Van Assche
  0 siblings, 1 reply; 34+ messages in thread
From: Stephen Rothwell @ 2017-12-07  3:57 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Bart Van Assche, Pavel Tikhomirov

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!

Caused by commit

  ac90420f17c9 ("scsi: core: Ensure that the SCSI error handler gets woken up")

I have used the scsi-mkp tree from next-20171206 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 34+ messages in thread

* linux-next: build failure after merge of the scsi-mkp tree
@ 2017-05-17  2:57 Stephen Rothwell
  0 siblings, 0 replies; 34+ messages in thread
From: Stephen Rothwell @ 2017-05-17  2:57 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, James Smart,
	Dick Kennedy, Hannes Reinecke

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: ".nvmet_fc_rcv_fcp_req" [drivers/scsi/lpfc/lpfc.ko] undefined!

Caused by commit

  a8cf5dfeb4d8 ("scsi: lpfc: Added recovery logic for running out of NVMET IO context resources")

CONFIG_NVME_TARGET_FC is not set for this build.

I have used the scsi-mkp tree from next-20170516 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-02-27  1:54   ` Stephen Rothwell
@ 2017-02-27 15:25     ` James Bottomley
  0 siblings, 0 replies; 34+ messages in thread
From: James Bottomley @ 2017-02-27 15:25 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, linux-next, linux-kernel, James Smart,
	Dick Kennedy, Hannes Reinecke

On Mon, 2017-02-27 at 12:54 +1100, Stephen Rothwell wrote:
> Hi James,
> 
> On Thu, 23 Feb 2017 08:06:39 +1100 Stephen Rothwell <
> sfr@canb.auug.org.au> wrote:
> > 
> > On Wed, 22 Feb 2017 13:41:19 +1100 Stephen Rothwell <
> > sfr@canb.auug.org.au> wrote:
> > > 
> > > After merging the scsi-mkp tree, today's linux-next build
> > > (powerpc
> > > ppc64_defconfig) failed like this:
> > > 
> > > ERROR: ".nvme_fc_unregister_remoteport"
> > > [drivers/scsi/lpfc/lpfc.ko] undefined!
> > > ERROR: ".nvme_fc_unregister_localport"
> > > [drivers/scsi/lpfc/lpfc.ko] undefined!
> > > ERROR: ".nvmet_fc_rcv_ls_req" [drivers/scsi/lpfc/lpfc.ko]
> > > undefined!
> > > ERROR: ".nvmet_fc_rcv_fcp_req" [drivers/scsi/lpfc/lpfc.ko]
> > > undefined!
> > > ERROR: ".nvme_fc_register_localport" [drivers/scsi/lpfc/lpfc.ko]
> > > undefined!
> > > ERROR: ".nvme_fc_register_remoteport" [drivers/scsi/lpfc/lpfc.ko]
> > > undefined!
> > > ERROR: ".nvmet_fc_register_targetport"
> > > [drivers/scsi/lpfc/lpfc.ko] undefined!
> > > ERROR: ".nvmet_fc_unregister_targetport"
> > > [drivers/scsi/lpfc/lpfc.ko] undefined!
> > > 
> > > Caused by commit
> > > 
> > >   462896e1808c ("scsi: lpfc: NVME Initiator: bind to nvme_fc
> > > api")
> > > 
> > > # CONFIG_NVME_FC is not set
> > > 
> > > Presumably a missing dependency.
> > > 
> > > I have used the scsi-mkp from next-20170221 for today.  
> > 
> > Unfortunately, you have just merged this build failure into the 
> > scsi tree :-(
> > 
> > James Smart has posted a fix:
> > 
> >   "[PATCH v2] lpfc: add missing Kconfig NVME dependencies"
> 
> I am still getting this failure in the scsi tree even though a fix 
> has been merged into the scsi-mkp tree a few days ago.

Sorry, was in meeting hell for the last part of last week.  Everything
should be up to date now.  The final pull for all of this should go out
Wed/Thu to give 0day a good run at the tree.

James

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-02-22 21:06 ` Stephen Rothwell
  2017-02-22 21:10   ` Martin K. Petersen
@ 2017-02-27  1:54   ` Stephen Rothwell
  2017-02-27 15:25     ` James Bottomley
  1 sibling, 1 reply; 34+ messages in thread
From: Stephen Rothwell @ 2017-02-27  1:54 UTC (permalink / raw)
  To: James Bottomley
  Cc: Martin K. Petersen, linux-next, linux-kernel, James Smart,
	Dick Kennedy, Hannes Reinecke

Hi James,

On Thu, 23 Feb 2017 08:06:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 22 Feb 2017 13:41:19 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the scsi-mkp tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > ERROR: ".nvme_fc_unregister_remoteport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> > ERROR: ".nvme_fc_unregister_localport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> > ERROR: ".nvmet_fc_rcv_ls_req" [drivers/scsi/lpfc/lpfc.ko] undefined!
> > ERROR: ".nvmet_fc_rcv_fcp_req" [drivers/scsi/lpfc/lpfc.ko] undefined!
> > ERROR: ".nvme_fc_register_localport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> > ERROR: ".nvme_fc_register_remoteport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> > ERROR: ".nvmet_fc_register_targetport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> > ERROR: ".nvmet_fc_unregister_targetport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> > 
> > Caused by commit
> > 
> >   462896e1808c ("scsi: lpfc: NVME Initiator: bind to nvme_fc api")
> > 
> > # CONFIG_NVME_FC is not set
> > 
> > Presumably a missing dependency.
> > 
> > I have used the scsi-mkp from next-20170221 for today.  
> 
> Unfortunately, you have just merged this build failure into the scsi
> tree :-(
> 
> James Smart has posted a fix:
> 
>   "[PATCH v2] lpfc: add missing Kconfig NVME dependencies"

I am still getting this failure in the scsi tree even though a fix has
been merged into the scsi-mkp tree a few days ago.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-02-23 14:19 ` Martin K. Petersen
@ 2017-02-23 15:04   ` Chad Dupuis
  0 siblings, 0 replies; 34+ messages in thread
From: Chad Dupuis @ 2017-02-23 15:04 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Stephen Rothwell, linux-next, linux-kernel, Nilesh Javali,
	Manish Rangankar, Saurav Kashyap, Arun Easi



On Thu, 23 Feb 2017, 2:19pm -0000, Martin K. Petersen wrote:

> 
> *sigh*
> 
> Chad: Please fix these up ASAP.
> 
> 

Just submitted a patch to the list to fix this up.  I tested against the 
mainline which has the net-next merge and the kref refcount_t conversion 
to verify.

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-02-23  3:12 Stephen Rothwell
@ 2017-02-23 14:19 ` Martin K. Petersen
  2017-02-23 15:04   ` Chad Dupuis
  0 siblings, 1 reply; 34+ messages in thread
From: Martin K. Petersen @ 2017-02-23 14:19 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, linux-next, linux-kernel, Nilesh Javali,
	Manish Rangankar, Saurav Kashyap, Arun Easi, Chad Dupuis

>>>>> "Stephen" == Stephen Rothwell <sfr@canb.auug.org.au> writes:

Stephen,

Stephen> Caused by commit

Stephen>   61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE
Stephen>   driver framework")

Stephen> being rebased on top of commit

Stephen>   10383aea2f44 ("kref: Implement 'struct kref' using
Stephen>   refcount_t")

Stephen> and not using kref_read() to access the refcounts.

*sigh*

Chad: Please fix these up ASAP.


Stephen> I don't understand why you would rebase you work onto Linus'
Stephen> tree in the middle of the merge window in any case. :-(

I didn't rebase my existing patch queue. I started a new for-next based
on linus/master. Half of this new QLogic driver lives under net so I had
to wait for Linus to pull DaveM's tree before I could merge the SCSI
portion :(

We often have to do two-stage merge windows with SCSI because of
dependencies on changes in both block and net (the latter increasingly
so because of the popularity of converged adapters that do both networks
and storage).

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 34+ messages in thread

* linux-next: build failure after merge of the scsi-mkp tree
@ 2017-02-23  3:12 Stephen Rothwell
  2017-02-23 14:19 ` Martin K. Petersen
  0 siblings, 1 reply; 34+ messages in thread
From: Stephen Rothwell @ 2017-02-23  3:12 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: linux-next, linux-kernel, Nilesh Javali, Manish Rangankar,
	Saurav Kashyap, Arun Easi, Chad Dupuis

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/scsi/qedf/qedf_io.c: In function 'qedf_trace_io':
drivers/scsi/qedf/qedf_io.c:1001:33: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
  io_log->refcount = atomic_read(&io_req->refcount.refcount);
                                 ^
In file included from arch/x86/include/asm/msr.h:66:0,
                 from arch/x86/include/asm/processor.h:20,
                 from arch/x86/include/asm/cpufeature.h:4,
                 from arch/x86/include/asm/thread_info.h:52,
                 from include/linux/thread_info.h:25,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:59,
                 from include/linux/spinlock.h:50,
                 from drivers/scsi/qedf/qedf_io.c:9:
arch/x86/include/asm/atomic.h:24:28: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
 static __always_inline int atomic_read(const atomic_t *v)
                            ^
drivers/scsi/qedf/qedf_io.c: In function 'qedf_scsi_completion':
drivers/scsi/qedf/qedf_io.c:1343:27: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
    refcount = atomic_read(&io_req->refcount.refcount);
                           ^
In file included from arch/x86/include/asm/msr.h:66:0,
                 from arch/x86/include/asm/processor.h:20,
                 from arch/x86/include/asm/cpufeature.h:4,
                 from arch/x86/include/asm/thread_info.h:52,
                 from include/linux/thread_info.h:25,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:59,
                 from include/linux/spinlock.h:50,
                 from drivers/scsi/qedf/qedf_io.c:9:
arch/x86/include/asm/atomic.h:24:28: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
 static __always_inline int atomic_read(const atomic_t *v)
                            ^
drivers/scsi/qedf/qedf_io.c: In function 'qedf_scsi_done':
drivers/scsi/qedf/qedf_io.c:1428:25: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
  refcount = atomic_read(&io_req->refcount.refcount);
                         ^
In file included from arch/x86/include/asm/msr.h:66:0,
                 from arch/x86/include/asm/processor.h:20,
                 from arch/x86/include/asm/cpufeature.h:4,
                 from arch/x86/include/asm/thread_info.h:52,
                 from include/linux/thread_info.h:25,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:59,
                 from include/linux/spinlock.h:50,
                 from drivers/scsi/qedf/qedf_io.c:9:
arch/x86/include/asm/atomic.h:24:28: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
 static __always_inline int atomic_read(const atomic_t *v)
                            ^
In file included from drivers/scsi/qedf/qedf.h:28:0,
                 from drivers/scsi/qedf/qedf_io.c:11:
drivers/scsi/qedf/qedf_io.c: In function 'qedf_flush_els_req':
drivers/scsi/qedf/qedf_io.c:1559:18: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
      atomic_read(&els_req->refcount.refcount));
                  ^
drivers/scsi/qedf/qedf_dbg.h:83:13: note: in definition of macro 'QEDF_INFO'
          ## __VA_ARGS__)
             ^
In file included from arch/x86/include/asm/msr.h:66:0,
                 from arch/x86/include/asm/processor.h:20,
                 from arch/x86/include/asm/cpufeature.h:4,
                 from arch/x86/include/asm/thread_info.h:52,
                 from include/linux/thread_info.h:25,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:59,
                 from include/linux/spinlock.h:50,
                 from drivers/scsi/qedf/qedf_io.c:9:
arch/x86/include/asm/atomic.h:24:28: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
 static __always_inline int atomic_read(const atomic_t *v)
                            ^
drivers/scsi/qedf/qedf_els.c: In function 'qedf_rrq_compl':
drivers/scsi/qedf/qedf_els.c:186:25: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
  refcount = atomic_read(&orig_io_req->refcount.refcount);
                         ^
In file included from arch/x86/include/asm/msr.h:66:0,
                 from arch/x86/include/asm/processor.h:20,
                 from arch/x86/include/asm/cpufeature.h:4,
                 from arch/x86/include/asm/thread_info.h:52,
                 from include/linux/thread_info.h:25,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:59,
                 from include/linux/spinlock.h:50,
                 from include/linux/mm_types.h:8,
                 from include/linux/kmemcheck.h:4,
                 from include/linux/skbuff.h:18,
                 from include/linux/if_ether.h:23,
                 from include/linux/etherdevice.h:25,
                 from include/scsi/libfcoe.h:24,
                 from drivers/scsi/qedf/qedf.h:12,
                 from drivers/scsi/qedf/qedf_els.c:9:
arch/x86/include/asm/atomic.h:24:28: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
 static __always_inline int atomic_read(const atomic_t *v)
                            ^
drivers/scsi/qedf/qedf_els.c: In function 'qedf_srr_compl':
drivers/scsi/qedf/qedf_els.c:477:25: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
  refcount = atomic_read(&orig_io_req->refcount.refcount);
                         ^
In file included from arch/x86/include/asm/msr.h:66:0,
                 from arch/x86/include/asm/processor.h:20,
                 from arch/x86/include/asm/cpufeature.h:4,
                 from arch/x86/include/asm/thread_info.h:52,
                 from include/linux/thread_info.h:25,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:59,
                 from include/linux/spinlock.h:50,
                 from include/linux/mm_types.h:8,
                 from include/linux/kmemcheck.h:4,
                 from include/linux/skbuff.h:18,
                 from include/linux/if_ether.h:23,
                 from include/linux/etherdevice.h:25,
                 from include/scsi/libfcoe.h:24,
                 from drivers/scsi/qedf/qedf.h:12,
                 from drivers/scsi/qedf/qedf_els.c:9:
arch/x86/include/asm/atomic.h:24:28: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
 static __always_inline int atomic_read(const atomic_t *v)
                            ^
drivers/scsi/qedf/qedf_els.c: In function 'qedf_rec_compl':
drivers/scsi/qedf/qedf_els.c:761:25: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
  refcount = atomic_read(&orig_io_req->refcount.refcount);
                         ^
In file included from arch/x86/include/asm/msr.h:66:0,
                 from arch/x86/include/asm/processor.h:20,
                 from arch/x86/include/asm/cpufeature.h:4,
                 from arch/x86/include/asm/thread_info.h:52,
                 from include/linux/thread_info.h:25,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:59,
                 from include/linux/spinlock.h:50,
                 from include/linux/mm_types.h:8,
                 from include/linux/kmemcheck.h:4,
                 from include/linux/skbuff.h:18,
                 from include/linux/if_ether.h:23,
                 from include/linux/etherdevice.h:25,
                 from include/scsi/libfcoe.h:24,
                 from drivers/scsi/qedf/qedf.h:12,
                 from drivers/scsi/qedf/qedf_els.c:9:
arch/x86/include/asm/atomic.h:24:28: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
 static __always_inline int atomic_read(const atomic_t *v)
                            ^

Caused by commit

  61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework")

being rebased on top of commit

  10383aea2f44 ("kref: Implement 'struct kref' using refcount_t")

and not using kref_read() to access the refcounts.

I don't understand why you would rebase you work onto Linus' tree in
the middle of the merge window in any case. :-(

I have used the scsi-mkp tree from next-20170221 again.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-02-22 21:13     ` James Bottomley
@ 2017-02-22 21:17       ` Martin K. Petersen
  0 siblings, 0 replies; 34+ messages in thread
From: Martin K. Petersen @ 2017-02-22 21:17 UTC (permalink / raw)
  To: James Bottomley
  Cc: Martin K. Petersen, Stephen Rothwell, linux-next, linux-kernel,
	James Smart, Dick Kennedy, Hannes Reinecke

>>>>> "James" == James Bottomley <James.Bottomley@HansenPartnership.com> writes:

James> Perhaps it would be nice to rebase so we don't get bisect into a
James> build failure.

My plan was to start 4.11/scsi-fixes based on linus/master. I need block
and net to satisfy dependencies for the remaining patches in the queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-02-22 21:10   ` Martin K. Petersen
@ 2017-02-22 21:13     ` James Bottomley
  2017-02-22 21:17       ` Martin K. Petersen
  0 siblings, 1 reply; 34+ messages in thread
From: James Bottomley @ 2017-02-22 21:13 UTC (permalink / raw)
  To: Martin K. Petersen, Stephen Rothwell
  Cc: linux-next, linux-kernel, James Smart, Dick Kennedy, Hannes Reinecke

On Wed, 2017-02-22 at 16:10 -0500, Martin K. Petersen wrote:
> > > > > > "Stephen" == Stephen Rothwell <sfr@canb.auug.org.au>
> > > > > > writes:
> 
> Stephen,
> 
> Stephen> Unfortunately, you have just merged this build failure into
> the
> Stephen> scsi tree :-(
> 
> Stephen> James Smart has posted a fix:
> 
> Stephen>   "[PATCH v2] lpfc: add missing Kconfig NVME dependencies"
> 
> I'll get the queued up shortly.

Perhaps it would be nice to rebase so we don't get bisect into a build
failure.

James

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-02-22 21:06 ` Stephen Rothwell
@ 2017-02-22 21:10   ` Martin K. Petersen
  2017-02-22 21:13     ` James Bottomley
  2017-02-27  1:54   ` Stephen Rothwell
  1 sibling, 1 reply; 34+ messages in thread
From: Martin K. Petersen @ 2017-02-22 21:10 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, Martin K. Petersen, linux-next, linux-kernel,
	James Smart, Dick Kennedy, Hannes Reinecke

>>>>> "Stephen" == Stephen Rothwell <sfr@canb.auug.org.au> writes:

Stephen,

Stephen> Unfortunately, you have just merged this build failure into the
Stephen> scsi tree :-(

Stephen> James Smart has posted a fix:

Stephen>   "[PATCH v2] lpfc: add missing Kconfig NVME dependencies"

I'll get the queued up shortly.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: linux-next: build failure after merge of the scsi-mkp tree
  2017-02-22  2:41 Stephen Rothwell
@ 2017-02-22 21:06 ` Stephen Rothwell
  2017-02-22 21:10   ` Martin K. Petersen
  2017-02-27  1:54   ` Stephen Rothwell
  0 siblings, 2 replies; 34+ messages in thread
From: Stephen Rothwell @ 2017-02-22 21:06 UTC (permalink / raw)
  To: James Bottomley
  Cc: Martin K. Petersen, linux-next, linux-kernel, James Smart,
	Dick Kennedy, Hannes Reinecke

Hi James,

On Wed, 22 Feb 2017 13:41:19 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> ERROR: ".nvme_fc_unregister_remoteport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: ".nvme_fc_unregister_localport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: ".nvmet_fc_rcv_ls_req" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: ".nvmet_fc_rcv_fcp_req" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: ".nvme_fc_register_localport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: ".nvme_fc_register_remoteport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: ".nvmet_fc_register_targetport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: ".nvmet_fc_unregister_targetport" [drivers/scsi/lpfc/lpfc.ko] undefined!
> 
> Caused by commit
> 
>   462896e1808c ("scsi: lpfc: NVME Initiator: bind to nvme_fc api")
> 
> # CONFIG_NVME_FC is not set
> 
> Presumably a missing dependency.
> 
> I have used the scsi-mkp from next-20170221 for today.

Unfortunately, you have just merged this build failure into the scsi
tree :-(

James Smart has posted a fix:

  "[PATCH v2] lpfc: add missing Kconfig NVME dependencies"

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 34+ messages in thread

* linux-next: build failure after merge of the scsi-mkp tree
@ 2017-02-22  2:41 Stephen Rothwell
  2017-02-22 21:06 ` Stephen Rothwell
  0 siblings, 1 reply; 34+ messages in thread
From: Stephen Rothwell @ 2017-02-22  2:41 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: linux-next, linux-kernel, James Smart, Dick Kennedy, Hannes Reinecke

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: ".nvme_fc_unregister_remoteport" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: ".nvme_fc_unregister_localport" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: ".nvmet_fc_rcv_ls_req" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: ".nvmet_fc_rcv_fcp_req" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: ".nvme_fc_register_localport" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: ".nvme_fc_register_remoteport" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: ".nvmet_fc_register_targetport" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: ".nvmet_fc_unregister_targetport" [drivers/scsi/lpfc/lpfc.ko] undefined!

Caused by commit

  462896e1808c ("scsi: lpfc: NVME Initiator: bind to nvme_fc api")

# CONFIG_NVME_FC is not set

Presumably a missing dependency.

I have used the scsi-mkp from next-20170221 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 34+ messages in thread

end of thread, back to index

Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09  6:27 linux-next: build failure after merge of the scsi-mkp tree Stephen Rothwell
2019-04-10  1:21 ` Stephen Rothwell
2019-04-10  1:33   ` Martin K. Petersen
2019-04-10  4:04     ` James Bottomley
2019-04-10  4:57       ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2019-10-25  3:07 Stephen Rothwell
2019-10-25 18:03 ` James Smart
2019-10-28  5:49 ` Stephen Rothwell
2019-10-29  2:28   ` Martin K. Petersen
2019-10-29  2:48     ` Stephen Rothwell
2018-03-22  6:25 Stephen Rothwell
2018-03-22 16:33 ` Madhani, Himanshu
2017-12-07  3:57 Stephen Rothwell
2017-12-07  3:59 ` Bart Van Assche
2017-12-07  4:25   ` Stephen Rothwell
2017-12-07  4:42     ` Paul E. McKenney
2017-12-07 17:30       ` Bart Van Assche
2017-12-07 17:40         ` Paul E. McKenney
2017-12-07 20:34           ` Stephen Rothwell
2017-12-07 21:10             ` Paul E. McKenney
2017-12-07 21:11             ` Martin K. Petersen
2017-12-08  1:00               ` Martin K. Petersen
2017-12-11 17:43                 ` Paul E. McKenney
2017-05-17  2:57 Stephen Rothwell
2017-02-23  3:12 Stephen Rothwell
2017-02-23 14:19 ` Martin K. Petersen
2017-02-23 15:04   ` Chad Dupuis
2017-02-22  2:41 Stephen Rothwell
2017-02-22 21:06 ` Stephen Rothwell
2017-02-22 21:10   ` Martin K. Petersen
2017-02-22 21:13     ` James Bottomley
2017-02-22 21:17       ` Martin K. Petersen
2017-02-27  1:54   ` Stephen Rothwell
2017-02-27 15:25     ` James Bottomley

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git