linux-next: Fixes tag needs some work in the i2c tree

linux-next: Fixes tag needs some work in the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi all,

In commit

  31cac068e9f3 ("i2c: imx: correct the method of getting private data in notifier_call")

Fixes tag

  Fixes: 90ad2cbe88c2("i2c: imx: use clk notifier for rate changes")

has these problem(s):

  - missing space between the SHA1 and the subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]


> has these problem(s):
> 
>   - missing space between the SHA1 and the subject

Thanks, I missed that. Pushed out a new for-next with it fixed.



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Fixes tag needs some work in the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi all,

In commit

  9c5718e14b81 ("i2c: at91: disable TXRDY interrupt after sending data")

Fixes tag

  Fixes: fac368a0404 ("i2c: at91: add new driver")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Hi Stephen,

> In commit
> 
>   9c5718e14b81 ("i2c: at91: disable TXRDY interrupt after sending data")
> 
> Fixes tag
> 
>   Fixes: fac368a0404 ("i2c: at91: add new driver")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Thanks for the report, I fixed it.

Michał, please check your gitconfig to avoid these issue in the future.
And I will check why checkpatch didn't report this flaw to me.

Kind regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Fixes tag needs some work in the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

In commit

  969f95fc9007 ("i2c: i2c-stm32f7: rework slave_id allocation")

Fixes tag

  Fixes: 60d609f3 ("i2c: i2c-stm32f7: Add slave support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi all,

In commit

  a66d0af81726 ("i2c: iproc: generate stop event for slave writes")

Fixes tag

  Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode")

has these problem(s):

  - No SHA1 recognised

This triggered because the "space" after the ":" is a Unicode non-breaking
space (U+0x00a0, UTF8 0xc2 0xa0).  I am not sure if this is a problem
or not.  This is the forst time I have seen this.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]


> This triggered because the "space" after the ":" is a Unicode non-breaking
> space (U+0x00a0, UTF8 0xc2 0xa0).  I am not sure if this is a problem
> or not.  This is the forst time I have seen this.

Thanks for reporting, I obviously didn't notice. Well, technically,
commit messages can be UTF8, so not really an error. However, it will
probably break lots of homebrew scripts, so a checkpatch warning it is,
then?

I'll fix it nonetheless.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: linux-next: Fixes tag needs some work in the i2c tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 795 bytes --]

Hi Wolfram,

On Tue, 28 Apr 2020 09:01:30 +0200 Wolfram Sang <wsa@the-dreams.de> wrote:
>
> > This triggered because the "space" after the ":" is a Unicode non-breaking
> > space (U+0x00a0, UTF8 0xc2 0xa0).  I am not sure if this is a problem
> > or not.  This is the forst time I have seen this.  
> 
> Thanks for reporting, I obviously didn't notice. Well, technically,
> commit messages can be UTF8, so not really an error. However, it will
> probably break lots of homebrew scripts, so a checkpatch warning it is,
> then?

Not checkpatch, but my own script that checks some things about Fixes
tags (attached).  Interestingly, my script does allow some other Unicode
things (like matching quotes) ...

> I'll fix it nonetheless.

Thanks.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_fixes --]
[-- Type: application/x-shellscript, Size: 4197 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]


> > Thanks for reporting, I obviously didn't notice. Well, technically,
> > commit messages can be UTF8, so not really an error. However, it will
> > probably break lots of homebrew scripts, so a checkpatch warning it is,
> > then?
> 
> Not checkpatch, but my own script that checks some things about Fixes
> tags (attached).  Interestingly, my script does allow some other Unicode
> things (like matching quotes) ...

I wondered if it makes sense to add a warning to checkpatch; but on
second thought, the tags may include UTF8 anyhow for proper author
names. So, maybe we should be generous in what we accept and simply
update our tooling?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Fixes tag needs some work in the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

Hi all,

In commit

  fcc750e0f4d8 ("i2c: s3c2410: fix IRQ check")

Fixes tag

  Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

So:

Fixes: 2bbd681ba2bf ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")

Or maybe you meant:

Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the i2c tree

[Sergey Shtylyov]

On 8/18/21 12:49 AM, Stephen Rothwell wrote:

[...]
> In commit
> 
>   fcc750e0f4d8 ("i2c: s3c2410: fix IRQ check")
> 
> Fixes tag
> 
>   Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> So:
> 
> Fixes: 2bbd681ba2bf ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")

   Sorry for this copypaste blunder. :-/

> Or maybe you meant:
> 
> Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")

   Yes, this one looks more correct.

   Wolfram, what should we do now?
 
MBR, Sergei

Re: linux-next: Fixes tag needs some work in the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]


> > Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")
> 
>    Yes, this one looks more correct.
> 
>    Wolfram, what should we do now?

I'll fix it locally. Thanks, Stephen for the report and fix!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Fixes tag needs some work in the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

In commit

  eef7fa1001c0 ("i2c: iop3xx: fix deferred probing")

Fixes tag

  Fixes: 489447380a29 ("handle errors returned by platform_get_irq*()")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

So:

Fixes: 489447380a29 ("[PATCH] handle errors returned by platform_get_irq*()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the i2c tree

[Sergey Shtylyov]

On 8/18/21 12:52 AM, Stephen Rothwell wrote:

> In commit
> 
>   eef7fa1001c0 ("i2c: iop3xx: fix deferred probing")
> 
> Fixes tag
> 
>   Fixes: 489447380a29 ("handle errors returned by platform_get_irq*()")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> So:
> 
> Fixes: 489447380a29 ("[PATCH] handle errors returned by platform_get_irq*()")

   In this case I was innocent, I guess something ate [PATCH] on Wolfram's side. :-)

MBR, Sergei

Re: linux-next: Fixes tag needs some work in the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]


> > So:
> > 
> > Fixes: 489447380a29 ("[PATCH] handle errors returned by platform_get_irq*()")
> 
>    In this case I was innocent, I guess something ate [PATCH] on Wolfram's side. :-)

Yes, mea culpa. It looked like an oversight to me, will check better
next time!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Fixes tag needs some work in the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi all,

In commit

  661e8a88e831 ("i2c: xlp9xx: fix main IRQ check")

Fixes tag

  Fixes: 2bbd681ba2b ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]