From: Pavel Machek <pavel@ucw.cz>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marek Behun <marek.behun@nic.cz>,
linux-leds@vger.kernel.org
Subject: Re: linux-next: Tree for Apr 29 (drivers/leds/leds-turris-omnia)
Date: Mon, 29 Apr 2019 17:32:00 +0200 [thread overview]
Message-ID: <20190429153200.GA11761@amd> (raw)
In-Reply-To: <d3822785-0683-28df-ffa6-ab679aa27c73@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]
On Mon 2019-04-29 08:03:02, Randy Dunlap wrote:
> On 4/29/19 2:03 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20190426:
> >
>
> on i386:
>
> when CONFIG_LEDS_TURRIS_OMNIA=y and CONFIG_I2C=m:
>
> Probably should also depend on I2C.
>
>
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_remove':
> leds-turris-omnia.c:(.text+0xb): undefined reference to `i2c_smbus_write_byte_data'
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_led_brightness_set_blocking':
> leds-turris-omnia.c:(.text+0x62): undefined reference to `i2c_smbus_write_byte_data'
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_probe':
> leds-turris-omnia.c:(.text+0x1d8): undefined reference to `i2c_smbus_write_byte_data'
> ld: leds-turris-omnia.c:(.text+0x1f6): undefined reference to `i2c_smbus_write_byte_data'
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_driver_init':
> leds-turris-omnia.c:(.init.text+0x8): undefined reference to `i2c_register_driver'
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_driver_exit':
> leds-turris-omnia.c:(.exit.text+0x6): undefined reference to `i2c_del_driver'
Ack.
It can also depend on ARM or even specific ARM soc... unless we are
compile testing. This is for specific router...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-04-29 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 9:03 linux-next: Tree for Apr 29 Stephen Rothwell
2019-04-29 14:52 ` linux-next: Tree for Apr 29 (drivers/md/dm-dust) Randy Dunlap
2019-04-29 15:03 ` linux-next: Tree for Apr 29 (drivers/leds/leds-turris-omnia) Randy Dunlap
2019-04-29 15:32 ` Pavel Machek [this message]
2019-04-29 15:38 ` Marek Behun
2019-04-29 16:37 ` Pavel Machek
2019-04-29 16:44 ` Marek Behun
2019-04-29 16:53 ` Pavel Machek
2019-04-29 17:51 ` Enrico Weigelt, metux IT consult
2019-04-29 18:12 ` Pavel Machek
2019-04-29 18:49 ` Enrico Weigelt, metux IT consult
2019-04-29 19:02 ` Marek Behun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429153200.GA11761@amd \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).