Hi Shawn, After merging the imx-mxs tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/clk/imx/clk.c: In function 'imx_mmdc_mask_handshake': drivers/clk/imx/clk.c:20:8: error: implicit declaration of function 'readl_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-declaration] reg = readl_relaxed(ccm_base + CCM_CCDR); ^~~~~~~~~~~~~ xchg_relaxed drivers/clk/imx/clk.c:22:2: error: implicit declaration of function 'writel_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-declaration] writel_relaxed(reg, ccm_base + CCM_CCDR); ^~~~~~~~~~~~~~ xchg_relaxed Caused by commit 0dc6b492b6e0 ("clk: imx: Add common API for masking MMDC handshake") I have used the imx-mxs tree from next-20190520 for today. -- Cheers, Stephen Rothwell