Re: linux-next: build warning after merge of the mfd tree

Re: linux-next: build warning after merge of the mfd tree

[Keerthy]

On 27/06/19 10:41 AM, Stephen Rothwell wrote:
> Hi Lee,
> 
> After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/regulator/lp87565-regulator.c: In function 'lp87565_regulator_probe':
> drivers/regulator/lp87565-regulator.c:182:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     max_idx = LP87565_BUCK_3210;

Missed adding a break here. Can i send a patch on top of linux-next?

>     ~~~~~~~~^~~~~~~~~~~~~~~~~~~
> drivers/regulator/lp87565-regulator.c:183:2: note: here
>    default:
>    ^~~~~~~
> 
> Introduced by commit
> 
>    7ee63bd74750 ("regulator: lp87565: Add 4-phase lp87561 regulator support")
> 
> I get these warnings because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early.  The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (assuming that the fall through is intentional).
> 

Re: linux-next: build warning after merge of the mfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

Hi all,

On Thu, 27 Jun 2019 11:29:18 +0530 Keerthy <j-keerthy@ti.com> wrote:
>
> On 27/06/19 10:41 AM, Stephen Rothwell wrote:
> > Hi Lee,
> > 
> > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > drivers/regulator/lp87565-regulator.c: In function 'lp87565_regulator_probe':
> > drivers/regulator/lp87565-regulator.c:182:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >     max_idx = LP87565_BUCK_3210;  
> 
> Missed adding a break here. Can i send a patch on top of linux-next?
> 
> >     ~~~~~~~~^~~~~~~~~~~~~~~~~~~
> > drivers/regulator/lp87565-regulator.c:183:2: note: here
> >    default:
> >    ^~~~~~~
> > 
> > Introduced by commit
> > 
> >    7ee63bd74750 ("regulator: lp87565: Add 4-phase lp87561 regulator support")
> > 
> > I get these warnings because I am building with -Wimplicit-fallthrough
> > in attempt to catch new additions early.  The gcc warning can be turned
> > off by adding a /* fall through */ comment at the point the fall through
> > happens (assuming that the fall through is intentional).
> >   

I am still seeing this warning ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the mfd tree

[Lee Jones]

On Tue, 02 Jul 2019, Stephen Rothwell wrote:

> Hi all,
> 
> On Thu, 27 Jun 2019 11:29:18 +0530 Keerthy <j-keerthy@ti.com> wrote:
> >
> > On 27/06/19 10:41 AM, Stephen Rothwell wrote:
> > > Hi Lee,
> > > 
> > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > > produced this warning:
> > > 
> > > drivers/regulator/lp87565-regulator.c: In function 'lp87565_regulator_probe':
> > > drivers/regulator/lp87565-regulator.c:182:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > >     max_idx = LP87565_BUCK_3210;  
> > 
> > Missed adding a break here. Can i send a patch on top of linux-next?
> > 
> > >     ~~~~~~~~^~~~~~~~~~~~~~~~~~~
> > > drivers/regulator/lp87565-regulator.c:183:2: note: here
> > >    default:
> > >    ^~~~~~~
> > > 
> > > Introduced by commit
> > > 
> > >    7ee63bd74750 ("regulator: lp87565: Add 4-phase lp87561 regulator support")
> > > 
> > > I get these warnings because I am building with -Wimplicit-fallthrough
> > > in attempt to catch new additions early.  The gcc warning can be turned
> > > off by adding a /* fall through */ comment at the point the fall through
> > > happens (assuming that the fall through is intentional).
> > >   
> 
> I am still seeing this warning ...

Just pushed the fix for this.

Thank you Stephen.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

linux-next: build warning after merge of the mfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

Hi all,

After merging the mfd tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/mfd/axp20x-i2c.c:82:5: warning: "CONFIG_ACPI" is not defined, evaluates to 0 [-Wundef]
   82 | #if CONFIG_ACPI
      |     ^~~~~~~~~~~

Introduced by commit

  20f359cb236b ("mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the mfd tree

[Lee Jones]

On Tue, 05 Jun 2018, Stephen Rothwell wrote:

> Hi Lee,
> 
> After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/mfd/cros_ec_dev.c:265:13: warning: '__remove' defined but not used [-Wunused-function]
>  static void __remove(struct device *dev) { }
>              ^~~~~~~~
> 
> Introduced by commit
> 
>   3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data")

Thanks Stephen.  Will chase today.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

linux-next: build warning after merge of the mfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/mfd/cros_ec_dev.c:265:13: warning: '__remove' defined but not used [-Wunused-function]
 static void __remove(struct device *dev) { }
             ^~~~~~~~

Introduced by commit

  3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the mfd tree

[Lee Jones]

On Thu, 30 Nov 2017, Stephen Rothwell wrote:

> Hi Lee,
> 
> After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/leds/leds-pm8058.c: In function 'pm8058_led_probe':
> drivers/leds/leds-pm8058.c:109:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   led->ledtype = (u32)of_device_get_match_data(&pdev->dev);

Linuuuuusssssss ...

Please fix.  I'm happy to squash.

> Exposed by commit
> 
>   deed10c2d603 ("mfd: pm8xxx: Make elegible for COMPILE_TEST")
> 
> CONFIG_LEDS_PM8058 depends on CONFIG_MFD_PM8XXX which is now turned on
> by allmodconfig.
> 
> The actual problematic commit is:
> 
>   7f866986e705 ("leds: add PM8058 LEDs driver")
> 
> from v4.9-rc1.
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

linux-next: build warning after merge of the mfd tree

[Stephen Rothwell]

Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/leds/leds-pm8058.c: In function 'pm8058_led_probe':
drivers/leds/leds-pm8058.c:109:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  led->ledtype = (u32)of_device_get_match_data(&pdev->dev);
                 ^

Exposed by commit

  deed10c2d603 ("mfd: pm8xxx: Make elegible for COMPILE_TEST")

CONFIG_LEDS_PM8058 depends on CONFIG_MFD_PM8XXX which is now turned on
by allmodconfig.

The actual problematic commit is:

  7f866986e705 ("leds: add PM8058 LEDs driver")

from v4.9-rc1.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the mfd tree

[Benjamin Gaignard]

2017-01-25 5:54 GMT+01:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Lee,
>
> After merging the mfd tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> drivers/pwm/pwm-stm32.c: In function 'stm32_pwm_apply':
> drivers/pwm/pwm-stm32.c:204:33: warning: 'curstate.polarity' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (state->polarity != curstate.polarity)
>                                  ^
>

I will send a patch to fix that today

Benjamin

> Introduced by commit
>
>   bafffb6e7bd1 ("pwm: Add driver for STM32 plaftorm")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

linux-next: build warning after merge of the mfd tree

[Stephen Rothwell]

Hi Lee,

After merging the mfd tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/pwm/pwm-stm32.c: In function 'stm32_pwm_apply':
drivers/pwm/pwm-stm32.c:204:33: warning: 'curstate.polarity' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (state->polarity != curstate.polarity)
                                 ^

Introduced by commit

  bafffb6e7bd1 ("pwm: Add driver for STM32 plaftorm")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the mfd tree

[Sebastian Andrzej Siewior]

On Wed, Jul 03, 2013 at 03:56:55PM +1000, Stephen Rothwell wrote:
> Hi Samuel,
Hi Stephen,

> Introduced by commit 18926edebcb8 ("iio: ti_am335x_adc: Allow to specify
> input line").  CONFIG_OF is not set in this build.
> 
> Maybe someone could come up with a way to make these arguments to
> of_property_for_each_u32() etc look used in the !CONFIG_OF case.

Already posted:

  https://lists.ozlabs.org/pipermail/devicetree-discuss/2013-June/035703.html

Sebastian

linux-next: build warning after merge of the mfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

drivers/mfd/ti_am335x_tscadc.c: In function 'ti_tscadc_probe':
drivers/mfd/ti_am335x_tscadc.c:95:27: warning: unused variable 'cur' [-Wunused-variable]
  const __be32            *cur;
                           ^
drivers/mfd/ti_am335x_tscadc.c:94:27: warning: unused variable 'prop' [-Wunused-variable]
  struct property         *prop;
                           ^

Introduced by commit 18926edebcb8 ("iio: ti_am335x_adc: Allow to specify
input line").  CONFIG_OF is not set in this build.

Maybe someone could come up with a way to make these arguments to
of_property_for_each_u32() etc look used in the !CONFIG_OF case.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the mfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64_allmodconfig)
produced this warning:

drivers/mfd/stmpe.c:114:1: warning: data definition has no type or storage class [enabled by default]
drivers/mfd/stmpe.c:114:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]

(and several more similar).

Caused by commit b25a31a3b4d3 ("mfd: Separate out STMPE controller and
interface specific code").  This file needs to include <linux/export.h>
since module.h has been removed.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the mfd tree

[Samuel Ortiz]

Hi Stephen,

On Mon, Nov 29, 2010 at 11:52:57AM +1100, Stephen Rothwell wrote:
> Hi Samuel,
> 
> After merging the mfd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/mfd/cs5535-mfd.c: In function 'cs5535_mfd_probe':
> drivers/mfd/cs5535-mfd.c:106: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> 
> Introduced by commit a0d4503a044e67ac46adfe8f42eddefd2b60f85e ("mfd: Add
> cs5535-mfd driver for AMD Geode's CS5535/CS5536 support").
That should be fixed by now, thanks for the report.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

linux-next: build warning after merge of the mfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/mfd/cs5535-mfd.c: In function 'cs5535_mfd_probe':
drivers/mfd/cs5535-mfd.c:106: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'

Introduced by commit a0d4503a044e67ac46adfe8f42eddefd2b60f85e ("mfd: Add
cs5535-mfd driver for AMD Geode's CS5535/CS5536 support").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build warning after merge of the mfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

Hi Sam,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

drivers/gpio/sch_gpio.c: In function 'sch_gpio_probe':
drivers/gpio/sch_gpio.c:232: warning: ignoring return value of 'gpiochip_remove', declared with attribute warn_unused_result
drivers/gpio/sch_gpio.c: In function 'sch_gpio_remove':
drivers/gpio/sch_gpio.c:245: warning: ignoring return value of 'gpiochip_remove', declared with attribute warn_unused_result
drivers/gpio/sch_gpio.c:246: warning: ignoring return value of 'gpiochip_remove', declared with attribute warn_unused_result

Introduced by commit 4faabcde03a89836169f1437127226f4b0714070 ("gpio: add
Intel SCH GPIO controller driver").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]