From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Keerthy <j-keerthy@ti.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<gustavo@embeddedor.com>, <keescook@chromium.org>
Subject: Re: linux-next: build warning after merge of the mfd tree
Date: Tue, 2 Jul 2019 18:49:15 +1000 [thread overview]
Message-ID: <20190702184916.5f0f9e99@canb.auug.org.au> (raw)
In-Reply-To: <1b5aa183-6e33-ee15-4c65-5b4cdf7655af@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]
Hi all,
On Thu, 27 Jun 2019 11:29:18 +0530 Keerthy <j-keerthy@ti.com> wrote:
>
> On 27/06/19 10:41 AM, Stephen Rothwell wrote:
> > Hi Lee,
> >
> > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/regulator/lp87565-regulator.c: In function 'lp87565_regulator_probe':
> > drivers/regulator/lp87565-regulator.c:182:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > max_idx = LP87565_BUCK_3210;
>
> Missed adding a break here. Can i send a patch on top of linux-next?
>
> > ~~~~~~~~^~~~~~~~~~~~~~~~~~~
> > drivers/regulator/lp87565-regulator.c:183:2: note: here
> > default:
> > ^~~~~~~
> >
> > Introduced by commit
> >
> > 7ee63bd74750 ("regulator: lp87565: Add 4-phase lp87561 regulator support")
> >
> > I get these warnings because I am building with -Wimplicit-fallthrough
> > in attempt to catch new additions early. The gcc warning can be turned
> > off by adding a /* fall through */ comment at the point the fall through
> > happens (assuming that the fall through is intentional).
> >
I am still seeing this warning ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-02 8:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190627151140.232a87e2@canb.auug.org.au>
2019-06-27 5:59 ` linux-next: build warning after merge of the mfd tree Keerthy
2019-07-02 8:49 ` Stephen Rothwell [this message]
2019-07-02 11:09 ` Lee Jones
2020-07-07 2:44 Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2018-06-05 3:15 Stephen Rothwell
2018-06-05 6:55 ` Lee Jones
2017-11-30 0:35 Stephen Rothwell
2017-11-30 8:28 ` Lee Jones
2017-01-25 4:54 Stephen Rothwell
2017-01-25 8:13 ` Benjamin Gaignard
2013-07-03 5:56 Stephen Rothwell
2013-07-07 18:29 ` Sebastian Andrzej Siewior
2011-12-20 3:11 Stephen Rothwell
2010-11-29 0:52 Stephen Rothwell
2010-11-30 10:02 ` Samuel Ortiz
2010-03-03 5:22 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702184916.5f0f9e99@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=gustavo@embeddedor.com \
--cc=j-keerthy@ti.com \
--cc=keescook@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).