From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D71C19759 for ; Thu, 1 Aug 2019 06:15:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0C99214DA for ; Thu, 1 Aug 2019 06:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564640132; bh=92hLQseZL4EWIhT7fDvRqlQp2hrTUuY/ntRwzMrFKnM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=g0h1zZ0aGvFaWe1PdhG+MHUniYTmv8wkS8BDAnC1U9NCamoSp74Y2pUG3as0IhZ7C ofSQ+GcWCSyXiHbi3gqmoa8k5YXRr6Z7gtae9hTcLOZ2Z3KVUxfSYN+agxDo5yTdk1 vAdoMCoTdGmNOhd57BUeQfhPTZV0A4IDM1i18Q2U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727960AbfHAGPb (ORCPT ); Thu, 1 Aug 2019 02:15:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:38962 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726783AbfHAGPb (ORCPT ); Thu, 1 Aug 2019 02:15:31 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0985EAEBD; Thu, 1 Aug 2019 06:15:30 +0000 (UTC) Date: Thu, 1 Aug 2019 08:15:28 +0200 From: Michal Hocko To: Stephen Rothwell Cc: Miles Chen , Andrew Morton , Linux Next Mailing List , Linux Kernel Mailing List , Qian Cai Subject: Re: linux-next: build warning after merge of the akpm-current tree Message-ID: <20190801061527.GB11627@dhcp22.suse.cz> References: <20190731161151.26ef081e@canb.auug.org.au> <1564554484.28000.3.camel@mtkswgap22> <20190801155130.29a07b1b@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190801155130.29a07b1b@canb.auug.org.au> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Archived-At: List-Archive: List-Post: On Thu 01-08-19 15:51:30, Stephen Rothwell wrote: > Hi Miles, > > On Wed, 31 Jul 2019 14:28:04 +0800 Miles Chen wrote: > > > > On Wed, 2019-07-31 at 16:11 +1000, Stephen Rothwell wrote: > > > > > > After merging the akpm-current tree, today's linux-next build (powerpc > > > ppc64_defconfig) produced this warning: > > > > > > mm/memcontrol.c: In function 'invalidate_reclaim_iterators': > > > mm/memcontrol.c:1160:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] > > > } while (memcg = parent_mem_cgroup(memcg)); > > > ^~~~~ > > > > > > > Hi Stephen, > > > > Thanks for the telling me this. Sorry for the build warning. > > Should I send patch v5 to the mailing list to fix this? > > You might as well (cc'ing Andrew, of course). > > I would suggest finishing that loop like this: > > memcg = parent_mem_cgroup(memcg); > } while (memcg); > > rather than adding a set of parentheses. Qian has already posted a patch http://lkml.kernel.org/r/1564580753-17531-1-git-send-email-cai@lca.pw -- Michal Hocko SUSE Labs