Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure after merge of the dma-mapping-fixes tree
@ 2019-08-07 22:29 Stephen Rothwell
  2019-08-07 22:37 ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2019-08-07 22:29 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]

Hi all,

After merging the dma-mapping-fixes tree, today's linux-next build
(x86_64 allmodconfig) failed like this:

/home/sfr/next/next/mm/migrate.c: In function 'migrate_vma_collect':
/home/sfr/next/next/mm/migrate.c:2350:61: error: 'mm_walk' undeclared (first use in this function)
  mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, NULL, mm_walk.mm,
                                                             ^~~~~~~

Caused by commit

  f4c1f66bf710 ("pagewalk: seperate function pointers from iterator data")

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 8 Aug 2019 08:25:40 +1000
Subject: [PATCH] pagewalk: fix up missed conversion in migrate_vma_collect()

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 mm/migrate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index 75de4378dfcd..585113d2e37d 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -2347,7 +2347,7 @@ static void migrate_vma_collect(struct migrate_vma *migrate)
 {
 	struct mmu_notifier_range range;
 
-	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, NULL, mm_walk.mm,
+	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, NULL, migrate->vma->vm_mm,
 				migrate->start,
 				migrate->end);
 	mmu_notifier_invalidate_range_start(&range);
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: build failure after merge of the dma-mapping-fixes tree
  2019-08-07 22:29 linux-next: build failure after merge of the dma-mapping-fixes tree Stephen Rothwell
@ 2019-08-07 22:37 ` Christoph Hellwig
  2019-08-08  0:42   ` Stephen Rothwell
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2019-08-07 22:37 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Christoph Hellwig, Linux Next Mailing List, Linux Kernel Mailing List

On Thu, Aug 08, 2019 at 08:29:48AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dma-mapping-fixes tree, today's linux-next build
> (x86_64 allmodconfig) failed like this:
> 
> /home/sfr/next/next/mm/migrate.c: In function 'migrate_vma_collect':
> /home/sfr/next/next/mm/migrate.c:2350:61: error: 'mm_walk' undeclared (first use in this function)
>   mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, NULL, mm_walk.mm,
>                                                              ^~~~~~~
> 
> Caused by commit
> 
>   f4c1f66bf710 ("pagewalk: seperate function pointers from iterator data")
> 
> I have applied the following patch for today:

That commit should not have been in that tree at all, let me check what
went wrong.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: build failure after merge of the dma-mapping-fixes tree
  2019-08-07 22:37 ` Christoph Hellwig
@ 2019-08-08  0:42   ` Stephen Rothwell
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2019-08-08  0:42 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi Christoph,

On Thu, 8 Aug 2019 00:37:22 +0200 Christoph Hellwig <hch@lst.de> wrote:
>
> That commit should not have been in that tree at all, let me check what
> went wrong.

I was wondering about that.  Now it has caused build problems further
along, so I have reverted the merge of the branch (along with my fix
up).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 22:29 linux-next: build failure after merge of the dma-mapping-fixes tree Stephen Rothwell
2019-08-07 22:37 ` Christoph Hellwig
2019-08-08  0:42   ` Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org linux-next@archiver.kernel.org
	public-inbox-index linux-next


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/ public-inbox