From: Guenter Roeck <linux@roeck-us.net>
To: Tao Zhou <tao.zhou1@amd.com>
Cc: amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
hawking.zhang@amd.com, dennis.li@amd.com, broonie@kernel.org,
akpm@linux-foundation.org, christian.koenig@amd.com,
linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-build-reports@lists.linaro.org
Subject: Re: drm/amdgpu: replace readq/writeq with atomic64 operations
Date: Thu, 8 Aug 2019 12:25:35 -0700 [thread overview]
Message-ID: <20190808192535.GA18697@roeck-us.net> (raw)
In-Reply-To: <20190807025640.682-1-tao.zhou1@amd.com>
On Wed, Aug 07, 2019 at 10:56:40AM +0800, Tao Zhou wrote:
> readq/writeq are not supported on all architectures
>
> Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Regarding the claim that this would work for 32-bit x86 builds:
make ARCH=i386 allmodconfig
make ARCH=i386 drivers/gpu/drm/amd/amdgpu/amdgpu_device.o
results in:
...
CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_device.o
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function ‘amdgpu_mm_rreg64’:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:279:9: error: implicit declaration of function ‘readq’;
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function ‘amdgpu_mm_wreg64’:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:298:3: error: implicit declaration of function ‘writeq’
This is with next-20190808.
Guenter
next prev parent reply other threads:[~2019-08-08 19:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 2:56 [PATCH] drm/amdgpu: replace readq/writeq with atomic64 operations Tao Zhou
2019-08-07 3:09 ` Jisheng Zhang
2019-08-07 4:02 ` Alex Deucher
2019-08-07 4:03 ` Alex Deucher
2019-08-07 7:08 ` Christoph Hellwig
2019-08-07 8:53 ` Koenig, Christian
2019-08-07 10:41 ` Christoph Hellwig
2019-08-07 10:55 ` Koenig, Christian
2019-08-07 12:59 ` Mark Brown
2019-08-07 13:00 ` Koenig, Christian
2019-08-07 13:07 ` Christoph Hellwig
2019-08-07 13:00 ` Christoph Hellwig
2019-08-07 13:03 ` Koenig, Christian
2019-08-07 18:00 ` Alex Deucher
2019-08-08 19:25 ` Guenter Roeck [this message]
2019-08-08 19:33 ` Alex Deucher
2019-08-09 9:04 ` Koenig, Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808192535.GA18697@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=broonie@kernel.org \
--cc=christian.koenig@amd.com \
--cc=dennis.li@amd.com \
--cc=hawking.zhang@amd.com \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=tao.zhou1@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).