Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Steffen Maier <maier@linux.ibm.com>
Cc: kbuild-all@01.org, "James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Ming Lei <ming.lei@redhat.com>,
	linux-next@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	linux-s390@vger.kernel.org, Benjamin Block <bblock@linux.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Steffen Maier <maier@linux.ibm.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Hannes Reinecke <hare@suse.com>, Jens Axboe <axboe@kernel.dk>,
	"Ewan D . Milne" <emilne@redhat.com>,
	Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH 1/2] scsi: core: fix missing .cleanup_rq for SCSI hosts without request batching
Date: Fri, 9 Aug 2019 09:56:25 +0800
Message-ID: <201908090927.suHYrb4U%lkp@intel.com> (raw)
In-Reply-To: <20190807144948.28265-2-maier@linux.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2387 bytes --]

Hi Steffen,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc3 next-20190808]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Steffen-Maier/scsi-core-fix-missing-cleanup_rq-for-SCSI-hosts-without-request-batching/20190808-052017
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers//scsi/scsi_lib.c:1824:3: error: 'const struct blk_mq_ops' has no member named 'cleanup_rq'; did you mean 'queue_rq'?
     .cleanup_rq = scsi_cleanup_rq,
      ^~~~~~~~~~
      queue_rq
   drivers//scsi/scsi_lib.c:1824:16: error: 'scsi_cleanup_rq' undeclared here (not in a function); did you mean 'scsi_queue_rq'?
     .cleanup_rq = scsi_cleanup_rq,
                   ^~~~~~~~~~~~~~~
                   scsi_queue_rq
>> drivers//scsi/scsi_lib.c:1824:16: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
   drivers//scsi/scsi_lib.c:1824:16: note: (near initialization for 'scsi_mq_ops')
   cc1: some warnings being treated as errors

vim +1824 drivers//scsi/scsi_lib.c

  1811	
  1812	static const struct blk_mq_ops scsi_mq_ops = {
  1813		.get_budget	= scsi_mq_get_budget,
  1814		.put_budget	= scsi_mq_put_budget,
  1815		.queue_rq	= scsi_queue_rq,
  1816		.complete	= scsi_softirq_done,
  1817		.timeout	= scsi_timeout,
  1818	#ifdef CONFIG_BLK_DEBUG_FS
  1819		.show_rq	= scsi_show_rq,
  1820	#endif
  1821		.init_request	= scsi_mq_init_request,
  1822		.exit_request	= scsi_mq_exit_request,
  1823		.initialize_rq_fn = scsi_initialize_rq,
> 1824		.cleanup_rq	= scsi_cleanup_rq,
  1825		.busy		= scsi_mq_lld_busy,
  1826		.map_queues	= scsi_map_queues,
  1827	};
  1828	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55829 bytes --]

  parent reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 14:49 [PATCH 0/2] scsi: core: regression fixes for " Steffen Maier
2019-08-07 14:49 ` [PATCH 1/2] scsi: core: fix missing .cleanup_rq for SCSI hosts without " Steffen Maier
2019-08-07 23:32   ` Ming Lei
2019-08-08  2:18     ` Martin K. Petersen
2019-09-18 15:09       ` Steffen Maier
2019-09-18 15:22         ` Martin K. Petersen
2019-09-18 15:32         ` Mark Brown
2019-08-08  5:52   ` kbuild test robot
2019-08-09  1:56   ` kbuild test robot [this message]
2019-08-07 14:49 ` [PATCH 2/2] scsi: core: fix dh and multipathing " Steffen Maier
2019-08-08  6:02   ` kbuild test robot
2019-08-09  9:08   ` kbuild test robot
2019-08-07 16:17 ` [PATCH 0/2] scsi: core: regression fixes for " Paolo Bonzini
2019-08-07 17:08 ` Bart Van Assche

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201908090927.suHYrb4U%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=axboe@kernel.dk \
    --cc=bblock@linux.ibm.com \
    --cc=bvanassche@acm.org \
    --cc=dm-devel@redhat.com \
    --cc=emilne@redhat.com \
    --cc=gor@linux.ibm.com \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jejb@linux.ibm.com \
    --cc=kbuild-all@01.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=maier@linux.ibm.com \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git