linux-next: build warning after merge of the staging tree

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Hi all,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/iio/light/noa1305.c: In function 'noa1305_scale':
drivers/iio/light/noa1305.c:87:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
   *val2 = 77 * 4;
   ~~~~~~^~~~~~~~
drivers/iio/light/noa1305.c:88:2: note: here
  case NOA1305_INTEGR_TIME_200MS:
  ^~~~

Introduced by commit

  741172d18e8a ("iio: light: noa1305: Add support for NOA1305")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the staging tree

[Greg KH]

On Wed, Aug 14, 2019 at 04:08:35PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/iio/light/noa1305.c: In function 'noa1305_scale':
> drivers/iio/light/noa1305.c:87:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    *val2 = 77 * 4;
>    ~~~~~~^~~~~~~~
> drivers/iio/light/noa1305.c:88:2: note: here
>   case NOA1305_INTEGR_TIME_200MS:
>   ^~~~
> 
> Introduced by commit
> 
>   741172d18e8a ("iio: light: noa1305: Add support for NOA1305")

Fix for this is already in my testing tree, forgot to push it to my
-next branch, but have done so now, thanks!

greg k-h

Re: linux-next: build warning after merge of the staging tree

[Greg KH]

On Wed, Sep 09, 2020 at 05:16:21PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the staging tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/iio/adc/stm32-adc-core.c: In function 'stm32_adc_core_switches_probe':
> drivers/iio/adc/stm32-adc-core.c:598:5: warning: ignoring return value of 'dev_err_probe' declared with attribute 'warn_unused_result' [-Wunused-result]
>   598 |     dev_err_probe(dev, ret, "can't get booster\n");
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   ce30eeb613cb ("iio: adc: stm32: Simplify with dev_err_probe()")

Offending patch now dropped from the driver-core tree, thanks.

greg k-h

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

Hi all,

After merging the staging tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/iio/adc/stm32-adc-core.c: In function 'stm32_adc_core_switches_probe':
drivers/iio/adc/stm32-adc-core.c:598:5: warning: ignoring return value of 'dev_err_probe' declared with attribute 'warn_unused_result' [-Wunused-result]
  598 |     dev_err_probe(dev, ret, "can't get booster\n");
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  ce30eeb613cb ("iio: adc: stm32: Simplify with dev_err_probe()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Hi all,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: drivers/isdn/capi/kernelcapi.o(.text+0x204b): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit()
The function kcapi_exit() references a function in an exit section.
Often the function kcapi_proc_exit() has valid usage outside the exit section
and the fix is to remove the __exit annotation of kcapi_proc_exit.

Introduced by commit

  f59aba2f7579 ("isdn: capi: dead code removal")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the staging tree

[Gao Xiang]

On Mon, Aug 26, 2019 at 05:53:28PM +0800, Gao Xiang wrote:

[]

> The attempt above compiles successfully as well... And I have tried
> the following commands (Just in case...) and the result turns out
> without any difference...
> 
>  $ make ARCH=x86_64 allmodconfig
>  $ make ARCH=x86_64 -j16
> 
> and I'm so confused now... Hope to get your hints...

I think I got the warning now... Sorry, I thought it is a compile error.
I am looking into that, sorry about that...

Thanks,
Gao Xiang

> 
> Thanks,
> Gao Xiang
> 
> > 
> > Out of curiosity, are there some merge conflicts raised? Or could you give
> > me some hints (code and .config) to reproduce that? since I don't find any
> > potential issue in include/trace/events/erofs.h and fs/erofs/*... I have no
> > idea what happened and how to do next... Thank you very much!
> > 
> > Thanks,
> > Gao Xiang
> > 
> > > 
> > > Thanks,
> > > Gao Xiang
> > > 
> > > > > > 
> > > > > > Introduced by commit
> > > > > > 
> > > > > >   47e4937a4a7c ("erofs: move erofs out of staging")
> > > > > > 
> > > > > > (or, at least, exposed by it).  It needs, at least, a "struct dentry;"
> > > > > > added to the file.
> > > > > 
> > > > > Odd, why has this never been seen before when the same files were in
> > > > > drivers/staging/ and why 0-day isn't reporting this?
> > > > 
> > > > I Think it is weird since it is never failed in staging and kbuild-all 0-day ci
> > > > (my tree and you tree)....
> > > > 
> > > > > 
> > > > > Gao, can you send me a patch for this?
> > > > 
> > > > Got it, I will look into that...
> > > > 
> > > > Thanks,
> > > > Gao Xiang
> > > > 
> > > > > 
> > > > > thanks,
> > > > > 
> > 

Re: linux-next: build warning after merge of the staging tree

[Gao Xiang]

On Mon, Aug 26, 2019 at 05:43:41PM +0800, Gao Xiang wrote:
> Hi Stephen,
> 
> On Mon, Aug 26, 2019 at 04:54:08PM +0800, Gao Xiang wrote:
> > Hi Stephen,
> > 
> > On Mon, Aug 26, 2019 at 04:38:01PM +0800, Gao Xiang wrote:
> > > Hi Greg,
> > > 
> > > On Mon, Aug 26, 2019 at 08:30:24AM +0200, Greg KH wrote:
> > > > On Mon, Aug 26, 2019 at 04:24:32PM +1000, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > > 
> > > > > After merging the staging tree, today's linux-next build (x86_64
> > > > > allmodconfig) produced this warning:
> > > > > 
> > > > > In file included from include/trace/events/erofs.h:8,
> > > > >                  from <command-line>:
> > > > > include/trace/events/erofs.h:28:37: warning: 'struct dentry' declared inside parameter list will not be visible outside of this definition or declaration
> > > > >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> > > > >                                      ^~~~~~
> > > > > include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
> > > > >   static inline void trace_##name(proto)    \
> > > > >                                   ^~~~~
> > > > > include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
> > > > >   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
> > > > >                         ^~~~~~
> > > > > include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
> > > > >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> > > > >   ^~~~~~~~~~~~~
> > > > > include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
> > > > >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> > > > >                       ^~~~~~
> > > > > include/trace/events/erofs.h:26:1: note: in expansion of macro 'TRACE_EVENT'
> > > > >  TRACE_EVENT(erofs_lookup,
> > > > >  ^~~~~~~~~~~
> > > > > include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
> > > > >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> > > > >   ^~~~~~~~
> > > > > 
> > > > > and moany more like this ...
> > 
> > Could you give me more log about this? I don't know how to reproduce that warning
> > since I can compile x86-64 kernel image with my configproperly on my PC...
> > I'm trying allmodconfig now...
> 
> I have tested the latest staging-next tree with x86_64 allmodconfig with
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> the following commands (on my x86-64 PC),
> 
>  $ make allmodconfig
>  $ make -j12
> 
> and it compiles successful as below:
>   LD [M]  sound/usb/hiface/snd-usb-hiface.ko
>   LD [M]  sound/usb/line6/snd-usb-line6.ko
>   LD [M]  sound/usb/line6/snd-usb-pod.ko
>   LD [M]  sound/usb/line6/snd-usb-podhd.ko
>   LD [M]  sound/usb/line6/snd-usb-toneport.ko
>   LD [M]  sound/usb/line6/snd-usb-variax.ko
>   LD [M]  sound/usb/misc/snd-ua101.ko
>   LD [M]  sound/usb/snd-usb-audio.ko
>   LD [M]  sound/usb/snd-usbmidi-lib.ko
>   LD [M]  sound/usb/usx2y/snd-usb-us122l.ko
>   LD [M]  sound/usb/usx2y/snd-usb-usx2y.ko
>   LD [M]  sound/x86/snd-hdmi-lpe-audio.ko
>   LD [M]  sound/xen/snd_xen_front.ko
>   LD [M]  virt/lib/irqbypass.ko
> g00380047@architecture4:~/oss/linux-staging$ 
> 
> I'm also testing the latest linux-next tree with commit 47e4937a4a7c applied,
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> 
> and the command is the same (on my x86-64 PC),
> 
>  $ make allmodconfig
>  $ make -j12
> 
> it seems all .o in fs/erofs have been generated properly, although the final
> result hasn't been generated. I will reply the final result later...

The attempt above compiles successfully as well... And I have tried
the following commands (Just in case...) and the result turns out
without any difference...

 $ make ARCH=x86_64 allmodconfig
 $ make ARCH=x86_64 -j16

and I'm so confused now... Hope to get your hints...

Thanks,
Gao Xiang

> 
> Out of curiosity, are there some merge conflicts raised? Or could you give
> me some hints (code and .config) to reproduce that? since I don't find any
> potential issue in include/trace/events/erofs.h and fs/erofs/*... I have no
> idea what happened and how to do next... Thank you very much!
> 
> Thanks,
> Gao Xiang
> 
> > 
> > Thanks,
> > Gao Xiang
> > 
> > > > > 
> > > > > Introduced by commit
> > > > > 
> > > > >   47e4937a4a7c ("erofs: move erofs out of staging")
> > > > > 
> > > > > (or, at least, exposed by it).  It needs, at least, a "struct dentry;"
> > > > > added to the file.
> > > > 
> > > > Odd, why has this never been seen before when the same files were in
> > > > drivers/staging/ and why 0-day isn't reporting this?
> > > 
> > > I Think it is weird since it is never failed in staging and kbuild-all 0-day ci
> > > (my tree and you tree)....
> > > 
> > > > 
> > > > Gao, can you send me a patch for this?
> > > 
> > > Got it, I will look into that...
> > > 
> > > Thanks,
> > > Gao Xiang
> > > 
> > > > 
> > > > thanks,
> > > > 
> 

Re: linux-next: build warning after merge of the staging tree

[Gao Xiang]

Hi Stephen,

On Mon, Aug 26, 2019 at 04:54:08PM +0800, Gao Xiang wrote:
> Hi Stephen,
> 
> On Mon, Aug 26, 2019 at 04:38:01PM +0800, Gao Xiang wrote:
> > Hi Greg,
> > 
> > On Mon, Aug 26, 2019 at 08:30:24AM +0200, Greg KH wrote:
> > > On Mon, Aug 26, 2019 at 04:24:32PM +1000, Stephen Rothwell wrote:
> > > > Hi all,
> > > > 
> > > > After merging the staging tree, today's linux-next build (x86_64
> > > > allmodconfig) produced this warning:
> > > > 
> > > > In file included from include/trace/events/erofs.h:8,
> > > >                  from <command-line>:
> > > > include/trace/events/erofs.h:28:37: warning: 'struct dentry' declared inside parameter list will not be visible outside of this definition or declaration
> > > >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> > > >                                      ^~~~~~
> > > > include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
> > > >   static inline void trace_##name(proto)    \
> > > >                                   ^~~~~
> > > > include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
> > > >   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
> > > >                         ^~~~~~
> > > > include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
> > > >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> > > >   ^~~~~~~~~~~~~
> > > > include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
> > > >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> > > >                       ^~~~~~
> > > > include/trace/events/erofs.h:26:1: note: in expansion of macro 'TRACE_EVENT'
> > > >  TRACE_EVENT(erofs_lookup,
> > > >  ^~~~~~~~~~~
> > > > include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
> > > >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> > > >   ^~~~~~~~
> > > > 
> > > > and moany more like this ...
> 
> Could you give me more log about this? I don't know how to reproduce that warning
> since I can compile x86-64 kernel image with my configproperly on my PC...
> I'm trying allmodconfig now...

I have tested the latest staging-next tree with x86_64 allmodconfig with
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
the following commands (on my x86-64 PC),

 $ make allmodconfig
 $ make -j12

and it compiles successful as below:
  LD [M]  sound/usb/hiface/snd-usb-hiface.ko
  LD [M]  sound/usb/line6/snd-usb-line6.ko
  LD [M]  sound/usb/line6/snd-usb-pod.ko
  LD [M]  sound/usb/line6/snd-usb-podhd.ko
  LD [M]  sound/usb/line6/snd-usb-toneport.ko
  LD [M]  sound/usb/line6/snd-usb-variax.ko
  LD [M]  sound/usb/misc/snd-ua101.ko
  LD [M]  sound/usb/snd-usb-audio.ko
  LD [M]  sound/usb/snd-usbmidi-lib.ko
  LD [M]  sound/usb/usx2y/snd-usb-us122l.ko
  LD [M]  sound/usb/usx2y/snd-usb-usx2y.ko
  LD [M]  sound/x86/snd-hdmi-lpe-audio.ko
  LD [M]  sound/xen/snd_xen_front.ko
  LD [M]  virt/lib/irqbypass.ko
g00380047@architecture4:~/oss/linux-staging$ 

I'm also testing the latest linux-next tree with commit 47e4937a4a7c applied,
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

and the command is the same (on my x86-64 PC),

 $ make allmodconfig
 $ make -j12

it seems all .o in fs/erofs have been generated properly, although the final
result hasn't been generated. I will reply the final result later...

Out of curiosity, are there some merge conflicts raised? Or could you give
me some hints (code and .config) to reproduce that? since I don't find any
potential issue in include/trace/events/erofs.h and fs/erofs/*... I have no
idea what happened and how to do next... Thank you very much!

Thanks,
Gao Xiang

> 
> Thanks,
> Gao Xiang
> 
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   47e4937a4a7c ("erofs: move erofs out of staging")
> > > > 
> > > > (or, at least, exposed by it).  It needs, at least, a "struct dentry;"
> > > > added to the file.
> > > 
> > > Odd, why has this never been seen before when the same files were in
> > > drivers/staging/ and why 0-day isn't reporting this?
> > 
> > I Think it is weird since it is never failed in staging and kbuild-all 0-day ci
> > (my tree and you tree)....
> > 
> > > 
> > > Gao, can you send me a patch for this?
> > 
> > Got it, I will look into that...
> > 
> > Thanks,
> > Gao Xiang
> > 
> > > 
> > > thanks,
> > > 

Re: linux-next: build warning after merge of the staging tree

[Gao Xiang]

Hi Stephen,

On Mon, Aug 26, 2019 at 04:38:01PM +0800, Gao Xiang wrote:
> Hi Greg,
> 
> On Mon, Aug 26, 2019 at 08:30:24AM +0200, Greg KH wrote:
> > On Mon, Aug 26, 2019 at 04:24:32PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the staging tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > In file included from include/trace/events/erofs.h:8,
> > >                  from <command-line>:
> > > include/trace/events/erofs.h:28:37: warning: 'struct dentry' declared inside parameter list will not be visible outside of this definition or declaration
> > >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> > >                                      ^~~~~~
> > > include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
> > >   static inline void trace_##name(proto)    \
> > >                                   ^~~~~
> > > include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
> > >   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
> > >                         ^~~~~~
> > > include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
> > >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> > >   ^~~~~~~~~~~~~
> > > include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
> > >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> > >                       ^~~~~~
> > > include/trace/events/erofs.h:26:1: note: in expansion of macro 'TRACE_EVENT'
> > >  TRACE_EVENT(erofs_lookup,
> > >  ^~~~~~~~~~~
> > > include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
> > >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> > >   ^~~~~~~~
> > > 
> > > and moany more like this ...

Could you give me more log about this? I don't know how to reproduce that warning
since I can compile x86-64 kernel image with my configproperly on my PC...
I'm trying allmodconfig now...

Thanks,
Gao Xiang

> > > 
> > > Introduced by commit
> > > 
> > >   47e4937a4a7c ("erofs: move erofs out of staging")
> > > 
> > > (or, at least, exposed by it).  It needs, at least, a "struct dentry;"
> > > added to the file.
> > 
> > Odd, why has this never been seen before when the same files were in
> > drivers/staging/ and why 0-day isn't reporting this?
> 
> I Think it is weird since it is never failed in staging and kbuild-all 0-day ci
> (my tree and you tree)....
> 
> > 
> > Gao, can you send me a patch for this?
> 
> Got it, I will look into that...
> 
> Thanks,
> Gao Xiang
> 
> > 
> > thanks,
> > 
> > greg k-h

Re: linux-next: build warning after merge of the staging tree

[Gao Xiang]

Hi Greg,

On Mon, Aug 26, 2019 at 08:30:24AM +0200, Greg KH wrote:
> On Mon, Aug 26, 2019 at 04:24:32PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the staging tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > In file included from include/trace/events/erofs.h:8,
> >                  from <command-line>:
> > include/trace/events/erofs.h:28:37: warning: 'struct dentry' declared inside parameter list will not be visible outside of this definition or declaration
> >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> >                                      ^~~~~~
> > include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
> >   static inline void trace_##name(proto)    \
> >                                   ^~~~~
> > include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
> >   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
> >                         ^~~~~~
> > include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
> >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> >   ^~~~~~~~~~~~~
> > include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
> >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> >                       ^~~~~~
> > include/trace/events/erofs.h:26:1: note: in expansion of macro 'TRACE_EVENT'
> >  TRACE_EVENT(erofs_lookup,
> >  ^~~~~~~~~~~
> > include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
> >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> >   ^~~~~~~~
> > 
> > and moany more like this ...
> > 
> > Introduced by commit
> > 
> >   47e4937a4a7c ("erofs: move erofs out of staging")
> > 
> > (or, at least, exposed by it).  It needs, at least, a "struct dentry;"
> > added to the file.
> 
> Odd, why has this never been seen before when the same files were in
> drivers/staging/ and why 0-day isn't reporting this?

I Think it is weird since it is never failed in staging and kbuild-all 0-day ci
(my tree and you tree)....

> 
> Gao, can you send me a patch for this?

Got it, I will look into that...

Thanks,
Gao Xiang

> 
> thanks,
> 
> greg k-h

Re: linux-next: build warning after merge of the staging tree

[Greg KH]

On Mon, Aug 26, 2019 at 04:24:32PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/trace/events/erofs.h:8,
>                  from <command-line>:
> include/trace/events/erofs.h:28:37: warning: 'struct dentry' declared inside parameter list will not be visible outside of this definition or declaration
>   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
>                                      ^~~~~~
> include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
>   static inline void trace_##name(proto)    \
>                                   ^~~~~
> include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
>   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
>                         ^~~~~~
> include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>   ^~~~~~~~~~~~~
> include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>                       ^~~~~~
> include/trace/events/erofs.h:26:1: note: in expansion of macro 'TRACE_EVENT'
>  TRACE_EVENT(erofs_lookup,
>  ^~~~~~~~~~~
> include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
>   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
>   ^~~~~~~~
> 
> and moany more like this ...
> 
> Introduced by commit
> 
>   47e4937a4a7c ("erofs: move erofs out of staging")
> 
> (or, at least, exposed by it).  It needs, at least, a "struct dentry;"
> added to the file.

Odd, why has this never been seen before when the same files were in
drivers/staging/ and why 0-day isn't reporting this?

Gao, can you send me a patch for this?

thanks,

greg k-h

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

Hi all,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/trace/events/erofs.h:8,
                 from <command-line>:
include/trace/events/erofs.h:28:37: warning: 'struct dentry' declared inside parameter list will not be visible outside of this definition or declaration
  TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
                                     ^~~~~~
include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
  static inline void trace_##name(proto)    \
                                  ^~~~~
include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
  __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
                        ^~~~~~
include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^~~~~~~~~~~~~
include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
                      ^~~~~~
include/trace/events/erofs.h:26:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(erofs_lookup,
 ^~~~~~~~~~~
include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
  TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
  ^~~~~~~~

and moany more like this ...

Introduced by commit

  47e4937a4a7c ("erofs: move erofs out of staging")

(or, at least, exposed by it).  It needs, at least, a "struct dentry;"
added to the file.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/staging/kpc2000/kpc_spi/spi_driver.c:97:5: note: offset of packed bit-field 'wl' has changed in GCC 4.4
     } bitfield;
     ^
drivers/staging/kpc2000/kpc_spi/spi_driver.c:97:5: note: offset of packed bit-field 'cs' has changed in GCC 4.4
drivers/staging/kpc2000/kpc_spi/spi_driver.c:97:5: note: offset of packed bit-field 'wcnt' has changed in GCC 4.4

Introduced by commit

  7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the staging tree

[Greg KH]

On Thu, Nov 08, 2018 at 01:33:07PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/linux/printk.h:336,
>                  from include/linux/kernel.h:14,
>                  from include/linux/clk.h:16,
>                  from drivers/staging/media/tegra-vde/tegra-vde.c:12:
> drivers/staging/media/tegra-vde/tegra-vde.c: In function 'tegra_vde_setup_iram_tables':
> drivers/staging/media/tegra-vde/tegra-vde.c:265:5: warning: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int' [-Wformat=]
>      "\tFrame %d: frame_num = %d B_frame = %d\n",
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
>    __dynamic_dev_dbg(&descriptor, dev, fmt, \
>                                        ^~~
> include/linux/device.h:1463:23: note: in expansion of macro 'dev_fmt'
>   dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
>                        ^~~~~~~
> drivers/staging/media/tegra-vde/tegra-vde.c:264:4: note: in expansion of macro 'dev_dbg'
>     dev_dbg(vde->miscdev.parent,
>     ^~~~~~~
> 
> Introduced by commit
> 
>   42e764d05712 ("staging: tegravde: replace bit assignment with macro")

I saw this warning, and ignored it, my fault.  Colin just sent a patch
for this so I'll queue that up now, thanks.

greg k-h

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/printk.h:336,
                 from include/linux/kernel.h:14,
                 from include/linux/clk.h:16,
                 from drivers/staging/media/tegra-vde/tegra-vde.c:12:
drivers/staging/media/tegra-vde/tegra-vde.c: In function 'tegra_vde_setup_iram_tables':
drivers/staging/media/tegra-vde/tegra-vde.c:265:5: warning: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int' [-Wformat=]
     "\tFrame %d: frame_num = %d B_frame = %d\n",
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                       ^~~
include/linux/device.h:1463:23: note: in expansion of macro 'dev_fmt'
  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
                       ^~~~~~~
drivers/staging/media/tegra-vde/tegra-vde.c:264:4: note: in expansion of macro 'dev_dbg'
    dev_dbg(vde->miscdev.parent,
    ^~~~~~~

Introduced by commit

  42e764d05712 ("staging: tegravde: replace bit assignment with macro")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the staging tree

[John Whitmore]

On Mon, Sep 03, 2018 at 12:06:17PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> WARNING: drivers/staging/rtl8192u/r8192u_usb: 'dot11d_init' exported twice. Previous export was in drivers/staging/rtl8192e/rtllib.ko
> 
> Introduced by commit
> 
>   c01f06b7506f ("staging:rtl8192u: Rename Dot11d_Init - Style")
> 
> -- 
> Cheers,
> Stephen Rothwell

Aragh, sorry my bad, and a newbie mistake. I now know to do more of a
check for exported symbols. If it had occured to me I'd not have touched
it.

I'm not sure what the procedure is, having written my first bug, but I'll
submit a patch to revert that change.

jwhitmore

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hi Greg,

After merging the staging tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

WARNING: drivers/staging/rtl8192u/r8192u_usb: 'dot11d_init' exported twice. Previous export was in drivers/staging/rtl8192e/rtllib.ko

Introduced by commit

  c01f06b7506f ("staging:rtl8192u: Rename Dot11d_Init - Style")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.o(.data+0x0): Section mismatch in reference from the variable bcm2835_camera_driver to the function .init.text:bcm2835_mmal_probe()
The variable bcm2835_camera_driver references
the function __init bcm2835_mmal_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.o(.data+0x0): Section mismatch in reference from the variable bcm2835_camera_driver to the function .init.text:bcm2835_mmal_probe()
The variable bcm2835_camera_driver references
the function __init bcm2835_mmal_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Introduced by commit

  4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform driver.")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the staging tree

[Greg KH]

On Tue, Jan 16, 2018 at 11:47:47AM +0100, Arnd Bergmann wrote:
> On Tue, Jan 16, 2018 at 6:59 AM, Greg KH <greg@kroah.com> wrote:
> > On Tue, Jan 16, 2018 at 01:45:44PM +1100, Stephen Rothwell wrote:
> >> Hi Greg,
> >>
> >> After merging the staging tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init':
> >> drivers/staging/lustre/lnet/selftest/module.c:98:10: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>    return rc;
> >>           ^~
> >>
> >> Introduced by commit
> >>
> >>   6106c0f82481 ("staging: lustre: lnet: convert selftest to use workqueues")
> >
> > Yeah, I told Neil about this, hopefully he sends me a fix soon :)
> 
> I sent a fix for that one, but now ran into another problem that I can't
> easily figure out:
> 
> drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init':
> drivers/staging/lustre/lnet/selftest/module.c:128:49: error: 'struct
> cfs_cpt_table' has no member named 'ctb_parts'; did you mean
> 'ctb_nparts'?
>    cpumask_copy(attrs.cpumask, lnet_cpt_table()->ctb_parts[i].cpt_cpumask);
> 
> I see that there are two definitions of 'struct cfs_cpt_table', and only
> one of them has a ctb_parts member, but I don't know what this means
> for its users.
> 
> The build regression also comes from commit 6106c0f82481 ("staging:
> lustre: lnet: convert selftest to use workqueues"), and I see that all
> other references to ctb_parts are in
> drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c.

Odd, I can't duplicate the build error here, but 0-day also complains
about this.  Neil is out until Friday, so maybe he can fix it up then...

thanks,

greg k-h

Re: linux-next: build warning after merge of the staging tree

[Arnd Bergmann]

On Tue, Jan 16, 2018 at 6:59 AM, Greg KH <greg@kroah.com> wrote:
> On Tue, Jan 16, 2018 at 01:45:44PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the staging tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init':
>> drivers/staging/lustre/lnet/selftest/module.c:98:10: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>    return rc;
>>           ^~
>>
>> Introduced by commit
>>
>>   6106c0f82481 ("staging: lustre: lnet: convert selftest to use workqueues")
>
> Yeah, I told Neil about this, hopefully he sends me a fix soon :)

I sent a fix for that one, but now ran into another problem that I can't
easily figure out:

drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init':
drivers/staging/lustre/lnet/selftest/module.c:128:49: error: 'struct
cfs_cpt_table' has no member named 'ctb_parts'; did you mean
'ctb_nparts'?
   cpumask_copy(attrs.cpumask, lnet_cpt_table()->ctb_parts[i].cpt_cpumask);

I see that there are two definitions of 'struct cfs_cpt_table', and only
one of them has a ctb_parts member, but I don't know what this means
for its users.

The build regression also comes from commit 6106c0f82481 ("staging:
lustre: lnet: convert selftest to use workqueues"), and I see that all
other references to ctb_parts are in
drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c.

         Arnd

Re: linux-next: build warning after merge of the staging tree

[Greg KH]

On Tue, Jan 16, 2018 at 01:45:44PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init':
> drivers/staging/lustre/lnet/selftest/module.c:98:10: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    return rc;
>           ^~
> 
> Introduced by commit
> 
>   6106c0f82481 ("staging: lustre: lnet: convert selftest to use workqueues")

Yeah, I told Neil about this, hopefully he sends me a fix soon :)

thanks,

greg k-h

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init':
drivers/staging/lustre/lnet/selftest/module.c:98:10: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
   return rc;
          ^~

Introduced by commit

  6106c0f82481 ("staging: lustre: lnet: convert selftest to use workqueues")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the staging tree

[Linus Walleij]

On Fri, Jan 20, 2017 at 9:37 AM, Greg KH <greg@kroah.com> wrote:
> On Fri, Jan 20, 2017 at 03:36:22PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the staging tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>>
>> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_I2C_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_I2C && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_I2C)
>> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
>> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
>> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_I2C_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_I2C && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_I2C)
>> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
>> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_I2C_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_I2C && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_I2C)
>>
>> Introduced by commit
>>
>>   762227721fe6 ("iio: accel: st_accel: handle deprecated bindings")
>
> Ick.  I've added Jonathan to the thread, any thoughts?

Probably my bad. Investigating and sending a patch.

Yours,
Linus Walleij

Re: linux-next: build warning after merge of the staging tree

[Greg KH]

On Fri, Jan 20, 2017 at 03:36:22PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_I2C_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_I2C && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_I2C)
> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_I2C_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_I2C && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_I2C)
> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_I2C_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_I2C && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_I2C)
> 
> Introduced by commit
> 
>   762227721fe6 ("iio: accel: st_accel: handle deprecated bindings")

Ick.  I've added Jonathan to the thread, any thoughts?

thanks,

greg k-h

linux-next: build warning after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_I2C_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_I2C && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_I2C)
warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_I2C_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_I2C && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_I2C)
warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_I2C_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_I2C && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_I2C)

Introduced by commit

  762227721fe6 ("iio: accel: st_accel: handle deprecated bindings")

-- 
Cheers,
Stephen Rothwell