linux-next: Fixes tag needs some work in the sound-asoc tree

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi all,

In commit

  9b4275c415ac ("ASoC: cs4349: Use PM ops 'cs4349_runtime_pm'")

Fixes tag

  Fixes: e40da86 ("ASoC: cs4349: Add support for Cirrus Logic CS4349")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,

In commit

  60b4a86cc6b8 ("ASoC: amd: acp: Fix for indentation issue")

Fixes tag

  Fixes: e84db124cb21 (ASoC: amd: acp: Add pci legacy driver support

has these problem(s):

  - Subject has leading but no trailing parentheses

Please do not split Fixes tags over more than one line and keep all the
commit message tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

Hi all,

In commit

  6d925797304e ("sh: boards: Fix Sound Simple-Card struct name")

Fixes tag

  Fixes: ad484cc98f2 ("ASoC: remove asoc_xxx() compatible macro")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hi all,

In commit

  99bad468846f ("ASoC: SOF: mediatek: fix mt8195 StatvectorSel wrong setting")

Fixes tag

  Fixes: b7f6503830 ("ASoC: SOF: mediatek: Add fw loader and mt8195 dsp ops to load firmware")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Hi all,

In commit

  c5003f08fe67 ("ASoC: SOF: ipc-msg-injector: Cap the rmaining to count in IPC4 mode")

Fixes tag

  Fixes: 066c67624d8c: "ASoC: SOF: ipc-msg-injector: Add support for IPC4 messages"

has these problem(s):

  - Not in the correct format
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

Hi all,

In commit

  9ce170dc9c08 ("ASoC: SOF: mediatek: Fix allyesconfig build error")

Fixes tag

  Fixes: 570c14dc92d5 ("ASoC: SOF: mediatek: Add mt8186 sof fw loader and

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, please keep
all the commit message tags together at the end of the commit message.

This whole commit message was badly word wrapped :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Tinghan Shen]

Hi Stephen,

On Thu, 2022-04-28 at 10:57 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   9ce170dc9c08 ("ASoC: SOF: mediatek: Fix allyesconfig build error")
> 
> Fixes tag
> 
>   Fixes: 570c14dc92d5 ("ASoC: SOF: mediatek: Add mt8186 sof fw loader and
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.  Also, please keep
> all the commit message tags together at the end of the commit message.
> 
> This whole commit message was badly word wrapped :-(

It's because I want to keep the original build message and 
wrap at the 75 columns at the same time. After look back of
your ealier email, I should refrain from doing so and leave the 
build message unwrapped, as you did.

I apologize for the fault, I'll keep this in my mind.


Thanks,
TingHan

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

Hi all,

In commit

  fb763299bd8e ("ASoC: SOF: topology: remove redundant code")

Fixes tag

  Fixes: bdf4ad3fd01f ('ASoC: SOF: Intel: hda: assign link DMA channel at

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, please keep
the commit message tags all together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

Hi all,

In commit

  de2c6f98817f ("ASoC: soc-compress: prevent the potentially use of null pointer")

Fixes tag

  Fixes: 467fece ("ASoC: soc-dai: move snd_soc_dai_stream_valid() to soc-dai.c")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Hi all,

In commit

  043c0a6278ca ("firmware: cs_dsp: Move lockdep asserts to avoid potential null pointer")

Fixes tag

  Fixes: fb2f364fb5b9 ("firmware: cs_dsp: Add lockdep asserts to interface functions")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 5065cfabec21 ("firmware: cs_dsp: Add lockdep asserts to interface functions")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Charles Keepax]

On Thu, Dec 02, 2021 at 08:25:54AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   043c0a6278ca ("firmware: cs_dsp: Move lockdep asserts to avoid potential null pointer")
> 
> Fixes tag
> 
>   Fixes: fb2f364fb5b9 ("firmware: cs_dsp: Add lockdep asserts to interface functions")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 5065cfabec21 ("firmware: cs_dsp: Add lockdep asserts to interface functions")

Sorry yeah that will be my fault, not sure how I managed to stuff
that up, but will try to be more careful.

Thanks,
Charles

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi all,

In commit

  da0363f7bfd3 ("ASoC: qcom: Fix for DMA interrupt clear reg overwriting")

Fixes tag

  Fixes: commit c5c8635a04711 ("ASoC: qcom: Add LPASS platform driver")

has these problem(s):

  - leading word 'commit' unexpected

Also, please keep all the tags in the commit message together at the end.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi all,

In commit

  ad839121dd4c ("ASoC: SOF: Intel: hda: fix index used in inner loop")

Fixes tag

  Fixes: 6f5d506d7ff1dq ('ASoC: SOF: Intel: SoundWire: refine ACPI match')

has these problem(s):

  - missing space between the SHA1 and the subject

Actually, there is a trailing 'q' on the SHA1.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

Hi all,

In commit

  a4856e15e58b ("ASoC: rsnd: check all BUSIF status when error")

Fixes tag

  Fixes: commit 66c705d07d784 ("SoC: rsnd: add interrupt support for SSI BUSIF buffer")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

In commit

  e5448d7ec656 ("ASoC: tlv320adcx140: Fix various style errors and warnings")

Fixes tag

  Fixes: 689c7655b50 ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Just a hint for the future.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hi all,

In commit

  7506baeed8d0 ("ASoC: stm32: sai: Add missing cleanup")

Fixes tag

  Fixes: commit 0d6defc7e0e4 ("ASoC: stm32: sai: manage rebind issue")

has these problem(s):

  - leading word 'commit' unexpected

Also, please keep all the commit tags together at the end of the commit
message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

In commit

  d4061518c398 ("ASoC: tlv320adcx140: Remove undocumented property")

Fixes tag

  Fixes: 302c0b7490cd ("dt-bindings: sound: Add TLV320ADCx140 dt

has these problem(s):

  - Target SHA1 does not exist

Maybe yuou meant

Fixes: 4ee67cbd9766 ("dt-bindings: sound: Add TLV320ADCx140 dt bindings")

Also, please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Hi all,

n commit

  5c82813ce43e ("ASoC: Intel: boards: drop reverse deps for SND_HDA_CODEC_HDMI")

Fixes tag

  Fixes: aa2b4a5 ('ASoC: Intel: boards: fix incorrect HDMI Kconfig dependency')

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Kai Vehmanen]

Hi,

On Sat, 14 Mar 2020, Stephen Rothwell wrote:

> n commit
>   5c82813ce43e ("ASoC: Intel: boards: drop reverse deps for SND_HDA_CODEC_HDMI")
> 
> Fixes tag
>   Fixes: aa2b4a5 ('ASoC: Intel: boards: fix incorrect HDMI Kconfig dependency')[
> 
>  - SHA1 should be at least 12 digits long

ack, thanks, this is a plain oversight -- other fixes tags from same 
author (i.e. me) as well as other use of the tag in the sound-asoc tree 
appear fine. So my bad, sorry!

Br, Kai

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi all,

In commit

  ac5bf39e3968 ("ASoC: soc-dapm: don't use rtd->cpu_dai on for_each_rtd_cpu_dai()")

Fixes tag

  Fixes: commit de6214a33633d ("ASoC: Add multiple CPU DAI support in DAPM")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Hi all,

In commit

  1c5312308c96 ("ASoC: soc-pcm/soc-compress: don't use snd_soc_dapm_stream_stop()")

Fixes tag

  Fixes: commit b0edff42360ab4 ("ASoC: soc-pcm/soc-compress: use snd_soc_dapm_stream_stop() for SND_SOC_DAPM_STREAM_STOP")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Hi all,

In commit

  a35716a95655 ("ASoC: pcm3168a: Fix serial mode dependent format support")

Fixes tag

  Fixes: ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")

has these problem(s):

  - No SHA1 recognised

Did you mean

Fixes: cfc28ac124c4 ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Peter Ujfalusi]

Hi Stephen,

On 15/10/2019 14.30, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   a35716a95655 ("ASoC: pcm3168a: Fix serial mode dependent format support")
> 
> Fixes tag
> 
>   Fixes: ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> Did you mean
> 
> Fixes: cfc28ac124c4 ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")

Not again, I have left out the SHA1 to look it up in linux-next which I
failed to do.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi all,

In commit

  c9cff337eab3 ("ASoC: mchp-i2s-mcc: Fix simultaneous capture and playback in master mode")

Fixes tag

  Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

Hi all,

In commit

  0f6fc97501b7 ("ASoC: mchp-i2s-mcc: Wait for RX/TX RDY only if controller is running")

Fixes tag

  Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

In commit

  988b59467b2b ("ASoC: mchp-i2s-mcc: Fix unprepare of GCLK")

Fixes tag

  Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

Hi all,

These actually relate to the sound-asoc-fixes tree.

On Wed, 21 Aug 2019 07:04:52 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> In commit
> 
>   0f6fc97501b7 ("ASoC: mchp-i2s-mcc: Wait for RX/TX RDY only if controller is running")
> 
> Fixes tag
> 
>   Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")
> 
> In commit
> 
>   988b59467b2b ("ASoC: mchp-i2s-mcc: Fix unprepare of GCLK")
> 
> Fixes tag
> 
>   Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi all,

In commit

  bed7f1469f08 ("ASoC: cs4349: Use PM ops 'cs4349_runtime_pm'")

Fixes tag

  Fixes: e40da86 ("ASoC: cs4349: Add support for Cirrus Logic CS4349")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,

In commit

  9fcf9139a2fd ("ASoC: ti: davinci-mcasp: Fix clk PDIR handling for i2s master mode")

Fixes tag

  Fixes: 2302be4126f52 ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: ca3d9433349e ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Peter Ujfalusi]

Stephen,

On 26/07/2019 0.27, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   9fcf9139a2fd ("ASoC: ti: davinci-mcasp: Fix clk PDIR handling for i2s master mode")
> 
> Fixes tag
> 
>   Fixes: 2302be4126f52 ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: ca3d9433349e ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")

Indeed this is the correct SHA1, looks like the 2302be4126f52 is on TI's
4.19-LTS branch and it got into the commit message because I have
validated first on that before moving on to linux-next.

Mark: can you either drop the patch and I'll send a new one with fixed
SHA1 or can you fix the commit message in place?

Sorry.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote:

> Mark: can you either drop the patch and I'll send a new one with fixed
> SHA1 or can you fix the commit message in place?

Both of which involve rebasing :(  Against my better judgement I
rebased.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Peter Ujfalusi]

Mark,

On 26/07/2019 15.11, Mark Brown wrote:
> On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote:
> 
>> Mark: can you either drop the patch and I'll send a new one with fixed
>> SHA1 or can you fix the commit message in place?
> 
> Both of which involve rebasing :(  Against my better judgement I
> rebased.

thank you and sorry again...

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Hi all,

In commit

  52db6685932e ("ASoC: simple_card_utils.h: care NULL dai at asoc_simple_debug_dai()")

Fixes tag

  Fixes: commit 0580dde59438 ("ASoC: simple-card-utils: add asoc_simple_debug_info()")

has these problem(s):

  - leading word 'commit' unexpected

In commit

  6cd249cfad68 ("ASoC: max98357a: use mdelay for sdmode-delay")

Fixes tag

  Fixes: cec5b01f8f1c ("ASoC: max98357a: avoid speaker pop when playback

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line. Also, don't
include blank lines among the tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Tzung-Bi Shih]

On Thu, Jul 11, 2019 at 12:13 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> In commit
>
>   6cd249cfad68 ("ASoC: max98357a: use mdelay for sdmode-delay")
>
> Fixes tag
>
>   Fixes: cec5b01f8f1c ("ASoC: max98357a: avoid speaker pop when playback
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line. Also, don't
> include blank lines among the tags.
I am sorry for this fault.

Mark, do you need me to resend the patch to fix the commit message?

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hi all,

In commit

  8a90efd15ef6 ("ASoC: vc4: vc4_htmi: consider CPU-Platform possibility")

Fixes tag

  Fixes: commit 6c6de1c9e2bf2 ("ASoC: vc4: vc4_hdmi: don't select unnecessary Platform")

has these problem(s):

  - leading word 'commit' unexpected

This as also the case for the whole follogin series of commits :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Hi all,

In commit

  e3303268f9cf ("ASoC: soc-core: don't use soc_find_component() at snd_soc_find_dai()")

Fixes tag

  Fixes: commit b9f2e25c599bb ("ASoC: soc-core: use soc_find_component() at snd_soc_find_dai()")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  970c43d17835 ("ASoC: SOF: Intel: hda: use the defined ppcap functions")

Fixes tag

  Fixes: 8a300c8fb17 ("ASoC: SOF: Intel: Add HDA controller for Intel DSP")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi all,

In commit

  e355d3de196f ("ASoC: Mediatek: MT8183: fix compile error")

Fixes tag

  Fixes: 1628fc3f4771 ("ASoC: Mediatek: MT8183: add memory interface data align")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  ad6eecbfc01c ("ASoC: cs42xx8: Add regcache mask dirty")

Fixes tag

  Fixes: 0c516b4ff85c ("ASoC: cs42xx8: Add codec driver

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the sound-asoc tree

[S.j. Wang]

Hi 

   Do I need to resend the patch?

Best regards
Wang shengjiu
> 
> In commit
> 
>   b06c58c2a1ee ("ASoC: fsl_asrc: Fix the issue about unsupported rate")
> 
> Fixes tag
> 
>   Fixes: fff6e03c7b65 ("ASoC: fsl_asrc: add support for 8-30kHz
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split fixes tags over more that one line.
> 
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hi all,

In commit

  b06c58c2a1ee ("ASoC: fsl_asrc: Fix the issue about unsupported rate")

Fixes tag

  Fixes: fff6e03c7b65 ("ASoC: fsl_asrc: add support for 8-30kHz

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split fixes tags over more that one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hi all,

In commit

  825b22e5961a ("ASoC: rsnd: src: fix compiler warnings")

Fixes tag

  Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR handling")

has these problem(s):

  - 'linux-next commit' was unexpected.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

Hi all,

In commit

  399706df420e ("ASoC: rsnd: src: fix compiler warnings")

Fixes tag

  Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR handling")

has these problem(s):

  - 'linux-next commit' was unexpected.

In commit

  ba164a49f8f7 ("ASoC: rsnd: src: Avoid a potential deadlock")

Fixes tag

  Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR handling")

has these problem(s):

  - 'linux-next commit' was unexpected.

Just use:

  got log --format='Fixes: %h ("%s")' <commit>

to generate the Fixes tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  2b13bee38849 ("ASoC: samsung: odroid: Fix clock configuration for 44100 sample rate")

Fixes tag

  Fixes: fbeec965b8d1c ("ASoC: samsung: odroid: Fix 32000 sample rate handling")

has these problem(s):

  - Target SHA1 does not exist

Did you mean:

  1d22c337dc8f ("ASoC: samsung: odroid: Fix 32000 sample rate handling"

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

[Sylwester Nawrocki]

On 3/17/19 02:28, Stephen Rothwell wrote:
> In commit
> 
>   2b13bee38849 ("ASoC: samsung: odroid: Fix clock configuration for 44100 sample rate")
> 
> Fixes tag
> 
>   Fixes: fbeec965b8d1c ("ASoC: samsung: odroid: Fix 32000 sample rate handling")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean:
> 
>   1d22c337dc8f ("ASoC: samsung: odroid: Fix 32000 sample rate handling"


Yes, I unfortunately used erroneously hash from this -stable commit:
 

commit fbeec965b8d1ca4005f2b63f70fd6ed54a147027
Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
Date:   Wed Mar 14 17:41:13 2018 +0100

    ASoC: samsung: odroid: Fix 32000 sample rate handling
    
    [ Upstream commit 1d22c337dc8f3a25638f7262e7bcb5729a34d140 ]
    
    In case of sample rates lower than 44100 currently there is too low MCLK
    frequency set for the CODEC. Playback fails with following errors:
    
    $ speaker-test -c2 -t sine -f 1500 -l2 -r 32000
    
    Sine wave rate is 1500.0000Hz
    Rate set to 32000Hz (requested 32000Hz)
    Buffer size range from 128 to 131072
    Period size range from 64 to 65536
    Using max buffer size 131072
    Periods = 4
    Unable to set hw params for playback: Invalid argument
    Setting of hwparams failed: Invalid argument
    
    [  497.883700] max98090 1-0010: Invalid master clock frequency
    
    To fix this the I2S root clock's frequency is increased, depending
    on sampling rate.
    
    Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
    Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


-- 
Thanks,
Sylwester

linux-next: Fixes tag needs some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi all,

In commit

  720734a0b66f ("ASoC: soc-core: use for_each_link_codecs() for dai_link codecs V2")

Fixes tag

  Fixes: 50acc7e49 ("ASoC: core: Fix multi-CODEC setups")

has these problem(s):

  - Target SHA1 does not exist

Maybe commit 3f6a125230d8bfcbfe0c06ff0b8eaccbc727acd7?

Fixes tag

  Fixes: 10dff9b0d ("ASoC: soc-core: use for_each_link_codecs() for dai_link codecs")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  141474c6ac7f ("ASoC: Fixup build error for mt6358")

Fixes tag

  Fixes: commit 6a8d4198ca8 ("ASoC: mediatek: mt6358: add codec driver")

has these problem(s):

  - leading word 'commit' unexpected
  - SHA1 should be at least 12 digits long

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]