From: Mark Brown <broonie@kernel.org>
To: Ashish Kumar <Ashish.Kumar@nxp.com>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux-next@vger.kernel.org,
Kuldeep Singh <kuldeep.singh@nxp.com>
Subject: Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings
Date: Wed, 21 Aug 2019 12:06:40 +0100 [thread overview]
Message-ID: <20190821110640.GC5128@sirena.co.uk> (raw)
In-Reply-To: <1565691791-26167-1-git-send-email-Ashish.Kumar@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Tue, Aug 13, 2019 at 03:53:09PM +0530, Ashish Kumar wrote:
> There are 2 version of QSPI-IP, according to which controller registers sets
> can be big endian or little endian.There are some other minor changes like
> RX fifo depth etc.
>
> The big endian version uses driver compatible "fsl,ls1021a-qspi" and
> little endian version uses driver compatible "fsl,ls2080a-qspi"
I'm not seeing the corresponding code changes anywhere? I'd at least
expect to see the compatibles added, and it sounds like some actual code
updates are needed.
Please use subject lines matching the style for the subsystem. This
makes it easier for people to identify relevant patches.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-21 11:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 10:23 [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings Ashish Kumar
2019-08-13 10:23 ` [Patch v4 2/3] dt-bindings: spi: spi-fsl-qspi: Add bindings of ls1088a and ls1012a Ashish Kumar
2019-08-13 10:23 ` [Patch v4 3/3] dt-bindings: Enhance binding to extend example for flash entry Ashish Kumar
2019-08-22 19:22 ` Applied "spi: fsl-qspi: Enhance binding to extend example for flash entry" to the spi tree Mark Brown
2019-08-21 11:06 ` Mark Brown [this message]
2019-08-21 14:18 ` [EXT] Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings Ashish Kumar
2019-08-22 6:39 ` Ashish Kumar
2019-08-22 18:49 ` Mark Brown
2019-08-27 15:50 ` Rob Herring
2019-08-27 19:56 ` Mark Brown
2019-08-28 20:01 ` Rob Herring
2019-08-28 21:20 ` Mark Brown
2019-08-22 19:05 ` Mark Brown
2019-08-26 6:19 ` Ashish Kumar
2019-08-27 18:03 ` Mark Brown
2019-08-28 6:20 ` Ashish Kumar
2019-08-22 19:22 ` Applied "spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821110640.GC5128@sirena.co.uk \
--to=broonie@kernel.org \
--cc=Ashish.Kumar@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kuldeep.singh@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).