From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for Aug 27 (objtool)
Date: Wed, 28 Aug 2019 11:13:31 -0500 [thread overview]
Message-ID: <20190828161331.kvikro257blxtzu5@treble> (raw)
In-Reply-To: <f354f4be-99c7-346f-c7c5-ac5ce8a72a16@infradead.org>
On Wed, Aug 28, 2019 at 09:05:18AM -0700, Randy Dunlap wrote:
> On 8/28/19 8:51 AM, Josh Poimboeuf wrote:
> > On Tue, Aug 27, 2019 at 12:05:42PM -0700, Randy Dunlap wrote:
> >> On 8/27/19 8:59 AM, Josh Poimboeuf wrote:
> >>> On Tue, Aug 27, 2019 at 08:40:07AM -0700, Randy Dunlap wrote:
> >>>> On 8/27/19 2:05 AM, Stephen Rothwell wrote:
> >>>>> Hi all,
> >>>>>
> >>>>> Changes since 20190826:
> >>>>>
> >>>>
> >>>> on x86_64:
> >>>>
> >>>> arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x33: unreachable instruction
> >>>>
> >>>>> gcc --version
> >>>> gcc (SUSE Linux) 7.4.0
> >>>>
> >>>>
> >>>> want more info?
> >>>
> >>> Yes, can you provide the .o and the .config?
> >>>
> >>
> >> Sure. The .o was 508KB, so I compressed it.
> >
> > Thanks Randy. Here's a tentative fix. I need to make sure it doesn't
> > break anything else.
>
> Works for me on the reported failure. Thanks.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
Turns out this patch does break something:
arch/x86/xen/enlighten_pv.o: warning: objtool: xen_cpuid()+0x25: can't find jump dest instruction at .text+0x9c
I'll need to figure out a better way to whitelist that
XEN_EMULATE_PREFIX fake instruction thing. I'll probably just teach
the objtool decoder about it.
--
Josh
next prev parent reply other threads:[~2019-08-28 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 9:05 linux-next: Tree for Aug 27 Stephen Rothwell
2019-08-27 15:18 ` linux-next: Tree for Aug 27 (amdgpu) Randy Dunlap
2019-08-27 15:41 ` Alex Deucher
2019-08-27 15:24 ` linux-next: Tree for Aug 27 (mshyperv.c) Randy Dunlap
2019-08-27 15:29 ` linux-next: Tree for Aug 27 (kunit) Randy Dunlap
2019-08-27 16:09 ` Brendan Higgins
2019-08-27 16:12 ` shuah
2019-08-27 15:37 ` linux-next: Tree for Aug 27 (mm/zsmalloc.c) Randy Dunlap
2019-08-28 5:30 ` Sergey Senozhatsky
2019-08-27 15:40 ` linux-next: Tree for Aug 27 (objtool) Randy Dunlap
2019-08-27 15:59 ` Josh Poimboeuf
2019-08-27 19:05 ` Randy Dunlap
2019-08-28 15:51 ` Josh Poimboeuf
2019-08-28 16:05 ` Randy Dunlap
2019-08-28 16:13 ` Josh Poimboeuf [this message]
2019-08-28 16:34 ` Josh Poimboeuf
2019-08-29 1:53 ` Masami Hiramatsu
2019-08-29 17:59 ` Josh Poimboeuf
2019-08-30 6:23 ` Masami Hiramatsu
2019-08-30 15:14 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828161331.kvikro257blxtzu5@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).