Hi all, After merging the drm-misc tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/gpu/drm/virtio/virtgpu_object.c:31:67: error: expected ')' before 'int' module_param_named(virglhack, virtio_gpu_virglrenderer_workaround, int, 0400); ^~~~ ) Caused by commit 3e93bc2a58aa ("drm/virtio: make resource id workaround runtime switchable.") I applied the following fix patch: From: Stephen Rothwell Date: Wed, 28 Aug 2019 18:37:40 +1000 Subject: [PATCH] drm/virtio: module_param_named() requires linux/moduleparam.h Signed-off-by: Stephen Rothwell --- drivers/gpu/drm/virtio/virtgpu_object.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c index aab5534056ec..b5f8923ac674 100644 --- a/drivers/gpu/drm/virtio/virtgpu_object.c +++ b/drivers/gpu/drm/virtio/virtgpu_object.c @@ -23,6 +23,8 @@ * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ +#include + #include #include "virtgpu_drv.h" -- 2.20.1 -- Cheers, Stephen Rothwell