linux-next: build warning from Linus' tree

linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Hi all,

From Linus tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

arch/x86/boot/edd.c: In function 'query_edd':
arch/x86/boot/edd.c:148:11: warning: taking address of packed member of 'struct boot_params' may result in an unaligned pointer value [-Waddress-of-packed-member]
  148 |  mbrptr = boot_params.edd_mbr_sig_buffer;
      |           ^~~~~~~~~~~

I assume this is a result of upgrading my x86_64 cross compiler to v9.2.1
(from v8.3.0).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning from Linus' tree

[Thomas Gleixner]

Stephen,

On Fri, 30 Aug 2019, Stephen Rothwell wrote:

> Hi all,
> 
> From Linus tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> arch/x86/boot/edd.c: In function 'query_edd':
> arch/x86/boot/edd.c:148:11: warning: taking address of packed member of 'struct boot_params' may result in an unaligned pointer value [-Waddress-of-packed-member]
>   148 |  mbrptr = boot_params.edd_mbr_sig_buffer;
>       |           ^~~~~~~~~~~
> 
> I assume this is a result of upgrading my x86_64 cross compiler to v9.2.1
> (from v8.3.0).

Yes. We have a fix queued which should hit next tomorrow.

Thanks,

	tglx

Re: linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

Hi Thomas,

On Fri, 30 Aug 2019 00:29:21 +0200 (CEST) Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Fri, 30 Aug 2019, Stephen Rothwell wrote:
> 
> Yes. We have a fix queued which should hit next tomorrow.

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

Hi all,

On Tue, 20 Jul 2021 17:31:42 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 8 Jul 2021 12:25:44 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Tue, 1 Jun 2021 17:20:26 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > When building Linus' tree, today's linux-next build (htmldocs) produced
> > > this warning:
> > > 
> > > include/linux/spi/spi.h:671: warning: Function parameter or member 'devm_allocated' not described in 'spi_controller'
> > > 
> > > Introduced by commit
> > > 
> > >   794aaf01444d ("spi: Fix use-after-free with devm_spi_alloc_*")
> > > 
> > > This has been around for a while (at least v5.13-rc1 and next-20210409).
> > > Sorry I did not report it earlier.    
> > 
> > I am still getting this warning.  
> 
> I am still getting this warning.  It is now on line 675.

Now line 672 ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Hi all,

On Thu, 8 Jul 2021 12:25:44 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 1 Jun 2021 17:20:26 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > When building Linus' tree, today's linux-next build (htmldocs) produced
> > this warning:
> > 
> > include/linux/spi/spi.h:671: warning: Function parameter or member 'devm_allocated' not described in 'spi_controller'
> > 
> > Introduced by commit
> > 
> >   794aaf01444d ("spi: Fix use-after-free with devm_spi_alloc_*")
> > 
> > This has been around for a while (at least v5.13-rc1 and next-20210409).
> > Sorry I did not report it earlier.  
> 
> I am still getting this warning.

I am still getting this warning.  It is now on line 675.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi all,

On Tue, 1 Jun 2021 17:20:26 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> When building Linus' tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> include/linux/spi/spi.h:671: warning: Function parameter or member 'devm_allocated' not described in 'spi_controller'
> 
> Introduced by commit
> 
>   794aaf01444d ("spi: Fix use-after-free with devm_spi_alloc_*")
> 
> This has been around for a while (at least v5.13-rc1 and next-20210409).
> Sorry I did not report it earlier.

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

Hi all,

When building Linus' tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/spi/spi.h:671: warning: Function parameter or member 'devm_allocated' not described in 'spi_controller'

Introduced by commit

  794aaf01444d ("spi: Fix use-after-free with devm_spi_alloc_*")

This has been around for a while (at least v5.13-rc1 and next-20210409).
Sorry I did not report it earlier.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning from Linus' tree

[Stephen Rothwell]

Hi all,

With just Linus' tree, today's linux-next build (powerpc ppc64_defconfig)
produced this warning:

fs/dax.c: In function 'dax_iomap_fault':
fs/dax.c:1462:35: warning: passing argument 2 of 'dax_iomap_pmd_fault' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   return dax_iomap_pmd_fault(vmf, ops);
                                   ^
fs/dax.c:1439:12: note: expected 'struct iomap_ops *' but argument is of type 'const struct iomap_ops *'
 static int dax_iomap_pmd_fault(struct vm_fault *vmf, struct iomap_ops *ops)
            ^

Introduced by commit

  a2d581675d48 ("mm,fs,dax: change ->pmd_fault to ->huge_fault")

which missed fixing up the !CONFIG_FS_DAX_PMD case.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning from Linus' tree

[David Sterba]

Hi,

On Fri, Jun 03, 2011 at 11:10:49AM +1000, Stephen Rothwell wrote:
> fs/btrfs/delayed-inode.c: In function 'btrfs_batch_insert_items':
> fs/btrfs/delayed-inode.c:670:6: warning: 'nitems' may be used uninitialized in this function
> 
> Introduced by commit 16cdcec736cd ("btrfs: implement delayed inode items
> operation").  I think this is a real bug.  This variable is not
> initialised, only incremented and tested.

yes, it's a bug and has been already hit (fix pending):

http://marc.info/?l=linux-btrfs&m=130678270307885&w=4

thanks,
david

linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

Hi all,

With Linus' tree, today's linux-next build (x86_64 allmodconfig) produced
this warning:

fs/btrfs/delayed-inode.c: In function 'btrfs_batch_insert_items':
fs/btrfs/delayed-inode.c:670:6: warning: 'nitems' may be used uninitialized in this function

Introduced by commit 16cdcec736cd ("btrfs: implement delayed inode items
operation").  I think this is a real bug.  This variable is not
initialised, only incremented and tested.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

P.S. Chris, time to get a tree into linux-next?

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

With Linus' tree, today's linux-next build (powercp ppc64_defconfig)
produced this warning:

fs/btrfs/delayed-inode.c: In function 'btrfs_delayed_update_inode':
fs/btrfs/delayed-inode.c:1598:6: warning: 'ret' may be used uninitialized in this function

Introduced by commit 16cdcec736cd ("btrfs: implement delayed inode items
operation").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning from Linus' tree

[Jesse Gross]

On Tue, Oct 26, 2010 at 5:29 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> While building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/net/igb/igb_main.c: In function 'igb_xmit_frame_ring_adv':
> drivers/net/igb/igb_main.c:4110: warning: unused variable 'adapter'
>
> Introduced by commit eab6d18d20fc5b5ba04a7e7fcd6f357197870e51 ("vlan:
> Don't check for vlan group before vlan_tx_tag_present").

Patch sent out to resolve this.

linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

While building Linus' tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/net/igb/igb_main.c: In function 'igb_xmit_frame_ring_adv':
drivers/net/igb/igb_main.c:4110: warning: unused variable 'adapter'

Introduced by commit eab6d18d20fc5b5ba04a7e7fcd6f357197870e51 ("vlan:
Don't check for vlan group before vlan_tx_tag_present").

Sorry I didn't catch it earlier.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hi ,

While building Linus' tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/char/pcmcia/synclink_cs.c:2194: warning: 'mgslpc_get_icount' defined but not used

Introduced by commit 0587102cf9f427c185bfdeb2cef41e13ee0264b1 ("tty:
icount changeover for other main devices").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning from Linus' tree

[Frederic Weisbecker]

On Fri, Sep 24, 2010 at 02:08:59PM +1000, Stephen Rothwell wrote:
> Hi Arnd,
> 
> Today's (and lots before) linux-next build (i386 defconfig) produced this
> warning:
> 
> fs/autofs4/root.c:31: warning: 'autofs4_root_compat_ioctl' declared 'static' but never defined
> 
> Introduced by commit c9243f5bdd6637b2bb7dc254b54d9edf957ef17e
> ("autofs/autofs4: Move compat_ioctl handling into fs").


Yeah, I've seen two patches:

autofs: only declare function when CONFIG_COMPAT is defined
autofs4: fix compilation warning

I'm going to relay them. Thanks!

linux-next: build warning from Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi Arnd,

Today's (and lots before) linux-next build (i386 defconfig) produced this
warning:

fs/autofs4/root.c:31: warning: 'autofs4_root_compat_ioctl' declared 'static' but never defined

Introduced by commit c9243f5bdd6637b2bb7dc254b54d9edf957ef17e
("autofs/autofs4: Move compat_ioctl handling into fs").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]