Hi all, After merging the compiler-attributes tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/boot/main.c:153:45: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__section' 153 | static char cmdline[BOOT_COMMAND_LINE_SIZE] __section(__builtin_cmdline); | ^~~~~~~~~ arch/powerpc/boot/main.c: In function 'prep_cmdline': arch/powerpc/boot/main.c:166:6: error: 'cmdline' undeclared (first use in this function) 166 | if (cmdline[0] == '\0') | ^~~~~~~ arch/powerpc/boot/main.c:166:6: note: each undeclared identifier is reported only once for each function it appears in arch/powerpc/boot/main.c: In function 'start': arch/powerpc/boot/main.c:196:40: error: 'cmdline' undeclared (first use in this function) 196 | if ((loader_info.cmdline_len > 0) && (cmdline[0] == '\0')) | ^~~~~~~ Caused by commit e81c903fb9e2 ("powerpc: prefer __section and __printf from compiler_attributes.h") I have reverted that commit for today. gcc v9.2.1 (in case that matters) The above error is from the PowerPC boot wrapper that is built without the kernel headers (mainly, I think). -- Cheers, Stephen Rothwell