Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the battery tree
@ 2019-09-01 23:31 Stephen Rothwell
  2019-09-02  7:10 ` Sebastian Reichel
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2019-09-01 23:31 UTC (permalink / raw)
  To: Sebastian Reichel
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Michael Nosthoff

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

Hi all,

In commit

  b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")

Fixes tag

  Fixes: 76b16f4cdfb8 ("power: supply: sbs-battery: don't assume

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  38fa8b9f75ea ("power: supply: sbs-battery: use correct flags field")

Fixes tag

  Fixes: 76b16f4cdfb8 ("power: supply: sbs-battery: don't assume

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Fixes tag needs some work in the battery tree
  2019-09-01 23:31 linux-next: Fixes tag needs some work in the battery tree Stephen Rothwell
@ 2019-09-02  7:10 ` Sebastian Reichel
  2019-09-02  7:32   ` Michael Nosthoff
  0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Reichel @ 2019-09-02  7:10 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Michael Nosthoff

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi Stephen,

On Mon, Sep 02, 2019 at 09:31:31AM +1000, Stephen Rothwell wrote:
> In commit
> 
> b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")
> 
> [...]
> 
> Please do not split Fixes tags over more than one line.

I have fixed this and rebased the branch, so the issue should be
gone tomororw. Thanks for the notice,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Fixes tag needs some work in  the battery tree
  2019-09-02  7:10 ` Sebastian Reichel
@ 2019-09-02  7:32   ` Michael Nosthoff
  2019-09-02  8:25     ` Sebastian Reichel
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Nosthoff @ 2019-09-02  7:32 UTC (permalink / raw)
  To: Sebastian Reichel
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

Hi Sebastian,

I think you missed that the second commit

38fa8b9f75ea ("power: supply: sbs-battery: use correct flags field")

also needs this fix.


Regards,
Michael

On Monday, September 02, 2019 09:10 CEST, Sebastian Reichel <sre@kernel.org> wrote:

> Hi Stephen,
>
> On Mon, Sep 02, 2019 at 09:31:31AM +1000, Stephen Rothwell wrote:
> > In commit
> >
> > b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")
> >
> > [...]
> >
> > Please do not split Fixes tags over more than one line.
>
> I have fixed this and rebased the branch, so the issue should be
> gone tomororw. Thanks for the notice,
>
> -- Sebastian


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Fixes tag needs some work in the battery tree
  2019-09-02  7:32   ` Michael Nosthoff
@ 2019-09-02  8:25     ` Sebastian Reichel
  0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2019-09-02  8:25 UTC (permalink / raw)
  To: Michael Nosthoff
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

Hi,

On Mon, Sep 02, 2019 at 09:32:47AM +0200, Michael Nosthoff wrote:
> On Monday, September 02, 2019 09:10 CEST, Sebastian Reichel <sre@kernel.org> wrote:
> > On Mon, Sep 02, 2019 at 09:31:31AM +1000, Stephen Rothwell wrote:
> > > In commit
> > >
> > > b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")
> > >
> > > [...]
> > >
> > > Please do not split Fixes tags over more than one line.
> >
> > I have fixed this and rebased the branch, so the issue should be
> > gone tomororw. Thanks for the notice,
>
> I think you missed that the second commit
> 
> 38fa8b9f75ea ("power: supply: sbs-battery: use correct flags field")
> 
> also needs this fix.

Right, now also fixed.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-01 23:31 linux-next: Fixes tag needs some work in the battery tree Stephen Rothwell
2019-09-02  7:10 ` Sebastian Reichel
2019-09-02  7:32   ` Michael Nosthoff
2019-09-02  8:25     ` Sebastian Reichel

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org linux-next@archiver.kernel.org
	public-inbox-index linux-next


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/ public-inbox