linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Thiago Jung Bauermann <bauerman@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Tom Lendacky <thomas.lendacky@amd.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the iommu tree
Date: Mon, 2 Sep 2019 16:03:47 +0200	[thread overview]
Message-ID: <20190902140347.GA23482@8bytes.org> (raw)
In-Reply-To: <20190902163951.6280e030@canb.auug.org.au>

Hi,

tl;dr: And IOMMU commit introduces a new user for sme_active() in
       generic code, and commit

       	284e21fab2cf x86, s390/mm: Move sme_active() and sme_me_mask to x86-specific header

       breaks the build of drivers/iommu/ for all architectures not
       implementing sme_active().

On Mon, Sep 02, 2019 at 04:39:51PM +1000, Stephen Rothwell wrote:
> drivers/iommu/iommu.c: In function 'iommu_subsys_init':
> drivers/iommu/iommu.c:123:38: error: implicit declaration of function 'sme_active'; did you mean 'cpu_active'? [-Werror=implicit-function-declaration]
>   123 |   if (iommu_default_passthrough() && sme_active()) {
>       |                                      ^~~~~~~~~~
>       |                                      cpu_active
> 
> Caused by commit
> 
>   2cc13bb4f59f ("iommu: Disable passthrough mode when SME is active")


Actually it is caused by:

	commit 284e21fab2cfcf90dacce565e0b12f29e5df00c1
	Author: Thiago Jung Bauermann <bauerman@linux.ibm.com>
	Date:   Tue Aug 6 01:49:17 2019 -0300

	    x86, s390/mm: Move sme_active() and sme_me_mask to x86-specific header

which removes the sme_active prototype from the generic headers. The
iommu commit is in next already for a couple of days and didn't cause
problems before.

> sme_active() seems to be only relevant to X86.

It has an implementation on x86 and s390.

> I have reverted that commit for today.

Thanks, but I suggest reverting above commit instead.


Regards,

	Joerg

  reply	other threads:[~2019-09-02 14:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02  6:39 linux-next: build failure after merge of the iommu tree Stephen Rothwell
2019-09-02 14:03 ` Joerg Roedel [this message]
2019-09-02 14:26   ` Lendacky, Thomas
2019-09-03  5:28     ` Stephen Rothwell
2019-09-03 13:20       ` [PATCH] iommu: Don't use sme_active() in generic code Joerg Roedel
2019-09-03 16:03         ` Thiago Jung Bauermann
  -- strict thread matches above, loose matches on Subject: below --
2021-10-12  3:46 linux-next: build failure after merge of the iommu tree Stephen Rothwell
2021-10-12  8:33 ` Marc Zyngier
2021-10-12 11:21   ` Lorenzo Pieralisi
2021-10-13  1:43     ` Bjorn Helgaas
2020-09-21  4:09 Stephen Rothwell
2020-10-13  7:31 ` Stephen Rothwell
2020-10-15  2:43   ` Stephen Rothwell
2015-11-01 11:42 Stephen Rothwell
2015-11-01 15:14 ` Joerg Roedel
2015-11-02  0:15   ` Magnus Damm
2014-11-05  2:47 Stephen Rothwell
2014-11-05 11:16 ` Joerg Roedel
2014-07-08  4:02 Stephen Rothwell
2014-07-08  4:12 ` Alex Williamson
2014-07-08 11:20 ` Joerg Roedel
2011-12-15  4:40 Stephen Rothwell
2011-12-15 10:09 ` Joerg Roedel
2011-08-29  3:32 Stephen Rothwell
2011-08-29  5:11 ` Ohad Ben-Cohen
2011-08-29 10:42   ` Joerg Roedel
2011-08-29  8:36 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190902140347.GA23482@8bytes.org \
    --to=joro@8bytes.org \
    --cc=bauerman@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=sfr@canb.auug.org.au \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).