Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: manual merge of the usb tree with the pm tree
@ 2019-09-04 10:09 Stephen Rothwell
  2019-09-06 13:43 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2019-09-04 10:09 UTC (permalink / raw)
  To: Greg KH, Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Heikki Krogerus, Saranya Gopal, Balaji Manoharan

[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]

Hi all,

Today's linux-next merge of the usb tree got a conflict in:

  drivers/usb/roles/intel-xhci-usb-role-switch.c

between commit:

  d2a90ebb6553 ("usb: roles: intel_xhci: Supplying software node for the role mux")

from the pm tree and commit:

  2be1fb64dfeb ("usb: roles: intel: Enable static DRD mode for role switch")

from the usb tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/usb/roles/intel-xhci-usb-role-switch.c
index 7325a84dd1c8,88d041601c51..000000000000
--- a/drivers/usb/roles/intel-xhci-usb-role-switch.c
+++ b/drivers/usb/roles/intel-xhci-usb-role-switch.c
@@@ -37,12 -44,9 +44,13 @@@
  struct intel_xhci_usb_data {
  	struct usb_role_switch *role_sw;
  	void __iomem *base;
+ 	bool enable_sw_switch;
  };
  
 +static const struct software_node intel_xhci_usb_node = {
 +	"intel-xhci-usb-sw",
 +};
 +
  static int intel_xhci_usb_set_role(struct device *dev, enum usb_role role)
  {
  	struct intel_xhci_usb_data *data = dev_get_drvdata(dev);
@@@ -147,20 -167,12 +167,22 @@@ static int intel_xhci_usb_probe(struct 
  
  	platform_set_drvdata(pdev, data);
  
+ 	data->enable_sw_switch = !device_property_read_bool(dev,
+ 						"sw_switch_disable");
 +	ret = software_node_register(&intel_xhci_usb_node);
 +	if (ret)
 +		return ret;
 +
 +	sw_desc.set = intel_xhci_usb_set_role,
 +	sw_desc.get = intel_xhci_usb_get_role,
 +	sw_desc.allow_userspace_control = true,
 +	sw_desc.fwnode = software_node_fwnode(&intel_xhci_usb_node);
  
  	data->role_sw = usb_role_switch_register(dev, &sw_desc);
 -	if (IS_ERR(data->role_sw))
 +	if (IS_ERR(data->role_sw)) {
 +		fwnode_handle_put(sw_desc.fwnode);
  		return PTR_ERR(data->role_sw);
 +	}
  
  	pm_runtime_set_active(dev);
  	pm_runtime_enable(dev);

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: manual merge of the usb tree with the pm tree
  2019-09-04 10:09 linux-next: manual merge of the usb tree with the pm tree Stephen Rothwell
@ 2019-09-06 13:43 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-09-06 13:43 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Rafael J. Wysocki, Linux Next Mailing List,
	Linux Kernel Mailing List, Heikki Krogerus, Saranya Gopal,
	Balaji Manoharan

On Wed, Sep 04, 2019 at 08:09:29PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next merge of the usb tree got a conflict in:
> 
>   drivers/usb/roles/intel-xhci-usb-role-switch.c
> 
> between commit:
> 
>   d2a90ebb6553 ("usb: roles: intel_xhci: Supplying software node for the role mux")
> 
> from the pm tree and commit:
> 
>   2be1fb64dfeb ("usb: roles: intel: Enable static DRD mode for role switch")
> 
> from the usb tree.

Ick, sorry about that, merge looks good to me, thanks!

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 10:09 linux-next: manual merge of the usb tree with the pm tree Stephen Rothwell
2019-09-06 13:43 ` Greg KH

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org linux-next@archiver.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/ public-inbox