Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-09-10 14:37 Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-09-10 14:37 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Quentin Monnet, Alexei Starovoitov

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Hi all,

In commit

  ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()")

Fixes tag

  Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types")

has these problem(s):

  - missing space between the SHA1 and the subject

Presumably:

Fixes: c93cc69004df ("bpftool: add ability to dump BTF types")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-08-01 22:54 Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-08-01 22:54 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jon Maloy

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi all,

In commit

  7c5b42055964 ("tipc: reduce risk of wakeup queue starvation")

Fixes tag

  Fixes: 365ad35 ("tipc: reduce risk of user starvation during link congestion")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-07-29 21:25 Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-07-29 21:25 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Oliver Hartkopp

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi all,

In commit

  473d924d7d46 ("can: fix ioctl function removal")

Fixes tag

  Fixes: 60649d4e0af ("can: remove obsolete empty ioctl() handler")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
       [not found] ` <CANP3RGcqGrPnt9eOiAKRbxWVuBkRHRQdWPnANKwrYvtVnTqaSQ@mail.gmail.com>
@ 2019-07-23  0:49   ` Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-07-23  0:49 UTC (permalink / raw)
  To: Maciej Żenczykowski
  Cc: David S. Miller, Linux NetDev, Linux Next Mailing List,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi Maciej,

On Tue, 23 Jul 2019 09:46:29 +0900 Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
>
> I'm afraid I'm currently travelling and due to an unplanned and f'ed up
> office move I've lost (access to?) my dev workstation so I can't respin
> this.  Might be too late either way?

Yeah, Dave doesn't rebase his trees, so just take this as a lesson for
next time. :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-07-22 21:35 Stephen Rothwell
       [not found] ` <CANP3RGcqGrPnt9eOiAKRbxWVuBkRHRQdWPnANKwrYvtVnTqaSQ@mail.gmail.com>
  0 siblings, 1 reply; 31+ messages in thread
From: Stephen Rothwell @ 2019-07-22 21:35 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Maciej Żenczykowski

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi all,

In commit

  66b5f1c43984 ("net-ipv6-ndisc: add support for RFC7710 RA Captive Portal Identifier")

Fixes tag

  Fixes: e35f30c131a56

has these problem(s):

  - missing subject

Did you mean

Fixes: e35f30c131a5 ("Treat ND option 31 as userland (DNSSL support)")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-07-03 21:42 Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-07-03 21:42 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Mahesh Bandewar

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

In commit

  d62962b37ceb ("loopback: fix lockdep splat")

Fixes tag

  Fixes: 4de83b88c66 ("loopback: create blackhole net device similar to loopack.")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-06-30 21:37 Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-06-30 21:37 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Yonglong Liu,
	Peng Li, Huazhong Tan

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi all,

In commit

  18d219b783da ("net: hns3: fix a -Wformat-nonliteral compile warning")

Fixes tag

  Fixes: 46a3df9f9718 ("Add HNS3 Acceleration Engine & Compatibility Layer Support")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-04-22 21:26 Stephen Rothwell
@ 2019-04-23 12:19 ` John Hurley
  0 siblings, 0 replies; 31+ messages in thread
From: John Hurley @ 2019-04-23 12:19 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List

On Mon, Apr 22, 2019 at 10:26 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   7d26c96052cd ("nfp: flower: fix size_t compile warning")
>
> Fixes tag
>
>   Fixes: a6156a6ab0f9 ("nfp: flower: handle merge hint messages")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: dbc2d68edc98 ("nfp: flower: handle merge hint messages")
>

Hi Stephen,
Yes, the fixes SHA1 tag you have is correct.
I have no idea how the incorrect one went in!
Thanks,
John

> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-04-22 21:26 Stephen Rothwell
  2019-04-23 12:19 ` John Hurley
  0 siblings, 1 reply; 31+ messages in thread
From: Stephen Rothwell @ 2019-04-22 21:26 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, John Hurley

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Hi all,

In commit

  7d26c96052cd ("nfp: flower: fix size_t compile warning")

Fixes tag

  Fixes: a6156a6ab0f9 ("nfp: flower: handle merge hint messages")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: dbc2d68edc98 ("nfp: flower: handle merge hint messages")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-04-05  5:58 Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-04-05  5:58 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Hoang Le

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

In commit

  e1279ff7aec1 ("tipc: add NULL pointer check")

Fixes tag

  Fixes: c55c8edafa9 ("tipc: smooth change between replicast and broadcast")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-03-21 18:54 Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-03-21 18:54 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Hoang Le

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Hi all,

In commits

  08e046c8966a ("tipc: fix a null pointer deref")
  77d5ad4048fb ("tipc: fix use-after-free in tipc_sk_filter_rcv")

Fixes tag

  Fixes: c55c8eda ("tipc: smooth change between replicast and broadcast")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-27  2:23   ` Stephen Rothwell
@ 2019-02-27  3:16     ` tanhuazhong
  0 siblings, 0 replies; 31+ messages in thread
From: tanhuazhong @ 2019-02-27  3:16 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Jian Shen, Peng Li



On 2019/2/27 10:23, Stephen Rothwell wrote:
> Hi,
> 
> On Wed, 27 Feb 2019 09:12:57 +0800 tanhuazhong <tanhuazhong@huawei.com> wrote:
>>
>> It is my mistake, so sorry about this. There is a redundant "net: hns3:
>> " in the fixes tag.
>>
>> How could I fix it?
> 
> Since Dave doesn't rebase his tree, there is no way to fix it (and it
> is not that important any in this case), just use this as a learning
> experience for next time :-)
> 

Thanks :)

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-27  1:12 ` tanhuazhong
@ 2019-02-27  2:23   ` Stephen Rothwell
  2019-02-27  3:16     ` tanhuazhong
  0 siblings, 1 reply; 31+ messages in thread
From: Stephen Rothwell @ 2019-02-27  2:23 UTC (permalink / raw)
  To: tanhuazhong
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Jian Shen, Peng Li

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hi,

On Wed, 27 Feb 2019 09:12:57 +0800 tanhuazhong <tanhuazhong@huawei.com> wrote:
>
> It is my mistake, so sorry about this. There is a redundant "net: hns3: 
> " in the fixes tag.
> 
> How could I fix it?

Since Dave doesn't rebase his tree, there is no way to fix it (and it
is not that important any in this case), just use this as a learning
experience for next time :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-25  8:00 Stephen Rothwell
@ 2019-02-27  1:12 ` tanhuazhong
  2019-02-27  2:23   ` Stephen Rothwell
  0 siblings, 1 reply; 31+ messages in thread
From: tanhuazhong @ 2019-02-27  1:12 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jian Shen, Peng Li

Hi Stephen & David,

It is my mistake, so sorry about this. There is a redundant "net: hns3: 
" in the fixes tag.

How could I fix it?

Thanks.

On 2019/2/25 16:00, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    a638b1d8cc87 ("net: hns3: fix get VF RSS issue")
> 
> Fixes tag
> 
>    Fixes: 374ad291762a ("net: hns3: net: hns3: Add RSS general configuration support for VF")
> 
> has these problem(s):
> 
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h (%s)'
> 

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-02-25  8:00 Stephen Rothwell
  2019-02-27  1:12 ` tanhuazhong
  0 siblings, 1 reply; 31+ messages in thread
From: Stephen Rothwell @ 2019-02-25  8:00 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jian Shen,
	Peng Li, Huazhong Tan

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi all,

In commit

  a638b1d8cc87 ("net: hns3: fix get VF RSS issue")

Fixes tag

  Fixes: 374ad291762a ("net: hns3: net: hns3: Add RSS general configuration support for VF")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h (%s)'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20 19:59         ` Stefano Brivio
  2019-02-20 20:25           ` David Miller
@ 2019-02-21  5:34           ` Vinod Koul
  1 sibling, 0 replies; 31+ messages in thread
From: Vinod Koul @ 2019-02-21  5:34 UTC (permalink / raw)
  To: Stefano Brivio
  Cc: David Miller, jiri, sfr, netdev, linux-next, linux-kernel, andrew

On 20-02-19, 20:59, Stefano Brivio wrote:
> On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> David Miller <davem@davemloft.net> wrote:
> 
> > From: Jiri Pirko <jiri@resnulli.us>
> > Date: Wed, 20 Feb 2019 09:36:11 +0100
> > 
> > > Would be good to have some robot checking "Fixes" sanity...  
> > 
> > I want to add a script to my trees that locally do it for me but the
> > backlog for patch review for me is so huge that I never get to "fun"
> > tasks like that....
> 
> If it helps, this is what I use after being bitten once:
> 
> #!/bin/sh
> 
> [ ${#} -ne 2 ] && echo "Usage: %0 PATCH_FILE GIT_TREE" && exit 1
> grep "^Fixes: " "${1}" | while read -r f; do
> 	sha="$(echo "${f}" | cut -d' ' -f2)"
> 	if [ -z "${sha}" ] || [ "${f}" != "$(git -C "${2}" show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
> 		echo "Bad tag: ${f}" && exit 1
> 	fi
> done

Awesome thanks, I am adding this into my patch commit script and well as
send script

-- 
~Vinod

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20 20:37             ` Stefano Brivio
@ 2019-02-20 20:42               ` David Miller
  0 siblings, 0 replies; 31+ messages in thread
From: David Miller @ 2019-02-20 20:42 UTC (permalink / raw)
  To: sbrivio; +Cc: jiri, vkoul, sfr, netdev, linux-next, linux-kernel, andrew

From: Stefano Brivio <sbrivio@redhat.com>
Date: Wed, 20 Feb 2019 21:37:29 +0100

> On Wed, 20 Feb 2019 12:25:48 -0800 (PST)
> David Miller <davem@davemloft.net> wrote:
> 
>> From: Stefano Brivio <sbrivio@redhat.com>
>> Date: Wed, 20 Feb 2019 20:59:10 +0100
>> 
>> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
>> > David Miller <davem@davemloft.net> wrote:
>> >   
>> >> From: Jiri Pirko <jiri@resnulli.us>
>> >> Date: Wed, 20 Feb 2019 09:36:11 +0100
>> >>   
>> >> > Would be good to have some robot checking "Fixes" sanity...    
>> >> 
>> >> I want to add a script to my trees that locally do it for me but the
>> >> backlog for patch review for me is so huge that I never get to "fun"
>> >> tasks like that....  
>> > 
>> > If it helps, this is what I use after being bitten once:  
>> 
>> Awesome, thanks!  You put this in as a pre-commit script?
> 
> Nope, I use it before sending patches out with git send-email.
> 
> But you can use this as .git/hooks/commit-msg, just skip taking the
> tree as second argument, something like this (just quickly tested):

Awesome, thank you!

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20 20:25           ` David Miller
@ 2019-02-20 20:37             ` Stefano Brivio
  2019-02-20 20:42               ` David Miller
  0 siblings, 1 reply; 31+ messages in thread
From: Stefano Brivio @ 2019-02-20 20:37 UTC (permalink / raw)
  To: David Miller; +Cc: jiri, vkoul, sfr, netdev, linux-next, linux-kernel, andrew

On Wed, 20 Feb 2019 12:25:48 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Stefano Brivio <sbrivio@redhat.com>
> Date: Wed, 20 Feb 2019 20:59:10 +0100
> 
> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> > David Miller <davem@davemloft.net> wrote:
> >   
> >> From: Jiri Pirko <jiri@resnulli.us>
> >> Date: Wed, 20 Feb 2019 09:36:11 +0100
> >>   
> >> > Would be good to have some robot checking "Fixes" sanity...    
> >> 
> >> I want to add a script to my trees that locally do it for me but the
> >> backlog for patch review for me is so huge that I never get to "fun"
> >> tasks like that....  
> > 
> > If it helps, this is what I use after being bitten once:  
> 
> Awesome, thanks!  You put this in as a pre-commit script?

Nope, I use it before sending patches out with git send-email.

But you can use this as .git/hooks/commit-msg, just skip taking the
tree as second argument, something like this (just quickly tested):

#!/bin/sh

grep "^Fixes: " "${1}" | while read -r f; do
	sha="$(echo "${f}" | cut -d' ' -f2)"
	if [ -z "${sha}" ] || [ "${f}" != "$(git show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
		echo "Bad tag: ${f}" && exit 1
	fi
done

-- 
Stefano

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20 20:25           ` David Miller
@ 2019-02-20 20:26             ` Jiri Pirko
  0 siblings, 0 replies; 31+ messages in thread
From: Jiri Pirko @ 2019-02-20 20:26 UTC (permalink / raw)
  To: David Miller; +Cc: vkoul, sfr, netdev, linux-next, linux-kernel, andrew

Wed, Feb 20, 2019 at 09:25:22PM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Wed, 20 Feb 2019 20:58:11 +0100
>
>> Wed, Feb 20, 2019 at 08:02:01PM CET, davem@davemloft.net wrote:
>>>From: Jiri Pirko <jiri@resnulli.us>
>>>Date: Wed, 20 Feb 2019 09:36:11 +0100
>>>
>>>> Would be good to have some robot checking "Fixes" sanity...
>>>
>>>I want to add a script to my trees that locally do it for me but the
>> 
>> When it is in tree, it's already late. The robot has to check
>> emails/patchwork.
>
>It's for me, on my computer, to abort things when I try to commit
>with a bad fixes tag or missing signoff.

Okay, but still, robot checking emails/patchwork would safe you some
overhead.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20 19:59         ` Stefano Brivio
@ 2019-02-20 20:25           ` David Miller
  2019-02-20 20:37             ` Stefano Brivio
  2019-02-21  5:34           ` Vinod Koul
  1 sibling, 1 reply; 31+ messages in thread
From: David Miller @ 2019-02-20 20:25 UTC (permalink / raw)
  To: sbrivio; +Cc: jiri, vkoul, sfr, netdev, linux-next, linux-kernel, andrew

From: Stefano Brivio <sbrivio@redhat.com>
Date: Wed, 20 Feb 2019 20:59:10 +0100

> On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> David Miller <davem@davemloft.net> wrote:
> 
>> From: Jiri Pirko <jiri@resnulli.us>
>> Date: Wed, 20 Feb 2019 09:36:11 +0100
>> 
>> > Would be good to have some robot checking "Fixes" sanity...  
>> 
>> I want to add a script to my trees that locally do it for me but the
>> backlog for patch review for me is so huge that I never get to "fun"
>> tasks like that....
> 
> If it helps, this is what I use after being bitten once:

Awesome, thanks!  You put this in as a pre-commit script?

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20 19:58         ` Jiri Pirko
@ 2019-02-20 20:25           ` David Miller
  2019-02-20 20:26             ` Jiri Pirko
  0 siblings, 1 reply; 31+ messages in thread
From: David Miller @ 2019-02-20 20:25 UTC (permalink / raw)
  To: jiri; +Cc: vkoul, sfr, netdev, linux-next, linux-kernel, andrew

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 20 Feb 2019 20:58:11 +0100

> Wed, Feb 20, 2019 at 08:02:01PM CET, davem@davemloft.net wrote:
>>From: Jiri Pirko <jiri@resnulli.us>
>>Date: Wed, 20 Feb 2019 09:36:11 +0100
>>
>>> Would be good to have some robot checking "Fixes" sanity...
>>
>>I want to add a script to my trees that locally do it for me but the
> 
> When it is in tree, it's already late. The robot has to check
> emails/patchwork.

It's for me, on my computer, to abort things when I try to commit
with a bad fixes tag or missing signoff.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20 19:02       ` David Miller
  2019-02-20 19:58         ` Jiri Pirko
@ 2019-02-20 19:59         ` Stefano Brivio
  2019-02-20 20:25           ` David Miller
  2019-02-21  5:34           ` Vinod Koul
  1 sibling, 2 replies; 31+ messages in thread
From: Stefano Brivio @ 2019-02-20 19:59 UTC (permalink / raw)
  To: David Miller; +Cc: jiri, vkoul, sfr, netdev, linux-next, linux-kernel, andrew

On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Jiri Pirko <jiri@resnulli.us>
> Date: Wed, 20 Feb 2019 09:36:11 +0100
> 
> > Would be good to have some robot checking "Fixes" sanity...  
> 
> I want to add a script to my trees that locally do it for me but the
> backlog for patch review for me is so huge that I never get to "fun"
> tasks like that....

If it helps, this is what I use after being bitten once:

#!/bin/sh

[ ${#} -ne 2 ] && echo "Usage: %0 PATCH_FILE GIT_TREE" && exit 1
grep "^Fixes: " "${1}" | while read -r f; do
	sha="$(echo "${f}" | cut -d' ' -f2)"
	if [ -z "${sha}" ] || [ "${f}" != "$(git -C "${2}" show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
		echo "Bad tag: ${f}" && exit 1
	fi
done

-- 
Stefano

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20 19:02       ` David Miller
@ 2019-02-20 19:58         ` Jiri Pirko
  2019-02-20 20:25           ` David Miller
  2019-02-20 19:59         ` Stefano Brivio
  1 sibling, 1 reply; 31+ messages in thread
From: Jiri Pirko @ 2019-02-20 19:58 UTC (permalink / raw)
  To: David Miller; +Cc: vkoul, sfr, netdev, linux-next, linux-kernel, andrew

Wed, Feb 20, 2019 at 08:02:01PM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Wed, 20 Feb 2019 09:36:11 +0100
>
>> Would be good to have some robot checking "Fixes" sanity...
>
>I want to add a script to my trees that locally do it for me but the

When it is in tree, it's already late. The robot has to check
emails/patchwork.


>backlog for patch review for me is so huge that I never get to "fun"
>tasks like that....
>
>This has been discussed before too.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20  8:36     ` Jiri Pirko
@ 2019-02-20 19:02       ` David Miller
  2019-02-20 19:58         ` Jiri Pirko
  2019-02-20 19:59         ` Stefano Brivio
  0 siblings, 2 replies; 31+ messages in thread
From: David Miller @ 2019-02-20 19:02 UTC (permalink / raw)
  To: jiri; +Cc: vkoul, sfr, netdev, linux-next, linux-kernel, andrew

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 20 Feb 2019 09:36:11 +0100

> Would be good to have some robot checking "Fixes" sanity...

I want to add a script to my trees that locally do it for me but the
backlog for patch review for me is so huge that I never get to "fun"
tasks like that....

This has been discussed before too.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20  6:48   ` David Miller
@ 2019-02-20  8:36     ` Jiri Pirko
  2019-02-20 19:02       ` David Miller
  0 siblings, 1 reply; 31+ messages in thread
From: Jiri Pirko @ 2019-02-20  8:36 UTC (permalink / raw)
  To: David Miller; +Cc: vkoul, sfr, netdev, linux-next, linux-kernel, andrew

Wed, Feb 20, 2019 at 07:48:13AM CET, davem@davemloft.net wrote:
>From: Vinod Koul <vkoul@kernel.org>
>Date: Wed, 20 Feb 2019 10:10:55 +0530
>
>> On 20-02-19, 09:31, Stephen Rothwell wrote:
>>> Hi all,
>>> 
>>> In commit
>>> 
>>>   a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>>> 
>>> Fixes tag
>>> 
>>>   Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>>> 
>>> has these problem(s):
>>> 
>>>   - Target SHA1 does not exist
>>> 
>>> Did you mean:
>>> 
>>>   Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
>> 
>> Yes looks like I messed up the commit id.. Not sure why :(
>> 
>> Dave would you like to drop this and me sending updated patch or
>> something else..
>> 
>> Sorry about the miss
>
>Doesn't work that way, something in my tree is there forever.

Would be good to have some robot checking "Fixes" sanity...

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20  4:40 ` Vinod Koul
  2019-02-20  5:38   ` Stephen Rothwell
@ 2019-02-20  6:48   ` David Miller
  2019-02-20  8:36     ` Jiri Pirko
  1 sibling, 1 reply; 31+ messages in thread
From: David Miller @ 2019-02-20  6:48 UTC (permalink / raw)
  To: vkoul; +Cc: sfr, netdev, linux-next, linux-kernel, andrew

From: Vinod Koul <vkoul@kernel.org>
Date: Wed, 20 Feb 2019 10:10:55 +0530

> On 20-02-19, 09:31, Stephen Rothwell wrote:
>> Hi all,
>> 
>> In commit
>> 
>>   a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>> 
>> Fixes tag
>> 
>>   Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>> 
>> has these problem(s):
>> 
>>   - Target SHA1 does not exist
>> 
>> Did you mean:
>> 
>>   Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
> 
> Yes looks like I messed up the commit id.. Not sure why :(
> 
> Dave would you like to drop this and me sending updated patch or
> something else..
> 
> Sorry about the miss

Doesn't work that way, something in my tree is there forever.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-20  4:40 ` Vinod Koul
@ 2019-02-20  5:38   ` Stephen Rothwell
  2019-02-20  6:48   ` David Miller
  1 sibling, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-02-20  5:38 UTC (permalink / raw)
  To: Vinod Koul
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Andrew Lunn

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

Hi Vinod,

On Wed, 20 Feb 2019 10:10:55 +0530 Vinod Koul <vkoul@kernel.org> wrote:
>
> Dave would you like to drop this and me sending updated patch or
> something else..

Dave doesn't rebase/reset net-next, so we will just have to use this as
a learning experience :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net-next tree
  2019-02-19 22:31 Stephen Rothwell
@ 2019-02-20  4:40 ` Vinod Koul
  2019-02-20  5:38   ` Stephen Rothwell
  2019-02-20  6:48   ` David Miller
  0 siblings, 2 replies; 31+ messages in thread
From: Vinod Koul @ 2019-02-20  4:40 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Andrew Lunn

On 20-02-19, 09:31, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
> 
> Fixes tag
> 
>   Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean:
> 
>   Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")

Yes looks like I messed up the commit id.. Not sure why :(

Dave would you like to drop this and me sending updated patch or
something else..

Sorry about the miss

-- 
~Vinod

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-02-19 22:31 Stephen Rothwell
  2019-02-20  4:40 ` Vinod Koul
  0 siblings, 1 reply; 31+ messages in thread
From: Stephen Rothwell @ 2019-02-19 22:31 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Vinod Koul,
	Andrew Lunn

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi all,

In commit

  a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")

Fixes tag

  Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")

has these problem(s):

  - Target SHA1 does not exist

Did you mean:

  Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-02-11 22:17 Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-02-11 22:17 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Tristram Ha

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi all,

In commit

  cbd72b485214 ("net: dsa: microchip: add switch offload forwarding support")

Fixes tag

  Fixes: c2e866911e254067 ("microchip: break KSZ9477 DSA driver into two files")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

* linux-next: Fixes tag needs some work in the net-next tree
@ 2019-01-31 20:35 Stephen Rothwell
  0 siblings, 0 replies; 31+ messages in thread
From: Stephen Rothwell @ 2019-01-31 20:35 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Huazhong Tan,
	Peng Li

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi all,

In commit

  9fc55413270f ("net: hns3: fix improper error handling in the hclge_init_ae_dev()")

Fixes tag

  Fixes: 288475b2ad01 ("{topost} net: hns3: refine umv space allocation")

has these problem(s):

  - Target SHA1 does not exist

I can't even find it by simple searches for the subject ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 31+ messages in thread

end of thread, back to index

Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 14:37 linux-next: Fixes tag needs some work in the net-next tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2019-08-01 22:54 Stephen Rothwell
2019-07-29 21:25 Stephen Rothwell
2019-07-22 21:35 Stephen Rothwell
     [not found] ` <CANP3RGcqGrPnt9eOiAKRbxWVuBkRHRQdWPnANKwrYvtVnTqaSQ@mail.gmail.com>
2019-07-23  0:49   ` Stephen Rothwell
2019-07-03 21:42 Stephen Rothwell
2019-06-30 21:37 Stephen Rothwell
2019-04-22 21:26 Stephen Rothwell
2019-04-23 12:19 ` John Hurley
2019-04-05  5:58 Stephen Rothwell
2019-03-21 18:54 Stephen Rothwell
2019-02-25  8:00 Stephen Rothwell
2019-02-27  1:12 ` tanhuazhong
2019-02-27  2:23   ` Stephen Rothwell
2019-02-27  3:16     ` tanhuazhong
2019-02-19 22:31 Stephen Rothwell
2019-02-20  4:40 ` Vinod Koul
2019-02-20  5:38   ` Stephen Rothwell
2019-02-20  6:48   ` David Miller
2019-02-20  8:36     ` Jiri Pirko
2019-02-20 19:02       ` David Miller
2019-02-20 19:58         ` Jiri Pirko
2019-02-20 20:25           ` David Miller
2019-02-20 20:26             ` Jiri Pirko
2019-02-20 19:59         ` Stefano Brivio
2019-02-20 20:25           ` David Miller
2019-02-20 20:37             ` Stefano Brivio
2019-02-20 20:42               ` David Miller
2019-02-21  5:34           ` Vinod Koul
2019-02-11 22:17 Stephen Rothwell
2019-01-31 20:35 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org linux-next@archiver.kernel.org
	public-inbox-index linux-next


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/ public-inbox