Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2019-09-10 14:42 Stephen Rothwell
  2019-09-11  5:24 ` Luciano Coelho
  0 siblings, 1 reply; 36+ messages in thread
From: Stephen Rothwell @ 2019-09-10 14:42 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Luca Coelho,
	Alex Malamud

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

Hi all,

Commit

  aa43ae121675 ("iwlwifi: LTR updates")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2019-09-10 14:42 linux-next: Signed-off-by missing for commit in the net-next tree Stephen Rothwell
@ 2019-09-11  5:24 ` Luciano Coelho
  0 siblings, 0 replies; 36+ messages in thread
From: Luciano Coelho @ 2019-09-11  5:24 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Alex Malamud

On Wed, 2019-09-11 at 00:42 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   aa43ae121675 ("iwlwifi: LTR updates")
> 
> is missing a Signed-off-by from its committer.

Oops, that was my fault.  What can we do about it? Is it enough if I
give my s-o-b publicly here?

I hereby sign off this change:

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>


--
Cheers,
Luca.


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2019-10-31 17:40 ` David Miller
@ 2019-10-31 18:40   ` Jeff Kirsher
  0 siblings, 0 replies; 36+ messages in thread
From: Jeff Kirsher @ 2019-10-31 18:40 UTC (permalink / raw)
  To: David Miller, sfr; +Cc: netdev, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Thu, 2019-10-31 at 10:40 -0700, David Miller wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 31 Oct 2019 18:10:44 +1100
> 
> > Commit
> > 
> >    a7023819404a ("e1000e: Use rtnl_lock to prevent race conditions
> > between net and pci/pm")
> > 
> > is missing a Signed-off-by from its committer.
> 
> Ok Jeff, that's two pull requests I've taken from you this week where
> there were incorrect SHA1 IDs in Fixes tags or missing signoffs.
> 
> Please use some scripts or other forms of automation to keep this
> from
> happening in the future.

Not sure what is going on to remove my SOB, since everything is
scripted, but I will look into it and I will add an additional check to
ensure future pull requests are not missing anything.  I apologize for
the missing SOB's.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2019-10-31  7:10 Stephen Rothwell
@ 2019-10-31 17:40 ` David Miller
  2019-10-31 18:40   ` Jeff Kirsher
  0 siblings, 1 reply; 36+ messages in thread
From: David Miller @ 2019-10-31 17:40 UTC (permalink / raw)
  To: sfr; +Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 31 Oct 2019 18:10:44 +1100

> Commit
> 
>   a7023819404a ("e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm")
> 
> is missing a Signed-off-by from its committer.

Ok Jeff, that's two pull requests I've taken from you this week where
there were incorrect SHA1 IDs in Fixes tags or missing signoffs.

Please use some scripts or other forms of automation to keep this from
happening in the future.

Thank you.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2019-10-31  7:10 Stephen Rothwell
  2019-10-31 17:40 ` David Miller
  0 siblings, 1 reply; 36+ messages in thread
From: Stephen Rothwell @ 2019-10-31  7:10 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jeff Kirsher

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Commit

  a7023819404a ("e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2019-10-30  7:42 Stephen Rothwell
  0 siblings, 0 replies; 36+ messages in thread
From: Stephen Rothwell @ 2019-10-30  7:42 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jeff Kirsher,
	Aleksandr Loktionov

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Hi all,

Commit

  621650cabee5 ("i40e: Refactoring VF MAC filters counting to make more reliable")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2019-10-02 22:06 Stephen Rothwell
@ 2019-10-02 22:12 ` Randy Dunlap
  0 siblings, 0 replies; 36+ messages in thread
From: Randy Dunlap @ 2019-10-02 22:12 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, rd.dunlab

On 10/2/19 3:06 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   0f04f8ea62ce ("Minor fixes to the CAIF Transport drivers Kconfig file")
>   21d549769e79 ("Isolate CAIF transport drivers into their own menu")
>   0903102f5785 ("Clean up the net/caif/Kconfig menu")
> 
> are missing a Signed-off-by from their authors.
> 
> I guess <rd.dunlab@gmail.com> and <rdunlap@infradead.org> may be the
> same person?  Please be consistent.

  Yes.          Yes, will do that.

-- 
~Randy

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2019-10-02 22:06 Stephen Rothwell
  2019-10-02 22:12 ` Randy Dunlap
  0 siblings, 1 reply; 36+ messages in thread
From: Stephen Rothwell @ 2019-10-02 22:06 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, rd.dunlab,
	Randy Dunlap

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

Commits

  0f04f8ea62ce ("Minor fixes to the CAIF Transport drivers Kconfig file")
  21d549769e79 ("Isolate CAIF transport drivers into their own menu")
  0903102f5785 ("Clean up the net/caif/Kconfig menu")

are missing a Signed-off-by from their authors.

I guess <rd.dunlab@gmail.com> and <rdunlap@infradead.org> may be the
same person?  Please be consistent.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2019-09-10 14:41 Stephen Rothwell
@ 2019-09-11  9:02 ` Oleksij Rempel
  0 siblings, 0 replies; 36+ messages in thread
From: Oleksij Rempel @ 2019-09-11  9:02 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, The j1939 authors, Bastian Stender,
	Elenita Hinds, Kurt Van Dijck, kbuild test robot, Maxime Jayat,
	Robin van der Gracht, Marc Kleine-Budde

Hi Stephen,

On Wed, Sep 11, 2019 at 12:41:03AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> 
> is missing a Signed-off-by from its author.
> 
> [Not sure if I should complain about this one ...]

Here is the original pull request message for this patch series:
"The final patch is the collective effort of many entities (The j1939
authors: Oliver Hartkopp, Bastian Stender, Elenita Hinds, kbuild test
robot, Kurt Van Dijck, Maxime Jayat, Robin van der Gracht, Oleksij
Rempel, Marc Kleine-Budde). It adds support of SAE J1939 protocol to the
CAN networking stack."
https://www.mail-archive.com/netdev@vger.kernel.org/msg313476.html

Since the patch can be hardly assigned to one author we deiced to use
address of CAN mailing list.

Best regards,
Oleksij Rempel
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2019-09-10 14:41 Stephen Rothwell
  2019-09-11  9:02 ` Oleksij Rempel
  0 siblings, 1 reply; 36+ messages in thread
From: Stephen Rothwell @ 2019-09-10 14:41 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	The j1939 authors, Bastian Stender, Elenita Hinds,
	Kurt Van Dijck, kbuild test robot, Maxime Jayat,
	Robin van der Gracht, Oleksij Rempel, Marc Kleine-Budde

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

Hi all,

Commit

  9d71dd0c7009 ("can: add support of SAE J1939 protocol")

is missing a Signed-off-by from its author.

[Not sure if I should complain about this one ...]

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2019-08-07  1:54   ` Stephen Rothwell
@ 2019-08-07  2:02     ` Yifeng Sun
  0 siblings, 0 replies; 36+ messages in thread
From: Yifeng Sun @ 2019-08-07  2:02 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List

Hi Stephen,

Sure, thanks!
Yifeng

On Tue, Aug 6, 2019 at 6:54 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Yifeng,
>
> On Tue, 6 Aug 2019 16:37:26 -0700 Yifeng Sun <pkusunyifeng@gmail.com> wrote:
> >
> > My apologies, thanks for the email. Please add the signed-off if you can.
>
> Dave does not rebase his trees, so that is not possible.  Just remember
> for next time, thanks :-)
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2019-08-06 23:37 ` Yifeng Sun
@ 2019-08-07  1:54   ` Stephen Rothwell
  2019-08-07  2:02     ` Yifeng Sun
  0 siblings, 1 reply; 36+ messages in thread
From: Stephen Rothwell @ 2019-08-07  1:54 UTC (permalink / raw)
  To: Yifeng Sun
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Hi Yifeng,

On Tue, 6 Aug 2019 16:37:26 -0700 Yifeng Sun <pkusunyifeng@gmail.com> wrote:
>
> My apologies, thanks for the email. Please add the signed-off if you can.

Dave does not rebase his trees, so that is not possible.  Just remember
for next time, thanks :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2019-08-06 23:30 Stephen Rothwell
@ 2019-08-06 23:37 ` Yifeng Sun
  2019-08-07  1:54   ` Stephen Rothwell
  0 siblings, 1 reply; 36+ messages in thread
From: Yifeng Sun @ 2019-08-06 23:37 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List

Hi Stephen,

My apologies, thanks for the email. Please add the signed-off if you can.

Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com>

Thanks,
Yifeng

On Tue, Aug 6, 2019 at 4:30 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commit
>
>   aa733660dbd8 ("openvswitch: Print error when ovs_execute_actions() fails")
>
> is missing a Signed-off-by from its author.
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2019-08-06 23:30 Stephen Rothwell
  2019-08-06 23:37 ` Yifeng Sun
  0 siblings, 1 reply; 36+ messages in thread
From: Stephen Rothwell @ 2019-08-06 23:30 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Yifeng Sun

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

Hi all,

Commit

  aa733660dbd8 ("openvswitch: Print error when ovs_execute_actions() fails")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2019-07-09 21:36 Stephen Rothwell
  0 siblings, 0 replies; 36+ messages in thread
From: Stephen Rothwell @ 2019-07-09 21:36 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Marcelo Ricardo Leitner, Marcelo Ricardo Leitner, Paul Blakey

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

Hi all,

Commit

  6e52fca36c67 ("tc-tests: Add tc action ct tests")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
       [not found] ` <CALqoU4ywdKaeD_DX4pF2hOTh-LQb2N+zGhap6x4sskaf_YthJw@mail.gmail.com>
@ 2019-01-16 23:09   ` David Miller
  0 siblings, 0 replies; 36+ messages in thread
From: David Miller @ 2019-01-16 23:09 UTC (permalink / raw)
  To: ytht.net; +Cc: sfr, netdev, linux-next, linux-kernel, stefanha

From: lepton <ytht.net@gmail.com>
Date: Wed, 16 Jan 2019 14:27:45 -0800

> I sent another version with signed off serveral days ago:
> 
> https://www.spinics.net/lists/netdev/msg543829.html
> 
> So for some reason it got missed?

I didn't see it before I applied the initial patch because I was
heavily backlogged, I saw it afterwards...

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2019-01-16 21:06 Stephen Rothwell
@ 2019-01-16 22:13 ` David Miller
       [not found] ` <CALqoU4ywdKaeD_DX4pF2hOTh-LQb2N+zGhap6x4sskaf_YthJw@mail.gmail.com>
  1 sibling, 0 replies; 36+ messages in thread
From: David Miller @ 2019-01-16 22:13 UTC (permalink / raw)
  To: sfr; +Cc: netdev, linux-next, linux-kernel, ytht.net, stefanha

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 17 Jan 2019 08:06:19 +1100

> Hi all,
> 
> Commit
> 
>   a22d3251423f ("Fix ERROR:do not initialise statics to 0 in af_vsock.c")
> 
> is missing a Signed-off-by from its author.

I know, I caught it right after I pushed out, sorry :(

I really have to go back to working on that automation so this stops
happening.  My bad.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2019-01-16 21:06 Stephen Rothwell
  2019-01-16 22:13 ` David Miller
       [not found] ` <CALqoU4ywdKaeD_DX4pF2hOTh-LQb2N+zGhap6x4sskaf_YthJw@mail.gmail.com>
  0 siblings, 2 replies; 36+ messages in thread
From: Stephen Rothwell @ 2019-01-16 21:06 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Lepton Wu,
	Stefan Hajnoczi

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Hi all,

Commit

  a22d3251423f ("Fix ERROR:do not initialise statics to 0 in af_vsock.c")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2018-10-01 23:34 Stephen Rothwell
  0 siblings, 0 replies; 36+ messages in thread
From: Stephen Rothwell @ 2018-10-01 23:34 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Saeed Mahameed, Gavi Teitz

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

Hi all,

Commit

  f128f138cc40 ("net/mlx5e: Add ethtool control of ring params to VF representors")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2018-09-03  5:08 ` Vakul Garg
  2018-09-03  5:16   ` David Miller
@ 2018-09-03  5:21   ` Stephen Rothwell
  1 sibling, 0 replies; 36+ messages in thread
From: Stephen Rothwell @ 2018-09-03  5:21 UTC (permalink / raw)
  To: Vakul Garg
  Cc: David Miller, Networking, Linux-Next Mailing List,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

Hi Vakul,

On Mon, 3 Sep 2018 05:08:08 +0000 Vakul Garg <vakul.garg@nxp.com> wrote:
>
> > -----Original Message-----
> > Commit
> > 
> >   c2ad647c6442 ("selftests/tls: Add test for recv(PEEK) spanning across
> > multiple records")
> > 
> > is missing a Signed-off-by from its author.
> 
> It is my fault to miss adding signoff.

See section 11 of Documentation/process/submitting-patches.rst.

> I am sorry about that.

It happens ...

> Please advise if I need to do something to fix it.

Dave's tree does not rebase, so nothing can be done about this case.  I
guess you should just remember to add a Signed-off-by line in the
future.  Also, Dave should probably check before publishing to his tree.

That being said, I have not seen many like this in Dave's tree.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2018-09-03  5:08 ` Vakul Garg
@ 2018-09-03  5:16   ` David Miller
  2018-09-03  5:21   ` Stephen Rothwell
  1 sibling, 0 replies; 36+ messages in thread
From: David Miller @ 2018-09-03  5:16 UTC (permalink / raw)
  To: vakul.garg; +Cc: sfr, netdev, linux-next, linux-kernel

From: Vakul Garg <vakul.garg@nxp.com>
Date: Mon, 3 Sep 2018 05:08:08 +0000

> 
>> -----Original Message-----
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Sent: Monday, September 3, 2018 3:11 AM
>> To: David Miller <davem@davemloft.net>; Networking
>> <netdev@vger.kernel.org>
>> Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel
>> Mailing List <linux-kernel@vger.kernel.org>; Vakul Garg
>> <vakul.garg@nxp.com>
>> Subject: linux-next: Signed-off-by missing for commit in the net-next tree
>> 
>> Hi all,
>> 
>> Commit
>> 
>>   c2ad647c6442 ("selftests/tls: Add test for recv(PEEK) spanning across
>> multiple records")
>> 
>> is missing a Signed-off-by from its author.
>> 
> 
> It is my fault to miss adding signoff.
> I am sorry about that.
> Please advise if I need to do something to fix it.

There is nothing you need to do, and since commits in my tree are immutable
once pushed out it cannot be fixed.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* RE: linux-next: Signed-off-by missing for commit in the net-next tree
  2018-09-02 21:40 Stephen Rothwell
@ 2018-09-03  5:08 ` Vakul Garg
  2018-09-03  5:16   ` David Miller
  2018-09-03  5:21   ` Stephen Rothwell
  0 siblings, 2 replies; 36+ messages in thread
From: Vakul Garg @ 2018-09-03  5:08 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List


> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Monday, September 3, 2018 3:11 AM
> To: David Miller <davem@davemloft.net>; Networking
> <netdev@vger.kernel.org>
> Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel
> Mailing List <linux-kernel@vger.kernel.org>; Vakul Garg
> <vakul.garg@nxp.com>
> Subject: linux-next: Signed-off-by missing for commit in the net-next tree
> 
> Hi all,
> 
> Commit
> 
>   c2ad647c6442 ("selftests/tls: Add test for recv(PEEK) spanning across
> multiple records")
> 
> is missing a Signed-off-by from its author.
> 

It is my fault to miss adding signoff.
I am sorry about that.
Please advise if I need to do something to fix it.
 

> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2018-09-02 21:40 Stephen Rothwell
  2018-09-03  5:08 ` Vakul Garg
  0 siblings, 1 reply; 36+ messages in thread
From: Stephen Rothwell @ 2018-09-02 21:40 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Vakul Garg

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

Hi all,

Commit

  c2ad647c6442 ("selftests/tls: Add test for recv(PEEK) spanning across multiple records")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2018-07-28  4:21 Stephen Rothwell
  0 siblings, 0 replies; 36+ messages in thread
From: Stephen Rothwell @ 2018-07-28  4:21 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Dave Taht

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Hi all,
Commit

  2db6dc2662ba ("sch_cake: Make gso-splitting configurable from userspace")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2018-05-13 22:02 Stephen Rothwell
  0 siblings, 0 replies; 36+ messages in thread
From: Stephen Rothwell @ 2018-05-13 22:02 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Russell King,
	Florian Fainelli

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

Hi all,

Commit

  9cd00a8aa42e ("net: phy: phylink: Poll link GPIOs")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2017-11-12 20:44 Stephen Rothwell
  0 siblings, 0 replies; 36+ messages in thread
From: Stephen Rothwell @ 2017-11-12 20:44 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Robert Stonehouse, Bert Kenward

Hi all,

Commit

  cbad52e92ad7 ("sfc: don't warn on successful change of MAC")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2017-11-01 10:55   ` Francois Romieu
@ 2017-11-01 12:15     ` Kirill Smelkov
  0 siblings, 0 replies; 36+ messages in thread
From: Kirill Smelkov @ 2017-11-01 12:15 UTC (permalink / raw)
  To: Francois Romieu
  Cc: Stephen Rothwell, David Miller, Networking,
	Linux-Next Mailing List, Linux Kernel Mailing List, Eric Dumazet

Francois,

On Wed, Nov 01, 2017 at 11:55:24AM +0100, Francois Romieu wrote:
> Kirill Smelkov <kirr@nexedi.com> :
> [...]
> > I was keeping you in To and Cc all the time but got no reply at all since my
> > first posting from ~ 1 month ago.
> 
> I thought it was longer than that. Sorry for the frustrating excess delay.
> 
> As Eric already said there is no problem and I am perfectly fine with
> the current attribution of this code.

Thanks for feedback.

> Use of errno.h::ELNRNG is really unusual but it's a different topic.

I wanted the error returned due to internal inconsistency to be different
from the error returned when there is error in provided parameters from
ethtool.

Your original patch was returning EINVAL for both cases which made it
hard to understand what is going on when the kernel was refusing to
accept something from user.

That's why I used ELNRNG (link number out of range) for situation when
lookup of timings vector by current link speed failed. A bit unusual,
yes, but this was the closest to the situation after studying `errno -l`
output.

Hope this clarifies a bit.

Please feel free to suggest a change here,
Kirill

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2017-10-31  6:14 ` Kirill Smelkov
  2017-10-31  6:20   ` Eric Dumazet
@ 2017-11-01 10:55   ` Francois Romieu
  2017-11-01 12:15     ` Kirill Smelkov
  1 sibling, 1 reply; 36+ messages in thread
From: Francois Romieu @ 2017-11-01 10:55 UTC (permalink / raw)
  To: Kirill Smelkov
  Cc: Stephen Rothwell, David Miller, Networking,
	Linux-Next Mailing List, Linux Kernel Mailing List, Eric Dumazet

Kirill Smelkov <kirr@nexedi.com> :
[...]
> I was keeping you in To and Cc all the time but got no reply at all since my
> first posting from ~ 1 month ago.

I thought it was longer than that. Sorry for the frustrating excess delay.

As Eric already said there is no problem and I am perfectly fine with
the current attribution of this code.

Use of errno.h::ELNRNG is really unusual but it's a different topic.

-- 
Ueimor

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2017-10-31  6:14 ` Kirill Smelkov
@ 2017-10-31  6:20   ` Eric Dumazet
  2017-11-01 10:55   ` Francois Romieu
  1 sibling, 0 replies; 36+ messages in thread
From: Eric Dumazet @ 2017-10-31  6:20 UTC (permalink / raw)
  To: Kirill Smelkov
  Cc: Francois Romieu, Stephen Rothwell, David Miller, Networking,
	Linux-Next Mailing List, Linux Kernel Mailing List

On Tue, 2017-10-31 at 09:14 +0300, Kirill Smelkov wrote:
> Francois,
> 
> On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool -C)")
> > 
> > is missing a Signed-off-by from its author (or its author is wrong).
> 
> Could we please get signoff for this your patch from 2012 which I've
> reworked a bit to be commit 509708310cf9 ?
> 
>     	https://www.spinics.net/lists/netdev/msg217984.html
>     	https://www.spinics.net/lists/netdev/msg218207.html
> 
> I was keeping you in To and Cc all the time but got no reply at all since my
> first posting from ~ 1 month ago.

Nothing we can do, patch is merged, we can not modify it anymore.

You provided all the rationale in the changelog, so no worries.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2017-10-31  5:40 Stephen Rothwell
@ 2017-10-31  6:14 ` Kirill Smelkov
  2017-10-31  6:20   ` Eric Dumazet
  2017-11-01 10:55   ` Francois Romieu
  0 siblings, 2 replies; 36+ messages in thread
From: Kirill Smelkov @ 2017-10-31  6:14 UTC (permalink / raw)
  To: Francois Romieu
  Cc: Stephen Rothwell, David Miller, Networking,
	Linux-Next Mailing List, Linux Kernel Mailing List

Francois,

On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool -C)")
> 
> is missing a Signed-off-by from its author (or its author is wrong).

Could we please get signoff for this your patch from 2012 which I've
reworked a bit to be commit 509708310cf9 ?

    	https://www.spinics.net/lists/netdev/msg217984.html
    	https://www.spinics.net/lists/netdev/msg218207.html

I was keeping you in To and Cc all the time but got no reply at all since my
first posting from ~ 1 month ago.

Thanks beforehand,
Kirill

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2017-10-31  5:40 Stephen Rothwell
  2017-10-31  6:14 ` Kirill Smelkov
  0 siblings, 1 reply; 36+ messages in thread
From: Stephen Rothwell @ 2017-10-31  5:40 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Francois Romieu, Kirill Smelkov

Hi all,

Commit

  509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool -C)")

is missing a Signed-off-by from its author (or its author is wrong).

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2017-09-28 21:46 Stephen Rothwell
  0 siblings, 0 replies; 36+ messages in thread
From: Stephen Rothwell @ 2017-09-28 21:46 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Eric Dumazet

Hi all,

Commit

  8f1975e31d8e ("inetpeer: speed up inetpeer_invalidate_tree()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2017-08-30 16:53 ` David Ahern
  2017-08-30 17:38   ` Stephen Rothwell
@ 2017-08-30 17:52   ` David Miller
  1 sibling, 0 replies; 36+ messages in thread
From: David Miller @ 2017-08-30 17:52 UTC (permalink / raw)
  To: dsahern; +Cc: sfr, netdev, linux-next, linux-kernel

From: David Ahern <dsahern@gmail.com>
Date: Wed, 30 Aug 2017 10:53:48 -0600

> On 8/30/17 10:51 AM, Stephen Rothwell wrote:
>> Hi all,
>> 
>> Commit
>> 
>>   1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address")
>> 
>> is missing a Signed-off-by from its author.
>> 
> 
> Eric pointed this out last night. The commit message copied output from
> a command that contained '---' so git ignored the remainder of the message.

Yes, it unfortunately got clipped off by GIT due to how the
commit message was written. :(

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2017-08-30 16:53 ` David Ahern
@ 2017-08-30 17:38   ` Stephen Rothwell
  2017-08-30 17:52   ` David Miller
  1 sibling, 0 replies; 36+ messages in thread
From: Stephen Rothwell @ 2017-08-30 17:38 UTC (permalink / raw)
  To: David Ahern
  Cc: David Miller, Networking, Linux-Next Mailing List,
	Linux Kernel Mailing List

Hi David,

On Wed, 30 Aug 2017 10:53:48 -0600 David Ahern <dsahern@gmail.com> wrote:
>
> On 8/30/17 10:51 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address")
> > 
> > is missing a Signed-off-by from its author.
> 
> Eric pointed this out last night. The commit message copied output from
> a command that contained '---' so git ignored the remainder of the message.

Rats!

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net-next tree
  2017-08-30 16:51 Stephen Rothwell
@ 2017-08-30 16:53 ` David Ahern
  2017-08-30 17:38   ` Stephen Rothwell
  2017-08-30 17:52   ` David Miller
  0 siblings, 2 replies; 36+ messages in thread
From: David Ahern @ 2017-08-30 16:53 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

On 8/30/17 10:51 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address")
> 
> is missing a Signed-off-by from its author.
> 

Eric pointed this out last night. The commit message copied output from
a command that contained '---' so git ignored the remainder of the message.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* linux-next: Signed-off-by missing for commit in the net-next tree
@ 2017-08-30 16:51 Stephen Rothwell
  2017-08-30 16:53 ` David Ahern
  0 siblings, 1 reply; 36+ messages in thread
From: Stephen Rothwell @ 2017-08-30 16:51 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, David Ahern

Hi all,

Commit

  1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 36+ messages in thread

end of thread, back to index

Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 14:42 linux-next: Signed-off-by missing for commit in the net-next tree Stephen Rothwell
2019-09-11  5:24 ` Luciano Coelho
  -- strict thread matches above, loose matches on Subject: below --
2019-10-31  7:10 Stephen Rothwell
2019-10-31 17:40 ` David Miller
2019-10-31 18:40   ` Jeff Kirsher
2019-10-30  7:42 Stephen Rothwell
2019-10-02 22:06 Stephen Rothwell
2019-10-02 22:12 ` Randy Dunlap
2019-09-10 14:41 Stephen Rothwell
2019-09-11  9:02 ` Oleksij Rempel
2019-08-06 23:30 Stephen Rothwell
2019-08-06 23:37 ` Yifeng Sun
2019-08-07  1:54   ` Stephen Rothwell
2019-08-07  2:02     ` Yifeng Sun
2019-07-09 21:36 Stephen Rothwell
2019-01-16 21:06 Stephen Rothwell
2019-01-16 22:13 ` David Miller
     [not found] ` <CALqoU4ywdKaeD_DX4pF2hOTh-LQb2N+zGhap6x4sskaf_YthJw@mail.gmail.com>
2019-01-16 23:09   ` David Miller
2018-10-01 23:34 Stephen Rothwell
2018-09-02 21:40 Stephen Rothwell
2018-09-03  5:08 ` Vakul Garg
2018-09-03  5:16   ` David Miller
2018-09-03  5:21   ` Stephen Rothwell
2018-07-28  4:21 Stephen Rothwell
2018-05-13 22:02 Stephen Rothwell
2017-11-12 20:44 Stephen Rothwell
2017-10-31  5:40 Stephen Rothwell
2017-10-31  6:14 ` Kirill Smelkov
2017-10-31  6:20   ` Eric Dumazet
2017-11-01 10:55   ` Francois Romieu
2017-11-01 12:15     ` Kirill Smelkov
2017-09-28 21:46 Stephen Rothwell
2017-08-30 16:51 Stephen Rothwell
2017-08-30 16:53 ` David Ahern
2017-08-30 17:38   ` Stephen Rothwell
2017-08-30 17:52   ` David Miller

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git