Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the pm tree
@ 2019-10-14 23:08 Stephen Rothwell
  2019-10-14 23:16 ` linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree) Stephen Rothwell
  2019-10-15  8:23 ` linux-next: build warning after merge of the pm tree Andy Shevchenko
  0 siblings, 2 replies; 30+ messages in thread
From: Stephen Rothwell @ 2019-10-14 23:08 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Andy Shevchenko, Mika Westerberg

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/irqchip.h:14,
                 from arch/arm/kernel/irq.c:26:
include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration
  682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, const char *uid2)
      |                               ^~~~~~~~~~~

and many more.

Introduced by commit

  d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper")

CONFIG_ACPI is not set for this build.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree)
  2019-10-14 23:08 linux-next: build warning after merge of the pm tree Stephen Rothwell
@ 2019-10-14 23:16 ` Stephen Rothwell
  2019-10-15 10:04   ` Rafael J. Wysocki
  2019-10-15  8:23 ` linux-next: build warning after merge of the pm tree Andy Shevchenko
  1 sibling, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2019-10-14 23:16 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Andy Shevchenko, Mika Westerberg

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]

Hi all,

On Tue, 15 Oct 2019 10:08:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the pm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/irqchip.h:14,
>                  from arch/arm/kernel/irq.c:26:
> include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration
>   682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, const char *uid2)
>       |                               ^~~~~~~~~~~
> 
> and many more.
> 
> Introduced by commit
> 
>   d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper")
> 
> CONFIG_ACPI is not set for this build.

This became a build failure for the powerpc ppc64_allmodconfig build:

In file included from include/linux/i2c.h:13,
                 from arch/powerpc/platforms/pasemi/misc.c:14:
include/linux/acpi.h:682:31: error: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
  682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, const char *uid2)
      |                               ^~~~~~~~~~~
cc1: all warnings being treated as errors

(and many more)

I have used the pm tree from next-20191014 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2019-10-14 23:08 linux-next: build warning after merge of the pm tree Stephen Rothwell
  2019-10-14 23:16 ` linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree) Stephen Rothwell
@ 2019-10-15  8:23 ` Andy Shevchenko
  2019-10-15  9:41   ` Rafael J. Wysocki
  1 sibling, 1 reply; 30+ messages in thread
From: Andy Shevchenko @ 2019-10-15  8:23 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Rafael J. Wysocki, Linux Next Mailing List,
	Linux Kernel Mailing List, Mika Westerberg

On Tue, Oct 15, 2019 at 10:08:55AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/irqchip.h:14,
>                  from arch/arm/kernel/irq.c:26:
> include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration
>   682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, const char *uid2)
>       |                               ^~~~~~~~~~~
> 
> and many more.
> 
> Introduced by commit
> 
>   d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper")
> 
> CONFIG_ACPI is not set for this build.

I'm puzzled. Why it builds before?

Another function has struct acpi_device *adev in its prototype and it was
before above mentioned commit.


-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2019-10-15  8:23 ` linux-next: build warning after merge of the pm tree Andy Shevchenko
@ 2019-10-15  9:41   ` Rafael J. Wysocki
  0 siblings, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2019-10-15  9:41 UTC (permalink / raw)
  To: Andy Shevchenko, Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Mika Westerberg

On Tuesday, October 15, 2019 10:23:33 AM CEST Andy Shevchenko wrote:
> On Tue, Oct 15, 2019 at 10:08:55AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the pm tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > 
> > In file included from include/linux/irqchip.h:14,
> >                  from arch/arm/kernel/irq.c:26:
> > include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration
> >   682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, const char *uid2)
> >       |                               ^~~~~~~~~~~
> > 
> > and many more.
> > 
> > Introduced by commit
> > 
> >   d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper")
> > 
> > CONFIG_ACPI is not set for this build.
> 
> I'm puzzled. Why it builds before?
> 
> Another function has struct acpi_device *adev in its prototype and it was
> before above mentioned commit.

Right.

The very next acpi_dev_get_first_match_dev() returns a pointer to
struct acpi_device too and it is not modified by the commit in question.

There may be a bug in there, but commit d1748b57dc88 doesn't look like the
source of it.




^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree)
  2019-10-14 23:16 ` linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree) Stephen Rothwell
@ 2019-10-15 10:04   ` Rafael J. Wysocki
  2019-10-16  9:15     ` Geert Uytterhoeven
  0 siblings, 1 reply; 30+ messages in thread
From: Rafael J. Wysocki @ 2019-10-15 10:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Andy Shevchenko, Mika Westerberg

On Tuesday, October 15, 2019 1:16:50 AM CEST Stephen Rothwell wrote:
> 
> --Sig_/6GS1h5au_w04qPbsgg/ztsa
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi all,
> 
> On Tue, 15 Oct 2019 10:08:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> =
> wrote:
> >
> > After merging the pm tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >=20
> > In file included from include/linux/irqchip.h:14,
> >                  from arch/arm/kernel/irq.c:26:
> > include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared insid=
> e parameter list will not be visible outside of this definition or declarat=
> ion
> >   682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2=
> , const char *uid2)
> >       |                               ^~~~~~~~~~~
> >=20
> > and many more.
> >=20
> > Introduced by commit
> >=20
> >   d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper")
> >=20
> > CONFIG_ACPI is not set for this build.
> 
> This became a build failure for the powerpc ppc64_allmodconfig build:
> 
> In file included from include/linux/i2c.h:13,
>                  from arch/powerpc/platforms/pasemi/misc.c:14:
> include/linux/acpi.h:682:31: error: 'struct acpi_device' declared inside pa=
> rameter list will not be visible outside of this definition or declaration =
> [-Werror]
>   682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, =
> const char *uid2)
>       |                               ^~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> (and many more)
> 
> I have used the pm tree from next-20191014 for today.

So this looks weird, because there is an acpi_dev_put() stub in
include/linux/acpi.h too in the same #else block and it takes a
(struct acpi_device *) pointer too and it has not been touched by
the commit in question.  So why has it built successfully so far?

Also I wonder why 0-day didn't warn about that commit.

Anyway, I've added an extra declaration of struct acpi_device to the #else
block in question to suppress the warning(s).




^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree)
  2019-10-15 10:04   ` Rafael J. Wysocki
@ 2019-10-16  9:15     ` Geert Uytterhoeven
  2019-10-16  9:33       ` Andy Shevchenko
  0 siblings, 1 reply; 30+ messages in thread
From: Geert Uytterhoeven @ 2019-10-16  9:15 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Andy Shevchenko, Mika Westerberg

Hi Rafael,

On Tue, Oct 15, 2019 at 1:27 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, October 15, 2019 1:16:50 AM CEST Stephen Rothwell wrote:
> > On Tue, 15 Oct 2019 10:08:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> =
> > wrote:
> > >
> > > After merging the pm tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced this warning:
> > >=20
> > > In file included from include/linux/irqchip.h:14,
> > >                  from arch/arm/kernel/irq.c:26:
> > > include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared insid=
> > e parameter list will not be visible outside of this definition or declarat=
> > ion
> > >   682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2=
> > , const char *uid2)
> > >       |                               ^~~~~~~~~~~
> > >=20
> > > and many more.
> > >=20
> > > Introduced by commit
> > >=20
> > >   d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper")
> > >=20
> > > CONFIG_ACPI is not set for this build.
> >
> > This became a build failure for the powerpc ppc64_allmodconfig build:
> >
> > In file included from include/linux/i2c.h:13,
> >                  from arch/powerpc/platforms/pasemi/misc.c:14:
> > include/linux/acpi.h:682:31: error: 'struct acpi_device' declared inside pa=
> > rameter list will not be visible outside of this definition or declaration =
> > [-Werror]
> >   682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, =
> > const char *uid2)
> >       |                               ^~~~~~~~~~~
> > cc1: all warnings being treated as errors
> >
> > (and many more)
> >
> > I have used the pm tree from next-20191014 for today.
>
> So this looks weird, because there is an acpi_dev_put() stub in
> include/linux/acpi.h too in the same #else block and it takes a
> (struct acpi_device *) pointer too and it has not been touched by
> the commit in question.  So why has it built successfully so far?

Looks like that never warned because acpi_dev_put() is located after

    static inline struct acpi_device *
    acpi_dev_get_first_match_dev(const char *hid, const char *uid, s64 hrv)
    {
            return NULL;
    }

Moving acpi_dev_hid_uid_match() down gets rid of the warning, too.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree)
  2019-10-16  9:15     ` Geert Uytterhoeven
@ 2019-10-16  9:33       ` Andy Shevchenko
  0 siblings, 0 replies; 30+ messages in thread
From: Andy Shevchenko @ 2019-10-16  9:33 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rafael J. Wysocki, Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Mika Westerberg

On Wed, Oct 16, 2019 at 11:15:44AM +0200, Geert Uytterhoeven wrote:
> On Tue, Oct 15, 2019 at 1:27 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Tuesday, October 15, 2019 1:16:50 AM CEST Stephen Rothwell wrote:
> > > On Tue, 15 Oct 2019 10:08:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> =
> > > wrote:

> > > This became a build failure for the powerpc ppc64_allmodconfig build:
> > >
> > > In file included from include/linux/i2c.h:13,
> > >                  from arch/powerpc/platforms/pasemi/misc.c:14:
> > > include/linux/acpi.h:682:31: error: 'struct acpi_device' declared inside pa=
> > > rameter list will not be visible outside of this definition or declaration =
> > > [-Werror]
> > >   682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, =
> > > const char *uid2)
> > >       |                               ^~~~~~~~~~~
> > > cc1: all warnings being treated as errors
> > >
> > > (and many more)
> > >
> > > I have used the pm tree from next-20191014 for today.
> >
> > So this looks weird, because there is an acpi_dev_put() stub in
> > include/linux/acpi.h too in the same #else block and it takes a
> > (struct acpi_device *) pointer too and it has not been touched by
> > the commit in question.  So why has it built successfully so far?
> 
> Looks like that never warned because acpi_dev_put() is located after
> 
>     static inline struct acpi_device *
>     acpi_dev_get_first_match_dev(const char *hid, const char *uid, s64 hrv)
>     {
>             return NULL;
>     }
> 
> Moving acpi_dev_hid_uid_match() down gets rid of the warning, too.

Sounds like a compiler bug.

It thinks that struct acpi_device * is defined as function prototype?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
       [not found] <201907111346291954773@zte.com.cn>
@ 2019-07-11 12:26 ` Rafael J. Wysocki
  0 siblings, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2019-07-11 12:26 UTC (permalink / raw)
  To: wen.yang99; +Cc: sfr, linux-next, linux-kernel

On Thursday, July 11, 2019 7:46:29 AM CEST wen.yang99@zte.com.cn wrote:
> > Hi all,
> > 
> > After merging the pm tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > drivers/cpufreq/pasemi-cpufreq.c: In function 'pas_cpufreq_cpu_init':
> > drivers/cpufreq/pasemi-cpufreq.c:199:1: warning: label 'out_unmap_sdcpwr' defined but not used [-Wunused-label]
> > out_unmap_sdcpwr:
> > ^~~~~~~~~~~~~~~~
> > 
> > Introduced by commit
> > 
> > f43e075f7252 ("cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init()")
> 
> Thank you very much.
> 
> We need to delete the useless code here:
> diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c
> index 1f0beb7..624c34a 100644
> --- a/drivers/cpufreq/pasemi-cpufreq.c
> +++ b/drivers/cpufreq/pasemi-cpufreq.c
> @@ -195,9 +195,6 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
> 
>         return cpufreq_generic_init(policy, pas_freqs, get_gizmo_latency());
> 
> -out_unmap_sdcpwr:
> -       iounmap(sdcpwr_mapbase);
> -
>  out_unmap_sdcasr:
>         iounmap(sdcasr_mapbase);
>  out:

I'm dropping commit f43e075f7252 from my linux-next branch, so please send a new version
of that patch with the issue fixed.

If you consider alternatives to the patch, please describe them in the message section between
the patch and the changelog.




^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the pm tree
@ 2019-07-11  1:31 Stephen Rothwell
  0 siblings, 0 replies; 30+ messages in thread
From: Stephen Rothwell @ 2019-07-11  1:31 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Wen Yang

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/cpufreq/pasemi-cpufreq.c: In function 'pas_cpufreq_cpu_init':
drivers/cpufreq/pasemi-cpufreq.c:199:1: warning: label 'out_unmap_sdcpwr' defined but not used [-Wunused-label]
 out_unmap_sdcpwr:
 ^~~~~~~~~~~~~~~~

Introduced by commit

  f43e075f7252 ("cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the pm tree
@ 2019-01-23 23:45 Stephen Rothwell
  0 siblings, 0 replies; 30+ messages in thread
From: Stephen Rothwell @ 2019-01-23 23:45 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Greg Kroah-Hartman

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/acpi/acpi_dbg.c: In function 'acpi_aml_init':
drivers/acpi/acpi_dbg.c:774:1: warning: label 'err_exit' defined but not used [-Wunused-label]
 err_exit:
 ^~~~~~~~

Introduced by commit

  9ec6dbfbdc0a ("ACPI: no need to check return value of debugfs_create functions")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2018-07-30  7:24 ` Sakari Ailus
  2018-07-30  7:30   ` jacopo mondi
@ 2018-07-31  0:39   ` Stephen Rothwell
  1 sibling, 0 replies; 30+ messages in thread
From: Stephen Rothwell @ 2018-07-31  0:39 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Sakari Ailus, Rafael J. Wysocki, Linux-Next Mailing List,
	Linux Kernel Mailing List, Jacopo Mondi

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

Hi all,

On Mon, 30 Jul 2018 10:24:45 +0300 Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
>
> On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> > 
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
> > drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >   unsigned int idx;
> >                ^~~
> > 
> > Introduced by commit
> > 
> >   aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")
> > 
> > Looks like a false positive, but not something that gcc can easily see.  
> 
> This must be coming from a new driver merged to media tree recently. Thanks
> for reporting this.

Yeah, sorry, process failure.  This should have been reported against
the v4l-dvb tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2018-07-30  7:24 ` Sakari Ailus
@ 2018-07-30  7:30   ` jacopo mondi
  2018-07-31  0:39   ` Stephen Rothwell
  1 sibling, 0 replies; 30+ messages in thread
From: jacopo mondi @ 2018-07-30  7:30 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Stephen Rothwell, Rafael J. Wysocki, Linux-Next Mailing List,
	Linux Kernel Mailing List, Jacopo Mondi

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

Hi,

On Mon, Jul 30, 2018 at 10:24:45AM +0300, Sakari Ailus wrote:
> Hi folks,
>
> On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> > Hi Rafael,
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
> > drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >   unsigned int idx;
> >                ^~~
> >
> > Introduced by commit
> >
> >   aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")
> >
> > Looks like a false positive, but not something that gcc can easily see.
>
> This must be coming from a new driver merged to media tree recently. Thanks
> for reporting this.
>

Yes, my bad, it is a false positive and I ignored it,
sorry about that. There is already a patch sent to linux-media to fix
this on top of the driver.

https://patchwork.kernel.org/patch/10547983/

Thanks
   j

> --
> Regards,
>
> Sakari Ailus
> sakari.ailus@linux.intel.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2018-07-30  2:00 Stephen Rothwell
@ 2018-07-30  7:24 ` Sakari Ailus
  2018-07-30  7:30   ` jacopo mondi
  2018-07-31  0:39   ` Stephen Rothwell
  0 siblings, 2 replies; 30+ messages in thread
From: Sakari Ailus @ 2018-07-30  7:24 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Rafael J. Wysocki, Linux-Next Mailing List,
	Linux Kernel Mailing List, Jacopo Mondi

Hi folks,

On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
> drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   unsigned int idx;
>                ^~~
> 
> Introduced by commit
> 
>   aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")
> 
> Looks like a false positive, but not something that gcc can easily see.

This must be coming from a new driver merged to media tree recently. Thanks
for reporting this.

-- 
Regards,

Sakari Ailus
sakari.ailus@linux.intel.com

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the pm tree
@ 2018-07-30  2:00 Stephen Rothwell
  2018-07-30  7:24 ` Sakari Ailus
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2018-07-30  2:00 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Jacopo Mondi,
	Sakari Ailus

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
  unsigned int idx;
               ^~~

Introduced by commit

  aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")

Looks like a false positive, but not something that gcc can easily see.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2018-06-08  0:30 Stephen Rothwell
@ 2018-06-08  9:14 ` Rafael J. Wysocki
  0 siblings, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2018-06-08  9:14 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Srinivas Pandruvada

On Friday, June 8, 2018 2:30:35 AM CEST Stephen Rothwell wrote:
> 
> --Sig_/ncqmE76IGCiWNItKgM.lURc
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi all,

Hi,

> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> WARNING: vmlinux.o(.text+0xc5b83a): Section mismatch in reference from the =
> function __intel_pstate_cpu_init() to the variable .init.rodata:intel_pstat=
> e_hwp_boost_ids
> The function __intel_pstate_cpu_init() references
> the variable __initconst intel_pstate_hwp_boost_ids.
> This is often because __intel_pstate_cpu_init lacks a __initconst=20
> annotation or the annotation of intel_pstate_hwp_boost_ids is wrong.
> 
> Introduced by commit
> 
>   f50f70793d78 ("cpufreq: intel_pstate: enable boost for Skylake Xeon")

Thanks for the report!

I've dropped the __initconst annotation from intel_pstate_hwp_boost_ids[].

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the pm tree
@ 2018-06-08  0:30 Stephen Rothwell
  2018-06-08  9:14 ` Rafael J. Wysocki
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2018-06-08  0:30 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Srinivas Pandruvada

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

WARNING: vmlinux.o(.text+0xc5b83a): Section mismatch in reference from the function __intel_pstate_cpu_init() to the variable .init.rodata:intel_pstate_hwp_boost_ids
The function __intel_pstate_cpu_init() references
the variable __initconst intel_pstate_hwp_boost_ids.
This is often because __intel_pstate_cpu_init lacks a __initconst 
annotation or the annotation of intel_pstate_hwp_boost_ids is wrong.

Introduced by commit

  f50f70793d78 ("cpufreq: intel_pstate: enable boost for Skylake Xeon")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2018-04-09  1:24 Stephen Rothwell
@ 2018-04-10  7:05 ` Rafael J. Wysocki
  0 siblings, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2018-04-10  7:05 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

On Monday, April 9, 2018 3:24:38 AM CEST Stephen Rothwell wrote:
> 
> --Sig_/QL=OZEguM./+7xhHdQruHaV
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit':
> kernel/time/tick-sched.c:1162:3: warning: 'now' may be used uninitialized i=
> n this function [-Wmaybe-uninitialized]
>    __tick_nohz_idle_restart_tick(ts, now);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> kernel/time/tick-sched.c:1146:10: note: 'now' was declared here
>   ktime_t now;
>           ^~~
> 
> This appears to be a false positive.
> 
> And another in the x86_64 allmodconfig build:
> 
> kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit':
> kernel/time/tick-sched.c:538:2: warning: 'now' may be used uninitialized in=
>  this function [-Wmaybe-uninitialized]
>   update_ts_time_stats(smp_processor_id(), ts, now, NULL);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> kernel/time/tick-sched.c:1146:10: note: 'now' was declared here
>   ktime_t now;
>           ^~~
> 
> also looks like a false positive.

Yes, they are false positives AFAICS.

Cheers,
Rafael

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the pm tree
@ 2018-04-09  1:24 Stephen Rothwell
  2018-04-10  7:05 ` Rafael J. Wysocki
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2018-04-09  1:24 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit':
kernel/time/tick-sched.c:1162:3: warning: 'now' may be used uninitialized in this function [-Wmaybe-uninitialized]
   __tick_nohz_idle_restart_tick(ts, now);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/time/tick-sched.c:1146:10: note: 'now' was declared here
  ktime_t now;
          ^~~

This appears to be a false positive.

And another in the x86_64 allmodconfig build:

kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit':
kernel/time/tick-sched.c:538:2: warning: 'now' may be used uninitialized in this function [-Wmaybe-uninitialized]
  update_ts_time_stats(smp_processor_id(), ts, now, NULL);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/time/tick-sched.c:1146:10: note: 'now' was declared here
  ktime_t now;
          ^~~

also looks like a false positive.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2016-11-14  0:03 ` Rafael J. Wysocki
@ 2016-11-14  8:49   ` Akshay Adiga
  0 siblings, 0 replies; 30+ messages in thread
From: Akshay Adiga @ 2016-11-14  8:49 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: linux-next, linux-kernel, Linux PM list, Stephen Rothwell

Hi Rafeal,

Good catch, I need to set lpstate_idx = gpstate_idx.
I will send a patch which fixes this commit.

Thanks Stephen for reporting it. :)

Regards
Akshay Adiga

On 11/14/2016 05:33 AM, Rafael J. Wysocki wrote:
> On Monday, November 14, 2016 10:40:09 AM Stephen Rothwell wrote:
> > Hi Rafael,
>
> Hi Stephen,
>
> > After merging the pm tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > drivers/cpufreq/powernv-cpufreq.c: In function 'gpstate_timer_handler':
> > drivers/cpufreq/powernv-cpufreq.c:642:5: warning: 'lpstate_idx' may
> be used uninitialized in this function [-Wmaybe-uninitialized]
> >   if (gpstate_idx != gpstates->last_lpstate_idx)
> >      ^
> >
> > Introduced by commit
> >
> >   20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and
> local pstate")
>
> Thanks for the notice!
>
> Akshay, any thoughts?
>
> Thanks,
> Rafael
>

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2016-11-13 23:40 Stephen Rothwell
@ 2016-11-14  0:03 ` Rafael J. Wysocki
  2016-11-14  8:49   ` Akshay Adiga
  0 siblings, 1 reply; 30+ messages in thread
From: Rafael J. Wysocki @ 2016-11-14  0:03 UTC (permalink / raw)
  To: Stephen Rothwell, Akshay Adiga; +Cc: linux-next, linux-kernel, Linux PM list

On Monday, November 14, 2016 10:40:09 AM Stephen Rothwell wrote:
> Hi Rafael,

Hi Stephen,

> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/cpufreq/powernv-cpufreq.c: In function 'gpstate_timer_handler':
> drivers/cpufreq/powernv-cpufreq.c:642:5: warning: 'lpstate_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (gpstate_idx != gpstates->last_lpstate_idx)
>      ^
> 
> Introduced by commit
> 
>   20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and local pstate")

Thanks for the notice!

Akshay, any thoughts?

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the pm tree
@ 2016-11-13 23:40 Stephen Rothwell
  2016-11-14  0:03 ` Rafael J. Wysocki
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2016-11-13 23:40 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Akshay Adiga

Hi Rafael,

After merging the pm tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/cpufreq/powernv-cpufreq.c: In function 'gpstate_timer_handler':
drivers/cpufreq/powernv-cpufreq.c:642:5: warning: 'lpstate_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (gpstate_idx != gpstates->last_lpstate_idx)
     ^

Introduced by commit

  20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and local pstate")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2014-11-17 23:45     ` Paul Bolle
@ 2014-11-18  0:34       ` Rafael J. Wysocki
  0 siblings, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2014-11-18  0:34 UTC (permalink / raw)
  To: Paul Bolle; +Cc: Stephen Rothwell, linux-next, linux-kernel, Kevin Hilman

On Tuesday, November 18, 2014 12:45:09 AM Paul Bolle wrote:
> On Tue, 2014-11-18 at 00:14 +0100, Rafael J. Wysocki wrote:
> > I'll drop the commit for now, but this looks strange.
> > 
> > Had you cleaned up the kernel configuration after dropping the PM_RUNTIME select
> > from ARCH_EXYNOS?
> 
> I retested this again:
> 
> [linux * (next-20141117)]$ git status
> HEAD detached at next-20141117
> nothing to commit (use -u to show untracked files)
> [linux * (next-20141117)]$ make clean
> [linux * (next-20141117)]$ cp arch/arm/configs/omap2plus_defconfig .config
> [linux * (next-20141117)]$ vim arch/arm/mach-exynos/Kconfig:24:
> [linux * (next-20141117)]$ git diff
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index e4a00bafffc1..02ff8534238b 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -21,7 +21,6 @@ menuconfig ARCH_EXYNOS
>         select HAVE_S3C_RTC if RTC_CLASS
>         select PINCTRL
>         select PINCTRL_EXYNOS
> -       select PM_GENERIC_DOMAINS if PM_RUNTIME
>         select S5P_DEV_MFC
>         select SRAM
>         select MFD_SYSCON
> [linux * (next-20141117)]$ yes "" | make  ARCH=arm oldconfig >/dev/null
> kernel/power/Kconfig:145:error: recursive dependency detected!
> kernel/power/Kconfig:145:	symbol PM depends on PM_RUNTIME
> kernel/power/Kconfig:132:	symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS
> kernel/power/Kconfig:272:	symbol PM_GENERIC_DOMAINS is selected by PM
> 
> Can you reproduce the above?

I can't personally.

Anyway, I'm going to drop the commit as I said.

Rafael

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2014-11-17 23:14   ` Rafael J. Wysocki
@ 2014-11-17 23:45     ` Paul Bolle
  2014-11-18  0:34       ` Rafael J. Wysocki
  0 siblings, 1 reply; 30+ messages in thread
From: Paul Bolle @ 2014-11-17 23:45 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Stephen Rothwell, linux-next, linux-kernel, Kevin Hilman

On Tue, 2014-11-18 at 00:14 +0100, Rafael J. Wysocki wrote:
> I'll drop the commit for now, but this looks strange.
> 
> Had you cleaned up the kernel configuration after dropping the PM_RUNTIME select
> from ARCH_EXYNOS?

I retested this again:

[linux * (next-20141117)]$ git status
HEAD detached at next-20141117
nothing to commit (use -u to show untracked files)
[linux * (next-20141117)]$ make clean
[linux * (next-20141117)]$ cp arch/arm/configs/omap2plus_defconfig .config
[linux * (next-20141117)]$ vim arch/arm/mach-exynos/Kconfig:24:
[linux * (next-20141117)]$ git diff
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index e4a00bafffc1..02ff8534238b 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -21,7 +21,6 @@ menuconfig ARCH_EXYNOS
        select HAVE_S3C_RTC if RTC_CLASS
        select PINCTRL
        select PINCTRL_EXYNOS
-       select PM_GENERIC_DOMAINS if PM_RUNTIME
        select S5P_DEV_MFC
        select SRAM
        select MFD_SYSCON
[linux * (next-20141117)]$ yes "" | make  ARCH=arm oldconfig >/dev/null
kernel/power/Kconfig:145:error: recursive dependency detected!
kernel/power/Kconfig:145:	symbol PM depends on PM_RUNTIME
kernel/power/Kconfig:132:	symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS
kernel/power/Kconfig:272:	symbol PM_GENERIC_DOMAINS is selected by PM

Can you reproduce the above?


Paul Bolle

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2014-11-17 11:31 ` Paul Bolle
@ 2014-11-17 23:14   ` Rafael J. Wysocki
  2014-11-17 23:45     ` Paul Bolle
  0 siblings, 1 reply; 30+ messages in thread
From: Rafael J. Wysocki @ 2014-11-17 23:14 UTC (permalink / raw)
  To: Paul Bolle; +Cc: Stephen Rothwell, linux-next, linux-kernel, Kevin Hilman

On Monday, November 17, 2014 12:31:43 PM Paul Bolle wrote:
> On Mon, 2014-11-17 at 13:44 +1100, Stephen Rothwell wrote:
> > Hi Rafael,
> > 
> > After merging the pm tree, today's linux-next build (arm multi_v7_defconfig)
> > produced this warning:
> > 
> > kernel/power/Kconfig:132:error: recursive dependency detected!
> > kernel/power/Kconfig:132:	symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS
> > kernel/power/Kconfig:272:	symbol PM_GENERIC_DOMAINS is selected by PM_RUNTIME
> > 
> > Caused by commit 9cdd5fd742e6 ("PM / domains: Kconfig: always enable
> > PM_RUNTIME when genpd enabled").
> 
> This error also popped up when I fiddled with omap2plus_defconfig on top
> of next-20141117. Note that I ended up with a .config which has
> CONFIG_ARCH_MULTI_V7 set. The error appears to be triggered by the
> Kconfig entry for ARCH_EXYNOS (in arch/arm/mach-exynos/Kconfig). It
> contains
>         select PM_GENERIC_DOMAINS if PM_RUNTIME
> 
> (Perhaps the :272: line needs rephrasing in the error Stephen quoted. It
> confused me quite a bit.)
> 
> Naively dropping that select statement from ARCH_EXYNOS triggered yet
> another error:
>     kernel/power/Kconfig:145:error: recursive dependency detected!
>     kernel/power/Kconfig:145:	symbol PM depends on PM_RUNTIME
>     kernel/power/Kconfig:132:	symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS
>     kernel/power/Kconfig:272:	symbol PM_GENERIC_DOMAINS is selected by PM
> 
> After that I admitted defeat.

I'll drop the commit for now, but this looks strange.

Had you cleaned up the kernel configuration after dropping the PM_RUNTIME select
from ARCH_EXYNOS?

Rafael

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2014-11-17  2:44 Stephen Rothwell
@ 2014-11-17 11:31 ` Paul Bolle
  2014-11-17 23:14   ` Rafael J. Wysocki
  0 siblings, 1 reply; 30+ messages in thread
From: Paul Bolle @ 2014-11-17 11:31 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Stephen Rothwell, linux-next, linux-kernel, Kevin Hilman

On Mon, 2014-11-17 at 13:44 +1100, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (arm multi_v7_defconfig)
> produced this warning:
> 
> kernel/power/Kconfig:132:error: recursive dependency detected!
> kernel/power/Kconfig:132:	symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS
> kernel/power/Kconfig:272:	symbol PM_GENERIC_DOMAINS is selected by PM_RUNTIME
> 
> Caused by commit 9cdd5fd742e6 ("PM / domains: Kconfig: always enable
> PM_RUNTIME when genpd enabled").

This error also popped up when I fiddled with omap2plus_defconfig on top
of next-20141117. Note that I ended up with a .config which has
CONFIG_ARCH_MULTI_V7 set. The error appears to be triggered by the
Kconfig entry for ARCH_EXYNOS (in arch/arm/mach-exynos/Kconfig). It
contains
        select PM_GENERIC_DOMAINS if PM_RUNTIME

(Perhaps the :272: line needs rephrasing in the error Stephen quoted. It
confused me quite a bit.)

Naively dropping that select statement from ARCH_EXYNOS triggered yet
another error:
    kernel/power/Kconfig:145:error: recursive dependency detected!
    kernel/power/Kconfig:145:	symbol PM depends on PM_RUNTIME
    kernel/power/Kconfig:132:	symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS
    kernel/power/Kconfig:272:	symbol PM_GENERIC_DOMAINS is selected by PM

After that I admitted defeat.


Paul Bolle

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the pm tree
@ 2014-11-17  2:44 Stephen Rothwell
  2014-11-17 11:31 ` Paul Bolle
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2014-11-17  2:44 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel, Kevin Hilman

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (arm multi_v7_defconfig)
produced this warning:

kernel/power/Kconfig:132:error: recursive dependency detected!
kernel/power/Kconfig:132:	symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS
kernel/power/Kconfig:272:	symbol PM_GENERIC_DOMAINS is selected by PM_RUNTIME

Caused by commit 9cdd5fd742e6 ("PM / domains: Kconfig: always enable
PM_RUNTIME when genpd enabled").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2014-10-29 15:23   ` Fengguang Wu
@ 2014-10-29 15:56     ` Rafael J. Wysocki
  0 siblings, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2014-10-29 15:56 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wednesday, October 29, 2014 11:23:38 PM Fengguang Wu wrote:
> On Wed, Oct 29, 2014 at 03:55:19PM +0100, Rafael J. Wysocki wrote:
> > On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote:
> > > Hi Rafael,
> > 
> > Hi,
> > 
> > > After merging the pm tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced this warning:
> > > 
> > > drivers/of/base.c: In function 'of_property_read_string_array':
> > > drivers/of/base.c:1472:1: warning: control reaches end of non-void function [-Wreturn-type]
> > >  }
> > >  ^
> > > 
> > > Introduced by commit ef23586751cd ("Driver core: Unified device
> > > properties interface for platform firmware").
> > 
> > Thanks for reporting this!
> > 
> > > Please don't ignore new warnings ...
> > 
> > I don't as a rule.  I'm not sure why I haven't seen that before (and the kbuild
> > robot reports BUILD SUCCESS for that branch).
> 
> I do find the build error id:
> 
> -rw-rw-r-- 1 kbuild kbuild  272 2014-10-29 23:11 /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function
> 
> However there happens to be an old one half year ago. Since I never
> delete old warnings, it prevents the reporting of the new warning on
> your tree..
> 
> % cat /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function
> drivers/of/base.c:1147:1: warning: control reaches end of non-void function [-Wreturn-type]
> 
> 2014-04-17 02:59:49 lkp-ib04 socfpga-nex:socfpga_for_next_dts_overlays:bdb1f0c2cbe39db8f4a2ac4794001ba2e99cb65b i386-randconfig-i001-0414 f11752c03ccfd747a1f0740955682a
> 304933361c                         
> 
> The easiest way to fix it is to delete any old error/warnings that
> have been *inactive* for more than 2 months (which means they are
> likely fixed).

That could be done more aggressively even in my view.  If something is inactive
for two weeks, then it probably has been fixed (this way or another).

Kind regards,
Rafael

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2014-10-29 14:55 ` Rafael J. Wysocki
@ 2014-10-29 15:23   ` Fengguang Wu
  2014-10-29 15:56     ` Rafael J. Wysocki
  0 siblings, 1 reply; 30+ messages in thread
From: Fengguang Wu @ 2014-10-29 15:23 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Oct 29, 2014 at 03:55:19PM +0100, Rafael J. Wysocki wrote:
> On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote:
> > Hi Rafael,
> 
> Hi,
> 
> > After merging the pm tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > 
> > drivers/of/base.c: In function 'of_property_read_string_array':
> > drivers/of/base.c:1472:1: warning: control reaches end of non-void function [-Wreturn-type]
> >  }
> >  ^
> > 
> > Introduced by commit ef23586751cd ("Driver core: Unified device
> > properties interface for platform firmware").
> 
> Thanks for reporting this!
> 
> > Please don't ignore new warnings ...
> 
> I don't as a rule.  I'm not sure why I haven't seen that before (and the kbuild
> robot reports BUILD SUCCESS for that branch).

I do find the build error id:

-rw-rw-r-- 1 kbuild kbuild  272 2014-10-29 23:11 /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function

However there happens to be an old one half year ago. Since I never
delete old warnings, it prevents the reporting of the new warning on
your tree..

% cat /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function
drivers/of/base.c:1147:1: warning: control reaches end of non-void function [-Wreturn-type]

2014-04-17 02:59:49 lkp-ib04 socfpga-nex:socfpga_for_next_dts_overlays:bdb1f0c2cbe39db8f4a2ac4794001ba2e99cb65b i386-randconfig-i001-0414 f11752c03ccfd747a1f0740955682a
304933361c                         

The easiest way to fix it is to delete any old error/warnings that
have been *inactive* for more than 2 months (which means they are
likely fixed).

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the pm tree
  2014-10-29  2:51 Stephen Rothwell
@ 2014-10-29 14:55 ` Rafael J. Wysocki
  2014-10-29 15:23   ` Fengguang Wu
  0 siblings, 1 reply; 30+ messages in thread
From: Rafael J. Wysocki @ 2014-10-29 14:55 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, kbuild test robot

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote:
> Hi Rafael,

Hi,

> After merging the pm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/of/base.c: In function 'of_property_read_string_array':
> drivers/of/base.c:1472:1: warning: control reaches end of non-void function [-Wreturn-type]
>  }
>  ^
> 
> Introduced by commit ef23586751cd ("Driver core: Unified device
> properties interface for platform firmware").

Thanks for reporting this!

> Please don't ignore new warnings ...

I don't as a rule.  I'm not sure why I haven't seen that before (and the kbuild
robot reports BUILD SUCCESS for that branch).

Rafael

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the pm tree
@ 2014-10-29  2:51 Stephen Rothwell
  2014-10-29 14:55 ` Rafael J. Wysocki
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2014-10-29  2:51 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/of/base.c: In function 'of_property_read_string_array':
drivers/of/base.c:1472:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Introduced by commit ef23586751cd ("Driver core: Unified device
properties interface for platform firmware").  Please don't ignore new
warnings ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, back to index

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-14 23:08 linux-next: build warning after merge of the pm tree Stephen Rothwell
2019-10-14 23:16 ` linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree) Stephen Rothwell
2019-10-15 10:04   ` Rafael J. Wysocki
2019-10-16  9:15     ` Geert Uytterhoeven
2019-10-16  9:33       ` Andy Shevchenko
2019-10-15  8:23 ` linux-next: build warning after merge of the pm tree Andy Shevchenko
2019-10-15  9:41   ` Rafael J. Wysocki
     [not found] <201907111346291954773@zte.com.cn>
2019-07-11 12:26 ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2019-07-11  1:31 Stephen Rothwell
2019-01-23 23:45 Stephen Rothwell
2018-07-30  2:00 Stephen Rothwell
2018-07-30  7:24 ` Sakari Ailus
2018-07-30  7:30   ` jacopo mondi
2018-07-31  0:39   ` Stephen Rothwell
2018-06-08  0:30 Stephen Rothwell
2018-06-08  9:14 ` Rafael J. Wysocki
2018-04-09  1:24 Stephen Rothwell
2018-04-10  7:05 ` Rafael J. Wysocki
2016-11-13 23:40 Stephen Rothwell
2016-11-14  0:03 ` Rafael J. Wysocki
2016-11-14  8:49   ` Akshay Adiga
2014-11-17  2:44 Stephen Rothwell
2014-11-17 11:31 ` Paul Bolle
2014-11-17 23:14   ` Rafael J. Wysocki
2014-11-17 23:45     ` Paul Bolle
2014-11-18  0:34       ` Rafael J. Wysocki
2014-10-29  2:51 Stephen Rothwell
2014-10-29 14:55 ` Rafael J. Wysocki
2014-10-29 15:23   ` Fengguang Wu
2014-10-29 15:56     ` Rafael J. Wysocki

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git