Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure after merge of the bluetooth tree
@ 2019-10-18  0:13 Stephen Rothwell
  0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2019-10-18  0:13 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Amit K Bag,
	Raghuram Hegde, Chethan T N

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

Hi all,

After merging the bluetooth tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from drivers/bluetooth/hci_ldisc.c:34:
drivers/bluetooth/btintel.h: In function 'btintel_reset_to_bootloader':
drivers/bluetooth/btintel.h:188:9: warning: 'return' with a value, in function returning void [-Wreturn-type]
  188 |  return -EOPNOTSUPP;
      |         ^
drivers/bluetooth/btintel.h:186:20: note: declared here
  186 | static inline void btintel_reset_to_bootloader(struct hci_dev *hdev)
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  b9a2562f4918 ("Bluetooth: btusb: Trigger Intel FW download error recovery")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: linux-next: build failure after merge of the bluetooth tree
  2015-09-22  1:20   ` Stephen Rothwell
@ 2015-09-22  3:42     ` David Miller
  0 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2015-09-22  3:42 UTC (permalink / raw)
  To: sfr
  Cc: gustavo, netdev, linux-next, linux-kernel, alex.aring, joe, akpm, marcel

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 22 Sep 2015 11:20:15 +1000

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Subject: drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Alexander Aring <alex.aring@gmail.com>
> Cc: Stefan Schmidt <stefan@osg.samsung.com>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: linux-next: build failure after merge of the bluetooth tree
  2015-09-14  0:22 ` Stephen Rothwell
@ 2015-09-22  1:20   ` Stephen Rothwell
  2015-09-22  3:42     ` David Miller
  0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2015-09-22  1:20 UTC (permalink / raw)
  To: Gustavo Padovan, David Miller, netdev
  Cc: linux-next, linux-kernel, Alexander Aring, Joe Perches,
	Andrew Morton, marcel

Hi Gustavo,

On Mon, 14 Sep 2015 10:22:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 14 Sep 2015 10:14:28 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > I applied the patches that Andrew has had in his post merge series
> > (but I think you were sent a rolled up version):
> 
> Actually it was sent by Alexander to Marcel:
> 
> From: Alexander Aring <alex.aring@gmail.com>
> To: marcel@holtmann.org
> Cc: Andrew Morton <akpm@linux-foundation.org>,
> 	Stephen Rothwell <sfr@canb.auug.org.au>,
> 	Alexander Aring <alex.aring@gmail.com>,
> 	Stefan Schmidt <stefan@osg.samsung.com>
> Subject: [PATCH bluetooth-next] drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL
> Date: Fri, 11 Sep 2015 11:23:30 +0200
> Message-Id: <1441963410-24844-1-git-send-email-alex.aring@gmail.com>
> X-Mailer: git-send-email 2.5.1
> 
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> I will shortly be sending
> http://ozlabs.org/~akpm/mmots/broken-out/fs-seq_file-convert-int-seq_vprint-seq_printf-etc-returns-to-void.patch
> to Linus.  This will cause the linux-next version of
> drivers/net/ieee802154/at86rf230.c to break at compilation time.
> 
> Below is the fix.  I suggest you apply this immediately.
> 
> Otherwise I'll try to remember to send this in after Alexander's
> 890acf8330cac is merged.  But there will be a window during which the
> build fails, and we'll get emails...
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Subject: drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL

OK, this is now a problem for the net-next tree since the bluetooth
tree was merged there :-(

Can someone please apply this patch?

Hi Dave,

An x64_64 allmodconfig build after merging the next-next tree breaks in
linux-next due to the patch below not being applied to the bluetooth
tree.  I have been applying the equivalent to the bluetooth tree merge
in linux-next for a while now.

[Patch repeated for Dave - this is from and email from Andrew via
Alexander to Marcel which I forwarded to Gustavo]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Stefan Schmidt <stefan@osg.samsung.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 drivers/net/ieee802154/at86rf230.c | 35 ++++++++++-------------------------
 1 file changed, 10 insertions(+), 25 deletions(-)

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index b8b0628..9756e64 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1645,32 +1645,17 @@ static struct dentry *at86rf230_debugfs_root;
 static int at86rf230_stats_show(struct seq_file *file, void *offset)
 {
 	struct at86rf230_local *lp = file->private;
-	int ret;
-
-	ret = seq_printf(file, "SUCCESS:\t\t%8llu\n", lp->trac.success);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "SUCCESS_DATA_PENDING:\t%8llu\n",
-			 lp->trac.success_data_pending);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "SUCCESS_WAIT_FOR_ACK:\t%8llu\n",
-			 lp->trac.success_wait_for_ack);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "CHANNEL_ACCESS_FAILURE:\t%8llu\n",
-			 lp->trac.channel_access_failure);
-	if (ret < 0)
-		return ret;
 
-	ret = seq_printf(file, "NO_ACK:\t\t\t%8llu\n", lp->trac.no_ack);
-	if (ret < 0)
-		return ret;
-
-	return seq_printf(file, "INVALID:\t\t%8llu\n", lp->trac.invalid);
+	seq_printf(file, "SUCCESS:\t\t%8llu\n", lp->trac.success);
+	seq_printf(file, "SUCCESS_DATA_PENDING:\t%8llu\n",
+		   lp->trac.success_data_pending);
+	seq_printf(file, "SUCCESS_WAIT_FOR_ACK:\t%8llu\n",
+		   lp->trac.success_wait_for_ack);
+	seq_printf(file, "CHANNEL_ACCESS_FAILURE:\t%8llu\n",
+		   lp->trac.channel_access_failure);
+	seq_printf(file, "NO_ACK:\t\t\t%8llu\n", lp->trac.no_ack);
+	seq_printf(file, "INVALID:\t\t%8llu\n", lp->trac.invalid);
+	return 0;
 }
 
 static int at86rf230_stats_open(struct inode *inode, struct file *file)
-- 
2.5.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: linux-next: build failure after merge of the bluetooth tree
  2015-09-14  0:14 Stephen Rothwell
@ 2015-09-14  0:22 ` Stephen Rothwell
  2015-09-22  1:20   ` Stephen Rothwell
  0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2015-09-14  0:22 UTC (permalink / raw)
  To: Gustavo Padovan
  Cc: linux-next, linux-kernel, Alexander Aring, Joe Perches,
	Andrew Morton, marcel

Hi Gustavo,

On Mon, 14 Sep 2015 10:14:28 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> I applied the patches that Andrew has had in his post merge series
> (but I think you were sent a rolled up version):

Actually it was sent by Alexander to Marcel:

From: Alexander Aring <alex.aring@gmail.com>
To: marcel@holtmann.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@osg.samsung.com>
Subject: [PATCH bluetooth-next] drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL
Date: Fri, 11 Sep 2015 11:23:30 +0200
Message-Id: <1441963410-24844-1-git-send-email-alex.aring@gmail.com>
X-Mailer: git-send-email 2.5.1

From: Andrew Morton <akpm@linux-foundation.org>

I will shortly be sending
http://ozlabs.org/~akpm/mmots/broken-out/fs-seq_file-convert-int-seq_vprint-seq_printf-etc-returns-to-void.patch
to Linus.  This will cause the linux-next version of
drivers/net/ieee802154/at86rf230.c to break at compilation time.

Below is the fix.  I suggest you apply this immediately.

Otherwise I'll try to remember to send this in after Alexander's
890acf8330cac is merged.  But there will be a window during which the
build fails, and we'll get emails...

From: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Stefan Schmidt <stefan@osg.samsung.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 drivers/net/ieee802154/at86rf230.c | 35 ++++++++++-------------------------
 1 file changed, 10 insertions(+), 25 deletions(-)

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index b8b0628..9756e64 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1645,32 +1645,17 @@ static struct dentry *at86rf230_debugfs_root;
 static int at86rf230_stats_show(struct seq_file *file, void *offset)
 {
 	struct at86rf230_local *lp = file->private;
-	int ret;
-
-	ret = seq_printf(file, "SUCCESS:\t\t%8llu\n", lp->trac.success);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "SUCCESS_DATA_PENDING:\t%8llu\n",
-			 lp->trac.success_data_pending);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "SUCCESS_WAIT_FOR_ACK:\t%8llu\n",
-			 lp->trac.success_wait_for_ack);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "CHANNEL_ACCESS_FAILURE:\t%8llu\n",
-			 lp->trac.channel_access_failure);
-	if (ret < 0)
-		return ret;
 
-	ret = seq_printf(file, "NO_ACK:\t\t\t%8llu\n", lp->trac.no_ack);
-	if (ret < 0)
-		return ret;
-
-	return seq_printf(file, "INVALID:\t\t%8llu\n", lp->trac.invalid);
+	seq_printf(file, "SUCCESS:\t\t%8llu\n", lp->trac.success);
+	seq_printf(file, "SUCCESS_DATA_PENDING:\t%8llu\n",
+		   lp->trac.success_data_pending);
+	seq_printf(file, "SUCCESS_WAIT_FOR_ACK:\t%8llu\n",
+		   lp->trac.success_wait_for_ack);
+	seq_printf(file, "CHANNEL_ACCESS_FAILURE:\t%8llu\n",
+		   lp->trac.channel_access_failure);
+	seq_printf(file, "NO_ACK:\t\t\t%8llu\n", lp->trac.no_ack);
+	seq_printf(file, "INVALID:\t\t%8llu\n", lp->trac.invalid);
+	return 0;
 }
 
 static int at86rf230_stats_open(struct inode *inode, struct file *file)
-- 
2.5.1

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 16+ messages in thread

* linux-next: build failure after merge of the bluetooth tree
@ 2015-09-14  0:14 Stephen Rothwell
  2015-09-14  0:22 ` Stephen Rothwell
  0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2015-09-14  0:14 UTC (permalink / raw)
  To: Gustavo Padovan
  Cc: linux-next, linux-kernel, Alexander Aring, Joe Perches, Andrew Morton

Hi Gustavo,

After merging the bluetooth tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/ieee802154/at86rf230.c: In function 'at86rf230_s
tats_show':
drivers/net/ieee802154/at86rf230.c:1650:6: error: void value not ignored as it ought to be
  ret = seq_printf(file, "SUCCESS:\t\t%8llu\n", lp->trac.success);
      ^
drivers/net/ieee802154/at86rf230.c:1654:6: error: void value not ignored as it ought to be
  ret = seq_printf(file, "SUCCESS_DATA_PENDING:\t%8llu\n",
      ^
drivers/net/ieee802154/at86rf230.c:1659:6: error: void value not ignored as it ought to be
  ret = seq_printf(file, "SUCCESS_WAIT_FOR_ACK:\t%8llu\n",
      ^
drivers/net/ieee802154/at86rf230.c:1664:6: error: void value not ignored as it ought to be
  ret = seq_printf(file, "CHANNEL_ACCESS_FAILURE:\t%8llu\n",
      ^
drivers/net/ieee802154/at86rf230.c:1669:6: error: void value not ignored as it ought to be
  ret = seq_printf(file, "NO_ACK:\t\t\t%8llu\n", lp->trac.no_ack);
      ^
drivers/net/ieee802154/at86rf230.c:1673:2: error: void value not ignored as it ought to be
  return seq_printf(file, "INVALID:\t\t%8llu\n", lp->trac.invalid);
  ^
drivers/net/ieee802154/at86rf230.c:1674:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Caused by commit

  890acf8330ca ("at86rf230: add debugfs support")

interacting with commit

  6798a8caaf64 ("fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void")

from Linus' tree (as you were warned it would).

I applied the patches that Andrew has had in his post merge series
(but I think you were sent a rolled up version):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Stefan Schmidt <stefan@osg.samsung.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/net/ieee802154/at86rf230.c |   28 ++++++---------------------
 1 file changed, 7 insertions(+), 21 deletions(-)

diff -puN drivers/net/ieee802154/at86rf230.c~drivers-net-ieee802154-at86rf230c-seq_printf-now-returns-null drivers/net/ieee802154/at86rf230.c
--- a/drivers/net/ieee802154/at86rf230.c~drivers-net-ieee802154-at86rf230c-seq_printf-now-returns-null
+++ a/drivers/net/ieee802154/at86rf230.c
@@ -1647,30 +1647,16 @@ static int at86rf230_stats_show(struct s
 	struct at86rf230_local *lp = file->private;
 	int ret;
 
-	ret = seq_printf(file, "SUCCESS:\t\t%8llu\n", lp->trac.success);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "SUCCESS_DATA_PENDING:\t%8llu\n",
+	seq_printf(file, "SUCCESS:\t\t%8llu\n", lp->trac.success);
+	seq_printf(file, "SUCCESS_DATA_PENDING:\t%8llu\n",
 			 lp->trac.success_data_pending);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "SUCCESS_WAIT_FOR_ACK:\t%8llu\n",
+	seq_printf(file, "SUCCESS_WAIT_FOR_ACK:\t%8llu\n",
 			 lp->trac.success_wait_for_ack);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "CHANNEL_ACCESS_FAILURE:\t%8llu\n",
+	seq_printf(file, "CHANNEL_ACCESS_FAILURE:\t%8llu\n",
 			 lp->trac.channel_access_failure);
-	if (ret < 0)
-		return ret;
-
-	ret = seq_printf(file, "NO_ACK:\t\t\t%8llu\n", lp->trac.no_ack);
-	if (ret < 0)
-		return ret;
-
-	return seq_printf(file, "INVALID:\t\t%8llu\n", lp->trac.invalid);
+	seq_printf(file, "NO_ACK:\t\t\t%8llu\n", lp->trac.no_ack);
+	seq_printf(file, "INVALID:\t\t%8llu\n", lp->trac.invalid);
+	return 0;
 }
 
 static int at86rf230_stats_open(struct inode *inode, struct file *file)

From: Alexander Aring <alex.aring@gmail.com>
Subject: drivers-net-ieee802154-at86rf230c-seq_printf-now-returns-null-fix
Date: Fri, 11 Sep 2015 11:28:20 -0700

fix whitespace, unused var `ret'

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Stefan Schmidt <stefan@osg.samsung.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/net/ieee802154/at86rf230.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff -puN drivers/net/ieee802154/at86rf230.c~drivers-net-ieee802154-at86rf230c-seq_printf-now-returns-null-fix drivers/net/ieee802154/at86rf230.c
--- a/drivers/net/ieee802154/at86rf230.c~drivers-net-ieee802154-at86rf230c-seq_printf-now-returns-null-fix
+++ a/drivers/net/ieee802154/at86rf230.c
@@ -1645,15 +1645,14 @@ static struct dentry *at86rf230_debugfs_
 static int at86rf230_stats_show(struct seq_file *file, void *offset)
 {
 	struct at86rf230_local *lp = file->private;
-	int ret;
 
 	seq_printf(file, "SUCCESS:\t\t%8llu\n", lp->trac.success);
 	seq_printf(file, "SUCCESS_DATA_PENDING:\t%8llu\n",
-			 lp->trac.success_data_pending);
+		   lp->trac.success_data_pending);
 	seq_printf(file, "SUCCESS_WAIT_FOR_ACK:\t%8llu\n",
-			 lp->trac.success_wait_for_ack);
+		   lp->trac.success_wait_for_ack);
 	seq_printf(file, "CHANNEL_ACCESS_FAILURE:\t%8llu\n",
-			 lp->trac.channel_access_failure);
+		   lp->trac.channel_access_failure);
 	seq_printf(file, "NO_ACK:\t\t\t%8llu\n", lp->trac.no_ack);
 	seq_printf(file, "INVALID:\t\t%8llu\n", lp->trac.invalid);
 	return 0;

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 16+ messages in thread

* linux-next: build failure after merge of the bluetooth tree
@ 2015-08-12  8:01 Stephen Rothwell
  0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2015-08-12  8:01 UTC (permalink / raw)
  To: Gustavo Padovan; +Cc: linux-next, linux-kernel, Frederic Danis, Marcel Holtmann

Hi Gustavo,

After merging the bluetooth tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/bluetooth/hci_bcm.c: In function 'bcm_acpi_probe':
drivers/bluetooth/hci_bcm.c:458:2: error: implicit declaration of function 'acpi_dev_get_resources' [-Werror=implicit-function-declaration]
  acpi_dev_get_resources(adev, &resources, bcm_resource, dev);
  ^

Caused by commit

  ae056908862b ("Bluetooth: hci_bcm: Retrieve UART speed from ACPI")

This build does not have ACPI enabled.

I have added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 12 Aug 2015 17:58:00 +1000
Subject: [PATCH] Bluetooth: hci_bcm: need to depend on CONFIG_ACPI

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/bluetooth/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 0bd88c942a52..affaecab4fa6 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -147,6 +147,7 @@ config BT_HCIUART_INTEL
 config BT_HCIUART_BCM
 	bool "Broadcom protocol support"
 	depends on BT_HCIUART
+	depends on ACPI
 	select BT_HCIUART_H4
 	select BT_BCM
 	help
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: linux-next: build failure after merge of the bluetooth tree
  2014-10-27  2:19 Stephen Rothwell
@ 2014-10-28 14:49 ` Johan Hedberg
  0 siblings, 0 replies; 16+ messages in thread
From: Johan Hedberg @ 2014-10-28 14:49 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Gustavo Padovan, linux-next, linux-kernel, marcel

Hi Stephen,

On Mon, Oct 27, 2014, Stephen Rothwell wrote:
> After merging the bluetooth tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> net/bluetooth/smp.o: In function `test_smp':
> smp.c:(.init.text+0x0): multiple definition of `init_module'
> net/bluetooth/af_bluetooth.o:af_bluetooth.c:(.init.text+0x0): first defined here
> 
> Probably caused by commit 4cd3362da899 ("Bluetooth: Add skeleton for
> SMP self-tests").
> 
> I have used the bluetooth tree from next-20141023 for today.

We've applied a revert patch for the SMP self-tests to the
bluetooth-next tree until we figure out how to fix this properly.

Johan

^ permalink raw reply	[flat|nested] 16+ messages in thread

* linux-next: build failure after merge of the bluetooth tree
@ 2014-10-27  2:19 Stephen Rothwell
  2014-10-28 14:49 ` Johan Hedberg
  0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2014-10-27  2:19 UTC (permalink / raw)
  To: Gustavo Padovan; +Cc: linux-next, linux-kernel, Johan Hedberg

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Hi Gustavo,

After merging the bluetooth tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/bluetooth/smp.o: In function `test_smp':
smp.c:(.init.text+0x0): multiple definition of `init_module'
net/bluetooth/af_bluetooth.o:af_bluetooth.c:(.init.text+0x0): first defined here

Probably caused by commit 4cd3362da899 ("Bluetooth: Add skeleton for
SMP self-tests").

I have used the bluetooth tree from next-20141023 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* linux-next: build failure after merge of the bluetooth tree
@ 2012-09-19  1:45 Stephen Rothwell
  0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2012-09-19  1:45 UTC (permalink / raw)
  To: Gustavo Padovan; +Cc: linux-next, linux-kernel, Jaroslav Resler, Cho, Yu-Chen

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Hi Gustavo,

After merging the bluetooth tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/bluetooth/btusb.c:100:2: error: expected '}' before '{' token

Caused by commit 493969cf4728 ("Bluetooth: Add support for BCM20702A0
[04ca, 2003]").  That wasn't really well tested, now was it? :-(

I have used the bluetooth tree from next-20120918 for today.

BTW, why is that commit not signed off by its author?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: linux-next: build failure after merge of the bluetooth tree
  2012-02-22  1:21 Stephen Rothwell
@ 2012-02-22  1:29 ` David Miller
  0 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2012-02-22  1:29 UTC (permalink / raw)
  To: sfr; +Cc: padovan, linux-next, linux-kernel, hjl.tools, marcel, hpa

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 22 Feb 2012 12:21:09 +1100

> Hi Gustavo,
> 
> After merging the bluetooth tree, today's linux-next build
> (x86_64_allmodconfig) failed like this:
> 
> net/bluetooth/hci_sock.c: In function 'hci_sock_cmsg':
> net/bluetooth/hci_sock.c:738:8: error: 'COMPAT_USE_64BIT_TIME' undeclared (first use in this function)
> 
> Caused by commit aebb77ca6ad1 ("compat: Use COMPAT_USE_64BIT_TIME in the
> Bluetooth subsystem").  That symbol doesn't exist anywhere in linux-next ...
> 
> I have used the bluetooth from next-20120221 for today.
> 
> P.S. that commit is supposedly authored by H. J. Lu but does not contain
> a Signed-off-by from him.

That patch series was meant to go in as a group, because all of the
subsequent patches depend upon patches earlier in the series.

There is zero reason you should have applied that patch into your
bluetooth subsystem tree.  The fact that it wasn't adequately build
tested either I find quite troubling.

Lots of red cards for the bluetooth maintainers today.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* linux-next: build failure after merge of the bluetooth tree
@ 2012-02-22  1:21 Stephen Rothwell
  2012-02-22  1:29 ` David Miller
  0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2012-02-22  1:21 UTC (permalink / raw)
  To: Gustavo F. Padovan
  Cc: linux-next, linux-kernel, H. J. Lu, David S. Miller,
	Marcel Holtmann, H. Peter Anvin

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

Hi Gustavo,

After merging the bluetooth tree, today's linux-next build
(x86_64_allmodconfig) failed like this:

net/bluetooth/hci_sock.c: In function 'hci_sock_cmsg':
net/bluetooth/hci_sock.c:738:8: error: 'COMPAT_USE_64BIT_TIME' undeclared (first use in this function)

Caused by commit aebb77ca6ad1 ("compat: Use COMPAT_USE_64BIT_TIME in the
Bluetooth subsystem").  That symbol doesn't exist anywhere in linux-next ...

I have used the bluetooth from next-20120221 for today.

P.S. that commit is supposedly authored by H. J. Lu but does not contain
a Signed-off-by from him.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* linux-next: build failure after merge of the bluetooth tree
@ 2011-12-21  2:19 Stephen Rothwell
  0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2011-12-21  2:19 UTC (permalink / raw)
  To: Gustavo F. Padovan; +Cc: linux-next, linux-kernel, John W. Linville

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

Hi Gustavo,

After merging the bluetooth tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/wireless/ath/ath9k/dfs.c: In function 'ath9k_postprocess_radar_event':
drivers/net/wireless/ath/ath9k/dfs.c:73:1: error: 'ATH_DBG_ATH_DBG_DFS' undeclared (first use in this function)
drivers/net/wireless/ath/ath9k/dfs.c: In function 'ath9k_dfs_process_phyerr':
drivers/net/wireless/ath/ath9k/dfs.c:166:1: error: 'ATH_DBG_ATH_DBG_DFS' undeclared (first use in this function)

This has been inherited by the rebase onto the wireless-next tree.  I
have used the bluetooth tree from next-20111220 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: linux-next: build failure after merge of the bluetooth tree
  2011-04-28  1:41 Stephen Rothwell
@ 2011-04-28  4:12 ` Gustavo F. Padovan
  0 siblings, 0 replies; 16+ messages in thread
From: Gustavo F. Padovan @ 2011-04-28  4:12 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

Hi Stephen,

* Stephen Rothwell <sfr@canb.auug.org.au> [2011-04-28 11:41:18 +1000]:

> Hi Gustavo,
> 
> After merging the bluetooth tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> net/bluetooth/cmtp/core.c: In function 'cmtp_add_connection':
> net/bluetooth/cmtp/core.c:349: error: 'struct l2cap_pinfo' has no member named 'omtu'
> net/bluetooth/cmtp/core.c:349: error: 'struct l2cap_pinfo' has no member named 'imtu'
> net/bluetooth/hidp/core.c: In function 'hidp_add_connection':
> net/bluetooth/hidp/core.c:982: error: 'struct l2cap_pinfo' has no member named 'omtu'
> net/bluetooth/hidp/core.c:982: error: 'struct l2cap_pinfo' has no member named 'imtu'
> net/bluetooth/hidp/core.c:983: error: 'struct l2cap_pinfo' has no member named 'omtu'
> net/bluetooth/hidp/core.c:983: error: 'struct l2cap_pinfo' has no member named 'imtu'
> 
> Caused by commit 6657e8f0cc05 ("Bluetooth: Move more channel info to
> struct l2cap_chan").

Thanks for spotting this, It's fixed now.

-- 
Gustavo F. Padovan
http://profusion.mobi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* linux-next: build failure after merge of the bluetooth tree
@ 2011-04-28  1:41 Stephen Rothwell
  2011-04-28  4:12 ` Gustavo F. Padovan
  0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2011-04-28  1:41 UTC (permalink / raw)
  To: Gustavo F. Padovan; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

Hi Gustavo,

After merging the bluetooth tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/bluetooth/cmtp/core.c: In function 'cmtp_add_connection':
net/bluetooth/cmtp/core.c:349: error: 'struct l2cap_pinfo' has no member named 'omtu'
net/bluetooth/cmtp/core.c:349: error: 'struct l2cap_pinfo' has no member named 'imtu'
net/bluetooth/hidp/core.c: In function 'hidp_add_connection':
net/bluetooth/hidp/core.c:982: error: 'struct l2cap_pinfo' has no member named 'omtu'
net/bluetooth/hidp/core.c:982: error: 'struct l2cap_pinfo' has no member named 'imtu'
net/bluetooth/hidp/core.c:983: error: 'struct l2cap_pinfo' has no member named 'omtu'
net/bluetooth/hidp/core.c:983: error: 'struct l2cap_pinfo' has no member named 'imtu'

Caused by commit 6657e8f0cc05 ("Bluetooth: Move more channel info to
struct l2cap_chan").

I have used the bluetooth tree from next-20110427 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: linux-next: build failure after merge of the bluetooth tree
  2011-02-15  2:16 Stephen Rothwell
@ 2011-02-15 12:48 ` Gustavo F. Padovan
  0 siblings, 0 replies; 16+ messages in thread
From: Gustavo F. Padovan @ 2011-02-15 12:48 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

Hi Stephen,

* Stephen Rothwell <sfr@canb.auug.org.au> [2011-02-15 13:16:15 +1100]:

> Hi Gustavo,
> 
> After merging the bluetooth tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "l2cap_load" [net/bluetooth/cmtp/cmtp.ko] undefined!
> 
> Caused by commit de5b38d18ca4f3f8b8e297211c3226c2a63226fe ("Bluetooth:
> remove l2cap_load() hack").

I fixed it. Thanks for finding this, CMTP was disabled by some reason in my
kernel. 

-- 
Gustavo F. Padovan
http://profusion.mobi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* linux-next: build failure after merge of the bluetooth tree
@ 2011-02-15  2:16 Stephen Rothwell
  2011-02-15 12:48 ` Gustavo F. Padovan
  0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2011-02-15  2:16 UTC (permalink / raw)
  To: Gustavo F. Padovan; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi Gustavo,

After merging the bluetooth tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "l2cap_load" [net/bluetooth/cmtp/cmtp.ko] undefined!

Caused by commit de5b38d18ca4f3f8b8e297211c3226c2a63226fe ("Bluetooth:
remove l2cap_load() hack").

I havbe used the version of the bluetooth tree from next-20110214 for
today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, back to index

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18  0:13 linux-next: build failure after merge of the bluetooth tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2015-09-14  0:14 Stephen Rothwell
2015-09-14  0:22 ` Stephen Rothwell
2015-09-22  1:20   ` Stephen Rothwell
2015-09-22  3:42     ` David Miller
2015-08-12  8:01 Stephen Rothwell
2014-10-27  2:19 Stephen Rothwell
2014-10-28 14:49 ` Johan Hedberg
2012-09-19  1:45 Stephen Rothwell
2012-02-22  1:21 Stephen Rothwell
2012-02-22  1:29 ` David Miller
2011-12-21  2:19 Stephen Rothwell
2011-04-28  1:41 Stephen Rothwell
2011-04-28  4:12 ` Gustavo F. Padovan
2011-02-15  2:16 Stephen Rothwell
2011-02-15 12:48 ` Gustavo F. Padovan

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git