Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the block tree
@ 2019-10-18  0:51 Stephen Rothwell
  2019-10-18  0:56 ` Jens Axboe
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2019-10-18  0:51 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

Hi all,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/io_uring.c: In function 'io_accept':
fs/io_uring.c:1729:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 1729 |  addr = (struct sockaddr __user *) READ_ONCE(sqe->addr);
      |         ^
fs/io_uring.c:1730:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 1730 |  addr_len = (int __user *) READ_ONCE(sqe->addr2);
      |             ^

Introduced by commit

  d674c2b9335f ("io_uring: add support for IORING_OP_ACCEPT")

addr and addr2 are __u64 ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-10-18  0:51 linux-next: build warning after merge of the block tree Stephen Rothwell
@ 2019-10-18  0:56 ` Jens Axboe
  2019-10-18  0:59   ` Jens Axboe
  2019-10-18  3:58   ` Stephen Rothwell
  0 siblings, 2 replies; 43+ messages in thread
From: Jens Axboe @ 2019-10-18  0:56 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 10/17/19 6:51 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> fs/io_uring.c: In function 'io_accept':
> fs/io_uring.c:1729:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   1729 |  addr = (struct sockaddr __user *) READ_ONCE(sqe->addr);
>        |         ^
> fs/io_uring.c:1730:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   1730 |  addr_len = (int __user *) READ_ONCE(sqe->addr2);
>        |             ^
> 
> Introduced by commit
> 
>    d674c2b9335f ("io_uring: add support for IORING_OP_ACCEPT")
> 
> addr and addr2 are __u64 ...

I'll fix these warnings up, guessing it's 32-bit?

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-10-18  0:56 ` Jens Axboe
@ 2019-10-18  0:59   ` Jens Axboe
  2019-10-18  3:58   ` Stephen Rothwell
  1 sibling, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2019-10-18  0:59 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 10/17/19 6:56 PM, Jens Axboe wrote:
> On 10/17/19 6:51 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the block tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> fs/io_uring.c: In function 'io_accept':
>> fs/io_uring.c:1729:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>    1729 |  addr = (struct sockaddr __user *) READ_ONCE(sqe->addr);
>>         |         ^
>> fs/io_uring.c:1730:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>    1730 |  addr_len = (int __user *) READ_ONCE(sqe->addr2);
>>         |             ^
>>
>> Introduced by commit
>>
>>     d674c2b9335f ("io_uring: add support for IORING_OP_ACCEPT")
>>
>> addr and addr2 are __u64 ...
> 
> I'll fix these warnings up, guessing it's 32-bit?

Should be fixed up and pushed out now.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-10-18  0:56 ` Jens Axboe
  2019-10-18  0:59   ` Jens Axboe
@ 2019-10-18  3:58   ` Stephen Rothwell
  1 sibling, 0 replies; 43+ messages in thread
From: Stephen Rothwell @ 2019-10-18  3:58 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

Hi Jens,

On Thu, 17 Oct 2019 18:56:39 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> I'll fix these warnings up, guessing it's 32-bit?

Thanks.  Yeah 32 bit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-08-29 15:41   ` Tejun Heo
@ 2019-08-29 15:44     ` Jens Axboe
  0 siblings, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2019-08-29 15:44 UTC (permalink / raw)
  To: Tejun Heo, Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 8/29/19 9:41 AM, Tejun Heo wrote:
> On Thu, Aug 29, 2019 at 02:08:28PM +1000, Stephen Rothwell wrote:
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Thu, 29 Aug 2019 14:03:43 +1000
>> Subject: [PATCH] blkcg: blk-iocost: predeclare used structs
>>
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> 
> Thanks.
> 
>> ---
>>   include/trace/events/iocost.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
>> index ec2217dd57ac..7ecaa65b7106 100644
>> --- a/include/trace/events/iocost.h
>> +++ b/include/trace/events/iocost.h
>> @@ -2,6 +2,10 @@
>>   #undef TRACE_SYSTEM
>>   #define TRACE_SYSTEM iocost
>>   
>> +struct ioc;
>> +struct ioc_now;
>> +struct ioc_gq;
>> +
>>   #if !defined(_TRACE_BLK_IOCOST_H) || defined(TRACE_HEADER_MULTI_READ)
>>   #define _TRACE_BLK_IOCOST_H

Added, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-08-29  4:08 ` Stephen Rothwell
@ 2019-08-29 15:41   ` Tejun Heo
  2019-08-29 15:44     ` Jens Axboe
  0 siblings, 1 reply; 43+ messages in thread
From: Tejun Heo @ 2019-08-29 15:41 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jens Axboe, Linux Next Mailing List, Linux Kernel Mailing List

On Thu, Aug 29, 2019 at 02:08:28PM +1000, Stephen Rothwell wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 29 Aug 2019 14:03:43 +1000
> Subject: [PATCH] blkcg: blk-iocost: predeclare used structs
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

> ---
>  include/trace/events/iocost.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> index ec2217dd57ac..7ecaa65b7106 100644
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
> @@ -2,6 +2,10 @@
>  #undef TRACE_SYSTEM
>  #define TRACE_SYSTEM iocost
>  
> +struct ioc;
> +struct ioc_now;
> +struct ioc_gq;
> +
>  #if !defined(_TRACE_BLK_IOCOST_H) || defined(TRACE_HEADER_MULTI_READ)
>  #define _TRACE_BLK_IOCOST_H

-- 
tejun

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-08-29  3:51 Stephen Rothwell
@ 2019-08-29  4:08 ` Stephen Rothwell
  2019-08-29 15:41   ` Tejun Heo
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2019-08-29  4:08 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Tejun Heo

[-- Attachment #1: Type: text/plain, Size: 3873 bytes --]

Hi all,

On Thu, 29 Aug 2019 13:51:50 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/trace/events/iocost.h:8,
>                  from <command-line>:
> include/trace/events/iocost.h:12:57: warning: 'struct ioc_now' declared inside parameter list will not be visible outside of this definition or declaration
>   TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
>                                                          ^~~~~~~
> include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
>   static inline void trace_##name(proto)    \
>                                   ^~~~~
> include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
>   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
>                         ^~~~~~
> include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>   ^~~~~~~~~~~~~
> include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>                       ^~~~~~
> include/trace/events/iocost.h:10:1: note: in expansion of macro 'TRACE_EVENT'
>  TRACE_EVENT(iocost_iocg_activate,
>  ^~~~~~~~~~~
> include/trace/events/iocost.h:12:2: note: in expansion of macro 'TP_PROTO'
>   TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
>   ^~~~~~~~
> include/trace/events/iocost.h:12:18: warning: 'struct ioc_gq' declared inside parameter list will not be visible outside of this definition or declaration
>   TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
>                   ^~~~~~
> include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
>   static inline void trace_##name(proto)    \
>                                   ^~~~~
> include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
>   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
>                         ^~~~~~
> include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>   ^~~~~~~~~~~~~
> include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>                       ^~~~~~
> include/trace/events/iocost.h:10:1: note: in expansion of macro 'TRACE_EVENT'
>  TRACE_EVENT(iocost_iocg_activate,
>  ^~~~~~~~~~~
> include/trace/events/iocost.h:12:2: note: in expansion of macro 'TP_PROTO'
>   TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
>   ^~~~~~~~
> 
> (and many more)
> 
> Introduced by commit
> 
>   7caa47151ab2 ("blkcg: implement blk-iocost")
> 
> To get these warnings you need to build with CONFIG_HEADER_TEST and
> CONFIG_KERNEL_HEADER_TEST (and maybe CONFIG_UAPI_HEADER_TEST).
> allmodconfig does that.

I have applied this patch to linux-next for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 29 Aug 2019 14:03:43 +1000
Subject: [PATCH] blkcg: blk-iocost: predeclare used structs

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/trace/events/iocost.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
index ec2217dd57ac..7ecaa65b7106 100644
--- a/include/trace/events/iocost.h
+++ b/include/trace/events/iocost.h
@@ -2,6 +2,10 @@
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM iocost
 
+struct ioc;
+struct ioc_now;
+struct ioc_gq;
+
 #if !defined(_TRACE_BLK_IOCOST_H) || defined(TRACE_HEADER_MULTI_READ)
 #define _TRACE_BLK_IOCOST_H
 
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2019-08-29  3:51 Stephen Rothwell
  2019-08-29  4:08 ` Stephen Rothwell
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2019-08-29  3:51 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Tejun Heo

[-- Attachment #1: Type: text/plain, Size: 2896 bytes --]

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/trace/events/iocost.h:8,
                 from <command-line>:
include/trace/events/iocost.h:12:57: warning: 'struct ioc_now' declared inside parameter list will not be visible outside of this definition or declaration
  TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
                                                         ^~~~~~~
include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
  static inline void trace_##name(proto)    \
                                  ^~~~~
include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
  __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
                        ^~~~~~
include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^~~~~~~~~~~~~
include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
                      ^~~~~~
include/trace/events/iocost.h:10:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(iocost_iocg_activate,
 ^~~~~~~~~~~
include/trace/events/iocost.h:12:2: note: in expansion of macro 'TP_PROTO'
  TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
  ^~~~~~~~
include/trace/events/iocost.h:12:18: warning: 'struct ioc_gq' declared inside parameter list will not be visible outside of this definition or declaration
  TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
                  ^~~~~~
include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
  static inline void trace_##name(proto)    \
                                  ^~~~~
include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
  __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
                        ^~~~~~
include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^~~~~~~~~~~~~
include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
                      ^~~~~~
include/trace/events/iocost.h:10:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(iocost_iocg_activate,
 ^~~~~~~~~~~
include/trace/events/iocost.h:12:2: note: in expansion of macro 'TP_PROTO'
  TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
  ^~~~~~~~

(and many more)

Introduced by commit

  7caa47151ab2 ("blkcg: implement blk-iocost")

To get these warnings you need to build with CONFIG_HEADER_TEST and
CONFIG_KERNEL_HEADER_TEST (and maybe CONFIG_UAPI_HEADER_TEST).
allmodconfig does that.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-08-09  4:00 Stephen Rothwell
  2019-08-09  4:13 ` Jens Axboe
@ 2019-08-09  6:15 ` Yuehaibing
  1 sibling, 0 replies; 43+ messages in thread
From: Yuehaibing @ 2019-08-09  6:15 UTC (permalink / raw)
  To: Stephen Rothwell, Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 2019/8/9 12:00, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/lightnvm/pblk-read.c: In function 'pblk_submit_read_gc':
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable 'geo' [-Wunused-variable]
>   struct nvm_geo *geo = &dev->geo;
>                   ^~~
> 
> Introduced by commit
> 
>   ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
> 
> Removing the above line will also remove the last use of the variable
> "dev" ...

Oh, my bad, thanks!

> 


^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-08-09  4:00 Stephen Rothwell
@ 2019-08-09  4:13 ` Jens Axboe
  2019-08-09  6:15 ` Yuehaibing
  1 sibling, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2019-08-09  4:13 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, YueHaibing

On 8/8/19 9:00 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/lightnvm/pblk-read.c: In function 'pblk_submit_read_gc':
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable 'geo' [-Wunused-variable]
>    struct nvm_geo *geo = &dev->geo;
>                    ^~~
> 
> Introduced by commit
> 
>    ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
> 
> Removing the above line will also remove the last use of the variable
> "dev" ...

Thanks, will fix it up.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2019-08-09  4:00 Stephen Rothwell
  2019-08-09  4:13 ` Jens Axboe
  2019-08-09  6:15 ` Yuehaibing
  0 siblings, 2 replies; 43+ messages in thread
From: Stephen Rothwell @ 2019-08-09  4:00 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, YueHaibing

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/lightnvm/pblk-read.c: In function 'pblk_submit_read_gc':
drivers/lightnvm/pblk-read.c:421:18: warning: unused variable 'geo' [-Wunused-variable]
  struct nvm_geo *geo = &dev->geo;
                  ^~~

Introduced by commit

  ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")

Removing the above line will also remove the last use of the variable
"dev" ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-04-18 14:01       ` Jaegeuk Kim
@ 2019-04-19  1:14         ` Chao Yu
  0 siblings, 0 replies; 43+ messages in thread
From: Chao Yu @ 2019-04-19  1:14 UTC (permalink / raw)
  To: Jaegeuk Kim
  Cc: Stephen Rothwell, Jens Axboe, Linux Next Mailing List,
	Linux Kernel Mailing List, Christoph Hellwig

On 2019/4/18 22:01, Jaegeuk Kim wrote:
> On 04/18, Chao Yu wrote:
>> On 2019/4/17 22:03, Jaegeuk Kim wrote:
>>> On 04/17, Chao Yu wrote:
>>>> Hi Jaegeuk,
>>>>
>>>> On 2019/4/17 10:31, Stephen Rothwell wrote:
>>>>> Hi all,
>>>>>
>>>>> After merging the block tree, today's linux-next build (x86_64
>>>>> allmodconfig) produced this warning:
>>>>>
>>>>> fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
>>>>> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
>>>>>     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
>>>>>                                              ~~^
>>>>>                                              %llu
>>>>>     inode->i_ino, inode->i_blocks);
>>>>>                   ~~~~~~~~~~~~~~~       
>>>>
>>>> Could you please help to fix that as below in your dev branch directly?
>>>>
>>>> "Inconsistent i_blocks, ino:%lu, iblocks:%llu",
>>>
>>> We can just use "%lu"?
>>
>> We'd better follow sample in Documentation/core-api/printk-formats.rst:
>>
>> If <type> is dependent on a config option for its size (e.g., sector_t,
>> blkcnt_t) or is architecture-dependent for its size (e.g., tcflag_t), use a
>> format specifier of its largest possible type and explicitly cast to it.
> 
> Great, done. :)

Thanks, :)

> 
> Thanks,
> 
>>
>> Example::
>>
>>         printk("test: sector number/total blocks: %llu/%llu\n",
>>                 (unsigned long long)sector, (unsigned long long)blockcount);
>>
>> Thanks,
>>
>>>
>>>> inode->i_ino, (unsigned long long)inode->i_blocks)
>>>>
>>>>
>>>> It looks that we need to fix below commits as well:
>>>>
>>>> f2fs: fix to avoid panic in dec_valid_block_count()
>>>> f2fs: fix to avoid panic in dec_valid_node_count()
>>>>
>>>> Thanks,
>>>>
>>>>>
>>>>> Introduced by commit
>>>>>
>>>>>   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
>>>>>
>>>>> from the f2fs tree interacting with commit
>>>>>
>>>>>   72deb455b5ec ("block: remove CONFIG_LBDAF")
>>>>>
>>> .
>>>
> .
> 

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-04-18  0:57     ` Chao Yu
@ 2019-04-18 14:01       ` Jaegeuk Kim
  2019-04-19  1:14         ` Chao Yu
  0 siblings, 1 reply; 43+ messages in thread
From: Jaegeuk Kim @ 2019-04-18 14:01 UTC (permalink / raw)
  To: Chao Yu
  Cc: Stephen Rothwell, Jens Axboe, Linux Next Mailing List,
	Linux Kernel Mailing List, Christoph Hellwig

On 04/18, Chao Yu wrote:
> On 2019/4/17 22:03, Jaegeuk Kim wrote:
> > On 04/17, Chao Yu wrote:
> >> Hi Jaegeuk,
> >>
> >> On 2019/4/17 10:31, Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> After merging the block tree, today's linux-next build (x86_64
> >>> allmodconfig) produced this warning:
> >>>
> >>> fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
> >>> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
> >>>     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
> >>>                                              ~~^
> >>>                                              %llu
> >>>     inode->i_ino, inode->i_blocks);
> >>>                   ~~~~~~~~~~~~~~~       
> >>
> >> Could you please help to fix that as below in your dev branch directly?
> >>
> >> "Inconsistent i_blocks, ino:%lu, iblocks:%llu",
> > 
> > We can just use "%lu"?
> 
> We'd better follow sample in Documentation/core-api/printk-formats.rst:
> 
> If <type> is dependent on a config option for its size (e.g., sector_t,
> blkcnt_t) or is architecture-dependent for its size (e.g., tcflag_t), use a
> format specifier of its largest possible type and explicitly cast to it.

Great, done. :)

Thanks,

> 
> Example::
> 
>         printk("test: sector number/total blocks: %llu/%llu\n",
>                 (unsigned long long)sector, (unsigned long long)blockcount);
> 
> Thanks,
> 
> > 
> >> inode->i_ino, (unsigned long long)inode->i_blocks)
> >>
> >>
> >> It looks that we need to fix below commits as well:
> >>
> >> f2fs: fix to avoid panic in dec_valid_block_count()
> >> f2fs: fix to avoid panic in dec_valid_node_count()
> >>
> >> Thanks,
> >>
> >>>
> >>> Introduced by commit
> >>>
> >>>   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
> >>>
> >>> from the f2fs tree interacting with commit
> >>>
> >>>   72deb455b5ec ("block: remove CONFIG_LBDAF")
> >>>
> > .
> > 

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-04-17 14:03   ` Jaegeuk Kim
@ 2019-04-18  0:57     ` Chao Yu
  2019-04-18 14:01       ` Jaegeuk Kim
  0 siblings, 1 reply; 43+ messages in thread
From: Chao Yu @ 2019-04-18  0:57 UTC (permalink / raw)
  To: Jaegeuk Kim
  Cc: Stephen Rothwell, Jens Axboe, Linux Next Mailing List,
	Linux Kernel Mailing List, Christoph Hellwig

On 2019/4/17 22:03, Jaegeuk Kim wrote:
> On 04/17, Chao Yu wrote:
>> Hi Jaegeuk,
>>
>> On 2019/4/17 10:31, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the block tree, today's linux-next build (x86_64
>>> allmodconfig) produced this warning:
>>>
>>> fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
>>> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
>>>     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
>>>                                              ~~^
>>>                                              %llu
>>>     inode->i_ino, inode->i_blocks);
>>>                   ~~~~~~~~~~~~~~~       
>>
>> Could you please help to fix that as below in your dev branch directly?
>>
>> "Inconsistent i_blocks, ino:%lu, iblocks:%llu",
> 
> We can just use "%lu"?

We'd better follow sample in Documentation/core-api/printk-formats.rst:

If <type> is dependent on a config option for its size (e.g., sector_t,
blkcnt_t) or is architecture-dependent for its size (e.g., tcflag_t), use a
format specifier of its largest possible type and explicitly cast to it.

Example::

        printk("test: sector number/total blocks: %llu/%llu\n",
                (unsigned long long)sector, (unsigned long long)blockcount);

Thanks,

> 
>> inode->i_ino, (unsigned long long)inode->i_blocks)
>>
>>
>> It looks that we need to fix below commits as well:
>>
>> f2fs: fix to avoid panic in dec_valid_block_count()
>> f2fs: fix to avoid panic in dec_valid_node_count()
>>
>> Thanks,
>>
>>>
>>> Introduced by commit
>>>
>>>   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
>>>
>>> from the f2fs tree interacting with commit
>>>
>>>   72deb455b5ec ("block: remove CONFIG_LBDAF")
>>>
> .
> 

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-04-17 10:05 ` Chao Yu
@ 2019-04-17 14:03   ` Jaegeuk Kim
  2019-04-18  0:57     ` Chao Yu
  0 siblings, 1 reply; 43+ messages in thread
From: Jaegeuk Kim @ 2019-04-17 14:03 UTC (permalink / raw)
  To: Chao Yu
  Cc: Stephen Rothwell, Jens Axboe, Linux Next Mailing List,
	Linux Kernel Mailing List, Christoph Hellwig

On 04/17, Chao Yu wrote:
> Hi Jaegeuk,
> 
> On 2019/4/17 10:31, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the block tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
> > fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
> >     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
> >                                              ~~^
> >                                              %llu
> >     inode->i_ino, inode->i_blocks);
> >                   ~~~~~~~~~~~~~~~       
> 
> Could you please help to fix that as below in your dev branch directly?
> 
> "Inconsistent i_blocks, ino:%lu, iblocks:%llu",

We can just use "%lu"?

> inode->i_ino, (unsigned long long)inode->i_blocks)
> 
> 
> It looks that we need to fix below commits as well:
> 
> f2fs: fix to avoid panic in dec_valid_block_count()
> f2fs: fix to avoid panic in dec_valid_node_count()
> 
> Thanks,
> 
> > 
> > Introduced by commit
> > 
> >   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
> > 
> > from the f2fs tree interacting with commit
> > 
> >   72deb455b5ec ("block: remove CONFIG_LBDAF")
> > 

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2019-04-17  2:31 Stephen Rothwell
@ 2019-04-17 10:05 ` Chao Yu
  2019-04-17 14:03   ` Jaegeuk Kim
  0 siblings, 1 reply; 43+ messages in thread
From: Chao Yu @ 2019-04-17 10:05 UTC (permalink / raw)
  To: Stephen Rothwell, Jens Axboe, Jaegeuk Kim
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Christoph Hellwig

Hi Jaegeuk,

On 2019/4/17 10:31, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
>     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
>                                              ~~^
>                                              %llu
>     inode->i_ino, inode->i_blocks);
>                   ~~~~~~~~~~~~~~~       

Could you please help to fix that as below in your dev branch directly?

"Inconsistent i_blocks, ino:%lu, iblocks:%llu",
inode->i_ino, (unsigned long long)inode->i_blocks)


It looks that we need to fix below commits as well:

f2fs: fix to avoid panic in dec_valid_block_count()
f2fs: fix to avoid panic in dec_valid_node_count()

Thanks,

> 
> Introduced by commit
> 
>   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
> 
> from the f2fs tree interacting with commit
> 
>   72deb455b5ec ("block: remove CONFIG_LBDAF")
> 

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2019-04-17  2:31 Stephen Rothwell
  2019-04-17 10:05 ` Chao Yu
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2019-04-17  2:31 UTC (permalink / raw)
  To: Jens Axboe, Jaegeuk Kim
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Christoph Hellwig, Chao Yu

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
    "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
                                             ~~^
                                             %llu
    inode->i_ino, inode->i_blocks);
                  ~~~~~~~~~~~~~~~               

Introduced by commit

  90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")

from the f2fs tree interacting with commit

  72deb455b5ec ("block: remove CONFIG_LBDAF")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2018-11-08  3:31 Stephen Rothwell
@ 2018-11-08  4:19 ` Jens Axboe
  0 siblings, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2018-11-08  4:19 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Hannes Reinecke, Ming Lei, Omar Sandoval, David Miller

On 11/7/18 8:31 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> After merging the block tree, today's linux-next build (sparc64 defconfig)
> produced this warning:
> 
> /home/sfr/next/next/drivers/block/sunvdc.c: In function 'init_queue':
> /home/sfr/next/next/drivers/block/sunvdc.c:788:6: warning: unused variable 'ret' [-Wunused-variable]
>   int ret;
>       ^~~
> 
> Introduced by commit
> 
>   fa182a1fa97d ("sunvdc: convert to blk-mq")

Thanks, leftover from v2 of the conversion that switched to the
sq init queue helper. I'll fix it.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2018-11-08  3:31 Stephen Rothwell
  2018-11-08  4:19 ` Jens Axboe
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2018-11-08  3:31 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Hannes Reinecke, Ming Lei, Omar Sandoval, David Miller

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (sparc64 defconfig)
produced this warning:

/home/sfr/next/next/drivers/block/sunvdc.c: In function 'init_queue':
/home/sfr/next/next/drivers/block/sunvdc.c:788:6: warning: unused variable 'ret' [-Wunused-variable]
  int ret;
      ^~~

Introduced by commit

  fa182a1fa97d ("sunvdc: convert to blk-mq")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2018-09-28  6:43 ` Omar Sandoval
@ 2018-09-28 14:26   ` Jens Axboe
  0 siblings, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2018-09-28 14:26 UTC (permalink / raw)
  To: Omar Sandoval, Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Omar Sandoval

On 9/28/18 12:43 AM, Omar Sandoval wrote:
> On Fri, Sep 28, 2018 at 11:11:24AM +1000, Stephen Rothwell wrote:
>> Hi Jens,
>>
>> After merging the block tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> block/kyber-iosched.c:84:22: warning: integer overflow in expression of type 'long int' results in '705032704' [-Woverflow]
>>   [KYBER_DISCARD] = 5 * NSEC_PER_SEC,
>>                       ^
>>
>> Introduced by commit
>>
>>   6e25cb01ea20 ("kyber: implement improved heuristics")
> 
> Ugh, thanks for the report. This should fix it:
> 
> diff --git a/block/kyber-iosched.c b/block/kyber-iosched.c
> index 2b62e362fb36..eccac01a10b6 100644
> --- a/block/kyber-iosched.c
> +++ b/block/kyber-iosched.c
> @@ -79,9 +79,9 @@ static const unsigned int kyber_depth[] = {
>   * Default latency targets for each scheduling domain.
>   */
>  static const u64 kyber_latency_targets[] = {
> -	[KYBER_READ] = 2 * NSEC_PER_MSEC,
> -	[KYBER_WRITE] = 10 * NSEC_PER_MSEC,
> -	[KYBER_DISCARD] = 5 * NSEC_PER_SEC,
> +	[KYBER_READ] = 2ULL * NSEC_PER_MSEC,
> +	[KYBER_WRITE] = 10ULL * NSEC_PER_MSEC,
> +	[KYBER_DISCARD] = 5ULL * NSEC_PER_SEC,
>  };
>  
>  /*
> 
> Jens, do you mind folding that in, or should I send it separately?

It's already applied, so please send it in separately. We only
really need it for the last one, NSEC_PER_SEC, but I agree let's do
all just in case it's changed later.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2018-09-28  1:11 Stephen Rothwell
@ 2018-09-28  6:43 ` Omar Sandoval
  2018-09-28 14:26   ` Jens Axboe
  0 siblings, 1 reply; 43+ messages in thread
From: Omar Sandoval @ 2018-09-28  6:43 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jens Axboe, Linux-Next Mailing List, Linux Kernel Mailing List,
	Omar Sandoval

On Fri, Sep 28, 2018 at 11:11:24AM +1000, Stephen Rothwell wrote:
> Hi Jens,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> block/kyber-iosched.c:84:22: warning: integer overflow in expression of type 'long int' results in '705032704' [-Woverflow]
>   [KYBER_DISCARD] = 5 * NSEC_PER_SEC,
>                       ^
> 
> Introduced by commit
> 
>   6e25cb01ea20 ("kyber: implement improved heuristics")

Ugh, thanks for the report. This should fix it:

diff --git a/block/kyber-iosched.c b/block/kyber-iosched.c
index 2b62e362fb36..eccac01a10b6 100644
--- a/block/kyber-iosched.c
+++ b/block/kyber-iosched.c
@@ -79,9 +79,9 @@ static const unsigned int kyber_depth[] = {
  * Default latency targets for each scheduling domain.
  */
 static const u64 kyber_latency_targets[] = {
-	[KYBER_READ] = 2 * NSEC_PER_MSEC,
-	[KYBER_WRITE] = 10 * NSEC_PER_MSEC,
-	[KYBER_DISCARD] = 5 * NSEC_PER_SEC,
+	[KYBER_READ] = 2ULL * NSEC_PER_MSEC,
+	[KYBER_WRITE] = 10ULL * NSEC_PER_MSEC,
+	[KYBER_DISCARD] = 5ULL * NSEC_PER_SEC,
 };
 
 /*

Jens, do you mind folding that in, or should I send it separately?

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2018-09-28  1:11 Stephen Rothwell
  2018-09-28  6:43 ` Omar Sandoval
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2018-09-28  1:11 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Omar Sandoval

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

block/kyber-iosched.c:84:22: warning: integer overflow in expression of type 'long int' results in '705032704' [-Woverflow]
  [KYBER_DISCARD] = 5 * NSEC_PER_SEC,
                      ^

Introduced by commit

  6e25cb01ea20 ("kyber: implement improved heuristics")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2018-05-31  3:49 Stephen Rothwell
  0 siblings, 0 replies; 43+ messages in thread
From: Stephen Rothwell @ 2018-05-31  3:49 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Kees Cook

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/md/md.c: In function 'mddev_put':
drivers/md/md.c:543:1: warning: the frame size of 2080 bytes is larger than 2048 bytes [-Wframe-larger-than=]
 }
 ^

This is caused because CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL is now
switched on.  Hopefully Kees (cc'd) can procide some guidance on how to
eliminate this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2018-05-14  8:29 ` Christoph Hellwig
@ 2018-05-14 14:31   ` Jens Axboe
  0 siblings, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2018-05-14 14:31 UTC (permalink / raw)
  To: Christoph Hellwig, Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

On 5/14/18 2:29 AM, Christoph Hellwig wrote:
> On Mon, May 14, 2018 at 12:51:39PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the block tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
> 
> The look entirely correct, but oddly enough my compiler did not bother
> to warn.

Applied, thanks.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2018-05-14  2:51 Stephen Rothwell
@ 2018-05-14  8:29 ` Christoph Hellwig
  2018-05-14 14:31   ` Jens Axboe
  0 siblings, 1 reply; 43+ messages in thread
From: Christoph Hellwig @ 2018-05-14  8:29 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jens Axboe, Linux-Next Mailing List, Linux Kernel Mailing List,
	Christoph Hellwig

On Mon, May 14, 2018 at 12:51:39PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:

The look entirely correct, but oddly enough my compiler did not bother
to warn.

Fix below:

--
>From 6610bd5bbbf05fa1d925b0601a09e84cada9e0a2 Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <hch@lst.de>
Date: Mon, 14 May 2018 10:24:34 +0200
Subject: memstick: remove unused variables

Fixes: 7c2d748e8476 ("memstick: don't call blk_queue_bounce_limit")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/memstick/core/ms_block.c    | 1 -
 drivers/memstick/core/mspro_block.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
index b2d025f42d14..a15181fa45f7 100644
--- a/drivers/memstick/core/ms_block.c
+++ b/drivers/memstick/core/ms_block.c
@@ -2094,7 +2094,6 @@ static const struct block_device_operations msb_bdops = {
 static int msb_init_disk(struct memstick_dev *card)
 {
 	struct msb_data *msb = memstick_get_drvdata(card);
-	struct memstick_host *host = card->host;
 	int rc;
 	unsigned long capacity;
 
diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
index a2fadc605750..5ee932631fae 100644
--- a/drivers/memstick/core/mspro_block.c
+++ b/drivers/memstick/core/mspro_block.c
@@ -1170,7 +1170,6 @@ static int mspro_block_init_card(struct memstick_dev *card)
 static int mspro_block_init_disk(struct memstick_dev *card)
 {
 	struct mspro_block_data *msb = memstick_get_drvdata(card);
-	struct memstick_host *host = card->host;
 	struct mspro_devinfo *dev_info = NULL;
 	struct mspro_sys_info *sys_info = NULL;
 	struct mspro_sys_attr *s_attr = NULL;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2018-05-14  2:51 Stephen Rothwell
  2018-05-14  8:29 ` Christoph Hellwig
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2018-05-14  2:51 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Christoph Hellwig

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/memstick/core/mspro_block.c: In function 'mspro_block_init_disk':
drivers/memstick/core/mspro_block.c:1173:24: warning: unused variable 'host' [-Wunused-variable]
  struct memstick_host *host = card->host;
                        ^~~~
drivers/memstick/core/ms_block.c: In function 'msb_init_disk':
drivers/memstick/core/ms_block.c:2097:24: warning: unused variable 'host' [-Wunused-variable]
  struct memstick_host *host = card->host;
                        ^~~~

Introduced by commit

  7c2d748e8476 ("memstick: don't call blk_queue_bounce_limit")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2017-05-10  3:00   ` Jens Axboe
@ 2017-05-10  6:19     ` Markus Trippelsdorf
  0 siblings, 0 replies; 43+ messages in thread
From: Markus Trippelsdorf @ 2017-05-10  6:19 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Stephen Rothwell, Linux-Next Mailing List,
	Linux Kernel Mailing List, Bart Van Assche

On 2017.05.09 at 21:00 -0600, Jens Axboe wrote:
> On 05/09/2017 08:20 PM, Markus Trippelsdorf wrote:
> > On 2017.05.10 at 11:24 +1000, Stephen Rothwell wrote:
> >> Hi Jens,
> >>
> >> After merging the block tree, today's linux-next build (arm
> >> multi_v7_defconfig) produced this warning:
> >>
> >> block/elevator.c: In function 'elv_iosched_store':
> >> block/elevator.c:1102:2: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result [-Wunused-result]
> >>   strstrip(elevator_name);
> >>   ^
> >>
> >> Introduced by commit
> >>
> >>   d0f6e2da5871 ("block: Remove leading whitespace and trailing newline in elevator switch error message")
> > 
> > Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
> > unfortunately removed both warnings, so the following patch should now
> > be enough:
> > 
> > diff --git a/block/elevator.c b/block/elevator.c
> > index fda6be933130..dd0ed19e4fb7 100644
> > --- a/block/elevator.c
> > +++ b/block/elevator.c
> > @@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
> >  		return count;
> >  
> >  	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
> > -	strstrip(elevator_name);
> > -	ret = __elevator_change(q, elevator_name);
> > +	ret = __elevator_change(q, strstrip(elevator_name));
> >  	if (!ret)
> >  		return count;
> 
> Care to send that as a proper patch? I don't see that warning here, fwiw.

I don't see it either. But no, I don't want to send a proper patch.
Please just drop my original patch (d0f6e2da5871), because its only
reason was to improve the two debug printks that you have removed later.

-- 
Markus

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2017-05-10  2:20 ` Markus Trippelsdorf
  2017-05-10  3:00   ` Jens Axboe
@ 2017-05-10  3:26   ` Stephen Rothwell
  1 sibling, 0 replies; 43+ messages in thread
From: Stephen Rothwell @ 2017-05-10  3:26 UTC (permalink / raw)
  To: Markus Trippelsdorf
  Cc: Jens Axboe, Linux-Next Mailing List, Linux Kernel Mailing List,
	Bart Van Assche

Hi Markus,

On Wed, 10 May 2017 04:20:54 +0200 Markus Trippelsdorf <markus@trippelsdorf.de> wrote:
>
> Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
> unfortunately removed both warnings, so the following patch should now
> be enough:
> 
> diff --git a/block/elevator.c b/block/elevator.c
> index fda6be933130..dd0ed19e4fb7 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
>  		return count;
>  
>  	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
> -	strstrip(elevator_name);
> -	ret = __elevator_change(q, elevator_name);
> +	ret = __elevator_change(q, strstrip(elevator_name));
>  	if (!ret)
>  		return count;

I think you (or someone) needs to do a proper patch submission to Jens,
please.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2017-05-10  2:20 ` Markus Trippelsdorf
@ 2017-05-10  3:00   ` Jens Axboe
  2017-05-10  6:19     ` Markus Trippelsdorf
  2017-05-10  3:26   ` Stephen Rothwell
  1 sibling, 1 reply; 43+ messages in thread
From: Jens Axboe @ 2017-05-10  3:00 UTC (permalink / raw)
  To: Markus Trippelsdorf, Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Bart Van Assche

On 05/09/2017 08:20 PM, Markus Trippelsdorf wrote:
> On 2017.05.10 at 11:24 +1000, Stephen Rothwell wrote:
>> Hi Jens,
>>
>> After merging the block tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> block/elevator.c: In function 'elv_iosched_store':
>> block/elevator.c:1102:2: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result [-Wunused-result]
>>   strstrip(elevator_name);
>>   ^
>>
>> Introduced by commit
>>
>>   d0f6e2da5871 ("block: Remove leading whitespace and trailing newline in elevator switch error message")
> 
> Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
> unfortunately removed both warnings, so the following patch should now
> be enough:
> 
> diff --git a/block/elevator.c b/block/elevator.c
> index fda6be933130..dd0ed19e4fb7 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
>  		return count;
>  
>  	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
> -	strstrip(elevator_name);
> -	ret = __elevator_change(q, elevator_name);
> +	ret = __elevator_change(q, strstrip(elevator_name));
>  	if (!ret)
>  		return count;

Care to send that as a proper patch? I don't see that warning here, fwiw.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2017-05-10  1:24 Stephen Rothwell
@ 2017-05-10  2:20 ` Markus Trippelsdorf
  2017-05-10  3:00   ` Jens Axboe
  2017-05-10  3:26   ` Stephen Rothwell
  0 siblings, 2 replies; 43+ messages in thread
From: Markus Trippelsdorf @ 2017-05-10  2:20 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jens Axboe, Linux-Next Mailing List, Linux Kernel Mailing List,
	Bart Van Assche

On 2017.05.10 at 11:24 +1000, Stephen Rothwell wrote:
> Hi Jens,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> block/elevator.c: In function 'elv_iosched_store':
> block/elevator.c:1102:2: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result [-Wunused-result]
>   strstrip(elevator_name);
>   ^
> 
> Introduced by commit
> 
>   d0f6e2da5871 ("block: Remove leading whitespace and trailing newline in elevator switch error message")

Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
unfortunately removed both warnings, so the following patch should now
be enough:

diff --git a/block/elevator.c b/block/elevator.c
index fda6be933130..dd0ed19e4fb7 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
 		return count;
 
 	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
-	strstrip(elevator_name);
-	ret = __elevator_change(q, elevator_name);
+	ret = __elevator_change(q, strstrip(elevator_name));
 	if (!ret)
 		return count;
 
-- 
Markus

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2017-05-10  1:24 Stephen Rothwell
  2017-05-10  2:20 ` Markus Trippelsdorf
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2017-05-10  1:24 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Markus Trippelsdorf, Bart Van Assche

Hi Jens,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

block/elevator.c: In function 'elv_iosched_store':
block/elevator.c:1102:2: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result [-Wunused-result]
  strstrip(elevator_name);
  ^

Introduced by commit

  d0f6e2da5871 ("block: Remove leading whitespace and trailing newline in elevator switch error message")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2014-10-23  1:28 Stephen Rothwell
@ 2014-10-23  2:14 ` Jens Axboe
  0 siblings, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2014-10-23  2:14 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Jan Kara

On 2014-10-22 19:28, Stephen Rothwell wrote:
> Hi Jens,
>
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> block/scsi_ioctl.c: In function 'sg_scsi_ioctl':
> block/scsi_ioctl.c:520:1: warning: label 'out' defined but not used [-Wunused-label]
>   out:
>   ^

Fixed up, thanks.


-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2014-10-23  1:28 Stephen Rothwell
  2014-10-23  2:14 ` Jens Axboe
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2014-10-23  1:28 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-next, linux-kernel, Jan Kara

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

block/scsi_ioctl.c: In function 'sg_scsi_ioctl':
block/scsi_ioctl.c:520:1: warning: label 'out' defined but not used [-Wunused-label]
 out:
 ^

Introduced by commit 374f8fdea4aa ("scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2013-09-23  4:29 Stephen Rothwell
  0 siblings, 0 replies; 43+ messages in thread
From: Stephen Rothwell @ 2013-09-23  4:29 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-next, linux-kernel, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/kernel.h:13:0,
                 from drivers/block/skd_main.c:19:
drivers/block/skd_main.c: In function 'skd_cons_skmsg':
drivers/block/skd_main.c:4562:33: warning: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'long unsigned int' [-Wformat=]
   (unsigned long) sizeof(struct skd_fitmsg_context) *
                                 ^
include/linux/printk.h:216:33: note: in definition of macro 'pr_err'
  printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
                                 ^
drivers/block/skd_main.c:4559:2: note: in expansion of macro 'VPRINTK'
  VPRINTK(skdev, "skmsg_table kzalloc, struct %u, count %u total %lu\n",
  ^

and several more.

Introduced by commit 0e2c4a3a6c0c ("drivers/block/skd_main.c: fix a few
things, disable on 32-bit"). sizeof() needs %zu to print, right?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2011-05-09  5:55 ` Tao Ma
@ 2011-05-09  6:34   ` Jens Axboe
  0 siblings, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2011-05-09  6:34 UTC (permalink / raw)
  To: Tao Ma; +Cc: linux-next, linux-kernel

On 2011-05-09 07:55, Tao Ma wrote:
> Hi Jens,
> 
> Sorry for the trouble. Here is the fix.

Already fixed it up, we don't need a cast at all.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2011-05-09  3:49 Stephen Rothwell
@ 2011-05-09  5:55 ` Tao Ma
  2011-05-09  6:34   ` Jens Axboe
  0 siblings, 1 reply; 43+ messages in thread
From: Tao Ma @ 2011-05-09  5:55 UTC (permalink / raw)
  To: axboe; +Cc: linux-next, linux-kernel

Hi Jens,

Sorry for the trouble. Here is the fix.

>From 60bf0c0972c0d0d237e30e1f1c79356f4aefa138 Mon Sep 17 00:00:00 2001
From: Tao Ma <boyu.mt@taobao.com>
Date: Mon, 9 May 2011 13:39:49 +0800
Subject: [PATCH] block: Change wrong type cast in part_discard_alignment_show.

Use 'unsigned int' instead of 'unsigned long long' introduced by commit
"block: Remove extra discard_alignment from hd_struct".

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 fs/partitions/check.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index b7e16bc..b2bae85 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -258,7 +258,7 @@ ssize_t part_discard_alignment_show(struct device *dev,
 	struct gendisk *disk = dev_to_disk(dev);
 
 	return sprintf(buf, "%u\n",
-		       (unsigned long long)queue_limit_discard_alignment(
+		       (unsigned int)queue_limit_discard_alignment(
 							&disk->queue->limits,
 							p->start_sect));
 }
-- 
1.7.4

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2011-05-09  3:49 Stephen Rothwell
  2011-05-09  5:55 ` Tao Ma
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2011-05-09  3:49 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-next, linux-kernel, Tao Ma

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/partitions/check.c: In function 'part_discard_alignment_show':
fs/partitions/check.c:263: warning: format '%u' expects type 'unsigned int', but argument 3 has type 'long long unsigned int'

Introduced by commit  ("block: Remove extra discard_alignment from
hd_struct")
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2010-12-20  4:42 ` Stephen Rothwell
@ 2010-12-20  8:12   ` Jens Axboe
  0 siblings, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2010-12-20  8:12 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Michał Mirosław

On 2010-12-20 05:42, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Mon, 20 Dec 2010 15:31:27 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the block tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> drivers/block/loop.c: In function 'lo_splice_actor':
>> drivers/block/loop.c:398: warning: unused variable 'ret'
>>
>> Introduced by commit a8adbe378b56acd5945df70753c7e8f6fe223304
>> ("fs/splice: Pull buf->ops->confirm() from splice_from_pipe actors").
> 
> Also:
> 
> fs/nfsd/vfs.c: In function 'nfsd_splice_actor':
> fs/nfsd/vfs.c:848: warning: unused variable 'ret'

Hrmpf, that's not very nice. I'll add a fixup patch, thanks Stephen.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2010-12-20  4:31 Stephen Rothwell
@ 2010-12-20  4:42 ` Stephen Rothwell
  2010-12-20  8:12   ` Jens Axboe
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2010-12-20  4:42 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-next, linux-kernel, \"Michał Mirosław\

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Hi Jens,

On Mon, 20 Dec 2010 15:31:27 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the block tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/block/loop.c: In function 'lo_splice_actor':
> drivers/block/loop.c:398: warning: unused variable 'ret'
> 
> Introduced by commit a8adbe378b56acd5945df70753c7e8f6fe223304
> ("fs/splice: Pull buf->ops->confirm() from splice_from_pipe actors").

Also:

fs/nfsd/vfs.c: In function 'nfsd_splice_actor':
fs/nfsd/vfs.c:848: warning: unused variable 'ret'

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2010-12-20  4:31 Stephen Rothwell
  2010-12-20  4:42 ` Stephen Rothwell
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2010-12-20  4:31 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-next, linux-kernel, \"Michał Mirosław\

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/block/loop.c: In function 'lo_splice_actor':
drivers/block/loop.c:398: warning: unused variable 'ret'

Introduced by commit a8adbe378b56acd5945df70753c7e8f6fe223304
("fs/splice: Pull buf->ops->confirm() from splice_from_pipe actors").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2010-09-16  3:30 Stephen Rothwell
  0 siblings, 0 replies; 43+ messages in thread
From: Stephen Rothwell @ 2010-09-16  3:30 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-next, linux-kernel, Namhyung Kim

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/sg.c: In function 'sg_start_req':
drivers/scsi/sg.c:1660: warning: passing argument 2 of 'blk_rq_aligned' makes integer from pointer without a cast
include/linux/blkdev.h:1045: note: expected 'long unsigned int' but argument is of type 'void *'

Introduced by commit 144177991ca624841ddbd1e7edff958fc0f6d1fe ("block:
fix an address space warning in blk-map.c").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: linux-next: build warning after merge of the block tree
  2010-04-29  6:14 Stephen Rothwell
@ 2010-04-29  7:28 ` Jens Axboe
  0 siblings, 0 replies; 43+ messages in thread
From: Jens Axboe @ 2010-04-29  7:28 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Dmitry Monakhov

On Thu, Apr 29 2010, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the block tree, today's linux-next build (powerpc
> ppc44x_defconfig) produced this warning:
> 
> block/blk-lib.c: In function 'blkdev_issue_zeroout':
> block/blk-lib.c:190: warning: comparison of distinct pointer types lacks a cast
> 
> Introduced by commit 3f14d792f9a8fede64ce918dbb517f934497a4f8 ("blkdev:
> add blkdev_issue_zeroout helper function").

I fixed that warning up.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 43+ messages in thread

* linux-next: build warning after merge of the block tree
@ 2010-04-29  6:14 Stephen Rothwell
  2010-04-29  7:28 ` Jens Axboe
  0 siblings, 1 reply; 43+ messages in thread
From: Stephen Rothwell @ 2010-04-29  6:14 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-next, linux-kernel, Dmitry Monakhov

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hi James,

After merging the block tree, today's linux-next build (powerpc
ppc44x_defconfig) produced this warning:

block/blk-lib.c: In function 'blkdev_issue_zeroout':
block/blk-lib.c:190: warning: comparison of distinct pointer types lacks a cast

Introduced by commit 3f14d792f9a8fede64ce918dbb517f934497a4f8 ("blkdev:
add blkdev_issue_zeroout helper function").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

end of thread, back to index

Thread overview: 43+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18  0:51 linux-next: build warning after merge of the block tree Stephen Rothwell
2019-10-18  0:56 ` Jens Axboe
2019-10-18  0:59   ` Jens Axboe
2019-10-18  3:58   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2019-08-29  3:51 Stephen Rothwell
2019-08-29  4:08 ` Stephen Rothwell
2019-08-29 15:41   ` Tejun Heo
2019-08-29 15:44     ` Jens Axboe
2019-08-09  4:00 Stephen Rothwell
2019-08-09  4:13 ` Jens Axboe
2019-08-09  6:15 ` Yuehaibing
2019-04-17  2:31 Stephen Rothwell
2019-04-17 10:05 ` Chao Yu
2019-04-17 14:03   ` Jaegeuk Kim
2019-04-18  0:57     ` Chao Yu
2019-04-18 14:01       ` Jaegeuk Kim
2019-04-19  1:14         ` Chao Yu
2018-11-08  3:31 Stephen Rothwell
2018-11-08  4:19 ` Jens Axboe
2018-09-28  1:11 Stephen Rothwell
2018-09-28  6:43 ` Omar Sandoval
2018-09-28 14:26   ` Jens Axboe
2018-05-31  3:49 Stephen Rothwell
2018-05-14  2:51 Stephen Rothwell
2018-05-14  8:29 ` Christoph Hellwig
2018-05-14 14:31   ` Jens Axboe
2017-05-10  1:24 Stephen Rothwell
2017-05-10  2:20 ` Markus Trippelsdorf
2017-05-10  3:00   ` Jens Axboe
2017-05-10  6:19     ` Markus Trippelsdorf
2017-05-10  3:26   ` Stephen Rothwell
2014-10-23  1:28 Stephen Rothwell
2014-10-23  2:14 ` Jens Axboe
2013-09-23  4:29 Stephen Rothwell
2011-05-09  3:49 Stephen Rothwell
2011-05-09  5:55 ` Tao Ma
2011-05-09  6:34   ` Jens Axboe
2010-12-20  4:31 Stephen Rothwell
2010-12-20  4:42 ` Stephen Rothwell
2010-12-20  8:12   ` Jens Axboe
2010-09-16  3:30 Stephen Rothwell
2010-04-29  6:14 Stephen Rothwell
2010-04-29  7:28 ` Jens Axboe

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git