From: Christian Brauner <christian.brauner@ubuntu.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
linux@rasmusvillemoes.dk, cyphar@cyphar.com,
keescook@chromium.org
Subject: Re: linux-next: Tree for Oct 18 (objtool)
Date: Mon, 21 Oct 2019 21:36:53 +0200 [thread overview]
Message-ID: <20191021193652.lfccehm37dkkofp7@wittgenstein> (raw)
In-Reply-To: <20191021134759.GG1800@hirez.programming.kicks-ass.net>
On Mon, Oct 21, 2019 at 03:47:59PM +0200, Peter Zijlstra wrote:
> On Mon, Oct 21, 2019 at 03:19:48PM +0200, Christian Brauner wrote:
> > On Mon, Oct 21, 2019 at 03:11:49PM +0200, Peter Zijlstra wrote:
>
> > > By popular request; here's that alternative. Completely untested :-)
> >
> > Am I not getting some mails? :)
>
> You're not on the 'right' IRC channels :-)
Well, we saw that that wasn't true today. :)
>
> > I prefer this one as it allows us to avoid working around this in
> > usercopy.c. Should especially make if this potentially helps in other
> > cases as well?
>
> That was Josh's argument too.
>
> Personally I think GCC is being a moron here, because with value range
> analysis it should be able to prove the shift-UB cannot happen (the <
> sizeof(unsigned long) conditions on both), but alas, it emits the UBSAN
> calls anyway.
Ok, so I take it you route that patch somehwere through tip?
I'm happy with the ubsan fix:
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
next prev parent reply other threads:[~2019-10-21 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 7:03 linux-next: Tree for Oct 18 Stephen Rothwell
2019-10-18 15:33 ` linux-next: Tree for Oct 18 (objtool) Randy Dunlap
2019-10-21 12:35 ` Peter Zijlstra
2019-10-21 13:11 ` Peter Zijlstra
2019-10-21 13:19 ` Christian Brauner
2019-10-21 13:47 ` Peter Zijlstra
2019-10-21 19:36 ` Christian Brauner [this message]
2019-10-22 7:40 ` Peter Zijlstra
2019-10-22 8:02 ` Christian Brauner
2019-10-21 15:59 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021193652.lfccehm37dkkofp7@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=cyphar@cyphar.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).