Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tags need some work in the tip tree
@ 2019-10-22 20:16 Stephen Rothwell
  2019-10-22 20:30 ` Thomas Hellstrom
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2019-10-22 20:16 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Thomas Hellstrom

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

Hi all,

n commit

  6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro")

Fixes tag

  Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

In commit

  db633a4e0e6e ("x86/cpu/vmware: Use the full form of INL in VMWARE_HYPERCALL, for clang/llvm")

Fixes tag

  Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: Fixes tags need some work in the tip tree
  2019-10-22 20:16 linux-next: Fixes tags need some work in the tip tree Stephen Rothwell
@ 2019-10-22 20:30 ` Thomas Hellstrom
  2019-10-23 10:16   ` Ingo Molnar
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Hellstrom @ 2019-10-22 20:30 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Stephen Rothwell, Thomas Gleixner, H. Peter Anvin,
	Peter Zijlstra, Linux Next Mailing List,
	Linux Kernel Mailing List

On 10/22/19 10:17 PM, Stephen Rothwell wrote:
> Hi all,
>
> n commit
>
>   6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro")
>
> Fixes tag
>
>   Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")

The cited subject is missing a leading "x86/vmware:". Ingo, please let
me know if you want me to respin those.

Thanks,

Thomas



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: Fixes tags need some work in the tip tree
  2019-10-22 20:30 ` Thomas Hellstrom
@ 2019-10-23 10:16   ` Ingo Molnar
  0 siblings, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2019-10-23 10:16 UTC (permalink / raw)
  To: Thomas Hellstrom
  Cc: Ingo Molnar, Stephen Rothwell, Thomas Gleixner, H. Peter Anvin,
	Peter Zijlstra, Linux Next Mailing List,
	Linux Kernel Mailing List


* Thomas Hellstrom <thellstrom@vmware.com> wrote:

> On 10/22/19 10:17 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > n commit
> >
> >   6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro")
> >
> > Fixes tag
> >
> >   Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")
> 
> The cited subject is missing a leading "x86/vmware:". Ingo, please let
> me know if you want me to respin those.

Those who are picking it up for a backport will go by the sha1, while 
humans reading it are fine without the prefix, I think this is OK as-is.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: Fixes tags need some work in the tip tree
  2019-11-05 11:18 Stephen Rothwell
@ 2019-11-05 11:52 ` Thomas Gleixner
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Gleixner @ 2019-11-05 11:52 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
	Linux Next Mailing List, Linux Kernel Mailing List, Jan Beulich,
	Fabien Parent, Daniel Lezcano

On Tue, 5 Nov 2019, Stephen Rothwell wrote:
> In commit
> 
>   fe6f85ca121e ("x86/apic/32: Avoid bogus LDR warnings")
> 
> Fixes tag
> 
>   Fixes: bae3a8d3308 ("x86/apic: Do not initialize LDR and DFR for bigsmp")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Yes. I missed that one when applying the patch which had the fixes tag
already inside. Will add a check for that to catch future ones.

Jan, please adjust your git settings.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* linux-next: Fixes tags need some work in the tip tree
@ 2019-11-05 11:18 Stephen Rothwell
  2019-11-05 11:52 ` Thomas Gleixner
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2019-11-05 11:18 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jan Beulich,
	Fabien Parent, Daniel Lezcano

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Hi all,

In commit

  fe6f85ca121e ("x86/apic/32: Avoid bogus LDR warnings")

Fixes tag

  Fixes: bae3a8d3308 ("x86/apic: Do not initialize LDR and DFR for bigsmp")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

In commit

  41d49e7939de ("clocksource/drivers/mediatek: Fix error handling")

Fixes tag

  Fixes: a0858f937960 ("mediatek: Convert the driver to timer-of")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 20:16 linux-next: Fixes tags need some work in the tip tree Stephen Rothwell
2019-10-22 20:30 ` Thomas Hellstrom
2019-10-23 10:16   ` Ingo Molnar
2019-11-05 11:18 Stephen Rothwell
2019-11-05 11:52 ` Thomas Gleixner

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git