Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the sound-asoc tree
@ 2019-10-22 23:45 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2019-10-22 23:45 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ben Zhang

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/rt5677-spi.c: In function 'rt5677_spi_pcm_close':
sound/soc/codecs/rt5677-spi.c:114:30: warning: unused variable 'rtd' [-Wunused-variable]
  114 |  struct snd_soc_pcm_runtime *rtd = substream->private_data;
      |                              ^~~

Introduced by commit

  a0e0d135427c ("ASoC: rt5677: Add a PCM device for streaming hotword via SPI")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2019-10-07 23:58 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2019-10-07 23:58 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Stephen Boyd

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/jz4740/jz4740-i2s.c: In function 'jz4740_i2s_dev_probe':
sound/soc/jz4740/jz4740-i2s.c:500:29: warning: unused variable 'match' [-Wunused-variable]
  500 |  const struct of_device_id *match;
      |                             ^~~~~

Introduced by commit

  67ad656bdd70 ("ASoC: jz4740: Use of_device_get_match_data()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2019-04-26  3:05 Stephen Rothwell
@ 2019-04-26  3:14 ` Nicolin Chen
  0 siblings, 0 replies; 45+ messages in thread
From: Nicolin Chen @ 2019-04-26  3:14 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Daniel Baluta, Shengjiu Wang

On Fri, Apr 26, 2019 at 01:05:49PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/soc/fsl/fsl_sai.c: In function 'fsl_sai_remove':
> sound/soc/fsl/fsl_sai.c:921:1: warning: no return statement in function returning non-void [-Wreturn-type]
>  }
>  ^
> 
> Introduced by commit
> 
>   812ad463e089 ("ASoC: fsl_sai: Add support for runtime pm")

Thanks. I am submitting a fix.

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2019-04-26  3:05 Stephen Rothwell
  2019-04-26  3:14 ` Nicolin Chen
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2019-04-26  3:05 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Daniel Baluta, Shengjiu Wang, Nicolin Chen

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/fsl/fsl_sai.c: In function 'fsl_sai_remove':
sound/soc/fsl/fsl_sai.c:921:1: warning: no return statement in function returning non-void [-Wreturn-type]
 }
 ^

Introduced by commit

  812ad463e089 ("ASoC: fsl_sai: Add support for runtime pm")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2019-04-08 23:12 ` Stephen Rothwell
@ 2019-04-09  4:04   ` Annaliese McDermond
  0 siblings, 0 replies; 45+ messages in thread
From: Annaliese McDermond @ 2019-04-09  4:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List

Stephen --

I’m testing a potential solution now and I’ll be submitting something in the next couple of days.  Thanks for the heads up.

--
Annaliese McDermond
nh6z@nh6z.net

> On Apr 8, 2019, at 4:12 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi all,
> 
> On Tue, 26 Mar 2019 10:01:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> 
>> After merging the sound-asoc tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>> 
>> sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_recalc_rate':
>> sound/soc/codecs/tlv320aic32x4-clk.c:149:38: warning: 'settings.d' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>     ((settings->j * 10000) + settings->d);
>>                              ~~~~~~~~^~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.d' was declared here
>>  struct clk_aic32x4_pll_muldiv settings;
>>                                ^~~~~~~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:149:15: warning: 'settings.j' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>     ((settings->j * 10000) + settings->d);
>>       ~~~~~~~~^~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.j' was declared here
>>  struct clk_aic32x4_pll_muldiv settings;
>>                                ^~~~~~~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:148:37: warning: 'settings.r' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  rate = (u64) parent_rate * settings->r *
>>                             ~~~~~~~~^~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.r' was declared here
>>  struct clk_aic32x4_pll_muldiv settings;
>>                                ^~~~~~~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:151:56: warning: 'settings.p' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  return (unsigned long) DIV_ROUND_UP_ULL(rate, settings->p * 10000);
>>                                                        ^~
>> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.p' was declared here
>>  struct clk_aic32x4_pll_muldiv settings;
>>                                ^~~~~~~~
>> 
>> Introduced by commit
>> 
>>  514b044cba66 ("ASoC: tlv320aic32x4: Model PLL in CCF")
> 
> I am still getting these warnings.
> 
> -- 
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2019-04-09  1:46 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2019-04-09  1:46 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Paul Cercueil

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/intel/boards/bytcht_es8316.c: In function 'snd_byt_cht_es8316_mc_probe':
sound/soc/intel/boards/bytcht_es8316.c:508:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   quirk = (int)dmi_id->driver_data;
           ^

Introduced by commit

  a8d218f4fe81 ("ASoC: Intel: bytcht_es8316: Add quirk for the Teclast X98+ II")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2019-03-25 23:01 Stephen Rothwell
@ 2019-04-08 23:12 ` Stephen Rothwell
  2019-04-09  4:04   ` Annaliese McDermond
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2019-04-08 23:12 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Annaliese McDermond

[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]

Hi all,

On Tue, 26 Mar 2019 10:01:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_recalc_rate':
> sound/soc/codecs/tlv320aic32x4-clk.c:149:38: warning: 'settings.d' may be used uninitialized in this function [-Wmaybe-uninitialized]
>      ((settings->j * 10000) + settings->d);
>                               ~~~~~~~~^~~
> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.d' was declared here
>   struct clk_aic32x4_pll_muldiv settings;
>                                 ^~~~~~~~
> sound/soc/codecs/tlv320aic32x4-clk.c:149:15: warning: 'settings.j' may be used uninitialized in this function [-Wmaybe-uninitialized]
>      ((settings->j * 10000) + settings->d);
>        ~~~~~~~~^~~
> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.j' was declared here
>   struct clk_aic32x4_pll_muldiv settings;
>                                 ^~~~~~~~
> sound/soc/codecs/tlv320aic32x4-clk.c:148:37: warning: 'settings.r' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   rate = (u64) parent_rate * settings->r *
>                              ~~~~~~~~^~~
> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.r' was declared here
>   struct clk_aic32x4_pll_muldiv settings;
>                                 ^~~~~~~~
> sound/soc/codecs/tlv320aic32x4-clk.c:151:56: warning: 'settings.p' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return (unsigned long) DIV_ROUND_UP_ULL(rate, settings->p * 10000);
>                                                         ^~
> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.p' was declared here
>   struct clk_aic32x4_pll_muldiv settings;
>                                 ^~~~~~~~
> 
> Introduced by commit
> 
>   514b044cba66 ("ASoC: tlv320aic32x4: Model PLL in CCF")

I am still getting these warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2019-03-25 23:01 Stephen Rothwell
  2019-04-08 23:12 ` Stephen Rothwell
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2019-03-25 23:01 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Annaliese McDermond

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_recalc_rate':
sound/soc/codecs/tlv320aic32x4-clk.c:149:38: warning: 'settings.d' may be used uninitialized in this function [-Wmaybe-uninitialized]
     ((settings->j * 10000) + settings->d);
                              ~~~~~~~~^~~
sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.d' was declared here
  struct clk_aic32x4_pll_muldiv settings;
                                ^~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:149:15: warning: 'settings.j' may be used uninitialized in this function [-Wmaybe-uninitialized]
     ((settings->j * 10000) + settings->d);
       ~~~~~~~~^~~
sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.j' was declared here
  struct clk_aic32x4_pll_muldiv settings;
                                ^~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:148:37: warning: 'settings.r' may be used uninitialized in this function [-Wmaybe-uninitialized]
  rate = (u64) parent_rate * settings->r *
                             ~~~~~~~~^~~
sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.r' was declared here
  struct clk_aic32x4_pll_muldiv settings;
                                ^~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:151:56: warning: 'settings.p' may be used uninitialized in this function [-Wmaybe-uninitialized]
  return (unsigned long) DIV_ROUND_UP_ULL(rate, settings->p * 10000);
                                                        ^~
sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.p' was declared here
  struct clk_aic32x4_pll_muldiv settings;
                                ^~~~~~~~

Introduced by commit

  514b044cba66 ("ASoC: tlv320aic32x4: Model PLL in CCF")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2019-03-19 23:45 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2019-03-19 23:45 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Charles Keepax, Wen Shi

[-- Attachment #1: Type: text/plain, Size: 2484 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/pm_runtime.h:12,
                 from sound/soc/codecs/wm_adsp.c:21:
sound/soc/codecs/wm_adsp.c: In function 'wmfw_parse_id_header':
sound/soc/codecs/wm_adsp.c:45:22: warning: format '%zu' expects argument of type 'size_t', but argument 8 has type 'int' [-Wformat=]
  dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
                      ^~~~~~
include/linux/device.h:1400:22: note: in definition of macro 'dev_fmt'
 #define dev_fmt(fmt) fmt
                      ^~~
sound/soc/codecs/wm_adsp.c:45:2: note: in expansion of macro 'dev_info'
  dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
  ^~~~~~~~
sound/soc/codecs/wm_adsp.c:2145:2: note: in expansion of macro 'adsp_info'
  adsp_info(dsp, "Firmware: %x v%d.%d.%d, %zu algorithms\n",
  ^~~~~~~~~
sound/soc/codecs/wm_adsp.c:2145:44: note: format string is defined here
  adsp_info(dsp, "Firmware: %x v%d.%d.%d, %zu algorithms\n",
                                          ~~^
                                          %u
In file included from include/linux/pm_runtime.h:12,
                 from sound/soc/codecs/wm_adsp.c:21:
sound/soc/codecs/wm_adsp.c: In function 'wmfw_v3_parse_id_header':
sound/soc/codecs/wm_adsp.c:45:22: warning: format '%zu' expects argument of type 'size_t', but argument 9 has type 'int' [-Wformat=]
  dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
                      ^~~~~~
include/linux/device.h:1400:22: note: in definition of macro 'dev_fmt'
 #define dev_fmt(fmt) fmt
                      ^~~
sound/soc/codecs/wm_adsp.c:45:2: note: in expansion of macro 'dev_info'
  dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
  ^~~~~~~~
sound/soc/codecs/wm_adsp.c:2158:2: note: in expansion of macro 'adsp_info'
  adsp_info(dsp, "Firmware: %x vendor: 0x%x v%d.%d.%d, %zu algorithms\n",
  ^~~~~~~~~
sound/soc/codecs/wm_adsp.c:2158:57: note: format string is defined here
  adsp_info(dsp, "Firmware: %x vendor: 0x%x v%d.%d.%d, %zu algorithms\n",
                                                       ~~^
                                                       %u

Introduced by commits

  a5dcb24d70ff ("ASoC: wm_adsp: Factor out parsing of firmware ID header")
  170b1e123f38 ("ASoC: wm_adsp: Add support for new Halo core DSPs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2019-02-21  2:13 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2019-02-21  2:13 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sylwester Nawrocki

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/samsung/odroid.c: In function 'odroid_audio_probe':
sound/soc/samsung/odroid.c:298:22: warning: 'cpu_dai' may be used uninitialized in this function [-Wmaybe-uninitialized]
  priv->clk_i2s_bus = of_clk_get_by_name(cpu_dai, "iis");
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  d832d2b246c5 ("ASoC: samsung: odroid: Fix of_node refcount unbalance")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2019-02-13  1:31 ` Stephen Rothwell
@ 2019-02-13 10:35   ` Sylwester Nawrocki
  0 siblings, 0 replies; 45+ messages in thread
From: Sylwester Nawrocki @ 2019-02-13 10:35 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown
  Cc: Liam Girdwood, Linux Next Mailing List, Linux Kernel Mailing List

Hi Stephen,

On 2/13/19 02:31, Stephen Rothwell wrote:
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/soc/samsung/i2s.c: In function 'samsung_i2s_remove':
> sound/soc/samsung/i2s.c:1469:27: warning: unused variable 'priv' [-Wunused-variable]
>   struct samsung_i2s_priv *priv = dev_get_drvdata(&pdev->dev);
                            ^~~~
> 
> Introduced by commit
> 
>   a404b72d2bdd ("ASoC: samsung: i2s: Convert to single component with multiple DAIs")

Thanks for the information. Due to my messed up rebase the line
quoted above ended up in the above mentioned commit instead of 
in the next on in the series, which has not yet been applied:

"ASoC: samsung: i2s: Restore support for the secondary PCM"

-- 
Regards
Sylwester

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2019-02-13  1:31 ` Stephen Rothwell
  2019-02-13 10:35   ` Sylwester Nawrocki
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2019-02-13  1:31 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sylwester Nawrocki

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/samsung/i2s.c: In function 'samsung_i2s_remove':
sound/soc/samsung/i2s.c:1469:27: warning: unused variable 'priv' [-Wunused-variable]
  struct samsung_i2s_priv *priv = dev_get_drvdata(&pdev->dev);
                           ^~~~

Introduced by commit

  a404b72d2bdd ("ASoC: samsung: i2s: Convert to single component with multiple DAIs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2018-09-07  0:57 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2018-09-07  0:57 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Charles Keepax

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/soc-dapm.c: In function 'snd_soc_dai_link_event':
sound/soc/soc-dapm.c:3771:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
  return ret;
         ^~~

This looks like a (subtle) false positive. You have to assume that all
the loops will be executed at least once.

Probably introduced by commit

  4a75aae17b2a ("ASoC: dapm: Add support for multi-CODEC CODEC to CODEC links")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2018-08-02  4:06 Stephen Rothwell
@ 2018-08-02 14:37 ` Mark Brown
  0 siblings, 0 replies; 45+ messages in thread
From: Mark Brown @ 2018-08-02 14:37 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List, Rohit kumar

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

On Thu, Aug 02, 2018 at 02:06:30PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:

I was sent a patch for this already, should be fixed tomorrow.  Thanks
for reporting.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2018-08-02  4:06 Stephen Rothwell
  2018-08-02 14:37 ` Mark Brown
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2018-08-02  4:06 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Rohit kumar

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
  Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && QCOM_APR [=n] && HAS_DMA [=y]
  Selected by [m]:
  - SND_SOC_SDM845 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m]

Introduced by commit

  6b1687bf76ef ("ASoC: qcom: add sdm845 sound card support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2018-07-26  2:19 Stephen Rothwell
@ 2018-07-26  5:58 ` Agrawal, Akshu
  0 siblings, 0 replies; 45+ messages in thread
From: Agrawal, Akshu @ 2018-07-26  5:58 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List



On 7/26/2018 7:49 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_probe':
> sound/soc/amd/acp-da7219-max98357a.c:367:3: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    dev_err(&pdev->dev, "Failed to register regulator: %d\n",
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     ret);
>     ~~~~
> 
> Introduced by commit
> 
>   7b5317aa809f ("ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002")
> 
> This is a real bug.
> 
Posted the fix for the above warning message:
https://patchwork.kernel.org/patch/10545235/

Thanks,
Akshu

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2018-07-26  2:19 Stephen Rothwell
  2018-07-26  5:58 ` Agrawal, Akshu
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2018-07-26  2:19 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Akshu Agrawal

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_probe':
sound/soc/amd/acp-da7219-max98357a.c:367:3: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
   dev_err(&pdev->dev, "Failed to register regulator: %d\n",
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ret);
    ~~~~

Introduced by commit

  7b5317aa809f ("ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002")

This is a real bug.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2018-05-10  3:09 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2018-05-10  3:09 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Peter Ujfalusi

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information

Introduced by commit

  dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2018-02-13  1:51 Stephen Rothwell
@ 2018-02-13  2:55 ` Kuninori Morimoto
  0 siblings, 0 replies; 45+ messages in thread
From: Kuninori Morimoto @ 2018-02-13  2:55 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List


Hi Stephen

> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/codecs/wm9081.c: In function 'wm9081_digital_mute':
> sound/soc/codecs/wm9081.c:1161:7: warning: 'reg' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    reg |= WM9081_DAC_MUTE;
> 
> Introduced by commit
> 
>   48c338764296 ("ASoC: wm9081: replace codec to component")

Thank you for your report.
I posted fixup patch for it.

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2018-02-13  1:51 Stephen Rothwell
  2018-02-13  2:55 ` Kuninori Morimoto
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2018-02-13  1:51 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Kuninori Morimoto

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/wm9081.c: In function 'wm9081_digital_mute':
sound/soc/codecs/wm9081.c:1161:7: warning: 'reg' may be used uninitialized in this function [-Wmaybe-uninitialized]
   reg |= WM9081_DAC_MUTE;

Introduced by commit

  48c338764296 ("ASoC: wm9081: replace codec to component")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2017-11-01  4:13 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2017-11-01  4:13 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Olivier Moysan

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/stm/stm32_sai_sub.c: In function 'stm32_sai_hw_params':
sound/soc/stm/stm32_sai_sub.c:485:7: warning: 'cr1' may be used uninitialized in this function [-Wmaybe-uninitialized]
   cr1 |= SAI_XCR1_DS_SET(SAI_DATASIZE_8);
       ^
sound/soc/stm/stm32_sai_sub.c:469:6: note: 'cr1' was declared here
  int cr1, cr1_mask, ret;
      ^

Introduced by commit

  61fb4ff70377 ("ASoC: stm32: sai: Move static settings to DAI init")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2017-09-04  2:27 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2017-09-04  2:27 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Li Xu

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/cs43130.c: In function 'cs43130_imp_meas':
sound/soc/codecs/cs43130.c:2089:18: warning: 'hpload_seq' may be used uninitialized in this function [-Wmaybe-uninitialized]
        hpload_seq[i].msk, ac_idx);
                  ^

Introduced by commit

  8f1e5bf9b440 ("ASoC: cs43130: Add support for CS43130 codec")

This is probably a false positive.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2017-08-23  2:20 Stephen Rothwell
@ 2017-08-23  6:03 ` Takashi Iwai
  0 siblings, 0 replies; 45+ messages in thread
From: Takashi Iwai @ 2017-08-23  6:03 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List

On Wed, 23 Aug 2017 04:20:07 +0200,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/soc/tegra/tegra_wm8903.c: In function 'tegra_wm8903_remove':
> sound/soc/tegra/tegra_wm8903.c:206:23: warning: unused variable 'machine' [-Wunused-variable]
>   struct tegra_wm8903 *machine = snd_soc_card_get_drvdata(card);
>                        ^
> 
> Introduced by commit
> 
>   2a8bd83af30e ("ASoC: tegra: Remove superfluous snd_soc_jack_free_gpios() call")

My bad, will submit the fix patch.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2017-08-23  2:20 Stephen Rothwell
  2017-08-23  6:03 ` Takashi Iwai
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2017-08-23  2:20 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Takashi Iwai

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/tegra/tegra_wm8903.c: In function 'tegra_wm8903_remove':
sound/soc/tegra/tegra_wm8903.c:206:23: warning: unused variable 'machine' [-Wunused-variable]
  struct tegra_wm8903 *machine = snd_soc_card_get_drvdata(card);
                       ^

Introduced by commit

  2a8bd83af30e ("ASoC: tegra: Remove superfluous snd_soc_jack_free_gpios() call")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2017-07-03  2:26 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2017-07-03  2:26 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Vunny Sodhi

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from sound/soc/intel/skylake/skl-debug.c:23:0:
sound/soc/intel/skylake/../common/sst-dsp-priv.h:63:42: warning: 'struct sst_pdata' declared inside parameter list
  int (*init)(struct sst_dsp *sst, struct sst_pdata *pdata);
                                          ^
sound/soc/intel/skylake/../common/sst-dsp-priv.h:63:42: warning: its scope is only this definition or declaration, which is probably not what you want

Exposed by commit

  bdd0384a5ada ("ASoC: Intel: Skylake: Add support to read firmware registers")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2017-04-27  1:29 Stephen Rothwell
@ 2017-04-27  2:27 ` Vinod Koul
  0 siblings, 0 replies; 45+ messages in thread
From: Vinod Koul @ 2017-04-27  2:27 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List, G Kranthi, Subhransu S. Prusty

On Thu, Apr 27, 2017 at 11:29:20AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
> sound/soc/intel/skylake/bxt-sst.c:567:14: warning: 'skl' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    dev_err(skl->dev, "%s: no device\n", __func__);
>               ^
> 

Yeah looks like that is the case, fortunately fix is quite simple, I will
send out soon

Thanks for reporting

> Introduced by commit
> 
>   9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")
> 
> This looks like an actual bug ...
> 
> -- 
> Cheers,
> Stephen Rothwell

-- 
~Vinod

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2017-04-27  1:29 Stephen Rothwell
  2017-04-27  2:27 ` Vinod Koul
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2017-04-27  1:29 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, G Kranthi,
	Subhransu S. Prusty, Vinod Koul

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
sound/soc/intel/skylake/bxt-sst.c:567:14: warning: 'skl' may be used uninitialized in this function [-Wmaybe-uninitialized]
   dev_err(skl->dev, "%s: no device\n", __func__);
              ^

Introduced by commit

  9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")

This looks like an actual bug ...

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2017-02-01  2:14 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2017-02-01  2:14 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Pierre-Louis Bossart

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/intel/boards/cht_bsw_rt5645.c: In function 'cht_codec_init':
sound/soc/intel/boards/cht_bsw_rt5645.c:265:22: warning: unused variable 'codec_dai' [-Wunused-variable]
  struct snd_soc_dai *codec_dai = runtime->codec_dai;
                      ^

Introduced by commit

  7bde09dfcf60 ("ASoC: Intel: cht-bsw-rt5645: fix DAI formats")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2016-12-06  0:11 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2016-12-06  0:11 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Mengdong Lin

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/soc-topology.c: In function 'soc_tplg_dapm_widget_create':
sound/soc/soc-topology.c:1566:36: warning: 'kcontrol_type' may be used uninitialized in this function [-Wmaybe-uninitialized]
  widget->dobj.widget.kcontrol_type = kcontrol_type;
                                    ^

Introduced by commit

  eea3dd4f1247 ("ASoC: topology: Only free TLV for volume mixers of a widget")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2015-07-13  3:23 Stephen Rothwell
@ 2015-07-13  6:14 ` Valentin Rothberg
  0 siblings, 0 replies; 45+ messages in thread
From: Valentin Rothberg @ 2015-07-13  6:14 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel,
	Arnaud Pouliquen, Paul Bolle, Andreas Ruprecht, hengelein Stefan

Hi,

On Mon, Jul 13, 2015 at 5:23 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> warning: (SND_SOC_ALL_CODECS) selects SND_SOC_STI_SAS which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_STI)

Here's the introducing hunk:

+config SND_SOC_STI_SAS
+       tristate "codec Audio support for STI SAS codec"
+       depends on SND_SOC_STI

SND_SOC_STI is not defined in Kconfig.

Kind regards,
 Valentin

> Introduced by commit
>
>   32a726b2e089 ("ASoC: sti-sas: Add sti platform codec")
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2015-07-13  3:23 Stephen Rothwell
  2015-07-13  6:14 ` Valentin Rothberg
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2015-07-13  3:23 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Arnaud Pouliquen

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

warning: (SND_SOC_ALL_CODECS) selects SND_SOC_STI_SAS which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_STI)

Introduced by commit

  32a726b2e089 ("ASoC: sti-sas: Add sti platform codec")

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2015-03-19  3:45 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2015-03-19  3:45 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Nikesh Oswal

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/soc-dapm.c: In function 'snd_soc_dapm_new_pcm':
sound/soc/soc-dapm.c:3389:4: warning: passing argument 1 of 'snprintf' discards 'const' qualifier from pointer target type
    snprintf(w_param_text[count], len,
    ^

Introduced by commit c66150824b8a ("ASoC: dapm: add code to configure
dai link parameters").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2014-04-15  1:44 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2014-04-15  1:44 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Lars-Peter Clausen

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/intel/sst-haswell-pcm.c: In function 'hsw_stream_volume_put':
sound/soc/intel/sst-haswell-pcm.c:139:38: warning: initialization from incompatible pointer type [enabled by default]
  struct snd_soc_platform *platform = snd_soc_kcontrol_platform(kcontrol);
                                      ^

And several others ... really, you should try build testing this stuff :-(

Caused by commit f6272ff8a5f4 ("ASoC: Add snd_soc_kcontrol_platform()
helper function").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2014-02-20  3:01 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2014-02-20  3:01 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/cs42l51.c: In function 'cs42l51_probe':
sound/soc/codecs/cs42l51.c:490:26: warning: unused variable 'cs42l51' [-Wunused-variable]
  struct cs42l51_private *cs42l51 = snd_soc_codec_get_drvdata(codec);
                          ^

Introduced by commit da0714897624 ("ASoC: cs42l51: Convert to direct
regmap API usage").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2012-06-08  4:03 Stephen Rothwell
  0 siblings, 0 replies; 45+ messages in thread
From: Stephen Rothwell @ 2012-06-08  4:03 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/soc-dapm.c: In function 'dapm_clock_event':
sound/soc/soc-dapm.c:1022:1: warning: control reaches end of non-void function [-Wreturn-type]

This is with CONFIG_HAVE_CLK not set.  Introduced by commit ec02995adad5
("ASoC: dapm: Bodge for lack of a widely available clk API").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2012-04-05  1:03 Stephen Rothwell
@ 2012-04-05 14:32 ` MR Swami Reddy
  0 siblings, 0 replies; 45+ messages in thread
From: MR Swami Reddy @ 2012-04-05 14:32 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, Girdwood, Liam, linux-next, Reddy, MR Swami

Hi,
I tried to reproduce the below mentioned warning messages using:
 - Latest for-next git repo sources  on x86_64 build machine
 - gcc version 4.3.2
 - -Woverflow option used in KBUILD_CFLAGS

But couldn't see the warning messages.

Below is the quick patch to remove the warning messages (and this patch
will be submitted to alsa-devel mailing list soon).

Signed-off-by: M R Swami Reddy <mr.swami.reddy@ti.com>
---
 sound/soc/codecs/lm49453.c  |   13 +-
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
index 744063d..74409ec 100644
--- a/sound/soc/codecs/lm49453.c
+++ b/sound/soc/codecs/lm49453.c
@@ -1178,27 +1178,24 @@ static int lm49453_set_dai_fmt(struct
snd_soc_dai *codec_dai, unsigned int fmt)
 {
        struct snd_soc_codec *codec = codec_dai->codec;

-       int aif_val = 0;
+       u16 aif_val;
        int mode = 0;
        int clk_phase = 0;
        int clk_shift = 0;

        switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
        case SND_SOC_DAIFMT_CBS_CFS:
-               aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+               aif_val = 0;
                break;
        case SND_SOC_DAIFMT_CBS_CFM:
-               aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+               aif_val = LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
                break;
        case SND_SOC_DAIFMT_CBM_CFS:
-               aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+               aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS;
                break;
        case SND_SOC_DAIFMT_CBM_CFM:
                aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+                         LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
                break;
        default:
                return -EINVAL;




On Thursday 05 April 2012 06:33 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> sound/soc/codecs/lm49453.c: In function 'lm49453_set_dai_fmt':
> sound/soc/codecs/lm49453.c:1189:4: warning: overflow in implicit constant conversion [-Woverflow]
> sound/soc/codecs/lm49453.c:1193:4: warning: overflow in implicit constant conversion [-Woverflow]
> sound/soc/codecs/lm49453.c:1197:4: warning: overflow in implicit constant conversion [-Woverflow]
>
> Introduced by commit dbf7a733f5fb (ASoC: Support TI LM49453 Audio driver"").

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2012-04-05  1:03 Stephen Rothwell
  2012-04-05 14:32 ` MR Swami Reddy
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2012-04-05  1:03 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, M R Swami Reddy

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/lm49453.c: In function 'lm49453_set_dai_fmt':
sound/soc/codecs/lm49453.c:1189:4: warning: overflow in implicit constant conversion [-Woverflow]
sound/soc/codecs/lm49453.c:1193:4: warning: overflow in implicit constant conversion [-Woverflow]
sound/soc/codecs/lm49453.c:1197:4: warning: overflow in implicit constant conversion [-Woverflow]

Introduced by commit dbf7a733f5fb (ASoC: Support TI LM49453 Audio driver"").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2012-01-09  3:03 ` Axel Lin
@ 2012-01-09  3:10   ` Mark Brown
  0 siblings, 0 replies; 45+ messages in thread
From: Mark Brown @ 2012-01-09  3:10 UTC (permalink / raw)
  To: Axel Lin; +Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

On Mon, Jan 09, 2012 at 11:03:35AM +0800, Axel Lin wrote:
> 2012/1/9 Stephen Rothwell <sfr@canb.auug.org.au>:

> I think this commit should be replaced by [PATCH] ASoC: Fix build
> dependency for SND_AT91_SOC_AFEB9260
> http://mailman.alsa-project.org/pipermail/alsa-devel/2012-January/047861.html

> Should I send a revert patch for commit 739be96ab837? Or you can do it
> by git-revert command directly?

Send an incremental patch to put things into the desired state.

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2012-01-09  1:55 Stephen Rothwell
@ 2012-01-09  3:03 ` Axel Lin
  2012-01-09  3:10   ` Mark Brown
  0 siblings, 1 reply; 45+ messages in thread
From: Axel Lin @ 2012-01-09  3:03 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel

2012/1/9 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> ppc64_defconfig and x86_64 allmodconfig) produced this warning:
>
> drivers/misc/Kconfig:212:error: recursive dependency detected!
> drivers/misc/Kconfig:212:       symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
> sound/soc/atmel/Kconfig:9:      symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
> sound/soc/atmel/Kconfig:18:     symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC
>
> Probably introduced by commit 739be96ab837 ("ASoC: Fix build dependency
> for SND_ATMEL_SOC_SSC").
Hi Mark,
I think this commit should be replaced by [PATCH] ASoC: Fix build
dependency for SND_AT91_SOC_AFEB9260
http://mailman.alsa-project.org/pipermail/alsa-devel/2012-January/047861.html

Should I send a revert patch for commit 739be96ab837? Or you can do it
by git-revert command directly?

Thanks,
Axel
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2012-01-09  1:55 Stephen Rothwell
  2012-01-09  3:03 ` Axel Lin
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2012-01-09  1:55 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Axel Lin

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
ppc64_defconfig and x86_64 allmodconfig) produced this warning:

drivers/misc/Kconfig:212:error: recursive dependency detected!
drivers/misc/Kconfig:212:	symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
sound/soc/atmel/Kconfig:9:	symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
sound/soc/atmel/Kconfig:18:	symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC

Probably introduced by commit 739be96ab837 ("ASoC: Fix build dependency
for SND_ATMEL_SOC_SSC").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2010-12-27 23:32 Stephen Rothwell
@ 2010-12-28  9:18 ` Peter Ujfalusi
  0 siblings, 0 replies; 45+ messages in thread
From: Peter Ujfalusi @ 2010-12-28  9:18 UTC (permalink / raw)
  To: ext Stephen Rothwell; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel

Hi,

On 12/28/2010 01:32 AM, ext Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_add_controls':
> sound/soc/codecs/tpa6130a2.c:342: warning: unused variable 'dapm'
> 
> Introduced by commit 39646871a47fd8808c08de0ce7d7ca8393af2805 ("ASoC:
> tpa6130a2: Replace DAPM code with direct interface").

Sorry about that.
I'll send the fix in a few minutes.

-- 
Péter

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2010-12-27 23:32 Stephen Rothwell
  2010-12-28  9:18 ` Peter Ujfalusi
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2010-12-27 23:32 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Peter Ujfalusi

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_add_controls':
sound/soc/codecs/tpa6130a2.c:342: warning: unused variable 'dapm'

Introduced by commit 39646871a47fd8808c08de0ce7d7ca8393af2805 ("ASoC:
tpa6130a2: Replace DAPM code with direct interface").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2010-08-17 23:30 ` Liam Girdwood
@ 2010-08-18  8:53   ` Mark Brown
  0 siblings, 0 replies; 45+ messages in thread
From: Mark Brown @ 2010-08-18  8:53 UTC (permalink / raw)
  To: Liam Girdwood; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Aug 18, 2010 at 12:30:30AM +0100, Liam Girdwood wrote:

> Mark, could you apply this fix.

Done.

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: linux-next: build warning after merge of the sound-asoc tree
  2010-08-17  2:21 Stephen Rothwell
@ 2010-08-17 23:30 ` Liam Girdwood
  2010-08-18  8:53   ` Mark Brown
  0 siblings, 1 reply; 45+ messages in thread
From: Liam Girdwood @ 2010-08-17 23:30 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, linux-next, linux-kernel

On Tue, 2010-08-17 at 12:21 +1000, Stephen Rothwell wrote:
> Hi ,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/soc-core.c: In function 'snd_soc_register_dais':
> sound/soc/soc-core.c:2919: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'
> 
> Caused by commit f0fba2ad1b6b53d5360125c41953b7afcd6deff0 ("ASoC:
> multi-component - ASoC Multi-Component Support").

Ah, this never showed up on ARM since size_t is 32 bits.

Mark, could you apply this fix.

Thanks

Liam

>From 4c3f9d5fcb46d769f4a52a044fead863419c1d58 Mon Sep 17 00:00:00 2001
From: Liam Girdwood <lrg@slimlogic.co.uk>
Date: Wed, 18 Aug 2010 00:25:12 +0100
Subject: [PATCH] ASoC: core - fix build warning on x86_64

Output size_t type as a "%Zu" to avoid warnings.

Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
---
 sound/soc/soc-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 3d480eb..7093c17 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -2916,7 +2916,7 @@ int snd_soc_register_dais(struct device *dev,
 	struct snd_soc_dai *dai;
 	int i, ret = 0;
 
-	dev_dbg(dev, "dai register %s #%d\n", dev_name(dev), count);
+	dev_dbg(dev, "dai register %s #%Zu\n", dev_name(dev), count);
 
 	for (i = 0; i < count; i++) {
 
-- 
1.7.0.4

^ permalink raw reply	[flat|nested] 45+ messages in thread

* linux-next: build warning after merge of the sound-asoc tree
@ 2010-08-17  2:21 Stephen Rothwell
  2010-08-17 23:30 ` Liam Girdwood
  0 siblings, 1 reply; 45+ messages in thread
From: Stephen Rothwell @ 2010-08-17  2:21 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi ,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/soc-core.c: In function 'snd_soc_register_dais':
sound/soc/soc-core.c:2919: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'

Caused by commit f0fba2ad1b6b53d5360125c41953b7afcd6deff0 ("ASoC:
multi-component - ASoC Multi-Component Support").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 45+ messages in thread

end of thread, back to index

Thread overview: 45+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 23:45 linux-next: build warning after merge of the sound-asoc tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2019-10-07 23:58 Stephen Rothwell
2019-04-26  3:05 Stephen Rothwell
2019-04-26  3:14 ` Nicolin Chen
2019-04-09  1:46 Stephen Rothwell
2019-03-25 23:01 Stephen Rothwell
2019-04-08 23:12 ` Stephen Rothwell
2019-04-09  4:04   ` Annaliese McDermond
2019-03-19 23:45 Stephen Rothwell
2019-02-21  2:13 Stephen Rothwell
     [not found] <CGME20190213013212epcas5p436da6762dea86287ed3aea31ef2bb830@epcas5p4.samsung.com>
2019-02-13  1:31 ` Stephen Rothwell
2019-02-13 10:35   ` Sylwester Nawrocki
2018-09-07  0:57 Stephen Rothwell
2018-08-02  4:06 Stephen Rothwell
2018-08-02 14:37 ` Mark Brown
2018-07-26  2:19 Stephen Rothwell
2018-07-26  5:58 ` Agrawal, Akshu
2018-05-10  3:09 Stephen Rothwell
2018-02-13  1:51 Stephen Rothwell
2018-02-13  2:55 ` Kuninori Morimoto
2017-11-01  4:13 Stephen Rothwell
2017-09-04  2:27 Stephen Rothwell
2017-08-23  2:20 Stephen Rothwell
2017-08-23  6:03 ` Takashi Iwai
2017-07-03  2:26 Stephen Rothwell
2017-04-27  1:29 Stephen Rothwell
2017-04-27  2:27 ` Vinod Koul
2017-02-01  2:14 Stephen Rothwell
2016-12-06  0:11 Stephen Rothwell
2015-07-13  3:23 Stephen Rothwell
2015-07-13  6:14 ` Valentin Rothberg
2015-03-19  3:45 Stephen Rothwell
2014-04-15  1:44 Stephen Rothwell
2014-02-20  3:01 Stephen Rothwell
2012-06-08  4:03 Stephen Rothwell
2012-04-05  1:03 Stephen Rothwell
2012-04-05 14:32 ` MR Swami Reddy
2012-01-09  1:55 Stephen Rothwell
2012-01-09  3:03 ` Axel Lin
2012-01-09  3:10   ` Mark Brown
2010-12-27 23:32 Stephen Rothwell
2010-12-28  9:18 ` Peter Ujfalusi
2010-08-17  2:21 Stephen Rothwell
2010-08-17 23:30 ` Liam Girdwood
2010-08-18  8:53   ` Mark Brown

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git