Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the block tree
@ 2019-10-24  6:16 Stephen Rothwell
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2019-10-24  6:16 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jackie Liu

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  f131f240623a ("io_uring: cq entries should be equal to (or greater) than sq entries")

Fixes tag

  Fixes: 95d8765bd9f2 ("io_uring: allow application controlled CQ ring size")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: f3cbc97703c5 ("io_uring: allow application controlled CQ ring size")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-10-10 17:36 ` Bart Van Assche
@ 2019-10-11  0:42   ` Stephen Rothwell
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2019-10-11  0:42 UTC (permalink / raw)
  To: Bart Van Assche
  Cc: Jens Axboe, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Hi Bart,

On Thu, 10 Oct 2019 10:36:36 -0700 Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 10/7/19 1:16 PM, Stephen Rothwell wrote:
> > 
> >    Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
> 
> The above fixes tag follows the recommended format except that it is 
> followed by a kernel version number. Is there a recommended format for 
> embedding the kernel version number in a Fixes: tag? I think that 
> information is useful. I haven't found any recommendations for how to do 
> that in Documentation/process/submitting-patches.rst.

I have not seen any recommended way to do that, but there is no
necessity to embed the version as it can easily be derived:

$ git describe --contains e34cbd307477
v4.10-rc1~153^2~94

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-10-07 20:16 Stephen Rothwell
@ 2019-10-10 17:36 ` Bart Van Assche
  2019-10-11  0:42   ` Stephen Rothwell
  0 siblings, 1 reply; 9+ messages in thread
From: Bart Van Assche @ 2019-10-10 17:36 UTC (permalink / raw)
  To: Stephen Rothwell, Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 10/7/19 1:16 PM, Stephen Rothwell wrote:
> In commit
> 
>    1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")
> 
> Fixes tag
> 
>    Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
> 
> has these problem(s):
> 
>    - Subject has leading but no trailing quotes
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Hi Stephen,

The above fixes tag follows the recommended format except that it is 
followed by a kernel version number. Is there a recommended format for 
embedding the kernel version number in a Fixes: tag? I think that 
information is useful. I haven't found any recommendations for how to do 
that in Documentation/process/submitting-patches.rst.

Thanks,

Bart.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-10-07 20:16 Stephen Rothwell
  2019-10-10 17:36 ` Bart Van Assche
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2019-10-07 20:16 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Bart Van Assche

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Hi all,

In commit

  1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")

Fixes tag

  Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-09-10 14:57 Stephen Rothwell
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2019-09-10 14:57 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jackie Liu

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi all,

In commit

  8776f3fa15a5 ("io_uring: fix wrong sequence setting logic")

Fixes tag

  Fixes: de0617e4671 ("io_uring: add support for marking commands as draining")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-07-11 22:03 ` Jens Axboe
@ 2019-07-12  8:47   ` Minwoo Im
  0 siblings, 0 replies; 9+ messages in thread
From: Minwoo Im @ 2019-07-12  8:47 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

On 19-07-11 16:03:22, Jens Axboe wrote:
> On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >    8f3858763d33 ("nvme: fix NULL deref for fabrics options")
> > 
> > Fixes tag
> > 
> >    Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
> > 
> > has these problem(s):
> > 
> >    - SHA1 should be at least 12 digits long
> >      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> >      or later) just making sure it is not set (or set to "auto").
> >    - Subject has leading but no trailing parentheses
> >    - Subject has leading but no trailing quotes
> > 
> > Please do not split Fixes tags over more than one line.  Also do not
> > include blank lines among the tags.

I'm sorry for noises here.  I will keep that in mind.

Thanks Stephen,

> 
> I should have caught that. Since it's top-of-tree and recent, I'll
> amend it.

Jens,  I will do it from the next time.  Thanks for ammend.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-07-11 21:35 Stephen Rothwell
@ 2019-07-11 22:03 ` Jens Axboe
  2019-07-12  8:47   ` Minwoo Im
  0 siblings, 1 reply; 9+ messages in thread
From: Jens Axboe @ 2019-07-11 22:03 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Minwoo Im

On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    8f3858763d33 ("nvme: fix NULL deref for fabrics options")
> 
> Fixes tag
> 
>    Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
> 
> has these problem(s):
> 
>    - SHA1 should be at least 12 digits long
>      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>      or later) just making sure it is not set (or set to "auto").
>    - Subject has leading but no trailing parentheses
>    - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.  Also do not
> include blank lines among the tags.

I should have caught that. Since it's top-of-tree and recent, I'll
amend it.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-07-11 21:35 Stephen Rothwell
  2019-07-11 22:03 ` Jens Axboe
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2019-07-11 21:35 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Minwoo Im

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi all,

In commit

  8f3858763d33 ("nvme: fix NULL deref for fabrics options")

Fixes tag

  Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also do not
include blank lines among the tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-02-21 20:39 Stephen Rothwell
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2019-02-21 20:39 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ming Lei

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi Jens,

In commit

  8f4e80da764e ("block: bounce: make sure that bvec table is updated")

Fixes tag

  Fixes: 6dc4f100c ("block: allow bio_for_each_segment_all() to iterate over multi-page bvec")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24  6:16 linux-next: Fixes tag needs some work in the block tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2019-10-07 20:16 Stephen Rothwell
2019-10-10 17:36 ` Bart Van Assche
2019-10-11  0:42   ` Stephen Rothwell
2019-09-10 14:57 Stephen Rothwell
2019-07-11 21:35 Stephen Rothwell
2019-07-11 22:03 ` Jens Axboe
2019-07-12  8:47   ` Minwoo Im
2019-02-21 20:39 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git