From: coverity-bot <keescook@chromium.org>
To: Vivien Didelot <vivien.didelot@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: dsa_switch_probe(): Null pointer dereferences
Date: Mon, 28 Oct 2019 16:01:52 -0700 [thread overview]
Message-ID: <201910281600.407E203F02@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")
Coverity reported the following:
*** CID 1487378: Null pointer dereferences (REVERSE_INULL)
/net/dsa/dsa2.c: 849 in dsa_switch_probe()
843 static int dsa_switch_probe(struct dsa_switch *ds)
844 {
845 struct dsa_chip_data *pdata = ds->dev->platform_data;
846 struct device_node *np = ds->dev->of_node;
847 int err;
848
vvv CID 1487378: Null pointer dereferences (REVERSE_INULL)
vvv Null-checking "ds->dev" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
849 if (!ds->dev)
850 return -ENODEV;
851
852 if (!ds->num_ports)
853 return -EINVAL;
854
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487378 ("Null pointer dereferences")
Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-10-28 23:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281600.407E203F02@keescook \
--to=keescook@chromium.org \
--cc=f.fainelli@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=jakub.kicinski@netronome.com \
--cc=linux-next@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).