Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* Coverity: dsa_switch_probe(): Null pointer dereferences
@ 2019-10-28 23:01 coverity-bot
  0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2019-10-28 23:01 UTC (permalink / raw)
  To: Vivien Didelot
  Cc: Florian Fainelli, Jakub Kicinski, Gustavo A. R. Silva, linux-next

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")

Coverity reported the following:

*** CID 1487378:  Null pointer dereferences  (REVERSE_INULL)
/net/dsa/dsa2.c: 849 in dsa_switch_probe()
843     static int dsa_switch_probe(struct dsa_switch *ds)
844     {
845     	struct dsa_chip_data *pdata = ds->dev->platform_data;
846     	struct device_node *np = ds->dev->of_node;
847     	int err;
848
vvv     CID 1487378:  Null pointer dereferences  (REVERSE_INULL)
vvv     Null-checking "ds->dev" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
849     	if (!ds->dev)
850     		return -ENODEV;
851
852     	if (!ds->num_ports)
853     		return -EINVAL;
854

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487378 ("Null pointer dereferences")
Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")


Thanks for your attention!

-- 
Coverity-bot

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 23:01 Coverity: dsa_switch_probe(): Null pointer dereferences coverity-bot

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git