From: coverity-bot <keescook@chromium.org>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: gen12_emit_flush_render(): Integer handling issues
Date: Mon, 28 Oct 2019 16:02:06 -0700 [thread overview]
Message-ID: <201910281601.9BE937D4@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
36a6b5d964d9 ("drm/i915/tgl: Add extra hdc flush workaround")
Coverity reported the following:
*** CID 1487377: Integer handling issues (NO_EFFECT)
/drivers/gpu/drm/i915/gt/intel_lrc.c: 3282 in gen12_emit_flush_render()
3276 *cs++ = preparser_disable(false);
3277 intel_ring_advance(request, cs);
3278
3279 /*
3280 * Wa_1604544889:tgl
3281 */
vvv CID 1487377: Integer handling issues (NO_EFFECT)
vvv This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "request->i915->drm.pdev->revision >= 0".
3282 if (IS_TGL_REVID(request->i915, TGL_REVID_A0, TGL_REVID_A0)) {
3283 flags = 0;
3284 flags |= PIPE_CONTROL_CS_STALL;
3285 flags |= PIPE_CONTROL_HDC_PIPELINE_FLUSH;
3286
3287 flags |= PIPE_CONTROL_STORE_DATA_INDEX;
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487377 ("Integer handling issues")
Fixes: 36a6b5d964d9 ("drm/i915/tgl: Add extra hdc flush workaround")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-10-28 23:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281601.9BE937D4@keescook \
--to=keescook@chromium.org \
--cc=chris@chris-wilson.co.uk \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).