Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: coverity-bot <keescook@chromium.org>
To: Dmitry Bezrukov <dmitry.bezrukov@aquantia.com>
Cc: Igor Russkikh <igor.russkikh@aquantia.com>,
	Andrew Lunn <andrew@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Nikita Danilov <nikita.danilov@aquantia.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	linux-next@vger.kernel.org
Subject: Coverity: aq_nic_init(): Code maintainability issues
Date: Mon, 28 Oct 2019 16:02:15 -0700
Message-ID: <201910281602.79939E6B@keescook> (raw)

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

dbcd6806af42 ("net: aquantia: add support for Phy access")

Coverity reported the following:

*** CID 1487376:  Code maintainability issues  (UNUSED_VALUE)
/drivers/net/ethernet/aquantia/atlantic/aq_nic.c: 344 in aq_nic_init()
338     				       aq_nic_get_ndev(self)->dev_addr);
339     	if (err < 0)
340     		goto err_exit;
341
342     	if (self->aq_nic_cfg.aq_hw_caps->media_type == AQ_HW_MEDIA_TYPE_TP) {
343     		self->aq_hw->phy_id = HW_ATL_PHY_ID_MAX;
vvv     CID 1487376:  Code maintainability issues  (UNUSED_VALUE)
vvv     Assigning value from "aq_phy_init(self->aq_hw)" to "err" here, but that stored value is overwritten before it can be used.
344     		err = aq_phy_init(self->aq_hw);
345     	}
346
347     	for (i = 0U, aq_vec = self->aq_vec[0];
348     		self->aq_vecs > i; ++i, aq_vec = self->aq_vec[i])
349     		aq_vec_init(aq_vec, self->aq_hw_ops, self->aq_hw);

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487376 ("Code maintainability issues")
Fixes: dbcd6806af42 ("net: aquantia: add support for Phy access")


Thanks for your attention!

-- 
Coverity-bot

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201910281602.79939E6B@keescook \
    --to=keescook@chromium.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dmitry.bezrukov@aquantia.com \
    --cc=gustavo@embeddedor.com \
    --cc=igor.russkikh@aquantia.com \
    --cc=linux-next@vger.kernel.org \
    --cc=nikita.danilov@aquantia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git