From: coverity-bot <keescook@chromium.org>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: tgl_gt_workarounds_init(): Integer handling issues
Date: Mon, 28 Oct 2019 16:03:12 -0700 [thread overview]
Message-ID: <201910281602.AE52B8D@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
65df78bda385 ("drm/i915/tgl: Wa_1409420604")
Coverity reported the following:
*** CID 1487372: Integer handling issues (NO_EFFECT)
/drivers/gpu/drm/i915/gt/intel_workarounds.c: 906 in tgl_gt_workarounds_init()
900 }
901
902 static void
903 tgl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
904 {
905 /* Wa_1409420604:tgl */
vvv CID 1487372: Integer handling issues (NO_EFFECT)
vvv This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "i915->drm.pdev->revision >= 0".
906 if (IS_TGL_REVID(i915, TGL_REVID_A0, TGL_REVID_A0))
907 wa_write_or(wal,
908 SUBSLICE_UNIT_LEVEL_CLKGATE2,
909 CPSSUNIT_CLKGATE_DIS);
910
911 /* Wa_1409180338:tgl */
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487372 ("Integer handling issues")
Fixes: 65df78bda385 ("drm/i915/tgl: Wa_1409420604")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-10-28 23:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281602.AE52B8D@keescook \
--to=keescook@chromium.org \
--cc=chris@chris-wilson.co.uk \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).