Linux-Next Archive on
 help / color / Atom feed
From: coverity-bot <>
To: Vincent Guittot <>
Cc: Ingo Molnar <>,
	"Gustavo A. R. Silva" <>,
Subject: Coverity: find_idlest_group(): Null pointer dereferences
Date: Mon, 28 Oct 2019 16:03:20 -0700
Message-ID: <201910281603.4378C08@keescook> (raw)


This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

57abff067a08 ("sched/fair: Rework find_idlest_group()")

Coverity reported the following:

*** CID 1487371:  Null pointer dereferences  (FORWARD_NULL)
/kernel/sched/fair.c: 8319 in find_idlest_group()
8313     	case group_asym_packing:
8314     		/* Those type are not used in the slow wakeup path */
8315     		return NULL;
8317     	case group_misfit_task:
8318     		/* Select group with the highest max capacity */
vvv     CID 1487371:  Null pointer dereferences  (FORWARD_NULL)
vvv     Dereferencing null pointer "local".
8319     		if (local->sgc->max_capacity >= idlest->sgc->max_capacity)
8320     			return NULL;
8321     		break;
8323     	case group_has_spare:
8324     		if (sd->flags & SD_NUMA) {

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please

Reported-by: coverity-bot <>
Addresses-Coverity-ID: 1487371 ("Null pointer dereferences")
Fixes: 57abff067a08 ("sched/fair: Rework find_idlest_group()")

Thanks for your attention!


             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 23:03 coverity-bot [this message]
2019-10-29  8:07 ` Vincent Guittot

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201910281603.4378C08@keescook \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on

Archives are clonable:
	git clone --mirror linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ \
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone