From: coverity-bot <keescook@chromium.org>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: intel_set_dp_tp_ctl_normal(): Memory - illegal accesses
Date: Mon, 28 Oct 2019 16:05:40 -0700 [thread overview]
Message-ID: <201910281605.5595C8C@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
eadf6f9170d5 ("drm/i915/display/icl: Enable master-slaves in trans port sync")
Coverity reported the following:
*** CID 1487364: Memory - illegal accesses (UNINIT)
/drivers/gpu/drm/i915/display/intel_display.c: 14249 in intel_set_dp_tp_ctl_normal()
14243 int i;
14244
14245 for_each_new_connector_in_state(&state->base, conn, conn_state, i) {
14246 if (conn_state->crtc == &crtc->base)
14247 break;
14248 }
vvv CID 1487364: Memory - illegal accesses (UNINIT)
vvv Using uninitialized value "conn" when calling "intel_attached_encoder".
14249 intel_dp = enc_to_intel_dp(&intel_attached_encoder(conn)->base);
14250 intel_dp_stop_link_train(intel_dp);
14251 }
14252
14253 static void intel_post_crtc_enable_updates(struct intel_crtc *crtc,
14254 struct intel_atomic_state *state)
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487364 ("Memory - illegal accesses")
Fixes: eadf6f9170d5 ("drm/i915/display/icl: Enable master-slaves in trans port sync")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-10-28 23:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281605.5595C8C@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).