Linux-Next Archive on
 help / color / Atom feed
From: coverity-bot <>
To: Tudor Ambarus <>
Cc: Boris Brezillon <>,
	"Gustavo A. R. Silva" <>,
Subject: Coverity: spi_nor_erase_sector(): Null pointer dereferences
Date: Mon, 28 Oct 2019 16:05:49 -0700
Message-ID: <201910281605.9E90B64E86@keescook> (raw)


This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

453977875364 ("mtd: spi-nor: Introduce 'struct spi_nor_controller_ops'")

Coverity reported the following:

*** CID 1487363:  Null pointer dereferences  (FORWARD_NULL)
/drivers/mtd/spi-nor/spi-nor.c: 967 in spi_nor_erase_sector()
961     	 */
962     	for (i = nor->addr_width - 1; i >= 0; i--) {
963     		nor->bouncebuf[i] = addr & 0xff;
964     		addr >>= 8;
965     	}
vvv     CID 1487363:  Null pointer dereferences  (FORWARD_NULL)
vvv     Dereferencing null pointer "nor->controller_ops".
967     	return nor->controller_ops->write_reg(nor, nor->erase_opcode,
968     					      nor->bouncebuf, nor->addr_width);
969     }
971     /**
972      * spi_nor_div_by_erase_size() - calculate remainder and update new dividend

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please

Reported-by: coverity-bot <>
Addresses-Coverity-ID: 1487363 ("Null pointer dereferences")
Fixes: 453977875364 ("mtd: spi-nor: Introduce 'struct spi_nor_controller_ops'")

Thanks for your attention!


             reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 23:05 coverity-bot [this message]
2019-10-29  5:59 ` Tudor.Ambarus
2019-10-29 16:05   ` Kees Cook

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201910281605.9E90B64E86@keescook \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on

Archives are clonable:
	git clone --mirror linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ \
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone