From: coverity-bot <keescook@chromium.org>
To: Tzu-En Huang <tehuang@realtek.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>, Chris Chiu <chiu@endlessm.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: rtw_phy_pwrtrack_get_pwridx(): NO_EFFECT
Date: Mon, 28 Oct 2019 16:06:06 -0700 [thread overview]
Message-ID: <201910281605.E73D72D2F2@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
c97ee3e0bea2 ("rtw88: add power tracking support")
Coverity reported the following:
*** CID 1487362: (NO_EFFECT)
/drivers/net/wireless/realtek/rtw88/phy.c: 2074 in rtw_phy_pwrtrack_get_pwridx()
2068
2069 if (delta >= RTW_PWR_TRK_TBL_SZ) {
2070 rtw_warn(rtwdev, "power track table overflow\n");
2071 return 0;
2072 }
2073
vvv CID 1487362: (NO_EFFECT)
vvv Comparing an array to null is not useful: "swing_table->p", since the test will always evaluate as true.
2074 if (!swing_table || !swing_table->n || !swing_table->p) {
2075 rtw_warn(rtwdev, "swing table not configured\n");
2076 return 0;
2077 }
2078
2079 delta_swing_table_idx_pos = swing_table->p[tbl_path];
/drivers/net/wireless/realtek/rtw88/phy.c: 2074 in rtw_phy_pwrtrack_get_pwridx()
2068
2069 if (delta >= RTW_PWR_TRK_TBL_SZ) {
2070 rtw_warn(rtwdev, "power track table overflow\n");
2071 return 0;
2072 }
2073
vvv CID 1487362: (NO_EFFECT)
vvv Comparing an array to null is not useful: "swing_table->n", since the test will always evaluate as true.
2074 if (!swing_table || !swing_table->n || !swing_table->p) {
2075 rtw_warn(rtwdev, "swing table not configured\n");
2076 return 0;
2077 }
2078
2079 delta_swing_table_idx_pos = swing_table->p[tbl_path];
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487362 ("NO_EFFECT")
Fixes: c97ee3e0bea2 ("rtw88: add power tracking support")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-10-28 23:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281605.E73D72D2F2@keescook \
--to=keescook@chromium.org \
--cc=chiu@endlessm.com \
--cc=gustavo@embeddedor.com \
--cc=kvalo@codeaurora.org \
--cc=linux-next@vger.kernel.org \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).