Linux-Next Archive on
 help / color / Atom feed
From: coverity-bot <>
To: Amit Kucheria <>
Cc: Stephen Boyd <>,
	Daniel Lezcano <>,
	"Gustavo A. R. Silva" <>,
Subject: Coverity: degc_to_code(): Integer handling issues
Date: Mon, 28 Oct 2019 16:06:23 -0700
Message-ID: <201910281606.F95870B3@keescook> (raw)


This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")

Coverity reported the following:

*** CID 1487360:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
/drivers/thermal/qcom/tsens-common.c: 95 in degc_to_code()
89     		dev_dbg(priv->dev, "%s: offset:%d\n", __func__, priv->sensor[i].offset);
90     	}
91     }
93     static inline u32 degc_to_code(int degc, const struct tsens_sensor *s)
94     {
vvv     CID 1487360:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
vvv     Potentially overflowing expression "degc * s->slope" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "u64" (64 bits, unsigned).
95     	u64 code = (degc * s->slope + s->offset) / SLOPE_FACTOR;
97     	pr_debug("%s: raw_code: 0x%llx, degc:%d\n", __func__, code, degc);
98     	return clamp_val(code, THRESHOLD_MIN_ADC_CODE, THRESHOLD_MAX_ADC_CODE);
99     }

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please

Reported-by: coverity-bot <>
Addresses-Coverity-ID: 1487360 ("Integer handling issues")
Fixes: fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")

Thanks for your attention!


                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201910281606.F95870B3@keescook \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on

Archives are clonable:
	git clone --mirror linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ \
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone