* linux-next: build warning after merge of the rtc tree
@ 2019-10-30 4:41 Stephen Rothwell
2019-11-08 5:29 ` Stephen Rothwell
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2019-10-30 4:41 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
Hi all,
After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
WARNING: unmet direct dependencies detected for FSL_RCPM
Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64)
Selected by [m]:
- RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y])
WARNING: unmet direct dependencies detected for FSL_RCPM
Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64)
Selected by [m]:
- RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y])
WARNING: unmet direct dependencies detected for FSL_RCPM
Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64)
Selected by [m]:
- RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y])
Introduced by commit
e1c2feb1efa2 ("rtc: fsl-ftm-alarm: allow COMPILE_TEST")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2019-10-30 4:41 linux-next: build warning after merge of the rtc tree Stephen Rothwell
@ 2019-11-08 5:29 ` Stephen Rothwell
2019-11-08 15:20 ` Alexandre Belloni
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2019-11-08 5:29 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
Hi all,
On Wed, 30 Oct 2019 15:41:05 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: unmet direct dependencies detected for FSL_RCPM
> Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64)
> Selected by [m]:
> - RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y])
>
> WARNING: unmet direct dependencies detected for FSL_RCPM
> Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64)
> Selected by [m]:
> - RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y])
>
> WARNING: unmet direct dependencies detected for FSL_RCPM
> Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64)
> Selected by [m]:
> - RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y])
>
> Introduced by commit
>
> e1c2feb1efa2 ("rtc: fsl-ftm-alarm: allow COMPILE_TEST")
I am still getting these warnings.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2019-11-08 5:29 ` Stephen Rothwell
@ 2019-11-08 15:20 ` Alexandre Belloni
0 siblings, 0 replies; 22+ messages in thread
From: Alexandre Belloni @ 2019-11-08 15:20 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
Hi,
On 08/11/2019 16:29:29+1100, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 30 Oct 2019 15:41:05 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > WARNING: unmet direct dependencies detected for FSL_RCPM
> > Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64)
> > Selected by [m]:
> > - RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y])
> >
> > WARNING: unmet direct dependencies detected for FSL_RCPM
> > Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64)
> > Selected by [m]:
> > - RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y])
> >
> > WARNING: unmet direct dependencies detected for FSL_RCPM
> > Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64)
> > Selected by [m]:
> > - RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y])
> >
> > Introduced by commit
> >
> > e1c2feb1efa2 ("rtc: fsl-ftm-alarm: allow COMPILE_TEST")
>
> I am still getting these warnings.
>
I've dropped the patch for now, sorry about that.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* linux-next: build warning after merge of the rtc tree
@ 2020-03-23 5:24 Stephen Rothwell
0 siblings, 0 replies; 22+ messages in thread
From: Stephen Rothwell @ 2020-03-23 5:24 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Peng Ma
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
Hi all,
After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
246 | struct device_node *np = pdev->dev.of_node;
| ^~
Introduced by commit
cd49b579e705 ("rtc: fsl-ftm-alarm: enable acpi support")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* linux-next: build warning after merge of the rtc tree
@ 2020-03-17 5:30 Stephen Rothwell
0 siblings, 0 replies; 22+ messages in thread
From: Stephen Rothwell @ 2020-03-17 5:30 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ran Bi
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
Hi all,
After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
drivers/rtc/rtc-mt2712.c: In function 'mt2712_rtc_set_alarm':
drivers/rtc/rtc-mt2712.c:235:6: warning: unused variable 'irqen' [-Wunused-variable]
235 | u16 irqen;
| ^~~~~
Introduced by commit
4037b7df1026 ("rtc: add support for the MediaTek MT2712 RTC")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* linux-next: build warning after merge of the rtc tree
@ 2019-08-21 6:31 Stephen Rothwell
0 siblings, 0 replies; 22+ messages in thread
From: Stephen Rothwell @ 2019-08-21 6:31 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
Hi all,
After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_probe':
drivers/rtc/rtc-aspeed.c:89:6: warning: unused variable 'ret' [-Wunused-variable]
int ret;
^~~
drivers/rtc/rtc-armada38x.c: In function 'armada38x_rtc_probe':
drivers/rtc/rtc-armada38x.c:505:6: warning: unused variable 'ret' [-Wunused-variable]
int ret;
^~~
Introduced by commit
5a3a2836e8bf ("rtc: remove superfluous error message")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* linux-next: build warning after merge of the rtc tree
@ 2019-03-28 1:23 Stephen Rothwell
2019-03-28 1:36 ` Joel Stanley
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2019-03-28 1:23 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Joel Stanley
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
Hi all,
After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_read_time':
drivers/rtc/rtc-aspeed.c:26:16: warning: unused variable 'flags' [-Wunused-variable]
unsigned long flags;
^~~~~
drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_set_time':
drivers/rtc/rtc-aspeed.c:57:16: warning: unused variable 'flags' [-Wunused-variable]
unsigned long flags;
^~~~~
Introduced by commit
7f4d485413fb ("rtc: Add ASPEED RTC driver")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2019-03-28 1:23 Stephen Rothwell
@ 2019-03-28 1:36 ` Joel Stanley
2019-03-28 1:57 ` Alexandre Belloni
0 siblings, 1 reply; 22+ messages in thread
From: Joel Stanley @ 2019-03-28 1:36 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Alexandre Belloni, Linux Next Mailing List, Linux Kernel Mailing List
On Thu, 28 Mar 2019 at 01:23, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_read_time':
> drivers/rtc/rtc-aspeed.c:26:16: warning: unused variable 'flags' [-Wunused-variable]
> unsigned long flags;
> ^~~~~
> drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_set_time':
> drivers/rtc/rtc-aspeed.c:57:16: warning: unused variable 'flags' [-Wunused-variable]
> unsigned long flags;
> ^~~~~
>
> Introduced by commit
>
> 7f4d485413fb ("rtc: Add ASPEED RTC driver")
Alexandre, it looks like v3 went in instead of v4. Do you need me to
send a follow up?
Cheers,
Joel
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2019-03-28 1:36 ` Joel Stanley
@ 2019-03-28 1:57 ` Alexandre Belloni
2019-03-28 2:09 ` Joel Stanley
0 siblings, 1 reply; 22+ messages in thread
From: Alexandre Belloni @ 2019-03-28 1:57 UTC (permalink / raw)
To: Joel Stanley
Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List
On 28/03/2019 01:36:21+0000, Joel Stanley wrote:
> On Thu, 28 Mar 2019 at 01:23, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_read_time':
> > drivers/rtc/rtc-aspeed.c:26:16: warning: unused variable 'flags' [-Wunused-variable]
> > unsigned long flags;
> > ^~~~~
> > drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_set_time':
> > drivers/rtc/rtc-aspeed.c:57:16: warning: unused variable 'flags' [-Wunused-variable]
> > unsigned long flags;
> > ^~~~~
> >
> > Introduced by commit
> >
> > 7f4d485413fb ("rtc: Add ASPEED RTC driver")
>
> Alexandre, it looks like v3 went in instead of v4. Do you need me to
> send a follow up?
>
I didn't get any v4, I'll fix it up in the tree.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2019-03-28 1:57 ` Alexandre Belloni
@ 2019-03-28 2:09 ` Joel Stanley
0 siblings, 0 replies; 22+ messages in thread
From: Joel Stanley @ 2019-03-28 2:09 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List
On Thu, 28 Mar 2019 at 01:59, Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> On 28/03/2019 01:36:21+0000, Joel Stanley wrote:
> > On Thu, 28 Mar 2019 at 01:23, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> > > produced this warning:
> > >
> > > drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_read_time':
> > > drivers/rtc/rtc-aspeed.c:26:16: warning: unused variable 'flags' [-Wunused-variable]
> > > unsigned long flags;
> > > ^~~~~
> > > drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_set_time':
> > > drivers/rtc/rtc-aspeed.c:57:16: warning: unused variable 'flags' [-Wunused-variable]
> > > unsigned long flags;
> > > ^~~~~
> > >
> > > Introduced by commit
> > >
> > > 7f4d485413fb ("rtc: Add ASPEED RTC driver")
> >
> > Alexandre, it looks like v3 went in instead of v4. Do you need me to
> > send a follow up?
> >
>
> I didn't get any v4, I'll fix it up in the tree.
Thanks!
(Sorry, I fat fingered v3 and then prepared a v4 but didn't send it.
The only change was removing the flags variable.)
^ permalink raw reply [flat|nested] 22+ messages in thread
* linux-next: build warning after merge of the rtc tree
@ 2018-03-21 6:44 Stephen Rothwell
0 siblings, 0 replies; 22+ messages in thread
From: Stephen Rothwell @ 2018-03-21 6:44 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
Hi Alexandre,
After merging the rtc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/rtc/rtc-st-lpc.c: In function 'st_rtc_probe':
drivers/rtc/rtc-st-lpc.c:198:18: warning: unused variable 'tm_check' [-Wunused-variable]
struct rtc_time tm_check;
^~~~~~~~
Introduced by commit
50f37481e794 ("rtc: st-lpc: remove artificial limitation")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* linux-next: build warning after merge of the rtc tree
@ 2017-07-06 4:24 Stephen Rothwell
2017-07-06 5:54 ` Heiner Kallweit
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2017-07-06 4:24 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Heiner Kallweit
Hi Alexandre,
After merging the rtc tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/rtc/rtc-ds1307.c: In function 'ds1307_get_time':
drivers/rtc/rtc-ds1307.c:342:26: warning: unused variable 'chip' [-Wunused-variable]
const struct chip_desc *chip = &chips[ds1307->type];
^
Introduced by commit
436c93db60a4 ("rtc: ds1307: factor out century bit handling")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2017-07-06 4:24 Stephen Rothwell
@ 2017-07-06 5:54 ` Heiner Kallweit
2017-07-06 6:59 ` Alexandre Belloni
0 siblings, 1 reply; 22+ messages in thread
From: Heiner Kallweit @ 2017-07-06 5:54 UTC (permalink / raw)
To: Stephen Rothwell, Alexandre Belloni
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Am 06.07.2017 um 06:24 schrieb Stephen Rothwell:
> Hi Alexandre,
>
> After merging the rtc tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/rtc/rtc-ds1307.c: In function 'ds1307_get_time':
> drivers/rtc/rtc-ds1307.c:342:26: warning: unused variable 'chip' [-Wunused-variable]
> const struct chip_desc *chip = &chips[ds1307->type];
> ^
>
> Introduced by commit
>
> 436c93db60a4 ("rtc: ds1307: factor out century bit handling")
>
Right, if RTC_DRV_DS1307 is defined but RTC_DRV_DS1307_CENTURY is not
then variable chip isn't used in ds1307_get_time.
We could fix this by simply defining variable chip only if
RTC_DRV_DS1307_CENTURY is defined.
However the current situation leaves the question why
RTC_DRV_DS1307_CENTURY isn't set in the ppc64 defconfig.
This config option should be n only temporarily if a system has
to be fixed, see description of this option.
Maybe we should set this config option to "default y" ?
Rgds, Heiner
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2017-07-06 5:54 ` Heiner Kallweit
@ 2017-07-06 6:59 ` Alexandre Belloni
0 siblings, 0 replies; 22+ messages in thread
From: Alexandre Belloni @ 2017-07-06 6:59 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List
On 06/07/2017 at 07:54:58 +0200, Heiner Kallweit wrote:
> Am 06.07.2017 um 06:24 schrieb Stephen Rothwell:
> > Hi Alexandre,
> >
> > After merging the rtc tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > drivers/rtc/rtc-ds1307.c: In function 'ds1307_get_time':
> > drivers/rtc/rtc-ds1307.c:342:26: warning: unused variable 'chip' [-Wunused-variable]
> > const struct chip_desc *chip = &chips[ds1307->type];
> > ^
> >
> > Introduced by commit
> >
> > 436c93db60a4 ("rtc: ds1307: factor out century bit handling")
> >
> Right, if RTC_DRV_DS1307 is defined but RTC_DRV_DS1307_CENTURY is not
> then variable chip isn't used in ds1307_get_time.
> We could fix this by simply defining variable chip only if
> RTC_DRV_DS1307_CENTURY is defined.
>
> However the current situation leaves the question why
> RTC_DRV_DS1307_CENTURY isn't set in the ppc64 defconfig.
> This config option should be n only temporarily if a system has
> to be fixed, see description of this option.
> Maybe we should set this config option to "default y" ?
>
Well, the code would still have to be fixed.
> Rgds, Heiner
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* linux-next: build warning after merge of the rtc tree
@ 2017-06-29 5:42 Stephen Rothwell
0 siblings, 0 replies; 22+ messages in thread
From: Stephen Rothwell @ 2017-06-29 5:42 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Brian Norris,
Markus Mayer, Florian Fainelli
Hi Alexandre,
After merging the rtc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/rtc/rtc-brcmstb-waketimer.c: In function 'brcmstb_waketmr_settime':
drivers/rtc/rtc-brcmstb-waketimer.c:142:6: warning: unused variable 'ret' [-Wunused-variable]
int ret;
^
Introduced by commit
9f4ad359c801 ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 22+ messages in thread* linux-next: build warning after merge of the rtc tree
@ 2017-01-13 3:18 Stephen Rothwell
2017-01-13 8:42 ` Amelie DELAUNAY
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2017-01-13 3:18 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-next, linux-kernel, Amelie Delaunay, Mathieu Poirier
Hi Alexandre,
After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
In file included from drivers/rtc/rtc-stm32.c:14:0:
drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_probe':
drivers/rtc/rtc-stm32.c:653:51: warning: large integer implicitly truncated to unsigned type [-Woverflow]
regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP);
^
include/linux/regmap.h:73:42: note: in definition of macro 'regmap_update_bits'
regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
^
drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_remove':
drivers/rtc/rtc-stm32.c:675:51: warning: large integer implicitly truncated to unsigned type [-Woverflow]
regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP);
^
include/linux/regmap.h:73:42: note: in definition of macro 'regmap_update_bits'
regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
^
Introduced by commit
4e64350f42e2 ("rtc: add STM32 RTC driver")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 22+ messages in thread* RE: linux-next: build warning after merge of the rtc tree
2017-01-13 3:18 Stephen Rothwell
@ 2017-01-13 8:42 ` Amelie DELAUNAY
0 siblings, 0 replies; 22+ messages in thread
From: Amelie DELAUNAY @ 2017-01-13 8:42 UTC (permalink / raw)
To: Stephen Rothwell, Alexandre Belloni
Cc: linux-next, linux-kernel, Mathieu Poirier
Hi Stephen,
I'm going to send a patch to fix this warning.
Thanks,
Regards,
Amelie
> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: vendredi 13 janvier 2017 04:18
> To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Amelie
> DELAUNAY <amelie.delaunay@st.com>; Mathieu Poirier
> <mathieu.poirier@linaro.org>
> Subject: linux-next: build warning after merge of the rtc tree
>
> Hi Alexandre,
>
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> In file included from drivers/rtc/rtc-stm32.c:14:0:
> drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_probe':
> drivers/rtc/rtc-stm32.c:653:51: warning: large integer implicitly truncated to
> unsigned type [-Woverflow]
> regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP);
> ^
> include/linux/regmap.h:73:42: note: in definition of macro
> 'regmap_update_bits'
> regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
> ^
> drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_remove':
> drivers/rtc/rtc-stm32.c:675:51: warning: large integer implicitly truncated to
> unsigned type [-Woverflow]
> regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP);
> ^
> include/linux/regmap.h:73:42: note: in definition of macro
> 'regmap_update_bits'
> regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
> ^
>
> Introduced by commit
>
> 4e64350f42e2 ("rtc: add STM32 RTC driver")
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 22+ messages in thread
* linux-next: build warning after merge of the rtc tree
@ 2017-01-10 3:01 Stephen Rothwell
2017-01-10 10:59 ` Alexandre Belloni
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2017-01-10 3:01 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-next, linux-kernel, Gregory CLEMENT
Hi Alexandre,
After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
drivers/rtc/rtc-armada38x.c: In function 'read_rtc_register_wa':
drivers/rtc/rtc-armada38x.c:131:25: warning: 'index_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
return rtc->val_to_freq[index_max].value;
^
Introduced by commit
61cffa2438e3 ("rtc: armada38x: Follow the new recommendation for errata implementation")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2017-01-10 3:01 Stephen Rothwell
@ 2017-01-10 10:59 ` Alexandre Belloni
0 siblings, 0 replies; 22+ messages in thread
From: Alexandre Belloni @ 2017-01-10 10:59 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Gregory CLEMENT
Hi,
On 10/01/2017 at 14:01:00 +1100, Stephen Rothwell wrote :
> Hi Alexandre,
>
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/rtc/rtc-armada38x.c: In function 'read_rtc_register_wa':
> drivers/rtc/rtc-armada38x.c:131:25: warning: 'index_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
> return rtc->val_to_freq[index_max].value;
> ^
>
> Introduced by commit
>
> 61cffa2438e3 ("rtc: armada38x: Follow the new recommendation for errata implementation")
This is definitively a false positive, is it worth fixing it?
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* linux-next: build warning after merge of the rtc tree
@ 2016-07-11 8:12 Stephen Rothwell
2016-07-11 8:23 ` Uwe Kleine-König
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2016-07-11 8:12 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-next, linux-kernel, Uwe Kleine-König
Hi Alexandre,
After merging the rtc tree, today's linux-next build (x86 64_allmodconfig)
produced this warning:
drivers/rtc/rtc-isl12057.c: In function 'isl12057_rtc_read_alarm':
drivers/rtc/rtc-isl12057.c:249:26: warning: unused variable 'alarm_secs' [-Wunused-variable]
unsigned long rtc_secs, alarm_secs;
^
drivers/rtc/rtc-isl12057.c:249:16: warning: unused variable 'rtc_secs' [-Wunused-variable]
unsigned long rtc_secs, alarm_secs;
^
drivers/rtc/rtc-isl12057.c:248:18: warning: unused variable 'rtc_tm' [-Wunused-variable]
struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
^
Introduced by commit
4e30a585a343 ("rtc: isl12057: let the rtc core interpret the partial alarm")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2016-07-11 8:12 Stephen Rothwell
@ 2016-07-11 8:23 ` Uwe Kleine-König
2016-07-11 21:23 ` Alexandre Belloni
0 siblings, 1 reply; 22+ messages in thread
From: Uwe Kleine-König @ 2016-07-11 8:23 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Stephen Rothwell, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]
Hello,
On Mon, Jul 11, 2016 at 06:12:08PM +1000, Stephen Rothwell wrote:
> After merging the rtc tree, today's linux-next build (x86 64_allmodconfig)
> produced this warning:
>
> drivers/rtc/rtc-isl12057.c: In function 'isl12057_rtc_read_alarm':
> drivers/rtc/rtc-isl12057.c:249:26: warning: unused variable 'alarm_secs' [-Wunused-variable]
> unsigned long rtc_secs, alarm_secs;
> ^
> drivers/rtc/rtc-isl12057.c:249:16: warning: unused variable 'rtc_secs' [-Wunused-variable]
> unsigned long rtc_secs, alarm_secs;
> ^
> drivers/rtc/rtc-isl12057.c:248:18: warning: unused variable 'rtc_tm' [-Wunused-variable]
> struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
> ^
>
> Introduced by commit
>
> 4e30a585a343 ("rtc: isl12057: let the rtc core interpret the partial alarm")
Thanks for catching that. The obvious fix is:
diff --git a/drivers/rtc/rtc-isl12057.c b/drivers/rtc/rtc-isl12057.c
index e0245fc6205e..0e7f0f52bfe4 100644
--- a/drivers/rtc/rtc-isl12057.c
+++ b/drivers/rtc/rtc-isl12057.c
@@ -245,8 +245,7 @@ static int isl12057_rtc_update_alarm(struct device *dev, int enable)
static int isl12057_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
{
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
- struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
- unsigned long rtc_secs, alarm_secs;
+ struct rtc_time *alarm_tm = &alarm->time;
u8 regs[ISL12057_A1_SEC_LEN];
unsigned int ir;
int ret;
Alexandre: Do you fixup, or should I send a proper patch for that?
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: linux-next: build warning after merge of the rtc tree
2016-07-11 8:23 ` Uwe Kleine-König
@ 2016-07-11 21:23 ` Alexandre Belloni
0 siblings, 0 replies; 22+ messages in thread
From: Alexandre Belloni @ 2016-07-11 21:23 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: Stephen Rothwell, linux-next, linux-kernel
On 11/07/2016 at 10:23:51 +0200, Uwe Kleine-König wrote :
> Hello,
>
> On Mon, Jul 11, 2016 at 06:12:08PM +1000, Stephen Rothwell wrote:
> > After merging the rtc tree, today's linux-next build (x86 64_allmodconfig)
> > produced this warning:
> >
> > drivers/rtc/rtc-isl12057.c: In function 'isl12057_rtc_read_alarm':
> > drivers/rtc/rtc-isl12057.c:249:26: warning: unused variable 'alarm_secs' [-Wunused-variable]
> > unsigned long rtc_secs, alarm_secs;
> > ^
> > drivers/rtc/rtc-isl12057.c:249:16: warning: unused variable 'rtc_secs' [-Wunused-variable]
> > unsigned long rtc_secs, alarm_secs;
> > ^
> > drivers/rtc/rtc-isl12057.c:248:18: warning: unused variable 'rtc_tm' [-Wunused-variable]
> > struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
> > ^
> >
> > Introduced by commit
> >
> > 4e30a585a343 ("rtc: isl12057: let the rtc core interpret the partial alarm")
>
> Thanks for catching that. The obvious fix is:
>
> diff --git a/drivers/rtc/rtc-isl12057.c b/drivers/rtc/rtc-isl12057.c
> index e0245fc6205e..0e7f0f52bfe4 100644
> --- a/drivers/rtc/rtc-isl12057.c
> +++ b/drivers/rtc/rtc-isl12057.c
> @@ -245,8 +245,7 @@ static int isl12057_rtc_update_alarm(struct device *dev, int enable)
> static int isl12057_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
> {
> struct isl12057_rtc_data *data = dev_get_drvdata(dev);
> - struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
> - unsigned long rtc_secs, alarm_secs;
> + struct rtc_time *alarm_tm = &alarm->time;
> u8 regs[ISL12057_A1_SEC_LEN];
> unsigned int ir;
> int ret;
>
> Alexandre: Do you fixup, or should I send a proper patch for that?
>
I fixed it up. I shouldn't have missed that one...
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2020-03-23 5:24 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 4:41 linux-next: build warning after merge of the rtc tree Stephen Rothwell
2019-11-08 5:29 ` Stephen Rothwell
2019-11-08 15:20 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2020-03-23 5:24 Stephen Rothwell
2020-03-17 5:30 Stephen Rothwell
2019-08-21 6:31 Stephen Rothwell
2019-03-28 1:23 Stephen Rothwell
2019-03-28 1:36 ` Joel Stanley
2019-03-28 1:57 ` Alexandre Belloni
2019-03-28 2:09 ` Joel Stanley
2018-03-21 6:44 Stephen Rothwell
2017-07-06 4:24 Stephen Rothwell
2017-07-06 5:54 ` Heiner Kallweit
2017-07-06 6:59 ` Alexandre Belloni
2017-06-29 5:42 Stephen Rothwell
2017-01-13 3:18 Stephen Rothwell
2017-01-13 8:42 ` Amelie DELAUNAY
2017-01-10 3:01 Stephen Rothwell
2017-01-10 10:59 ` Alexandre Belloni
2016-07-11 8:12 Stephen Rothwell
2016-07-11 8:23 ` Uwe Kleine-König
2016-07-11 21:23 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).