Coverity: iwl_dbg_tlv_alloc_fragment(): Control flow issues - coverity-bot

From: coverity-bot <keescook@chromium.org>
To: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	linux-next@vger.kernel.org
Subject: Coverity: iwl_dbg_tlv_alloc_fragment(): Control flow issues
Date: Mon, 4 Nov 2019 09:37:38 -0800	[thread overview]
Message-ID: <201911040937.0079956C5@keescook> (raw)

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

14124b25780d ("iwlwifi: dbg_ini: implement monitor allocation flow")

Coverity reported the following:

*** CID 1487402:  Control flow issues  (DEADCODE)
/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: 497 in iwl_dbg_tlv_alloc_fragment()
491     			 pages * PAGE_SIZE);
492
493     		pages = DIV_ROUND_UP(pages, 2);
494     	}
495
496     	if (!block)
vvv     CID 1487402:  Control flow issues  (DEADCODE)
vvv     Execution cannot reach this statement: "return -12;".
497     		return -ENOMEM;
498
499     	frag->physical = physical;
500     	frag->block = block;
501     	frag->size = pages * PAGE_SIZE;
502

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487402 ("Control flow issues")
Fixes: 14124b25780d ("iwlwifi: dbg_ini: implement monitor allocation flow")

Thanks for your attention!

-- 
Coverity-bot