Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* Coverity: pn532_dev_up(): Error handling issues
@ 2019-11-04 17:41 coverity-bot
  0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2019-11-04 17:41 UTC (permalink / raw)
  To: Lars Poeschel; +Cc: David S. Miller, Gustavo A. R. Silva, linux-next

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

c656aa4c27b1 ("nfc: pn533: add UART phy driver")

Coverity reported the following:

*** CID 1487395:  Error handling issues  (CHECKED_RETURN)
/drivers/nfc/pn533/uart.c: 107 in pn532_dev_up()
101     }
102
103     static void pn532_dev_up(struct pn533 *dev)
104     {
105     	struct pn532_uart_phy *pn532 = dev->phy;
106
vvv     CID 1487395:  Error handling issues  (CHECKED_RETURN)
vvv     Calling "serdev_device_open" without checking return value (as is done elsewhere 10 out of 11 times).
107     	serdev_device_open(pn532->serdev);
108     	pn532->send_wakeup = PN532_SEND_LAST_WAKEUP;
109     }
110
111     static void pn532_dev_down(struct pn533 *dev)
112     {

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487395 ("Error handling issues")
Fixes: c656aa4c27b1 ("nfc: pn533: add UART phy driver")


Thanks for your attention!

-- 
Coverity-bot

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 17:41 Coverity: pn532_dev_up(): Error handling issues coverity-bot

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git