From: coverity-bot <keescook@chromium.org>
To: David Francis <David.Francis@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: amdgpu_dm_commit_planes(): Null pointer dereferences
Date: Mon, 4 Nov 2019 09:41:15 -0800 [thread overview]
Message-ID: <201911040941.A2E9B4259@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
74aa7bd4c6f7 ("drm/amd/display: Make stream commits call into DC only once")
Coverity reported the following:
*** CID 1487396: Null pointer dereferences (FORWARD_NULL)
/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: 5901 in amdgpu_dm_commit_planes()
5895
5896 if (dc_plane && !dc_plane->tiling_info.gfx9.swizzle)
5897 swizzle = false;
5898
5899 bundle->surface_updates[planes_count].surface = dc_plane;
5900 if (new_pcrtc_state->color_mgmt_changed) {
vvv CID 1487396: Null pointer dereferences (FORWARD_NULL)
vvv Dereferencing null pointer "dc_plane".
5901 bundle->surface_updates[planes_count].gamma = dc_plane->gamma_correction;
5902 bundle->surface_updates[planes_count].in_transfer_func = dc_plane->in_transfer_func;
5903 }
5904
5905 fill_dc_scaling_info(new_plane_state,
5906 &bundle->scaling_infos[planes_count]);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487396 ("Null pointer dereferences")
Fixes: 74aa7bd4c6f7 ("drm/amd/display: Make stream commits call into DC only once")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-11-04 17:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911040941.A2E9B4259@keescook \
--to=keescook@chromium.org \
--cc=David.Francis@amd.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=alexander.deucher@amd.com \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).